Create an AcctUniqueId before adding a row in radacct in log_badlogins.

[freeradius.git] / dialup_admin / Changelog

Ver 1.63:
* Do an eval on the attribute description strings in the user_edit page. That will allow the login-time creation
  page to work properly.
* Add a login-time creation page which will allow the administrator to create the login-time string through a gui
  instead of writing it directly in UUCP format.
* Call lib/{ldap,sql}/user_info in user_info before displaying any information about the user
* Add a configuration directive general_charset. Add a language meta tag in all pages
* Use sql_extra_servers directive when adding users in the badusers table. Add a da_sql_host_connect() function
  to connect to a specific sql host
* Fix a typo in lib/sql/attrmap.php3
* Add an entry in the FAQ about the Dialup-Access attribute
* Add an entry in the FAQ about duplicate personal attributes in the user_admin page
* Only show the personal attributes in the New User page if we have ldap or we are using the userinfo table in sql
* Add a per nas finger_type directive
* Update the TODO file
* Add an entry in the FAQ about adding .php3 handling
* Add a few installation notes
* Fix a problem with user_stats.php3
* Update the README file with notes about the scripts present in the bin folder
* Add a <?php tag instead of a <?. Bug noted by Isam Ishaq <isam@planet.edu>
* Add support for regexp and like operators in accounting report generator
* Limit the split() to 2 elements in lib/defaults.php3
* Create a AcctUniqueId before adding a row in radacct in log_badlogins.
Ver 1.62:
* Remove one sql query from user_admin which was not needed.
* Instead of a query like "LIKE 'YYYY-MM-DD%'" use "AcctStopTime >= 'YYYY-MM-DD 00:00:00 AND AcctStopTime
  <= 'YYYY-MM-DD 23:59:59'" which will allow us to use sql indexes better.
* Add a few comments in bin/clean_radacct
* Add a new script bin/truncate_radacct which will delete all sessions from the radacct table which
  are older than a configurable number of days
* Fix a typo in sql.attrmap. Fix by Evren Yurtesen <eyurtese@turkuamk.fi>
* Work even when register_globals if off. Suggestion from Evren Yurtesen <eyurtese@turkuamk.fi>
  Also add an entry in the FAQ about that.
* We don't need ORDER BY GroupName in show_groups.php3 since we have GROUP BY
* Use CISCO-POP-MGMT-MIB in snmpfinger instead of CISCO-CALL-HISTORY-MIB. Thanks to
  Evren Yurtesen <eyurtese@turkuamk.fi> for the suggestion.
* Remember a few things in the user_test page. Also add another configuration file directive
  general_radius_server_auth_proto specifying the default authentication protocol of the radius
  server (pap or chap).
* Replace single quotes with double quotes in log_badlogins
* Add a missing <?php tag. Bug noted by Simon Burns <simon@ababa.org>
* Add sql_use_http_credentials configuration directive to connect to the sql database using the http user
  credentials (that way there can be more than one administrator usernames, each with different privileges
  on the sql database).
* Add more error messages when interacting with the SQL database
* Add sql_connect_timeout and sql_extra_servers configuration directives to be used by the log_badlogins script
* In log_badlogins create a separate sql input file for each sql server and append sql commands to it. If the
  sql command succeeds we delete the corresponding input file. That way if an sql server is down we store the
  accounting info in the input file and then send it all when it comes back up.
* Add a directive sql_debug. Add debugging statements in the sql library
* Add a directive ldap_debug. Add debugging statements in the ldap library
* Add debug statements in the pg driver
* In debug, output the sql queries in italic. Refer to enabling debugging in the FAQ
* Don't include user_info.php3 in the user_test page.
* Make things a little bit more simple in lib/ldap/change_attrs.php3
* Fix a small bug in lib/ldap/create_user.php3. Unset the mod array before adding any values to it.
* Fix a small problem with debugging
* Do a write lock in radacct before truncating it in truncate_radacct
* In user_new show a select box with all the available groups. Based on an idea by Karel Stadler (kstadler)
* Add a column Admin in the badusers table which will contain the administrator username if that is available
* Add two new tables totacct and mtotacct containing per user aggregated statistics for each day and month
  respectively. Also add two corresponding scripts in the bin folder, tot_stats and monthly_tot_stats. Lastly,
  create a new page, user_stats.php3 which will show the top users in connections or connections duration based
  on the data in the totacct table.
* Add a few comments in the tot_stats and monthly_tot_stats scripts
* Add support for ! in usernames in log_badlogins
* Call gethostbyaddr with an @ in front to suppress error messages
* Also add support for @ in usernames in log_badlogins
Ver 1.61:
* Add a string encoder for greek
* If general_decode_normal_attributes is set then encode attributes in lib/ldap/change_info. In the near future
  language specific user attributes will be added in the change info and new user pages. Remove comments from
  admin.conf about the change info page not working if this directive is used.
* When spliting cn in lib/ldap/create_user.php3 limit the split to 2 new elements not 3.
* Fix a few bugs in log_badlogins
* Fix a parse error in failed_logins.php3
* Fix a bug in lib/defaults.php3 which did not allow the default.vals file to be used correctly
* Include password.php3 in lib/ldap/password_check.php3
* When searching a user in ldap through the find page only try to find the users which have a uid attribute (username)
* Allow selecting a specific access server in the failed logins page
* In the user admin page use AcctStartTime not AcctStopTime when calculating usage for the last 7 days
* Also show server:port in the user test page (so that it shows when used for server checks)
* Now the create user page should work with sql
* Make the default general_lib_type sql instead of ldap
Ver 1.60:
* Use require_once when including lib/functions.php3 in lib/sql
* In the buttons toolbar Edit User should not be clickable.
* Add an arrow gif in htdocs/images to be used in the buttons page when adding multiple finger pages
* In snmpfinger also consider '-' as a valid character for a username
* Add support for realm in username and allow for realm striping in the web pages and in log_badlogins
* Add a few more comments in the admin.conf
* Update the FAQ with an entry about the Online Users page not showing anything.
* Update the FAQ with an entry about sessions.
* Allow the user to add extra attributes in the test user page
* Add a few comments in log_badlogins, support auth logs containing the password, work nice when the client
  is localhost, add an option to scan the whole radius.log and add failed logins in the sql database (can be
  used for initialization).
* html fixes in accounting.php3
* Fix a problem in user_accounting when NASIPAddress is not set.
* Use CISCO-AAA-SESSION-MIB in snmpfinger
* In lib/ldap/functions.php3 only ask for the cn attribute in ldap_search not the whole entry. That should make
  user_finger a lot faster when the user database is in ldap
* In lib/functions.php3 pass a second argument to date2timediv with the current time. user_finger calls that
  function for each online user so we now don't need to do a lot of calls to time() but only one. That should make
  user_finger somewhat faster.
* Fix a small issue with the general_accounting_info_order
* Fix a problem in failed_logins when NASIPAddress is not set.
* Allow for multiple regular profile attributes in a user entry.
* Allow for normal ldap user attributes to be utf8 encoded instead of ascii. Changing attribute values through
  user_info will not work in that case.
* Fix a small bug in lib/ldap/defaults.php3. We should not be using $i in a for() loop but a new variable
* Add a comment in admin.conf about ldap server failover
* Map a specific username to the directory manager if we are using ldap and http authentication
Ver 1.59:
* Small html fixes in user_edit.php3 and password.php3
* Show number of failed logins in the last 7 days in the user admin page
* Show date in the user/server test page
* In config.php3 include a relative admin.conf file not an absolute
* Add an entry in the FAQ about php magic quotes
* Escape double quotes in attribute values in the user edit page
* Fix a bug in lib/sql/change_passwd.php3 when not using operators.
  Bug report from Sheldon Fougere <sfougere@solutioninc.com>
* Add the caller id in the connection status attributes in the show user page
* Allow for multiple default values. Also add a generic flag in ldap attrmap. If it exists then the
  attribute is generic and user values *do not* overwrite default values. The operators in the generic
  attribute can be used for that. The same is very difficult to implement for sql, so for now user
  values overwrite default values in sql (user edit page).
  A lot of code and a lot of files where changed so there may be bugs somewhere.
* In the user edit page print a message under the User Password field about if it exists or not. Update
  the user_info.php3 lib files to check for it.
* In lib/ldap/defaults.php3 Dialup-Access should not be added in the default_vals. It is not inherited.
* If we are editing a group show a comment that in the radiusd sql module the group tables are evaluated
  after the user tables. As a result user values should in general overwrite default values.
* Add support for the default_user_profile of the sql module in lib/sql/defaults.php3
* In sql.attrmap User-Password should map to User-Password, not Password
* If an sql attribute is not contained in sql, assume that it has the same name as in dialup_admin and that
  it is a reply item. Add a comment for that in conf/sql.attrmap.
* Change the way radius attributes are read from the sql database. The change should make things somewhat
  faster. Create a reverse mapping from radius attributes to dialup_admin attributes.
* Add a configuration directive called ldap_use_http_credentials. If it is set to yes then we try to
  connect to the ldap server with the username/password given in http authentication, not those contained
  in admin.conf. That way multiple admins with different permissions on the ldap tree can work on a single
  dialup_admin.
* With the same logic we allow for multiple buttons html pages. We now create a folder html/buttons which
  by default contains a folder default. If the user logs in with http authentication then we try
  to open the file html/buttons/<username>/buttons.html.php3. If we can't we open
  html/buttons/default/buttons.html.php3. That way we can create muiltiple views of say the online users
  page based on which admin requests the page.
* Call config.php3 before outputing any html.
* Add sessions in order to cache the various mappings. Add a corresponding configuration directive
  general_use_session. Also add a session cache destroy page.
* Also cache the admin.conf if use_session is set to 1 in config.php3
* Fix a few bugs
* Remove the auto password generator from the user edit page. It has no meaning since the password is not
  shown
* In lib/sql/defaults.php3 instead of doing a select for each group the user belongs to, do one select with
  a where in () caluse.
* Also cache the default.vals file.
* Update documentation
* Only connect and bind to the ldap server if we haven't done that before.
* Remove previous change. It was causing problems
* In the user test page ignore comments from the auth.request file
* Add a new config directive, ldap_write_server. If it is set then when we update the directory we try to
  connect to that one instead of the ldap_server. That way we can read from the fast read-only replicas and
  write to a slower master.
* Fix a few more bugs
* Add a failed logins page, to show the most recent failed logins.
* Fix a bug in the failed logins page
* Change use of AcctStartTime with AcctStopTime in failed_logins.php3 to match that in user_admin
* Fix a bug with failed logins in user_admin.
* Add the failed logins page in the buttons page
* Add a missing WHERE UserName = '$login' in the UPDATE statement in lib/sql/change_info.php3. Patch by
  Eddie Bindt <eddieb@users.sourceforge.net>
Ver 1.55:
* Update the FAQ about missing attributes from the user/group edit pages and add a few comments
  in the configuration files
* Add support for the Expiration attribute. Add it in the sql attribute map, in user_edit.attrs and
  check for it in user_admin
* Add a few more keys in the userinfo and badusers tables.
* Fix a problem with lib/sql/defaults.php3 where the first character in the default value when using
  operators was set to the opeator
* Add a user find page. User can be searched based on the full name, department or RADIUS attribute.
  The radius attribute should be included in the _user_ profile, not in a group/regular/default profile.
* Add support for the user ldap regular profile attribute in user_edit.attrs
* Fix a stupid bug in accounting.php3. We should not use the show_attrs array.
Ver 1.54:
* Add attributes for the sql group tables in admin.conf. Now SQL group support should really work!
Ver 1.53:
* html fixes in show_groups.php3
* When reporting sql errors also print the output of da_sql_error
* When updating ldap user information don't do an update if the new attribute value
  is '-' (default value)
* Comment out Reply-Message in conf/user_edit.attrs since in sql it maps to the same attribute as
  the lock message
Ver 1.52:
* Add Reply-Message in conf/user_edit.attrs so that it appears in the user/group edit pages
* Allow the administrator to specify a group in the New User page. Update lib/sql/create_user.php3 to add
  the user to the specified group
* Call user_info.php3 and defaults.php3 in user_new.php3 after creating a user
* Only run if $login is not NULL in lib/sql/defaults.php3
* In group admin add a button to administer the selected user which will redirect the administrator to the
  corresponding user_admin page
* Add a show_groups.php3 to show all active user groups
Ver 1.51:
* Only call user_info.php3 in user_new.php3 when we are creating a user
* Fix a bug with personal information attributes in user_new.php3
Ver 1.50:
* Add support for groups in SQL. Added several new files and modified a few more.
* Default values in SQL are now extracted from the group membership. Added a lib/sql/defaults.php3 file.
  As a result the default operator is not '=' anymore but whatever we find in the group check and reply tables.
* In lib/sql/user_info.php3 set user_exists in more than one places.
* Add support for the '=*' and '!*' operators
* Added a HELP_WANTED file describing what are the major things missing which people could contribute.
* Updated TODO
* Added a help page for the Session Timeout and Idle Timeout attributes.
* The new group page should only be available if the general library type is sql.
* Fix a small bug in lib/sql/create_user.php3 where work and home phone were stored in the wrong fields.
* Set personal information attributes in lib/sql/user_info.php3 to default values.
* Add a page to change the user's personal information. Changed the user toolbar and added htdocs/user_info.php3
  along with lib/{sql,ldap}/change_info.php3
* Print a message if we can't connect to the ldap server in lib/ldap/user_info.php3
* Use a textarea for new members in group_admin.php3 and group_new.php3. Update lib/sql/create_group.php3 and
  lib/sql/group_admin.php3
* Set a few more personal information attributes to defaults in lib/sql/user_info.php3
* Fix a typo for department
* Set personal information attributes to defaults in lib/ldap/user_info.php3
* Have adddress and home address in user personal info
* Set $user_info in lib/{ldap,sql}/user_info.php3 and only if the user exists and has personal info
* Show language attributes only if general_prefered_lang is not 'en'
Ver 1.30:
* Add limit of results returned in accounting.php3
* Fix a bug in time2strclock() in lib/functions.php3. Seconds ammount more than 9 would not show.
  Bug noted by Timophey <bcloud@mail.ru>
* Reaarange a few things in user_admin. Put Subscription Analysis first and 'Account Status' second. Make a
  few things bold.
* Change log_badlogins to use the mysql binary instead of the DBI module. That way we don't have any
  dependencies and we don't need to bother with connection maintainance (dead mysql connections etc).
* html fixes in user_finger.php3
* Fix a bug in lib/add_badusers.php3 which did not allow inserts in the badusers table.
* Make lib/ldap/password_check.php3 behave properly when it is passed a null password
* Allow for daily/weekly/monthly limits to be set to none and show correct results in the show user page
* Fix a small bug in user_admin.php3.
* Pass the whole password as salt in da_encrypt() in password_check.php3
* Refresh the online users page every 50 secs. Patch by Alexandre Strube <surak@barroco.com.br>
* Check if the last logged in server and client ip are valid before calling gethostbyaddr
* If the same attribute appears more than once in the user edit page then show a count of the number of
  occurences next to the attribute name
* Add a server argument to user_finger.php3. If it is set then the page will only show the logged in users
  in that access server instead of all of them. Update the README with documentation for that fact.
Ver 1.29:
* Add general_ld_library_path directive and set LD_LIBRARY_PATH accordingly (used in snmpfinger and
  radaclient).
* Add general_finger_type directive to determine if we will use snmpfinger in user_finger.php3
* Fix a bug in config.php3 when we have a directive containing ':'
* Fix a bug in lib/ldap/change_attrs.php3 that did not allow changing more than one value of a 
  multivalued attribute simultaneously.
* Added selection of ordering in user_accounting.php3. Now it can be either ascending (older records
  first) or descending (most recent records first). Added a corresponding configuration directive.
* Added operator support in sql. The eq(=),set(:=) and add(+=) operators are supported. Added an
  sql_use_operators configuration directive. Hope everything works.
* Fixed a bug in sql/change_attrs which did not allow multi valued attributes in sql.
* unset item_vals before adding info in ldap and sql user_info files.
* Add support for the rest of the operators. Created the lib/operators.php3 file containing helper functions
* Fix a small bug in log_badlogins. The nas domain should be a variable not hard coded.
* Fix a bug in lib/sql/delete_user.php3. Call da_sql_query with the correct arguments
Ver 1.28:
* Make user_delete.php3 print something when a user is deleted
* Cache nas hostname lookups in user_accounting
Ver 1.27:
* Allow for variable expansion in the configuration file. Something like:
  general_base_dir: /usr/local/dialup_admin
  general_default_file: %{general_base_dir}/conf/default.vals
* Small changes in the README file
* A few corrections in the sql drivers
* Enlarged the textboxes in the user_edit page
* Created a folder help
* Added a help page for:
   o Login-Time
   o Simultaneous-Use
   o Dialup-Access
   o Framed-Compression
   o Port-Limit
   o Lock Message
   o Framed-IP-Address
Ver 1.26:
* A few bugfixes for the general sql code (typo mistakes mostly)
Ver 1.25:
* Deleted a mysql_close from lib/mysql/create_user since we now have persistent sql connections
* Removed the select_db() from accounting.php3 since it is not needed
* A lot of html changes in accounting.php3
* Changed the sql code to be modular. Now under lib we don't have a mysql directory but a sql directory
  with a directory drivers which contains the database specific functions. As a result all calls to mysql*
  functions where changed to call da_sql* functions. Right now mysql should work and postgresql *may* work
  It is not tested though. Hopefully things will come back to being stable in a few days.
* Added sql_port and sql_type configuration file directives
Ver 1.20:
* Fixed a bug in lib/ldap/change_attrs. When we modify an attribute do an ldap_mod_del($mod) and then a
  ldap_mod_add($add_r)
* In accounting.php3 show the attribute description instead of the attribute name.
Ver 1.19:
* In lib/ldap/check_password.php3 don't do a user search but use the already available user DN
* Remove the language support from the get_user_info() functions. They are only used in the user_finger page
* In user_state show weekly usage for the week starting from sunday 00:00, not for the last 7 days
* Show upload/download when connected or for the last time the user connected
* Fixed a few minor problems with the help and about pages
Ver 1.18:
* Fixed a small problem with total upload,download numbers in user_admin
* Fixed a major problem in the accounting report generator when adding an attribute check. Now it
  should be all OK.
* Fixed a small bug in lib/mysql/functions.php3. Bug found be galileo@microsky.net
Ver 1.17:
* Fixed a few more problems in the mysql code
* Updated README
* the help page now prints the README file. It also has a common layout with the other pages
* Changed the about page to have a common look with the other pages.
Ver 1.16:
* Fixed a few typing mistakes in mysql.attrmap
* If the corresponding attribute name (in ldap or mysql) is 'none' then do not
  edit/add it. Based on a bug report by galileo@microsky.net
* Fixed a few errors in lib/attrshow.php3
Ver 1.15:
* Added user test page. It will use radclient to send a radius access-request
  to the radius server and check the response. This page is also used to check
  that the radius server is working fine. Added user_test.php3 and a few config
  file parameters.
* Support for multi valued attributes.
* Changed cleartext encryption name from none to clear
* Renamed the general_sql_row_limit configuration directive to sql_row_limit
Ver 1.12:
* Added an FAQ
* Small changes in html code
* Small changes in the README file
* Fixed a small problem in delete_user from ldap
* Removed the Base64 encode since it was causing problems
Ver 1.11:
* Changed all ldap_bind() to use the ldap bind DN and password. Should have been
  the default behaviour
* Do a Base64 encode in ldap/change_password.php3 before sending the password to
  the ldap server
* Added support for module messages in log_badlogins and user_accounting
* Updated documentation
Ver 1.10:
* Added support for users in mysql database. All bugs are welcome. To activate
  just use mysql as library_type
* Added support for salt in crypt.php3
* Added userinfo table to keep information for users (Name,Phone etc). Added two
  corresponding values in admin.conf
* Added mysql.attrmap for mysql support
* Added TODO
* Added persistent connections for mysql (mysql_pconnect())
Ver 1.00:
* Added password change facility in user_edit. Support for multiple
  password encryption methods
* Added user deletion page user_delete.php3 with corresponding ldap lib code
* Moved the second user_info.php3 include in user_edit to the correct location. Also
  used isset instead of == ''
* Moved the action toolbar (show,edit,accounting...) into a separate html file
* Added the nas model in user_finger.php3
Ver 0.99.8:
* Added the caller id in the finger facility
* Changed the start date in the badusers file to 0000
* Added the out of quota message in user_admin
* fixed a few problems with the html code in user_admin.php3
* calculate account status in user_admin for the last week only
* Change font color to red if used time > corresponding limit (weekly or daily)
* Added the user_stats.php3. It can be used by outside pages to get a quick
  overview of the status of the user. It will return the following fields
  separated by new lines:
  account_status(active or inactive),lock message,weekly limit,daily limit,
  weekly used,weekly connections,daily used,daily connections
* fixed a bug in the subscription analysis in user_admin.php3
* calculate weekly used from sunday 00:00:00 when the counters reset
* added clean_radacct which will clean radacct entries which have been open
  for more than a day. It will not do any harm even if it is incorrect since
  when rlm_sql runs if the update operation fails then it will fall back to
  insert (see sql.conf)
* added log_badlogins. It will continuously read the radius.log file and log
  to the radacct table all login incorrect and multiple logins with a
  corresponding acctterminatecause. user_accounting.php3 is already prepared
  for this (it will show those entries in red)
* fix a small bug with null values in change_vals.php3 of the ldap lib
Ver 0.99:
* Added the badusers table
* Added the default and regular profile from ldap for user_edit
* Added the snmpfinger in the finger facility so that it will not
  relly on the sql database.
* Added the new user facility
* Added support for the Lock Message facility
* Various bug fixes and enhancements

Ver 0.31:
* Added the @ sign in the {mysql,ldap}_{open,close} functions so that
  they don't show error messages
* Changed double quotes with single quotes where applicable for performance
  reasons