projects
/
shibboleth
/
cpp-opensaml.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Refactor signature engines.
[shibboleth/cpp-opensaml.git]
/
saml
/
binding
/
impl
/
XMLSigningRule.cpp
diff --git
a/saml/binding/impl/XMLSigningRule.cpp
b/saml/binding/impl/XMLSigningRule.cpp
index
697c49a
..
3cb3daf
100644
(file)
--- a/
saml/binding/impl/XMLSigningRule.cpp
+++ b/
saml/binding/impl/XMLSigningRule.cpp
@@
-22,13
+22,15
@@
#include "internal.h"
#include "exceptions.h"
#include "internal.h"
#include "exceptions.h"
-#include "binding/
XMLSigning
Rule.h"
+#include "binding/
SecurityPolicy
Rule.h"
#include "saml2/core/Assertions.h"
#include "saml2/metadata/Metadata.h"
#include "saml2/core/Assertions.h"
#include "saml2/metadata/Metadata.h"
+#include "saml2/metadata/MetadataCredentialCriteria.h"
#include "saml2/metadata/MetadataProvider.h"
#include "signature/SignatureProfileValidator.h"
#include <log4cpp/Category.hh>
#include "saml2/metadata/MetadataProvider.h"
#include "signature/SignatureProfileValidator.h"
#include <log4cpp/Category.hh>
+#include <xmltooling/security/SignatureTrustEngine.h>
using namespace opensaml::saml2md;
using namespace opensaml;
using namespace opensaml::saml2md;
using namespace opensaml;
@@
-36,47
+38,75
@@
using namespace xmltooling;
using namespace log4cpp;
using namespace std;
using namespace log4cpp;
using namespace std;
+using xmlsignature::SignatureException;
+
namespace opensaml {
namespace opensaml {
+ class SAML_DLLLOCAL XMLSigningRule : public SecurityPolicyRule
+ {
+ public:
+ XMLSigningRule(const DOMElement* e);
+ virtual ~XMLSigningRule() {}
+
+ void evaluate(const xmltooling::XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const;
+
+ private:
+ bool m_errorsFatal;
+ };
+
SecurityPolicyRule* SAML_DLLLOCAL XMLSigningRuleFactory(const DOMElement* const & e)
{
return new XMLSigningRule(e);
}
SecurityPolicyRule* SAML_DLLLOCAL XMLSigningRuleFactory(const DOMElement* const & e)
{
return new XMLSigningRule(e);
}
+
+ static const XMLCh errorsFatal[] = UNICODE_LITERAL_11(e,r,r,o,r,s,F,a,t,a,l);
};
};
+XMLSigningRule::XMLSigningRule(const DOMElement* e) : m_errorsFatal(false)
+{
+ if (e) {
+ const XMLCh* flag = e->getAttributeNS(NULL, errorsFatal);
+ m_errorsFatal = (flag && (*flag==chLatin_t || *flag==chDigit_1));
+ }
+}
+
void XMLSigningRule::evaluate(const XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const
{
Category& log=Category::getInstance(SAML_LOGCAT".SecurityPolicyRule.XMLSigning");
void XMLSigningRule::evaluate(const XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const
{
Category& log=Category::getInstance(SAML_LOGCAT".SecurityPolicyRule.XMLSigning");
- log.debug("evaluating message signing policy");
if (!policy.getIssuerMetadata()) {
log.debug("ignoring message, no issuer metadata supplied");
return;
}
if (!policy.getIssuerMetadata()) {
log.debug("ignoring message, no issuer metadata supplied");
return;
}
- else if (!policy.getTrustEngine()) {
- log.debug("ignoring message, no TrustEngine supplied");
+
+ const SignatureTrustEngine* sigtrust;
+ if (!(sigtrust=dynamic_cast<const SignatureTrustEngine*>(policy.getTrustEngine()))) {
+ log.debug("ignoring message, no SignatureTrustEngine supplied");
return;
}
const SignableObject* signable = dynamic_cast<const SignableObject*>(&message);
return;
}
const SignableObject* signable = dynamic_cast<const SignableObject*>(&message);
- if (!signable || !signable->getSignature()) {
- log.debug("ignoring unsigned or unrecognized message");
+ if (!signable || !signable->getSignature())
return;
return;
- }
log.debug("validating signature profile");
try {
SignatureProfileValidator sigval;
log.debug("validating signature profile");
try {
SignatureProfileValidator sigval;
- sigval.validate
(signable->getSignature(
));
+ sigval.validate
Signature(*(signable->getSignature()
));
}
catch (ValidationException& ve) {
log.error("signature profile failed to validate: %s", ve.what());
}
catch (ValidationException& ve) {
log.error("signature profile failed to validate: %s", ve.what());
+ if (m_errorsFatal)
+ throw;
return;
}
return;
}
- if (!policy.getTrustEngine()->validate(
- *(signable->getSignature()), *(policy.getIssuerMetadata()), policy.getMetadataProvider()->getKeyResolver()
- )) {
+ // Set up criteria object.
+ MetadataCredentialCriteria cc(*(policy.getIssuerMetadata()));
+
+ if (!sigtrust->validate(*(signable->getSignature()), *(policy.getMetadataProvider()), &cc)) {
log.error("unable to verify message signature with supplied trust engine");
log.error("unable to verify message signature with supplied trust engine");
+ if (m_errorsFatal)
+ throw SignatureException("Message was signed, but signature could not be verified.");
return;
}
return;
}