projects
/
freeradius.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fixes from clang / scan-build
[freeradius.git]
/
src
/
modules
/
rlm_eap
/
types
/
rlm_eap_ttls
/
ttls.c
diff --git
a/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
b/src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
index
523bb13
..
fc2aca3
100644
(file)
--- a/
src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
+++ b/
src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c
@@
-76,7
+76,6
@@
static int diameter_verify(REQUEST *request,
*/
offset = 8;
if ((length & (1 << 31)) != 0) {
*/
offset = 8;
if ((length & (1 << 31)) != 0) {
- int attribute;
uint32_t vendor;
DICT_ATTR *da;
uint32_t vendor;
DICT_ATTR *da;
@@
-88,7
+87,7
@@
static int diameter_verify(REQUEST *request,
return 0;
}
return 0;
}
- da = dict_attrbyvalue(attr
ibute
, vendor);
+ da = dict_attrbyvalue(attr, vendor);
/*
* SHOULD check ((length & (1 << 30)) != 0)
/*
* SHOULD check ((length & (1 << 30)) != 0)
@@
-599,7
+598,7
@@
static int vp2diameter(REQUEST *request, tls_session_t *tls_session, VALUE_PAIR
/*
* FIXME: Check the return code.
*/
/*
* FIXME: Check the return code.
*/
- tls_handshake_send(tls_session);
+ tls_handshake_send(
request,
tls_session);
}
/*
}
/*
@@
-619,6
+618,8
@@
static int process_reply(EAP_HANDLER *handler, tls_session_t *tls_session,
ttls_tunnel_t *t = tls_session->opaque;
handler = handler; /* -Wunused */
ttls_tunnel_t *t = tls_session->opaque;
handler = handler; /* -Wunused */
+ rad_assert(request != NULL);
+ rad_assert(handler->request == request);
/*
* If the response packet was Access-Accept, then
/*
* If the response packet was Access-Accept, then
@@
-790,6
+791,7
@@
static int eapttls_postproxy(EAP_HANDLER *handler, void *data)
tls_session_t *tls_session = (tls_session_t *) data;
REQUEST *fake, *request = handler->request;
tls_session_t *tls_session = (tls_session_t *) data;
REQUEST *fake, *request = handler->request;
+ rad_assert(request != NULL);
RDEBUG("Passing reply from proxy back into the tunnel.");
/*
RDEBUG("Passing reply from proxy back into the tunnel.");
/*
@@
-930,6
+932,8
@@
int eapttls_process(EAP_HANDLER *handler, tls_session_t *tls_session)
size_t data_len;
REQUEST *request = handler->request;
size_t data_len;
REQUEST *request = handler->request;
+ rad_assert(request != NULL);
+
/*
* Just look at the buffer directly, without doing
* record_minus.
/*
* Just look at the buffer directly, without doing
* record_minus.