Zap a double free.

[radsecproxy.git] / lib / radsec.c

diff --git a/lib/radsec.c b/lib/radsec.c
index 16a554f..ddd4edd 100644 (file)
--- a/lib/radsec.c
+++ b/lib/radsec.c
@@ -1,4 +1,5 @@
-/* See the file COPYING for licensing information.  */
+/* Copyright 2010, 2011 NORDUnet A/S. All rights reserved.
+   See the file COPYING for licensing information.  */
 
 #if defined HAVE_CONFIG_H
 #include <config.h>
@@ -18,13 +19,16 @@
 #include <radsec/radsec-impl.h>
 #if defined (RS_ENABLE_TLS)
 #include <regex.h>
+#include "debug.h"
 #include "rsp_list.h"
 #include "../radsecproxy.h"
 #endif
 #include "rsp_debug.h"
 
+
+/* Public functions.  */
 int
-rs_context_create(struct rs_context **ctx, const char *dict)
+rs_context_create (struct rs_context **ctx, const char *dict)
 {
   int err = RSE_OK;
   struct rs_context *h;
@@ -53,7 +57,7 @@ rs_context_create(struct rs_context **ctx, const char *dict)
   fn = basename (buf2);
   if (dict_init (dir, fn) < 0)
     {
-      err = RSE_SOME_ERROR;
+      err = RSE_FR;
       goto err_out;
     }
   free (buf1);
@@ -69,14 +73,6 @@ rs_context_create(struct rs_context **ctx, const char *dict)
   debug_init ("libradsec");    /* radsecproxy compat, FIXME: remove */
 
   memset (h, 0, sizeof(struct rs_context));
-  h->realms = malloc (sizeof (struct rs_realm));
-  if (!h->realms)
-    {
-      err = RSE_NOMEM;
-      goto err_out;
-    }
-  memset (h->realms, 0, sizeof (struct rs_realm));
-  h->realms->next = h->realms;
   fr_randinit (&h->fr_randctx, 0);
   fr_rand_seed (NULL, 0);
 
@@ -95,19 +91,6 @@ rs_context_create(struct rs_context **ctx, const char *dict)
   return err;
 }
 
-void rs_context_destroy(struct rs_context *ctx)
-{
-  free (ctx);
-}
-
-int rs_context_set_alloc_scheme(struct rs_context *ctx,
-                               struct rs_alloc_scheme *scheme)
-{
-  return rs_err_ctx_push_fl (ctx, RSE_NOSYS, __FILE__, __LINE__,
-                            "%s: NYI", __func__);
-}
-
-
 struct rs_peer *
 _rs_peer_create (struct rs_context *ctx, struct rs_peer **rootp)
 {
@@ -117,66 +100,64 @@ _rs_peer_create (struct rs_context *ctx, struct rs_peer **rootp)
   if (p)
     {
       memset (p, 0, sizeof(struct rs_peer));
-      p->fd = -1;
       if (*rootp)
-       (*rootp)->next = p;
+       {
+         p->next = (*rootp)->next;
+         (*rootp)->next = p;
+       }
       else
        *rootp = p;
     }
   return p;
 }
 
-int
-rs_server_create (struct rs_connection *conn, struct rs_peer **server)
+static void
+_rs_peer_destroy (struct rs_peer *p)
 {
-  struct rs_peer *srv;
+  assert (p);
+  assert (p->conn);
+  assert (p->conn->ctx);
 
-  srv = _rs_peer_create (conn->ctx, &conn->peers);
-  if (srv)
+  /* NOTE: The peer object doesn't own conn, nor realm.  */
+  /* NOTE: secret is owned by config */
+  if (p->addr)
     {
-      srv->conn = conn;
-      srv->timeout = 1;
-      srv->tries = 3;
+      evutil_freeaddrinfo (p->addr);
+      p->addr = NULL;
     }
-  else
-    return rs_err_conn_push_fl (conn, RSE_NOMEM, __FILE__, __LINE__, NULL);
-  if (*server)
-    *server = srv;
-  return RSE_OK;
+  rs_free (p->conn->ctx, p);
 }
 
-int
-rs_server_set_address (struct rs_peer *server, const char *hostname,
-                      const char *service)
+void
+rs_context_destroy (struct rs_context *ctx)
 {
-  struct rs_error *err;
+  struct rs_realm *r = NULL;
+  struct rs_peer *p = NULL;
 
-  err = _rs_resolv (&server->addr, server->conn->type, hostname, service);
-  if (err)
-    return _rs_err_conn_push_err (server->conn, err);
-  return RSE_OK;
-}
+  for (r = ctx->realms; r; )
+    {
+      struct rs_realm *tmp = r;
+      for (p = r->peers; p; )
+       {
+         struct rs_peer *tmp = p;
+         p = p->next;
+         _rs_peer_destroy (tmp);
+       }
+      r = r->next;
+      rs_free (ctx, tmp);
+    }
 
-void
-rs_server_set_timeout (struct rs_peer *server, int timeout)
-{
-  server->timeout = timeout;
-}
-void
-rs_server_set_tries (struct rs_peer *server, int tries)
-{
-  server->tries = tries;
+  if (ctx->cfg)
+    cfg_free (ctx->cfg);
+  ctx->cfg = NULL;
+
+  rs_free (ctx, ctx);
 }
 
 int
-rs_server_set_secret (struct rs_peer *server, const char *secret)
+rs_context_set_alloc_scheme (struct rs_context *ctx,
+                            struct rs_alloc_scheme *scheme)
 {
-  if (server->secret)
-    free (server->secret);
-  server->secret = (char *) malloc (strlen(secret) + 1);
-  if (!server->secret)
-    return rs_err_conn_push (server->conn, RSE_NOMEM, NULL);
-  strcpy (server->secret, secret);
-  return RSE_OK;
+  return rs_err_ctx_push_fl (ctx, RSE_NOSYS, __FILE__, __LINE__, NULL);
 }