First three string functors, added authn context to resolver/filter contexts.
[shibboleth/cpp-sp.git] / shibsp / handler / impl / SAML1Consumer.cpp
index 7fe6831..2efa16c 100644 (file)
 #include "exceptions.h"
 #include "ServiceProvider.h"
 #include "SessionCache.h"
+#include "attribute/Attribute.h"
+#include "attribute/filtering/AttributeFilter.h"
+#include "attribute/filtering/BasicFilteringContext.h"
+#include "attribute/resolver/AttributeExtractor.h"
 #include "attribute/resolver/ResolutionContext.h"
 #include "handler/AssertionConsumerService.h"
 
@@ -120,6 +124,10 @@ string SAML1Consumer::implementProtocol(
     const AuthenticationStatement* ssoStatement=NULL;
     vector<const opensaml::Assertion*> tokens;
 
+    // Also track "bad" tokens that we'll cache but not use.
+    // This is necessary because there may be valid tokens not aimed at us.
+    vector<const opensaml::Assertion*> badtokens;
+
     // Profile validator.
     time_t now = time(NULL);
     BrowserSSOProfileValidator ssoValidator(application.getAudiences(), now);
@@ -131,6 +139,7 @@ string SAML1Consumer::implementProtocol(
         // Skip unsigned assertion?
         if (!(*a)->getSignature() && flag.first && flag.second) {
             m_log.warn("found unsigned assertion in SAML response, ignoring it per signedAssertions policy");
+            badtokens.push_back(*a);
             continue;
         }
 
@@ -143,8 +152,11 @@ string SAML1Consumer::implementProtocol(
             policy.evaluate(*(*a));
             
             // If no security is in place now, we kick it.
-            if (!alreadySecured && !policy.isSecure())
-                throw SecurityPolicyException("Unable to establish security of the assertion.");
+            if (!alreadySecured && !policy.isSecure()) {
+                m_log.warn("unable to establish security of assertion");
+                badtokens.push_back(*a);
+                continue;
+            }
 
             // Now do profile and core semantic validation to ensure we can use it for SSO.
             ssoValidator.validateAssertion(*(*a));
@@ -158,6 +170,7 @@ string SAML1Consumer::implementProtocol(
         }
         catch (exception& ex) {
             m_log.warn("detected a problem with assertion: %s", ex.what());
+            badtokens.push_back(*a);
         }
     }
 
@@ -173,26 +186,56 @@ string SAML1Consumer::implementProtocol(
 
     m_log.debug("SSO profile processing completed successfully");
 
+    NameIdentifier* n = ssoStatement->getSubject()->getNameIdentifier();
+
     // We've successfully "accepted" at least one SSO token, along with any additional valid tokens.
-    // To complete processing, we need to resolve attributes and then create the session.
+    // To complete processing, we need to extract and resolve attributes and then create the session.
+    multimap<string,Attribute*> resolvedAttributes;
+    AttributeExtractor* extractor = application.getAttributeExtractor();
+    if (extractor) {
+        m_log.debug("extracting pushed attributes...");
+        Locker extlocker(extractor);
+        if (n) {
+            try {
+                extractor->extractAttributes(application, policy.getIssuerMetadata(), *n, resolvedAttributes);
+            }
+            catch (exception& ex) {
+                m_log.error("caught exception extracting attributes: %s", ex.what());
+            }
+        }
+        for (vector<const opensaml::Assertion*>::const_iterator t = tokens.begin(); t!=tokens.end(); ++t) {
+            try {
+                extractor->extractAttributes(application, policy.getIssuerMetadata(), *(*t), resolvedAttributes);
+            }
+            catch (exception& ex) {
+                m_log.error("caught exception extracting attributes: %s", ex.what());
+            }
+        }
+
+        AttributeFilter* filter = application.getAttributeFilter();
+        if (filter && !resolvedAttributes.empty()) {
+            BasicFilteringContext fc(application, policy.getIssuerMetadata());
+            Locker filtlocker(filter);
+            try {
+                filter->filterAttributes(fc, resolvedAttributes);
+            }
+            catch (exception& ex) {
+                m_log.error("caught exception filtering attributes: %s", ex.what());
+                m_log.error("dumping extracted attributes due to filtering exception");
+                for_each(resolvedAttributes.begin(), resolvedAttributes.end(), cleanup_pair<string,shibsp::Attribute>());
+                resolvedAttributes.clear();
+            }
+        }
+    }
 
     // First, normalize the SAML 1.x NameIdentifier...
-    auto_ptr<NameID> nameid(NameIDBuilder::buildNameID());
-    NameIdentifier* n = ssoStatement->getSubject()->getNameIdentifier();
+    auto_ptr<NameID> nameid(n ? NameIDBuilder::buildNameID() : NULL);
     if (n) {
         nameid->setName(n->getName());
         nameid->setFormat(n->getFormat());
         nameid->setNameQualifier(n->getNameQualifier());
     }
 
-    const EntityDescriptor* issuerMetadata = dynamic_cast<const EntityDescriptor*>(policy.getIssuerMetadata()->getParent());
-    auto_ptr<ResolutionContext> ctx(
-        resolveAttributes(application, httpRequest, issuerMetadata, *nameid.get(), &tokens)
-        );
-
-    // Copy over any new tokens, but leave them in the context for cleanup.
-    tokens.insert(tokens.end(), ctx->getResolvedAssertions().begin(), ctx->getResolvedAssertions().end());
-
     // Now we have to extract the authentication details for session setup.
 
     // Session expiration for SAML 1.x is purely SP-driven, and the method is mapped to a ctx class.
@@ -205,20 +248,43 @@ string SAML1Consumer::implementProtocol(
         );
     auto_ptr_char authnMethod(ssoStatement->getAuthenticationMethod());
 
-    vector<shibsp::Attribute*>& attrs = ctx->getResolvedAttributes();
-    string key = application.getServiceProvider().getSessionCache()->insert(
-        lifetime.second ? now + lifetime.second : 0,
-        application,
-        httpRequest.getRemoteAddr().c_str(),
-        issuerMetadata,
-        *nameid.get(),
-        authnInstant.get(),
-        NULL,
-        authnMethod.get(),
-        NULL,
-        &tokens,
-        &attrs
+    const EntityDescriptor* issuerMetadata =
+        policy.getIssuerMetadata() ? dynamic_cast<const EntityDescriptor*>(policy.getIssuerMetadata()->getParent()) : NULL;
+    auto_ptr<ResolutionContext> ctx(
+        resolveAttributes(application, issuerMetadata, nameid.get(), authnMethod.get(), NULL, &tokens, &resolvedAttributes)
         );
-    attrs.clear();  // Attributes are owned by cache now.
-    return key;
+
+    if (ctx.get()) {
+        // Copy over any new tokens, but leave them in the context for cleanup.
+        tokens.insert(tokens.end(), ctx->getResolvedAssertions().begin(), ctx->getResolvedAssertions().end());
+
+        // Copy over new attributes, and transfer ownership.
+        resolvedAttributes.insert(ctx->getResolvedAttributes().begin(), ctx->getResolvedAttributes().end());
+        ctx->getResolvedAttributes().clear();
+    }
+
+    // Now merge in bad tokens for caching.
+    tokens.insert(tokens.end(), badtokens.begin(), badtokens.end());
+
+    try {
+        string key = application.getServiceProvider().getSessionCache()->insert(
+            lifetime.second ? now + lifetime.second : 0,
+            application,
+            httpRequest.getRemoteAddr().c_str(),
+            issuerMetadata,
+            nameid.get(),
+            authnInstant.get(),
+            NULL,
+            authnMethod.get(),
+            NULL,
+            &tokens,
+            &resolvedAttributes
+            );
+        resolvedAttributes.clear();  // Attributes are owned by cache now.
+        return key;
+    }
+    catch (exception&) {
+        for_each(resolvedAttributes.begin(), resolvedAttributes.end(), cleanup_pair<string,Attribute>());
+        throw;
+    }
 }