Ensure that the directory name always ends with /
[freeradius.git] / src / lib / dict.c
index 99d98da..a3ea796 100644 (file)
@@ -25,6 +25,10 @@ RCSID("$Id$")
 
 #include       <freeradius-devel/libradius.h>
 
+#ifdef WITH_DHCP
+#include       <freeradius-devel/dhcp.h>
+#endif
+
 #include       <ctype.h>
 
 #ifdef HAVE_MALLOC_H
@@ -35,16 +39,21 @@ RCSID("$Id$")
 #include       <sys/stat.h>
 #endif
 
+
 #define DICT_VALUE_MAX_NAME_LEN (128)
 #define DICT_VENDOR_MAX_NAME_LEN (128)
 #define DICT_ATTR_MAX_NAME_LEN (128)
 
+#define DICT_ATTR_SIZE sizeof(DICT_ATTR) + DICT_ATTR_MAX_NAME_LEN
+
 static fr_hash_table_t *vendors_byname = NULL;
 static fr_hash_table_t *vendors_byvalue = NULL;
 
 static fr_hash_table_t *attributes_byname = NULL;
 static fr_hash_table_t *attributes_byvalue = NULL;
 
+static fr_hash_table_t *attributes_combo = NULL;
+
 static fr_hash_table_t *values_byvalue = NULL;
 static fr_hash_table_t *values_byname = NULL;
 
@@ -78,7 +87,7 @@ typedef struct value_fixup_t {
  */
 static value_fixup_t *value_fixup = NULL;
 
-static const FR_NAME_NUMBER type_table[] = {
+const FR_NAME_NUMBER dict_attr_types[] = {
        { "integer",    PW_TYPE_INTEGER },
        { "string",     PW_TYPE_STRING },
        { "ipaddr",     PW_TYPE_IPADDR },
@@ -94,11 +103,56 @@ static const FR_NAME_NUMBER type_table[] = {
        { "combo-ip",   PW_TYPE_COMBO_IP },
        { "tlv",        PW_TYPE_TLV },
        { "signed",     PW_TYPE_SIGNED },
+       { "extended",   PW_TYPE_EXTENDED },
+       { "long-extended",      PW_TYPE_LONG_EXTENDED },
+       { "evs",        PW_TYPE_EVS },
+       { "uint8",      PW_TYPE_BYTE },
+       { "uint16",     PW_TYPE_SHORT },
+       { "uint32",     PW_TYPE_INTEGER },
+       { "int32",      PW_TYPE_SIGNED },
+       { "integer64",  PW_TYPE_INTEGER64 },
+       { "uint64",     PW_TYPE_INTEGER64 },
+       { "ipv4prefix", PW_TYPE_IPV4PREFIX },
+       { "vsa",        PW_TYPE_VSA },
        { NULL, 0 }
 };
 
 
 /*
+ *     For packing multiple TLV numbers into one 32-bit integer.  The
+ *     first 3 bytes are just the 8-bit number.  The next two are
+ *     more limited.  We only allow 31 attributes nested 3 layers
+ *     deep, and only 7 nested 4 layers deep.  This should be
+ *     sufficient for most purposes.
+ *
+ *     For TLVs and extended attributes, we packet the base attribute
+ *     number into the upper 8 bits of the "vendor" field.
+ *
+ *     e.g.    OID             attribute       vendor
+ *             241.1           1               (241 << 8)
+ *             241.26.9.1      1               (241 << 8) | (9)
+ *             241.1.2         1 | (2 << 8)    (241 << 8)
+ */
+#define MAX_TLV_NEST (4)
+/*
+ *     Bit packing:
+ *     8 bits of base attribute
+ *     8 bits for nested TLV 1
+ *     8 bits for nested TLV 2
+ *     5 bits for nested TLV 3
+ *     3 bits for nested TLV 4
+ */
+const int fr_attr_max_tlv = MAX_TLV_NEST;
+const int fr_attr_shift[MAX_TLV_NEST + 1] = {
+  0, 8, 16, 24, 29
+};
+
+const int fr_attr_mask[MAX_TLV_NEST + 1] = {
+  0xff, 0xff, 0xff, 0x1f, 0x07
+};
+
+
+/*
  *     Create the hash of the name.
  *
  *     We copy the hash function here because it's substantially faster.
@@ -159,6 +213,30 @@ static int dict_attr_value_cmp(const void *one, const void *two)
        return a->attr - b->attr;
 }
 
+static uint32_t dict_attr_combo_hash(const void *data)
+{
+       uint32_t hash;
+       const DICT_ATTR *attr = data;
+
+       hash = fr_hash(&attr->vendor, sizeof(attr->vendor));
+       hash = fr_hash_update(&attr->type, sizeof(attr->type), hash);
+       return fr_hash_update(&attr->attr, sizeof(attr->attr), hash);
+}
+
+static int dict_attr_combo_cmp(const void *one, const void *two)
+{
+       const DICT_ATTR *a = one;
+       const DICT_ATTR *b = two;
+
+       if (a->type < b->type) return -1;
+       if (a->type > b->type) return +1;
+
+       if (a->vendor < b->vendor) return -1;
+       if (a->vendor > b->vendor) return +1;
+
+       return a->attr - b->attr;
+}
+
 static uint32_t dict_vendor_name_hash(const void *data)
 {
        return dict_hashname(((const DICT_VENDOR *)data)->name);
@@ -348,8 +426,10 @@ static void fr_pool_delete(fr_pool_t **pfp)
 
        for (fp = *pfp; fp != NULL; fp = next) {
                next = fp->page_next;
+               fp->page_next = NULL;
                free(fp);
        }
+       *pfp = NULL;
 }
 
 
@@ -405,8 +485,10 @@ void dict_free(void)
 
        fr_hash_table_free(attributes_byname);
        fr_hash_table_free(attributes_byvalue);
+       fr_hash_table_free(attributes_combo);
        attributes_byname = NULL;
        attributes_byvalue = NULL;
+       attributes_combo = NULL;
 
        fr_hash_table_free(values_byname);
        fr_hash_table_free(values_byvalue);
@@ -420,17 +502,16 @@ void dict_free(void)
        dict_stat_free();
 }
 
-
 /*
  *     Add vendor to the list.
  */
-int dict_addvendor(const char *name, int value)
+int dict_addvendor(const char *name, unsigned int value)
 {
        size_t length;
        DICT_VENDOR *dv;
 
-       if (value > 65535) {
-               fr_strerror_printf("dict_addvendor: Cannot handle vendor ID larger than 65535");
+       if (value >= FR_MAX_VENDOR) {
+               fr_strerror_printf("dict_addvendor: Cannot handle vendor ID larger than 2^24");
                return -1;
        }
 
@@ -489,19 +570,45 @@ int dict_addvendor(const char *name, int value)
 /*
  *     Add an attribute to the dictionary.
  */
-int dict_addattr(const char *name, int attr, int vendor, int type,
+int dict_addattr(const char *name, int attr, unsigned int vendor, int type,
                 ATTR_FLAGS flags)
 {
        size_t namelen;
        static int      max_attr = 0;
-       DICT_ATTR       *da;
-
+       const char      *p;
+       const DICT_ATTR *da;
+       DICT_ATTR *n;
+       
        namelen = strlen(name);
        if (namelen >= DICT_ATTR_MAX_NAME_LEN) {
                fr_strerror_printf("dict_addattr: attribute name too long");
                return -1;
        }
 
+       for (p = name; *p != '\0'; p++) {
+               if (*p < ' ') {
+                       fr_strerror_printf("dict_addattr: attribute name cannot contain control characters");
+                       return -1;
+               }
+
+               if ((*p == '"') || (*p == '\\')) {
+                       fr_strerror_printf("dict_addattr: attribute name cannot contain quotation or backslash");
+                       return -1;
+               }
+
+               if ((*p == '<') || (*p == '>') || (*p == '&')) {
+                       fr_strerror_printf("dict_addattr: attribute name cannot contain XML control characters");
+                       return -1;
+               }
+       }
+
+       if (flags.has_tag &&
+           !((type == PW_TYPE_INTEGER) || (type == PW_TYPE_STRING))) {
+               fr_strerror_printf("dict_addattr: Only 'integer' and 'string' attributes can have tags");
+               return -1;
+       }
+
+
        /*
         *      If the attr is '-1', that means use a pre-existing
         *      one (if it already exists).  If one does NOT already exist,
@@ -524,25 +631,51 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
                }
        }
 
+       /*
+        *      Additional checks for extended attributes.
+        */
+       if (flags.extended || flags.long_extended || flags.evs) {
+               if (vendor && (vendor < FR_MAX_VENDOR)) {
+                       fr_strerror_printf("dict_addattr: VSAs cannot use the \"extended\" or \"evs\" attribute formats.");
+                       return -1;
+               }
+               if (flags.has_tag
+#ifdef WITH_DHCP
+                   || flags.array
+#endif
+                   || (flags.encrypt != FLAG_ENCRYPT_NONE)) {
+                       fr_strerror_printf("dict_addattr: The \"extended\" attributes MUST NOT have any flags set.");
+                       return -1;
+               }
+       }
+
+       if (flags.evs) {
+               if (!(flags.extended || flags.long_extended)) {
+                       fr_strerror_printf("dict_addattr: Attributes of type \"evs\" MUST have a parent of type \"extended\"");
+                       return -1;
+               }
+
+               /* VSAs cannot be of format EVS */
+               if ((vendor & (FR_MAX_VENDOR - 1)) != 0) {
+                       fr_strerror_printf("dict_addattr: Attribute of type \"evs\" fails internal sanity check");
+                       return -1;
+               }
+       }
+               
        if (attr < 0) {
                fr_strerror_printf("dict_addattr: ATTRIBUTE has invalid number (less than zero)");
                return -1;
        }
 
-       if (attr >= 65536) {
-               fr_strerror_printf("dict_addattr: ATTRIBUTE has invalid number (larger than 65535).");
+       if (flags.has_tlv && flags.length) {
+               fr_strerror_printf("TLVs cannot have a fixed length");
                return -1;
        }
 
-       if (vendor) {
+       if ((vendor & (FR_MAX_VENDOR -1)) != 0) {
                DICT_VENDOR *dv;
                static DICT_VENDOR *last_vendor = NULL;
 
-               if (flags.is_tlv && (flags.encrypt != FLAG_ENCRYPT_NONE)) {
-                       fr_strerror_printf("Sub-TLV's cannot be encrypted");
-                       return -1;
-               }
-
                if (flags.has_tlv && (flags.encrypt != FLAG_ENCRYPT_NONE)) {
                        fr_strerror_printf("TLV's cannot be encrypted");
                        return -1;
@@ -564,10 +697,14 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
                 *      dictionary initialization by caching the last
                 *      vendor.
                 */
-               if (last_vendor && (vendor == last_vendor->vendorpec)) {
+               if (last_vendor &&
+                   ((vendor & (FR_MAX_VENDOR - 1)) == last_vendor->vendorpec)) {
                        dv = last_vendor;
                } else {
-                       dv = dict_vendorbyvalue(vendor);
+                       /*
+                        *      Ignore the high byte (sigh)
+                        */
+                       dv = dict_vendorbyvalue(vendor & (FR_MAX_VENDOR - 1));
                        last_vendor = dv;
                }
 
@@ -575,7 +712,8 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
                 *      If the vendor isn't defined, die.
                 */
                if (!dv) {
-                       fr_strerror_printf("dict_addattr: Unknown vendor");
+                       fr_strerror_printf("dict_addattr: Unknown vendor %u",
+                                          vendor & (FR_MAX_VENDOR - 1));
                        return -1;
                }
 
@@ -587,39 +725,91 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
                        fr_strerror_printf("dict_addattr: ATTRIBUTE has invalid number (larger than 255).");
                        return -1;
                } /* else 256..65535 are allowed */
+
+               /*
+                *      If the attribute is in the standard space, AND
+                *      has a sub-type (e.g. 241.1 or 255.3), then its
+                *      number is placed into the upper 8 bits of the
+                *      vendor field.
+                *
+                *      This also happens for the new VSAs.
+                *
+                *      If we find it, then set the various flags
+                *      based on what we see.
+                */
+               if (vendor >= FR_MAX_VENDOR) {
+                       unsigned int parent;
+
+                       parent = (vendor / FR_MAX_VENDOR) & 0xff;
+
+                       da = dict_attrbyvalue(parent, 0);
+                       if (!da) {
+                               fr_strerror_printf("dict_addattr: ATTRIBUTE refers to unknown parent attribute %u.", parent);
+                               return -1;
+                       }
+
+                       /*
+                        *      These flags are inhereited inherited
+                        *      from the parent.
+                        */
+                       flags.extended = da->flags.extended;
+                       flags.long_extended = da->flags.long_extended;
+
+                       /*
+                        *      Non-extended attributes can't have VSAs.
+                        */
+                       if (!flags.extended &&
+                           ((vendor & (FR_MAX_VENDOR - 1)) != 0)) {
+                               fr_strerror_printf("dict_addattr: ATTRIBUTE cannot be a VSA");
+                               return -1;
+                       }
+
+                       if ((vendor & (FR_MAX_VENDOR - 1)) != 0) {
+                               flags.evs = 1;
+                       }
+               }
+
+               /*
+                *      <sigh> Alvarion, being *again* a horribly
+                *      broken vendor, has re-used the WiMAX format in
+                *      their proprietary vendor space.  This re-use
+                *      means that there are *multiple* conflicting
+                *      Alvarion dictionaries.
+                */
+               flags.wimax = dv->flags;
        }
 
        /*
         *      Create a new attribute for the list
         */
-       if ((da = fr_pool_alloc(sizeof(*da) + namelen)) == NULL) {
-               fr_strerror_printf("dict_addattr: out of memory");
+       if ((n = fr_pool_alloc(sizeof(*n) + namelen)) == NULL) {
+       oom:
+               fr_strerror_printf("dict_adnttr: out of memory");
                return -1;
        }
 
-       memcpy(da->name, name, namelen);
-       da->name[namelen] = '\0';
-       da->attr = attr;
-       da->vendor = vendor;
-       da->type = type;
-       da->flags = flags;
-       da->vendor = vendor;
+       memcpy(n->name, name, namelen);
+       n->name[namelen] = '\0';
+       n->attr = attr;
+       n->vendor = vendor;
+       n->type = type;
+       n->flags = flags;
 
        /*
         *      Insert the attribute, only if it's not a duplicate.
         */
-       if (!fr_hash_table_insert(attributes_byname, da)) {
+       if (!fr_hash_table_insert(attributes_byname, n)) {
                DICT_ATTR       *a;
 
                /*
                 *      If the attribute has identical number, then
                 *      ignore the duplicate.
                 */
-               a = fr_hash_table_finddata(attributes_byname, da);
-               if (a && (strcasecmp(a->name, da->name) == 0)) {
-                       if (a->attr != da->attr) {
-                               fr_strerror_printf("dict_addattr: Duplicate attribute name %s", name);
-                               fr_pool_free(da);
+               a = fr_hash_table_finddata(attributes_byname, n);
+               if (a && (strcasecmp(a->name, n->name) == 0)) {
+                       if (a->attr != n->attr) {
+                               fr_strerror_printf("dict_adnttr: Duplicate attribute name %s", name);
+                               fr_pool_free(n);
                                return -1;
                        }
 
@@ -634,9 +824,9 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
 
                fr_hash_table_delete(attributes_byvalue, a);
 
-               if (!fr_hash_table_replace(attributes_byname, da)) {
-                       fr_strerror_printf("dict_addattr: Internal error storing attribute %s", name);
-                       fr_pool_free(da);
+               if (!fr_hash_table_replace(attributes_byname, n)) {
+                       fr_strerror_printf("dict_adnttr: Internal error storing attribute %s", name);
+                       fr_pool_free(n);
                        return -1;
                }
        }
@@ -650,13 +840,48 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
         *      files, but when we're printing them, (and looking up
         *      by value) we want to use the NEW name.
         */
-       if (!fr_hash_table_replace(attributes_byvalue, da)) {
-               fr_strerror_printf("dict_addattr: Failed inserting attribute name %s", name);
+       if (!fr_hash_table_replace(attributes_byvalue, n)) {
+               fr_strerror_printf("dict_adnttr: Failed inserting attribute name %s", name);
                return -1;
        }
 
+       /*
+        *      Hacks for combo-IP
+        */
+       if (n->type == PW_TYPE_COMBO_IP) {
+               DICT_ATTR *v4, *v6;
+
+               v4 = fr_pool_alloc(sizeof(*v4));
+               if (!v4) goto oom;
+
+               v6 = fr_pool_alloc(sizeof(*v6));
+               if (!v6) {
+                       free(v4);
+                       goto oom;
+               }
+
+               memcpy(v4, n, sizeof(*v4));
+               v4->type = PW_TYPE_IPADDR;
+
+               memcpy(v6, n, sizeof(*v6));
+               v6->type = PW_TYPE_IPV6ADDR;
+
+               if (!fr_hash_table_insert(attributes_combo, v4)) {
+                       fr_strerror_printf("dict_addattr: Failed inserting attribute name %s - IPv4", name);
+                       free(v4);
+                       free(v6);
+                       return -1;
+               }
+
+               if (!fr_hash_table_insert(attributes_combo, v6)) {
+                       fr_strerror_printf("dict_addattr: Failed inserting attribute name %s - IPv6", name);
+                       free(v6);
+                       return -1;
+               }
+       }
+
        if (!vendor && (attr > 0) && (attr < 256)) {
-                dict_base_attrs[attr] = da;
+                dict_base_attrs[attr] = n;
        }
 
        return 0;
@@ -669,10 +894,10 @@ int dict_addattr(const char *name, int attr, int vendor, int type,
 int dict_addvalue(const char *namestr, const char *attrstr, int value)
 {
        size_t          length;
-       DICT_ATTR       *dattr;
+       const DICT_ATTR *dattr;
        DICT_VALUE      *dval;
 
-       static DICT_ATTR *last_attr = NULL;
+       static const DICT_ATTR *last_attr = NULL;
 
        if (!*namestr) {
                fr_strerror_printf("dict_addvalue: empty names are not permitted");
@@ -748,14 +973,13 @@ int dict_addvalue(const char *namestr, const char *attrstr, int value)
                        case PW_TYPE_INTEGER:
                                break;
 
+                       case PW_TYPE_INTEGER64:
                        default:
                                fr_pool_free(dval);
                                fr_strerror_printf("dict_addvalue: VALUEs cannot be defined for attributes of type '%s'",
-                                          fr_int2str(type_table, dattr->type, "?Unknown?"));
+                                          fr_int2str(dict_attr_types, dattr->type, "?Unknown?"));
                                return -1;
                }
-
-               dattr->flags.has_value = 1;
        } else {
                value_fixup_t *fixup;
 
@@ -782,25 +1006,30 @@ int dict_addvalue(const char *namestr, const char *attrstr, int value)
        /*
         *      Add the value into the dictionary.
         */
-       if (!fr_hash_table_insert(values_byname, dval)) {
-               if (dattr) {
-                       DICT_VALUE *old;
+       {
+               DICT_ATTR *tmp;
+               memcpy(&tmp, &dval, sizeof(tmp));
+               
+               if (!fr_hash_table_insert(values_byname, tmp)) {
+                       if (dattr) {
+                               DICT_VALUE *old;
 
-                       /*
-                        *      Suppress duplicates with the same
-                        *      name and value.  There are lots in
-                        *      dictionary.ascend.
-                        */
-                       old = dict_valbyname(dattr->attr, dattr->vendor, namestr);
-                       if (old && (old->value == dval->value)) {
-                               fr_pool_free(dval);
-                               return 0;
+                               /*
+                                *      Suppress duplicates with the same
+                                *      name and value.  There are lots in
+                                *      dictionary.ascend.
+                                */
+                               old = dict_valbyname(dattr->attr, dattr->vendor, namestr);
+                               if (old && (old->value == dval->value)) {
+                                       fr_pool_free(dval);
+                                       return 0;
+                               }
                        }
-               }
 
-               fr_pool_free(dval);
-               fr_strerror_printf("dict_addvalue: Duplicate value name %s for attribute %s", namestr, attrstr);
-               return -1;
+                       fr_pool_free(dval);
+                       fr_strerror_printf("dict_addvalue: Duplicate value name %s for attribute %s", namestr, attrstr);
+                       return -1;
+               }
        }
 
        /*
@@ -816,11 +1045,11 @@ int dict_addvalue(const char *namestr, const char *attrstr, int value)
        return 0;
 }
 
-static int sscanf_i(const char *str, int *pvalue)
+static int sscanf_i(const char *str, unsigned int *pvalue)
 {
        int rcode = 0;
        int base = 10;
-       const char *tab = "0123456789";
+       static const char *tab = "0123456789";
 
        if ((str[0] == '0') &&
            ((str[1] == 'x') || (str[1] == 'X'))) {
@@ -833,6 +1062,8 @@ static int sscanf_i(const char *str, int *pvalue)
        while (*str) {
                const char *c;
 
+               if (*str == '.') break;
+
                c = memchr(tab, tolower((int) *str), base);
                if (!c) return 0;
 
@@ -847,160 +1078,501 @@ static int sscanf_i(const char *str, int *pvalue)
 
 
 /*
- *     Process the ATTRIBUTE command
+ *     Get the OID based on various pieces of information.
+ *
+ *     Remember, the packing format is weird.
+ *
+ *     00VID   000000AA        normal VSA for vendor VID
+ *     00VID   AABBCCDD        normal VSAs with TLVs
+ *     EE000   000000AA        extended attr (241.1)
+ *     EE000   AABBCCDD        extended attr with TLVs
+ *     EEVID   000000AA        EVS with vendor VID, attr AAA
+ *     EEVID   AABBCCDD        EVS with TLVs
+ *
+ *     <whew>!  Are we crazy, or what?
  */
-static int process_attribute(const char* fn, const int line,
-                            const int block_vendor, DICT_ATTR *block_tlv,
-                            char **argv, int argc)
+int dict_str2oid(const char *ptr, unsigned int *pvalue, unsigned int *pvendor,
+                int tlv_depth)
 {
-       int             vendor = 0;
-       int             value;
-       int             type;
-       ATTR_FLAGS      flags;
+       const char *p;
+       unsigned int value;
+       const DICT_ATTR *da = NULL;
 
-       if ((argc < 3) || (argc > 4)) {
-               fr_strerror_printf("dict_init: %s[%d]: invalid ATTRIBUTE line",
-                       fn, line);
+       if (tlv_depth > fr_attr_max_tlv) {
+               fr_strerror_printf("Too many sub-attributes");
                return -1;
        }
 
        /*
-        *      Validate all entries
+        *      If *pvalue is set, check if the attribute exists.
+        *      Otherwise, check that the vendor exists.
         */
-       if (!sscanf_i(argv[1], &value)) {
-               fr_strerror_printf("dict_init: %s[%d]: invalid value", fn, line);
-               return -1;
-       }
+       if (*pvalue) {
+               da = dict_attrbyvalue(*pvalue, *pvendor);
+               if (!da) {
+                       fr_strerror_printf("Parent attribute is undefined.");
+                       return -1;
+               }
+               
+               if (!da->flags.has_tlv && !da->flags.extended) {
+                       fr_strerror_printf("Parent attribute %s cannot have sub-attributes",
+                                          da->name);
+                       return -1;
+               }
 
-       /*
-        *      find the type of the attribute.
-        */
-       type = fr_str2int(type_table, argv[2], -1);
-       if (type < 0) {
-               fr_strerror_printf("dict_init: %s[%d]: invalid type \"%s\"",
-                       fn, line, argv[2]);
-               return -1;
+       } else if ((*pvendor & (FR_MAX_VENDOR - 1)) != 0) {
+               if (!dict_vendorbyvalue(*pvendor & (FR_MAX_VENDOR - 1))) {
+                       fr_strerror_printf("Unknown vendor %u",
+                                          *pvendor & (FR_MAX_VENDOR - 1));
+                       return -1;
+               }
        }
 
+       p = strchr(ptr, '.');
+
        /*
-        *      Only look up the vendor if the string
-        *      is non-empty.
+        *      Look for 26.VID.x.y
+        *
+        *      If we find it, re-write the parameters, and recurse.
         */
-       memset(&flags, 0, sizeof(flags));
-       if (argc == 4) {
-               char *key, *next, *last;
+       if (!*pvendor && (tlv_depth == 0) && (*pvalue == PW_VENDOR_SPECIFIC)) {
+               const DICT_VENDOR *dv;
 
-               key = argv[3];
-               do {
-                       next = strchr(key, ',');
-                       if (next) *(next++) = '\0';
+               if (!p) {
+                       fr_strerror_printf("VSA needs to have sub-attribute");
+                       return -1;
+               }
 
-                       if (strcmp(key, "has_tag") == 0 ||
-                           strcmp(key, "has_tag=1") == 0) {
-                               /* Boolean flag, means this is a
-                                  tagged attribute */
-                               flags.has_tag = 1;
-                               
-                       } else if (strncmp(key, "encrypt=", 8) == 0) {
-                               /* Encryption method, defaults to 0 (none).
-                                  Currently valid is just type 2,
-                                  Tunnel-Password style, which can only
-                                  be applied to strings. */
-                               flags.encrypt = strtol(key + 8, &last, 0);
-                               if (*last) {
-                                       fr_strerror_printf( "dict_init: %s[%d] invalid option %s",
-                                                   fn, line, key);
-                                       return -1;
-                               }
-                               
-                       } else if (strncmp(key, "array", 8) == 0) {
-                               flags.array = 1;
-                               
-                               switch (type) {
-                                       case PW_TYPE_IPADDR:
-                                       case PW_TYPE_BYTE:
-                                       case PW_TYPE_SHORT:
-                                       case PW_TYPE_INTEGER:
-                                       case PW_TYPE_DATE:
-                                               break;
+               if (!sscanf_i(ptr, pvendor)) {
+                       fr_strerror_printf("Invalid number in attribute");
+                       return -1;
+               }
 
-                                       default:
-                                               fr_strerror_printf( "dict_init: %s[%d] Only IP addresses can have the \"array\" flag set.",
-                                                           fn, line);
-                                               return -1;
-                               }
+               if (*pvendor >= FR_MAX_VENDOR) {
+                       fr_strerror_printf("Cannot handle vendor ID larger than 2^24");
+                       
+                       return -1;
+               }
 
-                               /*
-                                *      The only thing is the vendor name,
-                                *      and it's a known name: allow it.
-                                */
-                       } else if ((key == argv[3]) && !next && !block_vendor &&
-                                  ((vendor = dict_vendorbyname(key)) !=0)) {
-                               break;
+               dv = dict_vendorbyvalue(*pvendor & (FR_MAX_VENDOR - 1));
+               if (!dv) {
+                       fr_strerror_printf("Unknown vendor \"%u\" ",
+                                          *pvendor  & (FR_MAX_VENDOR - 1));
+                       return -1;
+               }
 
-                       } else {
-                               fr_strerror_printf( "dict_init: %s[%d]: unknown option \"%s\"",
-                                           fn, line, key);
-                               return -1;
-                       }
+               /*
+                *      Start off with (attr=0, vendor=VID), and
+                *      recurse.  This causes the various checks above
+                *      to be done.
+                */
+               *pvalue = 0;
+               return dict_str2oid(p + 1, pvalue, pvendor, 0);
+       }
 
-                       key = next;
-                       if (key && !*key) break;
-               } while (key);
+       if (!sscanf_i(ptr, &value)) {
+               fr_strerror_printf("Invalid number in attribute");
+               return -1;
        }
 
-       if (block_vendor) vendor = block_vendor;
+       if (!*pvendor && (tlv_depth == 1) && da &&
+           (da->flags.has_tlv || da->flags.extended)) {
+
+
+               *pvendor = *pvalue * FR_MAX_VENDOR;
+               *pvalue = value;
+
+               if (!p) return 0;
+               return dict_str2oid(p + 1, pvalue, pvendor, 1);
+       }
 
        /*
-        *      Special checks for tags, they make our life much more
-        *      difficult.
+        *      And pack the data according to the scheme described in
+        *      the comments at the start of this function.
         */
-       if (flags.has_tag) {
-               /*
-                *      Only string, octets, and integer can be tagged.
-                */
-               switch (type) {
-               case PW_TYPE_STRING:
-               case PW_TYPE_INTEGER:
-                       break;
+       if (*pvalue) {
+               *pvalue |= (value & fr_attr_mask[tlv_depth]) << fr_attr_shift[tlv_depth];
+       } else {
+               *pvalue = value;
+       }
 
-               default:
-                       fr_strerror_printf("dict_init: %s[%d]: Attributes of type %s cannot be tagged.",
-                                  fn, line,
-                                  fr_int2str(type_table, type, "?Unknown?"));
-                       return -1;
+       if (p) {
+               return dict_str2oid(p + 1, pvalue, pvendor, tlv_depth + 1);
+       }
 
-               }
+       return tlv_depth;
+}
+
+/*
+ *     Bamboo skewers under the fingernails in 5, 4, 3, 2, ...
+ */
+static const DICT_ATTR *dict_parent(unsigned int attr, unsigned int vendor)
+{
+       if (vendor < FR_MAX_VENDOR) {
+               return dict_attrbyvalue(attr & 0xff, vendor);
        }
 
-       if (type == PW_TYPE_TLV) {
-               flags.has_tlv = 1;
+       if (attr < 256) {
+               return dict_attrbyvalue((vendor / FR_MAX_VENDOR) & 0xff, 0);
        }
 
-       if (block_tlv) {
+       return dict_attrbyvalue(attr & 0xff, vendor);
+}
+
+
+/*
+ *     Process the ATTRIBUTE command
+ */
+static int process_attribute(const char* fn, const int line,
+                            unsigned int block_vendor,
+                            const DICT_ATTR *block_tlv, int tlv_depth,
+                            char **argv, int argc)
+{
+       int             oid = 0;
+       unsigned int    vendor = 0;
+       unsigned int    value;
+       int             type;
+       unsigned int    length = 0;
+       ATTR_FLAGS      flags;
+       char            *p;
+
+       if ((argc < 3) || (argc > 4)) {
+               fr_strerror_printf("dict_init: %s[%d]: invalid ATTRIBUTE line",
+                       fn, line);
+               return -1;
+       }
+
+       /*
+        *      Dictionaries need to have real names, not shitty ones.
+        */
+       if (strncmp(argv[1], "Attr-", 5) == 0) {
+               fr_strerror_printf("dict_init: %s[%d]: Invalid attribute name",
+                                  fn, line);
+               return -1;
+       }
+
+       memset(&flags, 0, sizeof(flags));
+
+       /*
+        *      Look for OIDs before doing anything else.
+        */
+       p = strchr(argv[1], '.');
+       if (p) oid = 1;
+
+       /*
+        *      Validate all entries
+        */
+       if (!sscanf_i(argv[1], &value)) {
+               fr_strerror_printf("dict_init: %s[%d]: invalid value", fn, line);
+               return -1;
+       }
+
+       if (oid) {
+               const DICT_ATTR *da;
+
+               vendor = block_vendor;
+
                /*
-                *      TLV's can be only one octet.
+                *      Parse the rest of the OID.
                 */
-               if ((value <= 0) || (value > 255)) {
-                       fr_strerror_printf( "dict_init: %s[%d]: sub-tlv's cannot have value > 255",
-                                   fn, line);
+               if (dict_str2oid(p + 1, &value, &vendor, tlv_depth + 1) < 0) {
+                       char buffer[256];
+
+                       strlcpy(buffer, fr_strerror(), sizeof(buffer));
+                       
+                       fr_strerror_printf("dict_init: %s[%d]: Invalid attribute identifier: %s", fn, line, buffer);
                        return -1;
                }
+               block_vendor = vendor;
 
-               if (flags.encrypt != FLAG_ENCRYPT_NONE) {
-                       fr_strerror_printf( "dict_init: %s[%d]: sub-tlv's cannot be encrypted",
-                                   fn, line);
+               /*
+                *      Set the flags based on the parents flags.
+                */
+               da = dict_parent(value, vendor);
+               if (!da) {
+                       fr_strerror_printf("dict_init: %s[%d]: Parent attribute is undefined.", fn, line);
+                       return -1;
+               }
+
+               flags.extended = da->flags.extended;
+               flags.long_extended = da->flags.long_extended;
+               flags.evs = da->flags.evs;
+               if (da->flags.has_tlv) flags.is_tlv = 1;
+       }
+
+       if (strncmp(argv[2], "octets[", 7) != 0) {
+               /*
+                *      find the type of the attribute.
+                */
+               type = fr_str2int(dict_attr_types, argv[2], -1);
+               if (type < 0) {
+                       fr_strerror_printf("dict_init: %s[%d]: invalid type \"%s\"",
+                                          fn, line, argv[2]);
+                       return -1;
+               }
+
+       } else {
+               type = PW_TYPE_OCTETS;
+               
+               p = strchr(argv[2] + 7, ']');
+               if (!p) {
+                       fr_strerror_printf("dict_init: %s[%d]: Invalid format for octets", fn, line);
+                       return -1;
+               }
+
+               *p = 0;
+
+               if (!sscanf_i(argv[1], &length)) {
+                       fr_strerror_printf("dict_init: %s[%d]: invalid length", fn, line);
+                       return -1;
+               }
+
+               if ((length == 0) || (length > 253)) {
+                       fr_strerror_printf("dict_init: %s[%d]: invalid length", fn, line);
+                       return -1;
+               }
+       }
+
+       /*
+        *      Only look up the vendor if the string
+        *      is non-empty.
+        */
+       if (argc < 4) {
+               /*
+                *      Force "length" for data types of fixed length;
+                */
+               switch (type) {
+               case PW_TYPE_BYTE:
+                       length = 1;
+                       break;
+
+               case PW_TYPE_SHORT:
+                       length = 2;
+                       break;
+
+               case PW_TYPE_DATE:
+               case PW_TYPE_IPADDR:
+               case PW_TYPE_INTEGER:
+               case PW_TYPE_SIGNED:
+                       length = 4;
+                       break;
+
+               case PW_TYPE_INTEGER64:
+                       length = 8;
+                       break;
+
+               case PW_TYPE_ETHERNET:
+                       length = 6;
+                       break;
+
+               case PW_TYPE_IFID:
+                       length = 8;
+                       break;
+
+               case PW_TYPE_IPV6ADDR:
+                       length = 16;
+                       break;
+
+               case PW_TYPE_EXTENDED:
+                       if ((vendor != 0) || (value < 241)) {
+                               fr_strerror_printf("dict_init: %s[%d]: Attributes of type \"extended\" MUST be RFC attributes with value >= 241.", fn, line);
+                               return -1;
+                       }
+                       flags.extended = 1;
+                       break;
+
+               case PW_TYPE_LONG_EXTENDED:
+                       if ((vendor != 0) || (value < 241)) {
+                               fr_strerror_printf("dict_init: %s[%d]: Attributes of type \"long-extended\" MUST be RFC attributes with value >= 241.", fn, line);
+                               return -1;
+                       }
+                       flags.extended = 1;
+                       flags.long_extended = 1;
+                       break;
+
+               case PW_TYPE_EVS:
+                       flags.extended = 1;
+                       flags.evs = 1;
+                       if (value != PW_VENDOR_SPECIFIC) {
+                               fr_strerror_printf("dict_init: %s[%d]: Attributes of type \"evs\" MUST have attribute code 26.", fn, line);
+                               return -1;
+                       }
+                       break;
+
+               default:
+                       break;
+               }
+
+               flags.length = length;
+
+       } else {                /* argc == 4: we have options */
+               char *key, *next, *last;
+
+               /*
+                *      Keep it real.
+                */
+               if (flags.extended) {
+                       fr_strerror_printf("dict_init: %s[%d]: Extended attributes cannot use flags", fn, line);
+                       return -1;
+               }
+
+               if (length != 0) {
+                       fr_strerror_printf("dict_init: %s[%d]: length cannot be used with options", fn, line);
+                       return -1;
+               }
+
+               key = argv[3];
+               do {
+                       next = strchr(key, ',');
+                       if (next) *(next++) = '\0';
+
+                       if (strcmp(key, "has_tag") == 0 ||
+                           strcmp(key, "has_tag=1") == 0) {
+                               /* Boolean flag, means this is a
+                                  tagged attribute */
+                               flags.has_tag = 1;
+                               
+                       } else if (strncmp(key, "encrypt=", 8) == 0) {
+                               /* Encryption method, defaults to 0 (none).
+                                  Currently valid is just type 2,
+                                  Tunnel-Password style, which can only
+                                  be applied to strings. */
+                               flags.encrypt = strtol(key + 8, &last, 0);
+                               if (*last) {
+                                       fr_strerror_printf( "dict_init: %s[%d] invalid option %s",
+                                                   fn, line, key);
+                                       return -1;
+                               }
+
+                               if ((flags.encrypt == FLAG_ENCRYPT_ASCEND_SECRET) &&
+                                   (type != PW_TYPE_STRING)) {
+                                       fr_strerror_printf( "dict_init: %s[%d] Only \"string\" types can have the \"encrypt=3\" flag set.",
+                                                           fn, line);
+                                       return -1;
+                               }
+                               
+                       } else if (strncmp(key, "array", 6) == 0) {
+                               flags.array = 1;
+                               
+                               switch (type) {
+                                       case PW_TYPE_IPADDR:
+                                       case PW_TYPE_BYTE:
+                                       case PW_TYPE_SHORT:
+                                       case PW_TYPE_INTEGER:
+                                       case PW_TYPE_DATE:
+                                               break;
+
+                                       default:
+                                               fr_strerror_printf( "dict_init: %s[%d] Only IP addresses can have the \"array\" flag set.",
+                                                           fn, line);
+                                               return -1;
+                               }
+
+                               /*
+                                *      The only thing is the vendor name,
+                                *      and it's a known name: allow it.
+                                */
+                       } else if ((key == argv[3]) && !next) {
+                               if (oid) {
+                                       fr_strerror_printf( "dict_init: %s[%d] New-style attributes cannot use a vendor flag.",
+                                                           fn, line);
+                                       return -1;
+                               }
+
+                               if (block_vendor) {
+                                       fr_strerror_printf( "dict_init: %s[%d] Vendor flag inside of \"BEGIN-VENDOR\" is not allowed.",
+                                                           fn, line);
+                                       return -1;
+                               }
+
+                               vendor = dict_vendorbyname(key);
+                               if (!vendor) goto unknown;
+                               break;
+
+                       } else {
+                       unknown:
+                               fr_strerror_printf( "dict_init: %s[%d]: unknown option \"%s\"",
+                                           fn, line, key);
+                               return -1;
+                       }
+
+                       key = next;
+                       if (key && !*key) break;
+               } while (key);
+       }
+
+       if (block_vendor) vendor = block_vendor;
+
+       /*
+        *      Special checks for tags, they make our life much more
+        *      difficult.
+        */
+       if (flags.has_tag) {
+               /*
+                *      Only string, octets, and integer can be tagged.
+                */
+               switch (type) {
+               case PW_TYPE_STRING:
+               case PW_TYPE_INTEGER:
+                       break;
+
+               default:
+                       fr_strerror_printf("dict_init: %s[%d]: Attributes of type %s cannot be tagged.",
+                                  fn, line,
+                                  fr_int2str(dict_attr_types, type, "?Unknown?"));
+                       return -1;
+               }
+       }
+
+       if (type == PW_TYPE_TLV) {
+               if (vendor && (vendor < FR_MAX_VENDOR)
+#ifdef WITH_DHCP
+                   && (vendor != DHCP_MAGIC_VENDOR)
+#endif
+                       ) {
+                       DICT_VENDOR *dv;
+
+                       dv = dict_vendorbyvalue(vendor);
+                       if (!dv || (dv->type != 1) || (dv->length != 1)) {
+                               fr_strerror_printf("dict_init: %s[%d]: Type \"tlv\" can only be for \"format=1,1\".",
+                                                  fn, line);
+                               return -1;
+                       }
+
+               }
+               flags.has_tlv = 1;
+       }
+       
+       if (block_tlv) {
+               /*
+                *      TLV's can be only one octet.
+                */
+               if ((value == 0) || ((value & ~fr_attr_mask[tlv_depth]) != 0)) {
+                       fr_strerror_printf( "dict_init: %s[%d]: sub-tlv has invalid attribute number",
+                                           fn, line);
                        return -1;
                }
 
                /*
                 *      
                 */
-               value <<= 8;
-               value |= (block_tlv->attr & 0xffff);
+               value <<= fr_attr_shift[tlv_depth];
+               value |= block_tlv->attr;
                flags.is_tlv = 1;
        }
 
+#ifdef WITH_DICTIONARY_WARNINGS
+       /*
+        *      Hack to help us discover which vendors have illegal
+        *      attributes.
+        */
+       if (!vendor && (value < 256) &&
+           !strstr(fn, "rfc") && !strstr(fn, "illegal")) {
+               fprintf(stderr, "WARNING: Illegal Attribute %s in %s\n",
+                       argv[0], fn);
+       }
+#endif
+
        /*
         *      Add it in.
         */
@@ -1024,7 +1596,7 @@ static int process_attribute(const char* fn, const int line,
 static int process_value(const char* fn, const int line, char **argv,
                         int argc)
 {
-       int     value;
+       unsigned int    value;
 
        if (argc != 3) {
                fr_strerror_printf("dict_init: %s[%d]: invalid VALUE line",
@@ -1069,7 +1641,7 @@ static int process_value(const char* fn, const int line, char **argv,
 static int process_value_alias(const char* fn, const int line, char **argv,
                               int argc)
 {
-       DICT_ATTR *my_da, *da;
+       const DICT_ATTR *my_da, *da;
        DICT_VALUE *dval;
 
        if (argc != 2) {
@@ -1085,12 +1657,6 @@ static int process_value_alias(const char* fn, const int line, char **argv,
                return -1;
        }
 
-       if (my_da->flags.has_value) {
-               fr_strerror_printf("dict_init: %s[%d]: Cannot add VALUE-ALIAS to ATTRIBUTE \"%s\" with pre-existing VALUE",
-                          fn, line, argv[0]);
-               return -1;
-       }
-
        if (my_da->flags.has_value_alias) {
                fr_strerror_printf("dict_init: %s[%d]: Cannot add VALUE-ALIAS to ATTRIBUTE \"%s\" with pre-existing VALUE-ALIAS",
                           fn, line, argv[0]);
@@ -1104,12 +1670,6 @@ static int process_value_alias(const char* fn, const int line, char **argv,
                return -1;
        }
 
-       if (!da->flags.has_value) {
-               fr_strerror_printf("dict_init: %s[%d]: VALUE-ALIAS cannot refer to ATTRIBUTE %s: It has no values",
-                          fn, line, argv[1]);
-               return -1;
-       }
-
        if (da->flags.has_value_alias) {
                fr_strerror_printf("dict_init: %s[%d]: Cannot add VALUE-ALIAS to ATTRIBUTE \"%s\" which itself has a VALUE-ALIAS",
                           fn, line, argv[1]);
@@ -1223,6 +1783,12 @@ static int process_vendor(const char* fn, const int line, char **argv,
                length = (int) (p[2] - '0');
 
                if (p[3] == ',') {
+                       if (!p[4]) {
+                               fr_strerror_printf("dict_init: %s[%d]: Invalid format for VENDOR.  Expected text like \"1,1\", got \"%s\"",
+                                  fn, line, p);
+                               return -1;
+                       }
+
                        if ((p[4] != 'c') ||
                            (p[5] != '\0')) {
                                fr_strerror_printf("dict_init: %s[%d]: Invalid format for VENDOR.  Expected text like \"1,1\", got \"%s\"",
@@ -1230,6 +1796,13 @@ static int process_vendor(const char* fn, const int line, char **argv,
                                return -1;
                        }
                        continuation = 1;
+
+                       if ((value != VENDORPEC_WIMAX) ||
+                           (type != 1) || (length != 1)) {
+                               fr_strerror_printf("dict_init: %s[%d]: Only WiMAX VSAs can have continuations",
+                                          fn, line);
+                               return -1;
+                       }
                }
 
                dv = dict_vendorbyvalue(value);
@@ -1263,12 +1836,12 @@ static int process_vendor(const char* fn, const int line, char **argv,
  *     String split routine.  Splits an input string IN PLACE
  *     into pieces, based on spaces.
  */
-static int str2argv(char *str, char **argv, int max_argc)
+int str2argv(char *str, char **argv, int max_argc)
 {
        int argc = 0;
 
        while (*str) {
-               if (argc >= max_argc) return argc;
+               if (argc >= max_argc) break;
 
                /*
                 *      Chop out comments early.
@@ -1283,7 +1856,7 @@ static int str2argv(char *str, char **argv, int max_argc)
                       (*str == '\r') ||
                       (*str == '\n')) *(str++) = '\0';
 
-               if (!*str) return argc;
+               if (!*str) break;
 
                argv[argc] = str;
                argc++;
@@ -1303,38 +1876,72 @@ static int str2argv(char *str, char **argv, int max_argc)
 /*
  *     Initialize the dictionary.
  */
-static int my_dict_init(const char *dir, const char *fn,
+static int my_dict_init(const char *parent, const char *filename,
                        const char *src_file, int src_line)
 {
        FILE    *fp;
-       char    dirtmp[256];
+       char    dir[256], fn[256];
        char    buf[256];
        char    *p;
        int     line = 0;
-       int     vendor;
-       int     block_vendor;
+       unsigned int    vendor;
+       unsigned int    block_vendor;
        struct stat statbuf;
        char    *argv[MAX_ARGV];
        int     argc;
-       DICT_ATTR *da, *block_tlv = NULL;
+       const DICT_ATTR *da, *block_tlv[MAX_TLV_NEST + 1];
+       int     which_block_tlv = 0;
+
+       block_tlv[0] = NULL;
+       block_tlv[1] = NULL;
+       block_tlv[2] = NULL;
+       block_tlv[3] = NULL;
 
-       if (strlen(fn) >= sizeof(dirtmp) / 2 ||
-           strlen(dir) >= sizeof(dirtmp) / 2) {
+       if ((strlen(parent) + 3 + strlen(filename)) > sizeof(dir)) {
                fr_strerror_printf("dict_init: filename name too long");
                return -1;
        }
 
        /*
-        *      First see if fn is relative to dir. If so, create
-        *      new filename. If not, remember the absolute dir.
+        *      If it's an absolute dir, forget the parent dir,
+        *      and remember the new one.
+        *
+        *      If it's a relative dir, tack on the current filename
+        *      to the parent dir.  And use that.
         */
-       if ((p = strrchr(fn, FR_DIR_SEP)) != NULL) {
-               strcpy(dirtmp, fn);
-               dirtmp[p - fn] = 0;
-               dir = dirtmp;
-       } else if (dir && dir[0] && strcmp(dir, ".") != 0) {
-               snprintf(dirtmp, sizeof(dirtmp), "%s/%s", dir, fn);
-               fn = dirtmp;
+       if (!FR_DIR_IS_RELATIVE(filename)) {
+               strlcpy(dir, filename, sizeof(dir));
+               p = strrchr(dir, FR_DIR_SEP);
+               if (p) {
+                       p[1] = '\0';
+               } else {
+                       strlcat(dir, "/", sizeof(dir));
+               }
+
+               strlcpy(fn, filename, sizeof(fn));
+       } else {
+               strlcpy(dir, parent, sizeof(dir));
+               p = strrchr(dir, FR_DIR_SEP);
+               if (p) {
+                       if (p[1]) strlcat(dir, "/", sizeof(dir));
+               } else {
+                       strlcat(dir, "/", sizeof(dir));
+               }
+               strlcat(dir, filename, sizeof(dir));
+               p = strrchr(dir, FR_DIR_SEP);
+               if (p) {
+                       p[1] = '\0';
+               } else {
+                       strlcat(dir, "/", sizeof(dir));
+               }
+
+               p = strrchr(filename, FR_DIR_SEP);
+               if (p) {
+                       snprintf(fn, sizeof(fn), "%s%s", dir, p);
+               } else {
+                       snprintf(fn, sizeof(fn), "%s%s", dir, filename);
+               }
+
        }
 
        if ((fp = fopen(fn, "r")) == NULL) {
@@ -1345,7 +1952,7 @@ static int my_dict_init(const char *dir, const char *fn,
                        fr_strerror_printf("dict_init: %s[%d]: Couldn't open dictionary \"%s\": %s",
                                   src_file, src_line, fn, strerror(errno));
                }
-               return -1;
+               return -2;
        }
 
        stat(fn, &statbuf); /* fopen() guarantees this will succeed */
@@ -1418,7 +2025,8 @@ static int my_dict_init(const char *dir, const char *fn,
                 */
                if (strcasecmp(argv[0], "ATTRIBUTE") == 0) {
                        if (process_attribute(fn, line, block_vendor,
-                                             block_tlv,
+                                             block_tlv[which_block_tlv],
+                                             which_block_tlv,
                                              argv + 1, argc - 1) == -1) {
                                fclose(fp);
                                return -1;
@@ -1437,6 +2045,21 @@ static int my_dict_init(const char *dir, const char *fn,
                        continue;
                } /* $INCLUDE */
 
+               /*
+                *      Optionally include a dictionary
+                */
+               if (strcasecmp(argv[0], "$INCLUDE-") == 0) {
+                       int rcode = my_dict_init(dir, argv[1], fn, line);
+
+                       if (rcode == -2) continue;
+
+                       if (rcode < 0) {
+                               fclose(fp);
+                               return -1;
+                       }
+                       continue;
+               } /* $INCLUDE- */
+
                if (strcasecmp(argv[0], "VALUE-ALIAS") == 0) {
                        if (process_value_alias(fn, line,
                                                argv + 1, argc - 1) == -1) {
@@ -1484,7 +2107,16 @@ static int my_dict_init(const char *dir, const char *fn,
                                return -1;
                        }
 
-                       block_tlv = da;
+                       if (which_block_tlv >= MAX_TLV_NEST) {
+                               fr_strerror_printf(
+                                       "dict_init: %s[%d]: TLVs are nested too deep",
+                                       fn, line);
+                               fclose(fp);
+                               return -1;
+                       }
+
+
+                       block_tlv[++which_block_tlv] = da;
                        continue;
                } /* BEGIN-TLV */
 
@@ -1506,19 +2138,19 @@ static int my_dict_init(const char *dir, const char *fn,
                                return -1;
                        }
 
-                       if (da != block_tlv) {
+                       if (da != block_tlv[which_block_tlv]) {
                                fr_strerror_printf(
                                        "dict_init: %s[%d]: END-TLV %s does not match any previous BEGIN-TLV",
                                        fn, line, argv[1]);
                                fclose(fp);
                                return -1;
                        }
-                       block_tlv = NULL;
+                       block_tlv[which_block_tlv--] = NULL;
                        continue;
                } /* END-VENDOR */
 
                if (strcasecmp(argv[0], "BEGIN-VENDOR") == 0) {
-                       if (argc != 2) {
+                       if (argc < 2) {
                                fr_strerror_printf(
                                "dict_init: %s[%d] invalid BEGIN-VENDOR entry",
                                        fn, line);
@@ -1534,7 +2166,47 @@ static int my_dict_init(const char *dir, const char *fn,
                                fclose(fp);
                                return -1;
                        }
+
                        block_vendor = vendor;
+
+                       /*
+                        *      Check for extended attr VSAs
+                        *
+                        *      BEGIN-VENDOR foo format=Foo-Encapsulation-Attr
+                        */
+                       if (argc > 2) {
+                               if (strncmp(argv[2], "format=", 7) != 0) {
+                                       fr_strerror_printf(
+                                               "dict_init: %s[%d]: Invalid format %s",
+                                               fn, line, argv[2]);
+                                       fclose(fp);
+                                       return -1;
+                               }
+                               
+                               p = argv[2] + 7;
+                               da = dict_attrbyname(p);
+                               if (!da) {
+                                       fr_strerror_printf("dict_init: %s[%d]: Invalid format for BEGIN-VENDOR: unknown attribute \"%s\"",
+                                                          fn, line, p);
+                                       fclose(fp);
+                                       return -1;
+                               }
+
+                               if (!da->flags.evs) {
+                                       fr_strerror_printf("dict_init: %s[%d]: Invalid format for BEGIN-VENDOR.  Attribute \"%s\" is not of \"evs\" data type",
+                                                          fn, line, p);
+                                       fclose(fp);
+                                       return -1;
+                               }
+                               
+                               /*
+                                *      Pack the encapsulating
+                                *      attribute into the upper 8
+                                *      bits of the vendor ID
+                                */
+                               block_vendor |= (da->attr & fr_attr_mask[0]) * FR_MAX_VENDOR;
+                       }
+
                        continue;
                } /* BEGIN-VENDOR */
 
@@ -1556,7 +2228,7 @@ static int my_dict_init(const char *dir, const char *fn,
                                return -1;
                        }
 
-                       if (vendor != block_vendor) {
+                       if (vendor != (block_vendor & (FR_MAX_VENDOR - 1))) {
                                fr_strerror_printf(
                                        "dict_init: %s[%d]: END-VENDOR %s does not match any previous BEGIN-VENDOR",
                                        fn, line, argv[1]);
@@ -1663,6 +2335,16 @@ int dict_init(const char *dir, const char *fn)
                return -1;
        }
 
+       /*
+        *      Horrible hacks for combo-IP.
+        */
+       attributes_combo = fr_hash_table_create(dict_attr_combo_hash,
+                                               dict_attr_combo_cmp,
+                                               fr_pool_free);
+       if (!attributes_combo) {
+               return -1;
+       }
+
        values_byname = fr_hash_table_create(dict_value_name_hash,
                                               dict_value_name_cmp,
                                               fr_pool_free);
@@ -1683,7 +2365,7 @@ int dict_init(const char *dir, const char *fn)
                return -1;
 
        if (value_fixup) {
-               DICT_ATTR *a;
+               const DICT_ATTR *a;
                value_fixup_t *this, *next;
 
                for (this = value_fixup; this != NULL; this = next) {
@@ -1744,10 +2426,390 @@ int dict_init(const char *dir, const char *fn)
        return 0;
 }
 
+static size_t print_attr_oid(char *buffer, size_t size, unsigned int attr,
+                            int dv_type)
+{
+       int nest;
+       size_t outlen;
+       size_t len;
+
+       switch (dv_type) {
+       case 4:
+               return snprintf(buffer, size, "%u", attr);
+
+       case 2:
+               return snprintf(buffer, size, "%u", attr & 0xffff);
+
+       default:
+       case 1:
+               len = snprintf(buffer, size, "%u", attr & 0xff);
+               break;
+       }
+
+       if ((attr >> 8) == 0) return len;
+
+       outlen = len;
+       buffer += len;
+       size -= len;
+
+       for (nest = 1; nest <= fr_attr_max_tlv; nest++) {
+               if (((attr >> fr_attr_shift[nest]) & fr_attr_mask[nest]) == 0) break;
+
+               len = snprintf(buffer, size, ".%u",
+                              (attr >> fr_attr_shift[nest]) & fr_attr_mask[nest]);
+
+               outlen = len;
+               buffer += len;
+               size -= len;
+       }
+
+       return outlen;
+}
+
+/** Free dynamically allocated (unknown attributes)
+ * 
+ * If the da was dynamically allocated it will be freed, else the function
+ * will return without doing anything.
+ *
+ * @param da to free.
+ */
+void dict_attr_free(DICT_ATTR const **da)
+{
+       DICT_ATTR **tmp;
+       
+       if (!da || !*da) return;
+       
+       /* Don't free real DAs */
+       if (!(*da)->flags.is_unknown) {
+               return;
+       }
+       
+       memcpy(&tmp, &da, sizeof(*tmp));
+       free(*tmp);
+       
+       *tmp = NULL;    
+}
+
+/** Copies a dictionary attr
+ *
+ * If the attr is dynamically allocated (unknown attribute), then it will be
+ * copied to a new attr.
+ *
+ * If the attr is known, a pointer to the da will be returned.
+ *
+ * @param da to copy.
+ * @param vp_free if TRUE, da will be freed at the same time as the
+ *     VALUE_PAIR which contains it.
+ * @return return a copy of the da.
+ */
+const DICT_ATTR *dict_attr_copy(const DICT_ATTR *da, int vp_free)
+{
+       DICT_ATTR *copy;
+       
+       if (!da) return NULL;
+       
+       if (!da->flags.is_unknown) {
+               return da;
+       }
+       
+       copy = malloc(DICT_ATTR_SIZE);
+       if (!copy) {
+               fr_strerror_printf("Out of memory");
+               return NULL;
+       }
+       
+       memcpy(copy, da, DICT_ATTR_SIZE);
+       copy->flags.vp_free = (vp_free != 0);
+       
+       return copy;
+}
+
+
+/** Allocs an dictionary attr for unknown attributes
+ *
+ * Allocates a dict attr for an unknown attribute/vendor/type
+ * without adding it to dictionary pools/hashes.
+ *
+ * @note Must be freed with dict_attr_free if not used as part of a valuepair.
+ *
+ * @param[in] attr number.
+ * @param[in] vendor number.
+ * @param[in] vp_free if > 0 DICT_ATTR will be freed on VALUE_PAIR free.
+ * @return new dictionary attribute.
+ */
+const DICT_ATTR *dict_attrunknown(unsigned int attr, unsigned int vendor,
+                                 int vp_free)
+{
+       DICT_ATTR *da;
+       char *p;
+       int dv_type = 1;
+       size_t len = 0;
+       size_t bufsize = DICT_ATTR_MAX_NAME_LEN;
+       
+       da = malloc(DICT_ATTR_SIZE);
+       if (!da) {
+               fr_strerror_printf("Out of memory");
+               return NULL;
+       }
+       memset(da, 0, DICT_ATTR_SIZE);
+       
+       da->attr = attr;
+       da->vendor = vendor;
+       da->type = PW_TYPE_OCTETS;
+       da->flags.is_unknown = TRUE;
+       da->flags.vp_free = (vp_free != 0);
+       
+       p = da->name;
+       
+       len = snprintf(p, bufsize, "Attr-");
+       p += len;
+       bufsize -= len;
+
+       if (vendor > FR_MAX_VENDOR) {
+               len = snprintf(p, bufsize, "%u.", vendor / FR_MAX_VENDOR);
+               p += len;
+               bufsize -= len;
+               vendor &= (FR_MAX_VENDOR) - 1;
+       }
+
+       if (vendor) {
+               DICT_VENDOR *dv;
+
+               /*
+                *      dv_type is the length of the vendor's type field
+                *      RFC 2865 never defined a mandatory length, so
+                *      different vendors have different length type fields.
+                */
+               dv = dict_vendorbyvalue(vendor);
+               if (dv) {
+                       dv_type = dv->type;
+               }
+               len = snprintf(p, bufsize, "26.%u.", vendor);
+               
+               p += len;
+               bufsize -= len;
+       }
+
+       p += print_attr_oid(p, bufsize , attr, dv_type);
+       
+       return da;
+}
+
+/** Create a DICT_ATTR from an ASCII attribute and value
+ *
+ * Where the attribute name is in the form:
+ *  - Attr-%d
+ *  - Attr-%d.%d.%d...
+ *  - Vendor-%d-Attr-%d
+ *  - VendorName-Attr-%d
+ *
+ * @todo should check attr/vendor against dictionary and return the real da.
+ *
+ * @param[in] attribute name.
+ * @param[in] vp_free if > 0 DICT_ATTR will be freed on VALUE_PAIR free.
+ * @return new da or NULL on error.
+ */
+const DICT_ATTR *dict_attrunknownbyname(const char *attribute, int vp_free)
+{
+       unsigned int    attr, vendor = 0;
+       unsigned int    dv_type = 1;    /* The type of vendor field */
+
+       const char      *p = attribute;
+       char            *q;
+       
+       DICT_VENDOR     *dv;
+       const DICT_ATTR *da;
+
+       /*
+        *      Pull off vendor prefix first.
+        */
+       if (strncasecmp(p, "Attr-", 5) != 0) {
+               if (strncasecmp(p, "Vendor-", 7) == 0) {
+                       vendor = (int) strtol(p + 7, &q, 10);
+                       if ((vendor == 0) || (vendor > FR_MAX_VENDOR)) {
+                               fr_strerror_printf("Invalid vendor value in "
+                                                  "attribute name \"%s\"", 
+                                                  attribute);
+                               return NULL;
+                       }
+
+                       p = q;
+
+               /* must be vendor name */
+               } else {
+                       char buffer[256];
+
+                       q = strchr(p, '-');
+
+                       if (!q) {
+                               fr_strerror_printf("Invalid vendor name in "
+                                                  "attribute name \"%s\"",
+                                                  attribute);
+                               return NULL;
+                       }
+
+                       if ((size_t) (q - p) >= sizeof(buffer)) {
+                               fr_strerror_printf("Vendor name too long "
+                                                  "in attribute name \"%s\"",
+                                                  attribute);
+                               return NULL;
+                       }
+
+                       memcpy(buffer, p, (q - p));
+                       buffer[q - p] = '\0';
+
+                       vendor = dict_vendorbyname(buffer);
+                       if (!vendor) {
+                               fr_strerror_printf("Unknown vendor name in "
+                                                  "attribute name \"%s\"",
+                                                  attribute);
+                               return NULL;
+                       }
+
+                       p = q;
+               }
+
+               if (*p != '-') {
+                       fr_strerror_printf("Invalid text following vendor "
+                                          "definition in attribute name "
+                                          "\"%s\"", attribute);
+                       return NULL;
+               }
+               p++;
+       }
+       
+       /*
+        *      Attr-%d
+        */
+       if (strncasecmp(p, "Attr-", 5) != 0) {
+               fr_strerror_printf("Invalid format in attribute name \"%s\"",
+                                  attribute);
+               return NULL;
+       }
+
+       attr = strtol(p + 5, &q, 10);
+
+       /*
+        *      Invalid attribute.
+        */
+       if (attr == 0) {
+               fr_strerror_printf("Invalid value in attribute name \"%s\"",
+                                  attribute);
+               return NULL;
+       }
+
+       p = q;
+       
+       /*
+        *      Vendor-%d-Attr-%d
+        *      VendorName-Attr-%d
+        *      Attr-%d
+        *      Attr-%d.
+        *
+        *      Anything else is invalid.
+        */
+       if (((vendor != 0) && (*p != '\0')) ||
+           ((vendor == 0) && *p && (*p != '.'))) {
+       invalid:
+               fr_strerror_printf("Invalid OID");
+               return NULL;
+       }
+       
+       /*
+        *      Look for OIDs.  Require the "Attr-26.Vendor-Id.type"
+        *      format, and disallow "Vendor-%d-Attr-%d" and
+        *      "VendorName-Attr-%d"
+        *
+        *      This section parses the Vendor-Id portion of
+        *      Attr-%d.%d.  where the first number is 26, *or* an
+        *      extended attribute of the "evs" data type.
+        */
+       if (*p == '.') {
+               da = dict_attrbyvalue(attr, 0);
+               if (!da) {
+                       fr_strerror_printf("Cannot parse attributes without "
+                                          "dictionaries");
+                       return NULL;
+               }               
+               
+               if ((attr != PW_VENDOR_SPECIFIC) &&
+                   !(da->flags.extended || da->flags.long_extended)) {
+                       fr_strerror_printf("Standard attributes cannot use "
+                                          "OIDs");
+                       return NULL;
+               }
+
+               if ((attr == PW_VENDOR_SPECIFIC) || da->flags.evs) {
+                       vendor = strtol(p + 1, &q, 10);
+                       if ((vendor == 0) || (vendor > FR_MAX_VENDOR)) {
+                               fr_strerror_printf("Invalid vendor");
+                               return NULL;
+                       }
+
+                       if (*q != '.') goto invalid;
+
+                       p = q;
+
+                       if (da->flags.evs) {
+                               vendor |= attr * FR_MAX_VENDOR;
+                       }
+                       attr = 0;
+               } /* else the second number is a TLV number */
+       }
+
+       /*
+        *      Get the expected maximum size of the attribute.
+        */
+       if (vendor) {
+               dv = dict_vendorbyvalue(vendor & (FR_MAX_VENDOR - 1));
+               if (dv) {
+                       dv_type = dv->type;
+                       if (dv_type > 3) dv_type = 3; /* hack */
+               }
+       }
+       
+       /*
+        *      Parse the next number.  It could be a Vendor-Type
+        *      of 1..2^24, or it could be a TLV.
+        */
+       if (*p == '.') {
+               attr = strtol(p + 1, &q, 10);
+               if (attr == 0) {
+                       fr_strerror_printf("Invalid attribute number");
+                       return NULL;
+               }
+
+               if (*q) {
+                       if (*q != '.') {
+                               goto invalid;
+                       }
+                       
+                       if (dv_type != 1) {
+                               goto invalid;
+                       }
+               }
+
+               p = q;
+       }
+
+       /*
+        *      Enforce a maximum value on the attribute number.
+        */
+       if (attr >= (unsigned) (1 << (dv_type << 3))) goto invalid;
+
+       if (*p == '.') {
+               if (dict_str2oid(p + 1, &attr, &vendor, 1) < 0) {
+                       return NULL;
+               }
+       }
+
+       return dict_attrunknown(attr, vendor, vp_free);
+}
+
 /*
  *     Get an attribute by its numerical value.
  */
-DICT_ATTR *dict_attrbyvalue(unsigned int attr, unsigned int vendor)
+const DICT_ATTR *dict_attrbyvalue(unsigned int attr, unsigned int vendor)
 {
        DICT_ATTR dattr;
 
@@ -1759,10 +2821,134 @@ DICT_ATTR *dict_attrbyvalue(unsigned int attr, unsigned int vendor)
        return fr_hash_table_finddata(attributes_byvalue, &dattr);
 }
 
+
+/**
+ * @brief Get an attribute by its numerical value. and data type
+ *
+ *     Used only for COMBO_IP
+ *
+ * @return The attribute, or NULL if not found
+ */
+const DICT_ATTR *dict_attrbytype(unsigned int attr, unsigned int vendor,
+                                PW_TYPE type)
+{
+       DICT_ATTR dattr;
+
+       dattr.attr = attr;
+       dattr.vendor = vendor;
+       dattr.type = type;
+
+       return fr_hash_table_finddata(attributes_combo, &dattr);
+}
+
+/**
+ * @brief Using a parent and attr/vendor, find a child attr/vendor
+ */
+int dict_attr_child(const DICT_ATTR *parent,
+                   unsigned int *pattr, unsigned int *pvendor)
+{
+       unsigned int attr, vendor;
+       DICT_ATTR dattr;
+
+       if (!parent || !pattr || !pvendor) return FALSE;
+
+       attr = *pattr;
+       vendor = *pvendor;
+
+       /*
+        *      Only some types can have children
+        */
+       switch (parent->type) {
+       default: return FALSE;
+
+       case PW_TYPE_VSA:
+       case PW_TYPE_TLV:
+       case PW_TYPE_EVS:
+       case PW_TYPE_EXTENDED:
+       case PW_TYPE_LONG_EXTENDED:
+         break;
+       }
+
+       if ((vendor == 0) && (parent->vendor != 0)) return FALSE;
+
+       /*
+        *      Bootstrap by starting off with the parents values.
+        */
+       dattr.attr = parent->attr;
+       dattr.vendor = parent->vendor;
+
+       /*
+        *      Do various butchery to insert the "attr" value.
+        *
+        *      00VID   000000AA        normal VSA for vendor VID
+        *      00VID   DDCCBBAA        normal VSAs with TLVs
+        *      EE000   000000AA        extended attr (241.1)
+        *      EE000   DDCCBBAA        extended attr with TLVs
+        *      EEVID   000000AA        EVS with vendor VID, attr AAA
+        *      EEVID   DDCCBBAA        EVS with TLVs
+        */
+       if (!dattr.vendor) {
+               dattr.vendor = parent->attr * FR_MAX_VENDOR;
+               dattr.vendor |= vendor;
+               dattr.attr = attr;
+
+       } else {
+               int i;
+
+               /*
+                *      Trying to nest too deep.  It's an error
+                */
+               if (parent->attr & (fr_attr_mask[MAX_TLV_NEST] << fr_attr_shift[MAX_TLV_NEST])) {
+                       return FALSE;
+               }
+
+               for (i = MAX_TLV_NEST - 1; i >= 0; i--) {
+                       if ((parent->attr & (fr_attr_mask[i] << fr_attr_shift[i]))) {
+                               dattr.attr |= (attr & fr_attr_mask[i + 1]) << fr_attr_shift[i + 1];
+                               goto find;
+                       }
+               }
+
+               return FALSE;
+       }
+
+find:
+#if 0
+       fprintf(stderr, "LOOKING FOR %08x %08x + %08x %08x --> %08x %08x\n",
+               parent->vendor, parent->attr, attr, vendor,
+               dattr.vendor, dattr.attr);
+#endif
+
+       *pattr = dattr.attr;
+       *pvendor = dattr.vendor;
+       return TRUE;
+}
+
+/*
+ *     Get an attribute by it's numerical value, and the parent
+ */
+const DICT_ATTR *dict_attrbyparent(const DICT_ATTR *parent,
+                            unsigned int attr, unsigned int vendor)
+{
+       unsigned int my_attr, my_vendor;
+       DICT_ATTR dattr;
+
+       my_attr = attr;
+       my_vendor = vendor;
+
+       if (!dict_attr_child(parent, &my_attr, &my_vendor)) return NULL;
+
+       dattr.attr = my_attr;
+       dattr.vendor = my_vendor;
+
+       return fr_hash_table_finddata(attributes_byvalue, &dattr);
+}
+
+
 /*
  *     Get an attribute by its name.
  */
-DICT_ATTR *dict_attrbyname(const char *name)
+const DICT_ATTR *dict_attrbyname(const char *name)
 {
        DICT_ATTR *da;
        uint32_t buffer[(sizeof(*da) + DICT_ATTR_MAX_NAME_LEN + 3)/4];
@@ -1802,6 +2988,19 @@ DICT_VALUE *dict_valbyattr(unsigned int attr, unsigned int vendor, int value)
 }
 
 /*
+ *     Associate a value with an attribute and return it.
+ */
+const char *dict_valnamebyattr(unsigned int attr, unsigned int vendor, int value)
+{
+       DICT_VALUE *dv;
+
+       dv = dict_valbyattr(attr, vendor, value);
+       if (!dv) return "";
+
+       return dv->name;
+}
+
+/*
  *     Get a value by its name, keyed off of an attribute.
  */
 DICT_VALUE *dict_valbyname(unsigned int attr, unsigned int vendor, const char *name)