newvector should be a bool

[freeradius.git] / src / lib / tcp.c

diff --git a/src/lib/tcp.c b/src/lib/tcp.c
index 6e7c86b..186198c 100644 (file)
--- a/src/lib/tcp.c
+++ b/src/lib/tcp.c
@@ -33,18 +33,12 @@ RCSID("$Id$")
  *     Open a socket TO the given IP and port.
  */
 int fr_tcp_client_socket(fr_ipaddr_t *src_ipaddr,
-                        fr_ipaddr_t *dst_ipaddr, int dst_port)
+                        fr_ipaddr_t *dst_ipaddr, uint16_t dst_port)
 {
        int sockfd;
        struct sockaddr_storage salocal;
        socklen_t       salen;
 
-       if ((dst_port < 0) || (dst_port > 65535)) {
-               fr_strerror_printf("Port %d is out of allowed bounds",
-                                  dst_port);
-               return -1;
-       }
-
        if (!dst_ipaddr) return -1;
 
        sockfd = socket(dst_ipaddr->af, SOCK_STREAM, 0);
@@ -85,22 +79,13 @@ int fr_tcp_client_socket(fr_ipaddr_t *src_ipaddr,
                return -1;
        }
 
-       /*
-        *      Set non-block *AFTER* connecting to the remote server
-        *      so it doesn't return immediately.
-        */
-       if (fr_nonblock(sockfd) < 0) {
-               close(sockfd);
-               return -1;
-       }
-
        return sockfd;
 }
 
 
 RADIUS_PACKET *fr_tcp_recv(int sockfd, int flags)
 {
-       RADIUS_PACKET *packet = rad_alloc(NULL, 0);
+       RADIUS_PACKET *packet = rad_alloc(NULL, false);
 
        if (!packet) return NULL;