Print out section name for empty sections
[freeradius.git] / src / main / modules.c
index 5ea8674..e15ee76 100644 (file)
@@ -84,47 +84,94 @@ static const section_type_value_t section_type_value[RLM_COMPONENT_COUNT] = {
        { "session",      "Session-Type",    PW_SESSION_TYPE },
        { "pre-proxy",    "Pre-Proxy-Type",  PW_PRE_PROXY_TYPE },
        { "post-proxy",   "Post-Proxy-Type", PW_POST_PROXY_TYPE },
-       { "post-auth",    "Post-Auth-Type",  PW_POST_AUTH_TYPE },
+       { "post-auth",    "Post-Auth-Type",  PW_POST_AUTH_TYPE }
+#ifdef WITH_COA
+       ,
+       { "recv-coa",     "Recv-CoA-Type",   PW_RECV_COA_TYPE },
+       { "send-coa",     "Send-CoA-Type",   PW_SEND_COA_TYPE }
+#endif
 };
 
 
 #ifdef WITHOUT_LIBLTDL
+#ifdef WITH_DLOPEN
+#include <dlfcn.h>
+
+#ifndef RTLD_NOW
+#define RTLD_NOW (0)
+#endif
+#ifndef RTLD_LOCAL
+#define RTLD_LOCAL (0)
+#endif
+
+lt_dlhandle lt_dlopenext(const char *name)
+{
+       char buffer[256];
+
+       strlcpy(buffer, name, sizeof(buffer));
+
+       /*
+        *      FIXME: Make this configurable...
+        */
+       strlcat(buffer, ".so", sizeof(buffer));
+
+       return dlopen(buffer, RTLD_NOW | RTLD_LOCAL);
+}
+
+void *lt_dlsym(lt_dlhandle handle, UNUSED const char *symbol)
+{
+       return dlsym(handle, symbol);
+}
+
+int lt_dlclose(lt_dlhandle handle)
+{
+       return dlclose(handle);
+}
+
+const char *lt_dlerror(void)
+{
+       return dlerror();
+}
+
+
+#else  /* without dlopen */
 typedef struct lt_dlmodule_t {
   const char   *name;
   void         *ref;
 } lt_dlmodule_t;
 
+typedef struct eap_type_t EAP_TYPE;
+typedef struct rlm_sql_module_t rlm_sql_module_t;
+
 /*
- *     Define modules here.
+ *     FIXME: Write hackery to auto-generate this data.
+ *     We only need to do this on systems that don't have dlopen.
  */
 extern module_t rlm_pap;
 extern module_t rlm_chap;
 extern module_t rlm_eap;
+extern module_t rlm_sql;
+/* and so on ... */
 
-/*
- *     EAP structures are defined elsewhere.
- */
-typedef struct eap_type_t EAP_TYPE;
-
-/*
- *     And so on for other EAP types.
- */
 extern EAP_TYPE rlm_eap_md5;
+extern rlm_sql_module_t rlm_sql_mysql;
+/* and so on ... */
 
 static const lt_dlmodule_t lt_dlmodules[] = {
        { "rlm_pap", &rlm_pap },
        { "rlm_chap", &rlm_chap },
        { "rlm_eap", &rlm_eap },
+       /* and so on ... */
+
        { "rlm_eap_md5", &rlm_eap_md5 },
-       
-       /*
-        *      Add other modules here.
-        */
+       /* and so on ... */
+               
+       { "rlm_sql_mysql", &rlm_sql_mysql },
+       /* and so on ... */
                
        { NULL, NULL }
 };
 
-
 lt_dlhandle lt_dlopenext(const char *name)
 {
        int i;
@@ -142,6 +189,43 @@ void *lt_dlsym(lt_dlhandle handle, UNUSED const char *symbol)
 {
        return handle;
 }
+
+int lt_dlclose(lt_dlhandle handle)
+{
+       return 0;
+}
+
+const char *lt_dlerror(void)
+{
+       return "Unspecified error";
+}
+
+#endif /* WITH_DLOPEN */
+#else  /* WITHOUT_LIBLTDL */
+
+/*
+ *     Solve the issues of libraries linking to other libraries
+ *     by using a newer libltdl API.
+ */
+#ifndef HAVE_LT_DLADVISE_INIT
+#define fr_dlopenext lt_dlopenext
+#else
+static lt_dlhandle fr_dlopenext(const char *filename)
+{
+       lt_dlhandle handle = 0;
+       lt_dladvise advise;
+
+       if (!lt_dladvise_init (&advise) &&
+           !lt_dladvise_ext (&advise) &&
+           !lt_dladvise_global (&advise)) {
+               handle = lt_dlopenadvise (filename, advise);
+       }
+
+       lt_dladvise_destroy (&advise);
+
+       return handle;
+}
+#endif /* HAVE_LT_DLADVISE_INIT */
 #endif /* WITHOUT_LIBLTDL */
 
 static int virtual_server_idx(const char *name)
@@ -352,7 +436,7 @@ static module_entry_t *linkto_module(const char *module_name,
        /*
         *      Keep the handle around so we can dlclose() it.
         */
-       handle = lt_dlopenext(module_name);
+       handle = fr_dlopenext(module_name);
        if (handle == NULL) {
                cf_log_err(cf_sectiontoitem(cs),
                           "Failed to link to module '%s': %s\n",
@@ -427,7 +511,7 @@ module_instance_t *find_module_instance(CONF_SECTION *modules,
 {
        int check_config_safe = FALSE;
        CONF_SECTION *cs;
-       const char *name1, *name2;
+       const char *name1;
        module_instance_t *node, myNode;
        char module_name[256];
 
@@ -607,12 +691,13 @@ int indexed_modcall(int comp, int idx, REQUEST *request)
        }
 
        if (!server) {
-               RDEBUG("No such virtual server %s", request->server);
+               RDEBUG("No such virtual server \"%s\"", request->server);
                return RLM_MODULE_FAIL;
        }
 
        if (idx == 0) {
                list = server->mc[comp];
+               if (!list) RDEBUG2("  WARNING: Empty %s section.  Using default return values.", section_type_value[comp].section);
 
        } else {
                indexed_modcallable *this;
@@ -860,6 +945,7 @@ static int load_byserver(CONF_SECTION *cs)
        const char *name = cf_section_name2(cs);
        rbtree_t *components;
        virtual_server_t *server = NULL;
+       indexed_modcallable *c;
 
        if (name) {
                cf_log_info(cs, "server %s {", name);
@@ -961,7 +1047,6 @@ static int load_byserver(CONF_SECTION *cs)
        flag = 0;
        for (comp = 0; comp < RLM_COMPONENT_COUNT; ++comp) {
                CONF_SECTION *subcs;
-               indexed_modcallable *c;
 
                subcs = cf_section_sub_find(cs,
                                            section_type_value[comp].section);
@@ -1016,6 +1101,9 @@ static int load_byserver(CONF_SECTION *cs)
                                                   RLM_COMPONENT_POST_AUTH) < 0) {
                                goto error;
                        }
+                       c = lookup_by_index(components,
+                                           RLM_COMPONENT_POST_AUTH, 0);
+                       if (c) server->mc[RLM_COMPONENT_POST_AUTH] = c->modulelist;
                        flag = 1;
                }
 
@@ -1024,19 +1112,14 @@ static int load_byserver(CONF_SECTION *cs)
                        const DICT_ATTR *dattr;
 
                        dattr = dict_attrbyname("DHCP-Message-Type");
-                       if (!dattr) {
-                               radlog(L_ERR, "No DHCP-Message-Type attribute");
-                               goto error;
-                       }
 
                        /*
                         *      Handle each DHCP Message type separately.
                         */
-                       for (subcs = cf_subsection_find_next(cs, NULL,
-                                                            "dhcp");
-                            subcs != NULL;
-                            subcs = cf_subsection_find_next(cs, subcs,
-                                                            "dhcp")) {
+                       if (dattr) for (subcs = cf_subsection_find_next(cs, NULL, "dhcp");
+                                       subcs != NULL;
+                                       subcs = cf_subsection_find_next(cs, subcs,
+                                                                       "dhcp")) {
                                const char *name2 = cf_section_name2(subcs);
 
                                DEBUG2(" Module: Checking dhcp %s {...} for more modules to load", name2);
@@ -1046,6 +1129,9 @@ static int load_byserver(CONF_SECTION *cs)
                                                               RLM_COMPONENT_POST_AUTH)) {
                                        goto error; /* FIXME: memleak? */
                                }
+                               c = lookup_by_index(components,
+                                                   RLM_COMPONENT_POST_AUTH, 0);
+                               if (c) server->mc[RLM_COMPONENT_POST_AUTH] = c->modulelist;
                                flag = 1;
                        }
                }
@@ -1243,6 +1329,26 @@ int setup_modules(int reload, CONF_SECTION *config)
         */
        if (!reload) {
                /*
+                *      This line works around a completely
+                *
+                *              RIDICULOUS INSANE IDIOTIC
+                *
+                *      bug in libltdl on certain systems.  The "set
+                *      preloaded symbols" macro below ends up
+                *      referencing this name, but it isn't defined
+                *      anywhere in the libltdl source.  As a result,
+                *      any program STUPID enough to rely on libltdl
+                *      fails to link, because the symbol isn't
+                *      defined anywhere.
+                *
+                *      It's like libtool and libltdl are some kind
+                *      of sick joke.
+                */
+#ifdef IE_LIBTOOL_DIE
+#define lt__PROGRAM__LTX_preloaded_symbols lt_libltdl_LTX_preloaded_symbols
+#endif
+
+               /*
                 *      Set the default list of preloaded symbols.
                 *      This is used to initialize libltdl's list of
                 *      preloaded modules.
@@ -1346,7 +1452,9 @@ int setup_modules(int reload, CONF_SECTION *config)
             listener = listener->next) {
                char buffer[256];
 
+#ifdef WITH_PROXY
                if (listener->type == RAD_LISTEN_PROXY) continue;
+#endif
 
                cs = cf_section_sub_find_name2(config,
                                               "server", listener->server);
@@ -1451,3 +1559,15 @@ int module_post_auth(int postauth_type, REQUEST *request)
 {
        return indexed_modcall(RLM_COMPONENT_POST_AUTH, postauth_type, request);
 }
+
+#ifdef WITH_COA
+int module_recv_coa(int recv_coa_type, REQUEST *request)
+{
+       return indexed_modcall(RLM_COMPONENT_RECV_COA, recv_coa_type, request);
+}
+
+int module_send_coa(int send_coa_type, REQUEST *request)
+{
+       return indexed_modcall(RLM_COMPONENT_SEND_COA, send_coa_type, request);
+}
+#endif