Removed all free(inst->foo) where "foo" comes from parsing

[freeradius.git] / src / modules / rlm_expiration / rlm_expiration.c

diff --git a/src/modules/rlm_expiration/rlm_expiration.c b/src/modules/rlm_expiration/rlm_expiration.c
index 0912b3e..d5e8a83 100644 (file)
--- a/src/modules/rlm_expiration/rlm_expiration.c
+++ b/src/modules/rlm_expiration/rlm_expiration.c
@@ -84,7 +84,7 @@ static int expiration_authorize(void *instance, REQUEST *request)
 
                        DEBUG("rlm_expiration: Account has expired");
 
-                       if (data->msg){
+                       if (data->msg && data->msg[0]){
                                if (!radius_xlat(msg, sizeof(msg), data->msg, request, NULL)) {
                                        radlog(L_ERR, "rlm_expiration: xlat failed.");
                                        return RLM_MODULE_FAIL;
@@ -150,8 +150,6 @@ static int expiration_detach(void *instance)
        rlm_expiration_t *data = (rlm_expiration_t *) instance;
 
        paircompare_unregister(PW_EXPIRATION, expirecmp);
-       if (data->msg)
-               free(data->msg);
        free(instance);
        return 0;
 }
@@ -191,14 +189,6 @@ static int expiration_instantiate(CONF_SECTION *conf, void **instance)
        }
 
        /*
-        * If we are passed an empty reply-message don't use it
-        */
-       if (!strlen(data->msg)){
-               free(data->msg);
-               data->msg = NULL;
-       }
-
-       /*
         * Register the expiration comparison operation.
         */
        paircompare_register(PW_EXPIRATION, 0, expirecmp, data);