TDLS: Update peer STA as soon as full peer info is available
[mech_eap.git] / src / rsn_supp / tdls.c
index f84139d..c1d0c62 100644 (file)
@@ -2,14 +2,8 @@
  * wpa_supplicant - TDLS
  * Copyright (c) 2010-2011, Atheros Communications
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Alternatively, this software may be distributed under the terms of BSD
- * license.
- *
- * See README and COPYING for more details.
+ * This software may be distributed under the terms of the BSD license.
+ * See README for more details.
  */
 
 #include "utils/includes.h"
 #define TDLS_TESTING_SHORT_LIFETIME BIT(3)
 #define TDLS_TESTING_WRONG_LIFETIME_RESP BIT(4)
 #define TDLS_TESTING_WRONG_LIFETIME_CONF BIT(5)
+#define TDLS_TESTING_LONG_LIFETIME BIT(6)
+#define TDLS_TESTING_CONCURRENT_INIT BIT(7)
+#define TDLS_TESTING_NO_TPK_EXPIRATION BIT(8)
+#define TDLS_TESTING_DECLINE_RESP BIT(9)
+#define TDLS_TESTING_IGNORE_AP_PROHIBIT BIT(10)
+#define TDLS_TESTING_WRONG_MIC BIT(11)
 unsigned int tdls_testing = 0;
 #endif /* CONFIG_TDLS_TESTING */
 
 #define TPK_LIFETIME 43200 /* 12 hours */
-#define TPK_RETRY_COUNT 3
-#define TPK_TIMEOUT 5000 /* in milliseconds */
+#define TPK_M1_RETRY_COUNT 3
+#define TPK_M1_TIMEOUT 5000 /* in milliseconds */
+#define TPK_M2_RETRY_COUNT 10
+#define TPK_M2_TIMEOUT 500 /* in milliseconds */
 
 #define TDLS_MIC_LEN           16
 
@@ -80,11 +82,18 @@ struct wpa_tdls_frame {
 static u8 * wpa_add_tdls_timeoutie(u8 *pos, u8 *ie, size_t ie_len, u32 tsecs);
 static void wpa_tdls_tpk_retry_timeout(void *eloop_ctx, void *timeout_ctx);
 static void wpa_tdls_peer_free(struct wpa_sm *sm, struct wpa_tdls_peer *peer);
+static void wpa_tdls_disable_peer_link(struct wpa_sm *sm,
+                                      struct wpa_tdls_peer *peer);
+static int wpa_tdls_send_teardown(struct wpa_sm *sm, const u8 *addr,
+                                 u16 reason_code);
 
 
 #define TDLS_MAX_IE_LEN 80
+#define IEEE80211_MAX_SUPP_RATES 32
+
 struct wpa_tdls_peer {
        struct wpa_tdls_peer *next;
+       unsigned int reconfig_key:1;
        int initiator; /* whether this end was initiator for TDLS setup */
        u8 addr[ETH_ALEN]; /* other end MAC address */
        u8 inonce[WPA_NONCE_LEN]; /* Initiator Nonce */
@@ -103,6 +112,7 @@ struct wpa_tdls_peer {
        } tpk;
        int tpk_set;
        int tpk_success;
+       int tpk_in_progress;
 
        struct tpk_timer {
                u8 dest[ETH_ALEN];
@@ -111,9 +121,33 @@ struct wpa_tdls_peer {
                u8 action_code; /* TDLS frame type */
                u8 dialog_token;
                u16 status_code;
+               u32 peer_capab;
                int buf_len;    /* length of TPK message for retransmission */
                u8 *buf;        /* buffer for TPK message */
        } sm_tmr;
+
+       u16 capability;
+
+       u8 supp_rates[IEEE80211_MAX_SUPP_RATES];
+       size_t supp_rates_len;
+
+       struct ieee80211_ht_capabilities *ht_capabilities;
+       struct ieee80211_vht_capabilities *vht_capabilities;
+
+       u8 qos_info;
+
+       u16 aid;
+
+       u8 *ext_capab;
+       size_t ext_capab_len;
+
+       u8 *supp_channels;
+       size_t supp_channels_len;
+
+       u8 *supp_oper_classes;
+       size_t supp_oper_classes_len;
+
+       u8 wmm_capable;
 };
 
 
@@ -139,7 +173,7 @@ static int wpa_tdls_del_key(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
 {
        if (wpa_sm_set_key(sm, WPA_ALG_NONE, peer->addr,
                           0, 0, NULL, 0, NULL, 0) < 0) {
-               wpa_printf(MSG_WARNING, "TDLS: Failed to delete PTK-TK from "
+               wpa_printf(MSG_WARNING, "TDLS: Failed to delete TPK-TK from "
                           "the driver");
                return -1;
        }
@@ -183,33 +217,36 @@ static int wpa_tdls_set_key(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
 
 static int wpa_tdls_send_tpk_msg(struct wpa_sm *sm, const u8 *dst,
                                 u8 action_code, u8 dialog_token,
-                                u16 status_code, const u8 *buf, size_t len)
+                                u16 status_code, u32 peer_capab,
+                                const u8 *buf, size_t len)
 {
        return wpa_sm_send_tdls_mgmt(sm, dst, action_code, dialog_token,
-                                    status_code, buf, len);
+                                    status_code, peer_capab, buf, len);
 }
 
 
 static int wpa_tdls_tpk_send(struct wpa_sm *sm, const u8 *dest, u8 action_code,
-                            u8 dialog_token, u16 status_code,
+                            u8 dialog_token, u16 status_code, u32 peer_capab,
                             const u8 *msg, size_t msg_len)
 {
        struct wpa_tdls_peer *peer;
 
        wpa_printf(MSG_DEBUG, "TDLS: TPK send dest=" MACSTR " action_code=%u "
-                  "dialog_token=%u status_code=%u msg_len=%u",
+                  "dialog_token=%u status_code=%u peer_capab=%u msg_len=%u",
                   MAC2STR(dest), action_code, dialog_token, status_code,
-                  (unsigned int) msg_len);
+                  peer_capab, (unsigned int) msg_len);
 
        if (wpa_tdls_send_tpk_msg(sm, dest, action_code, dialog_token,
-                                 status_code, msg, msg_len)) {
+                                 status_code, peer_capab, msg, msg_len)) {
                wpa_printf(MSG_INFO, "TDLS: Failed to send message "
                           "(action_code=%u)", action_code);
                return -1;
        }
 
        if (action_code == WLAN_TDLS_SETUP_CONFIRM ||
-           action_code == WLAN_TDLS_TEARDOWN)
+           action_code == WLAN_TDLS_TEARDOWN ||
+           action_code == WLAN_TDLS_DISCOVERY_REQUEST ||
+           action_code == WLAN_TDLS_DISCOVERY_RESPONSE)
                return 0; /* No retries */
 
        for (peer = sm->tdls; peer; peer = peer->next) {
@@ -225,14 +262,20 @@ static int wpa_tdls_tpk_send(struct wpa_sm *sm, const u8 *dest, u8 action_code,
 
        eloop_cancel_timeout(wpa_tdls_tpk_retry_timeout, sm, peer);
 
-       peer->sm_tmr.count = TPK_RETRY_COUNT;
-       peer->sm_tmr.timer = TPK_TIMEOUT;
+       if (action_code == WLAN_TDLS_SETUP_RESPONSE) {
+               peer->sm_tmr.count = TPK_M2_RETRY_COUNT;
+               peer->sm_tmr.timer = TPK_M2_TIMEOUT;
+       } else {
+               peer->sm_tmr.count = TPK_M1_RETRY_COUNT;
+               peer->sm_tmr.timer = TPK_M1_TIMEOUT;
+       }
 
        /* Copy message to resend on timeout */
        os_memcpy(peer->sm_tmr.dest, dest, ETH_ALEN);
        peer->sm_tmr.action_code = action_code;
        peer->sm_tmr.dialog_token = dialog_token;
        peer->sm_tmr.status_code = status_code;
+       peer->sm_tmr.peer_capab = peer_capab;
        peer->sm_tmr.buf_len = msg_len;
        os_free(peer->sm_tmr.buf);
        peer->sm_tmr.buf = os_malloc(msg_len);
@@ -242,29 +285,23 @@ static int wpa_tdls_tpk_send(struct wpa_sm *sm, const u8 *dest, u8 action_code,
 
        wpa_printf(MSG_DEBUG, "TDLS: Retry timeout registered "
                   "(action_code=%u)", action_code);
-       eloop_register_timeout(peer->sm_tmr.timer / 1000, 0,
+       eloop_register_timeout(peer->sm_tmr.timer / 1000,
+                              (peer->sm_tmr.timer % 1000) * 1000,
                               wpa_tdls_tpk_retry_timeout, sm, peer);
        return 0;
 }
 
 
-static void tdls_clear_peer(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
+static int wpa_tdls_do_teardown(struct wpa_sm *sm, struct wpa_tdls_peer *peer,
+                               u16 reason_code)
 {
-       u8 mac[ETH_ALEN];
-       struct wpa_tdls_peer *tmp;
-
-       os_memcpy(mac, peer->addr, ETH_ALEN);
-       tmp = peer->next;
-       peer->initiator = 0;
-       eloop_cancel_timeout(wpa_tdls_tpk_retry_timeout, sm, peer);
-       os_free(peer->sm_tmr.buf);
+       int ret;
 
-       /* reset all */
-       os_memset(peer, 0, sizeof(*peer));
+       ret = wpa_tdls_send_teardown(sm, peer->addr, reason_code);
+       /* disable the link after teardown was sent */
+       wpa_tdls_disable_peer_link(sm, peer);
 
-       /* restore things */
-       os_memcpy(peer->addr, mac, ETH_ALEN);
-       peer->next = tmp;
+       return ret;
 }
 
 
@@ -276,7 +313,6 @@ static void wpa_tdls_tpk_retry_timeout(void *eloop_ctx, void *timeout_ctx)
 
        if (peer->sm_tmr.count) {
                peer->sm_tmr.count--;
-               peer->sm_tmr.timer = TPK_TIMEOUT;
 
                wpa_printf(MSG_INFO, "TDLS: Retrying sending of message "
                           "(action_code=%u)",
@@ -296,6 +332,7 @@ static void wpa_tdls_tpk_retry_timeout(void *eloop_ctx, void *timeout_ctx)
                                          peer->sm_tmr.action_code,
                                          peer->sm_tmr.dialog_token,
                                          peer->sm_tmr.status_code,
+                                         peer->sm_tmr.peer_capab,
                                          peer->sm_tmr.buf,
                                          peer->sm_tmr.buf_len)) {
                        wpa_printf(MSG_INFO, "TDLS: Failed to retry "
@@ -303,18 +340,15 @@ static void wpa_tdls_tpk_retry_timeout(void *eloop_ctx, void *timeout_ctx)
                }
 
                eloop_cancel_timeout(wpa_tdls_tpk_retry_timeout, sm, peer);
-               eloop_register_timeout(peer->sm_tmr.timer / 1000, 0,
+               eloop_register_timeout(peer->sm_tmr.timer / 1000,
+                                      (peer->sm_tmr.timer % 1000) * 1000,
                                       wpa_tdls_tpk_retry_timeout, sm, peer);
        } else {
-               wpa_printf(MSG_INFO, "Sending Tear_Down Request");
-               wpa_sm_tdls_oper(sm, TDLS_TEARDOWN, peer->addr);
-
-               wpa_printf(MSG_INFO, "Clearing SM: Peerkey(" MACSTR ")",
-                          MAC2STR(peer->addr));
                eloop_cancel_timeout(wpa_tdls_tpk_retry_timeout, sm, peer);
 
-               /* clear the Peerkey statemachine */
-               wpa_tdls_peer_free(sm, peer);
+               wpa_printf(MSG_DEBUG, "TDLS: Sending Teardown Request");
+               wpa_tdls_do_teardown(sm, peer,
+                                    WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED);
        }
 }
 
@@ -591,18 +625,75 @@ static void wpa_tdls_tpk_timeout(void *eloop_ctx, void *timeout_ctx)
        } else {
                wpa_printf(MSG_DEBUG, "TDLS: TPK lifetime expired for " MACSTR
                           " - tear down", MAC2STR(peer->addr));
-               wpa_sm_tdls_oper(sm, TDLS_TEARDOWN, peer->addr);
+               wpa_tdls_do_teardown(sm, peer,
+                                    WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED);
        }
 }
 
 
-static void wpa_tdls_peer_free(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
+static void wpa_tdls_peer_remove_from_list(struct wpa_sm *sm,
+                                          struct wpa_tdls_peer *peer)
+{
+       struct wpa_tdls_peer *cur, *prev;
+
+       cur = sm->tdls;
+       prev = NULL;
+       while (cur && cur != peer) {
+               prev = cur;
+               cur = cur->next;
+       }
+
+       if (cur != peer) {
+               wpa_printf(MSG_ERROR, "TDLS: Could not find peer " MACSTR
+                          " to remove it from the list",
+                          MAC2STR(peer->addr));
+               return;
+       }
+
+       if (prev)
+               prev->next = peer->next;
+       else
+               sm->tdls = peer->next;
+}
+
+
+static void wpa_tdls_peer_clear(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
 {
+       wpa_printf(MSG_DEBUG, "TDLS: Clear state for peer " MACSTR,
+                  MAC2STR(peer->addr));
        eloop_cancel_timeout(wpa_tdls_tpk_timeout, sm, peer);
+       eloop_cancel_timeout(wpa_tdls_tpk_retry_timeout, sm, peer);
+       peer->reconfig_key = 0;
+       peer->initiator = 0;
+       peer->tpk_in_progress = 0;
+       os_free(peer->sm_tmr.buf);
+       peer->sm_tmr.buf = NULL;
+       os_free(peer->ht_capabilities);
+       peer->ht_capabilities = NULL;
+       os_free(peer->vht_capabilities);
+       peer->vht_capabilities = NULL;
+       os_free(peer->ext_capab);
+       peer->ext_capab = NULL;
+       os_free(peer->supp_channels);
+       peer->supp_channels = NULL;
+       os_free(peer->supp_oper_classes);
+       peer->supp_oper_classes = NULL;
+       peer->rsnie_i_len = peer->rsnie_p_len = 0;
+       peer->cipher = 0;
+       peer->qos_info = 0;
+       peer->wmm_capable = 0;
+       peer->tpk_set = peer->tpk_success = 0;
+       os_memset(&peer->tpk, 0, sizeof(peer->tpk));
+       os_memset(peer->inonce, 0, WPA_NONCE_LEN);
+       os_memset(peer->rnonce, 0, WPA_NONCE_LEN);
+}
 
-       /* need to clear Peerkey SM */
-       tdls_clear_peer(sm, peer);
-       //os_free(peer);
+
+static void wpa_tdls_peer_free(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
+{
+       wpa_tdls_peer_clear(sm, peer);
+       wpa_tdls_peer_remove_from_list(sm, peer);
+       os_free(peer);
 }
 
 
@@ -622,7 +713,7 @@ static void wpa_tdls_linkid(struct wpa_sm *sm, struct wpa_tdls_peer *peer,
 }
 
 
-int wpa_tdls_recv_teardown_notify(struct wpa_sm *sm, const u8 *addr,
+static int wpa_tdls_send_teardown(struct wpa_sm *sm, const u8 *addr,
                                  u16 reason_code)
 {
        struct wpa_tdls_peer *peer;
@@ -632,6 +723,9 @@ int wpa_tdls_recv_teardown_notify(struct wpa_sm *sm, const u8 *addr,
        u8 *rbuf, *pos;
        int ielen;
 
+       if (sm->tdls_disabled || !sm->tdls_supported)
+               return -1;
+
        /* Find the node and free from the list */
        for (peer = sm->tdls; peer; peer = peer->next) {
                if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
@@ -681,10 +775,11 @@ int wpa_tdls_recv_teardown_notify(struct wpa_sm *sm, const u8 *addr,
                ftie->ie_len += 170;
                *pos++ = 255; /* FTIE subelem */
                *pos++ = 168; /* FTIE subelem length */
+               pos += 168;
        }
 #endif /* CONFIG_TDLS_TESTING */
        wpa_hexdump(MSG_DEBUG, "TDLS: FTIE for TDLS Teardown handshake",
-                   (u8 *) ftie, sizeof(*ftie));
+                   (u8 *) ftie, pos - (u8 *) ftie);
 
        /* compute MIC before sending */
        wpa_tdls_linkid(sm, peer, &lnkid);
@@ -698,14 +793,99 @@ skip_ies:
 
        /* request driver to send Teardown using this FTIE */
        wpa_tdls_tpk_send(sm, addr, WLAN_TDLS_TEARDOWN, 0,
-                         WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED, rbuf,
-                         pos - rbuf);
+                         reason_code, 0, rbuf, pos - rbuf);
        os_free(rbuf);
 
-       /* clear the Peerkey statemachine */
+       return 0;
+}
+
+
+int wpa_tdls_teardown_link(struct wpa_sm *sm, const u8 *addr, u16 reason_code)
+{
+       struct wpa_tdls_peer *peer;
+
+       if (sm->tdls_disabled || !sm->tdls_supported)
+               return -1;
+
+       for (peer = sm->tdls; peer; peer = peer->next) {
+               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
+                       break;
+       }
+
+       if (peer == NULL) {
+               wpa_printf(MSG_DEBUG, "TDLS: Could not find peer " MACSTR
+                  " for link Teardown", MAC2STR(addr));
+               return -1;
+       }
+
+       if (!peer->tpk_success) {
+               wpa_printf(MSG_DEBUG, "TDLS: Peer " MACSTR
+                  " not connected - cannot Teardown link", MAC2STR(addr));
+               return -1;
+       }
+
+       return wpa_tdls_do_teardown(sm, peer, reason_code);
+}
+
+
+static void wpa_tdls_disable_peer_link(struct wpa_sm *sm,
+                                      struct wpa_tdls_peer *peer)
+{
+       wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK, peer->addr);
        wpa_tdls_peer_free(sm, peer);
+}
 
-       return 0;
+
+void wpa_tdls_disable_unreachable_link(struct wpa_sm *sm, const u8 *addr)
+{
+       struct wpa_tdls_peer *peer;
+
+       for (peer = sm->tdls; peer; peer = peer->next) {
+               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
+                       break;
+       }
+
+       if (!peer || !peer->tpk_success) {
+               wpa_printf(MSG_DEBUG, "TDLS: Peer " MACSTR
+                          " not connected - cannot teardown unreachable link",
+                          MAC2STR(addr));
+               return;
+       }
+
+       if (wpa_tdls_is_external_setup(sm)) {
+               /*
+                * Disable the link, send a teardown packet through the
+                * AP, and then reset link data.
+                */
+               wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK, addr);
+               wpa_tdls_send_teardown(sm, addr,
+                                      WLAN_REASON_TDLS_TEARDOWN_UNREACHABLE);
+               wpa_tdls_peer_free(sm, peer);
+       } else {
+               wpa_tdls_disable_peer_link(sm, peer);
+       }
+}
+
+
+const char * wpa_tdls_get_link_status(struct wpa_sm *sm, const u8 *addr)
+{
+       struct wpa_tdls_peer *peer;
+
+       if (sm->tdls_disabled || !sm->tdls_supported)
+               return "disabled";
+
+       for (peer = sm->tdls; peer; peer = peer->next) {
+               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
+                       break;
+       }
+
+       if (peer == NULL)
+               return "peer does not exist";
+
+       if (!peer->tpk_success)
+               return "peer not connected";
+
+       return "connected";
 }
 
 
@@ -757,7 +937,7 @@ static int wpa_tdls_recv_teardown(struct wpa_sm *sm, const u8 *src_addr,
        if (!wpa_tdls_get_privacy(sm) || !peer->tpk_set || !peer->tpk_success)
                goto skip_ftie;
 
-       if (kde.ftie == NULL) {
+       if (kde.ftie == NULL || kde.ftie_len < sizeof(*ftie)) {
                wpa_printf(MSG_INFO, "TDLS: No FTIE in TDLS Teardown");
                return -1;
        }
@@ -770,14 +950,7 @@ static int wpa_tdls_recv_teardown(struct wpa_sm *sm, const u8 *src_addr,
                                                    (u8 *) lnkid, ftie) < 0) {
                wpa_printf(MSG_DEBUG, "TDLS: MIC failure for TDLS "
                           "Teardown Request from " MACSTR, MAC2STR(src_addr));
-#if 0
                return -1;
-#else
-               /* TODO: figure out whether this workaround could be disabled
-                */
-               wpa_printf(MSG_DEBUG, "TDLS: Workaround - ignore Teardown MIC "
-                          "failure");
-#endif
        }
 
 skip_ftie:
@@ -785,11 +958,7 @@ skip_ftie:
         * Request the driver to disable the direct link and clear associated
         * keys.
         */
-       wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK, src_addr);
-
-       /* clear the Peerkey statemachine */
-       wpa_tdls_peer_free(sm, peer);
-
+       wpa_tdls_disable_peer_link(sm, peer);
        return 0;
 }
 
@@ -805,8 +974,41 @@ skip_ftie:
 static int wpa_tdls_send_error(struct wpa_sm *sm, const u8 *dst,
                               u8 tdls_action, u8 dialog_token, u16 status)
 {
+       wpa_printf(MSG_DEBUG, "TDLS: Sending error to " MACSTR
+                  " (action=%u status=%u)",
+                  MAC2STR(dst), tdls_action, status);
        return wpa_tdls_tpk_send(sm, dst, tdls_action, dialog_token, status,
-                                NULL, 0);
+                                0, NULL, 0);
+}
+
+
+static struct wpa_tdls_peer *
+wpa_tdls_add_peer(struct wpa_sm *sm, const u8 *addr, int *existing)
+{
+       struct wpa_tdls_peer *peer;
+
+       if (existing)
+               *existing = 0;
+       for (peer = sm->tdls; peer; peer = peer->next) {
+               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0) {
+                       if (existing)
+                               *existing = 1;
+                       return peer; /* re-use existing entry */
+               }
+       }
+
+       wpa_printf(MSG_INFO, "TDLS: Creating peer entry for " MACSTR,
+                  MAC2STR(addr));
+
+       peer = os_zalloc(sizeof(*peer));
+       if (peer == NULL)
+               return NULL;
+
+       os_memcpy(peer->addr, addr, ETH_ALEN);
+       peer->next = sm->tdls;
+       sm->tdls = peer;
+
+       return peer;
 }
 
 
@@ -820,6 +1022,7 @@ static int wpa_tdls_send_tpk_m1(struct wpa_sm *sm,
        u8 *rbuf, *pos, *count_pos;
        u16 count;
        struct rsn_ie_hdr *hdr;
+       int status;
 
        if (!wpa_tdls_get_privacy(sm)) {
                wpa_printf(MSG_DEBUG, "TDLS: No security used on the link");
@@ -953,6 +1156,11 @@ skip_rsnie:
                           "lifetime");
                peer->lifetime = 301;
        }
+       if (tdls_testing & TDLS_TESTING_LONG_LIFETIME) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - use long TPK "
+                          "lifetime");
+               peer->lifetime = 0xffffffff;
+       }
 #endif /* CONFIG_TDLS_TESTING */
        pos = wpa_add_tdls_timeoutie(pos, (u8 *) &timeoutie,
                                     sizeof(timeoutie), peer->lifetime);
@@ -975,11 +1183,11 @@ skip_ies:
                   "Handshake Message 1 (peer " MACSTR ")",
                   MAC2STR(peer->addr));
 
-       wpa_tdls_tpk_send(sm, peer->addr, WLAN_TDLS_SETUP_REQUEST, 0, 0,
-                         rbuf, pos - rbuf);
+       status = wpa_tdls_tpk_send(sm, peer->addr, WLAN_TDLS_SETUP_REQUEST,
+                                  1, 0, 0, rbuf, pos - rbuf);
        os_free(rbuf);
 
-       return 0;
+       return status;
 }
 
 
@@ -993,6 +1201,7 @@ static int wpa_tdls_send_tpk_m2(struct wpa_sm *sm,
        u32 lifetime;
        struct wpa_tdls_timeoutie timeoutie;
        struct wpa_tdls_ftie *ftie;
+       int status;
 
        buf_len = 0;
        if (wpa_tdls_get_privacy(sm)) {
@@ -1056,13 +1265,19 @@ static int wpa_tdls_send_tpk_m2(struct wpa_sm *sm,
        /* compute MIC before sending */
        wpa_tdls_ftie_mic(peer->tpk.kck, 2, (u8 *) lnkid, peer->rsnie_p,
                          (u8 *) &timeoutie, (u8 *) ftie, ftie->mic);
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_WRONG_MIC) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - use wrong MIC");
+               ftie->mic[0] ^= 0x01;
+       }
+#endif /* CONFIG_TDLS_TESTING */
 
 skip_ies:
-       wpa_tdls_tpk_send(sm, src_addr, WLAN_TDLS_SETUP_RESPONSE, dtoken, 0,
-                         rbuf, pos - rbuf);
+       status = wpa_tdls_tpk_send(sm, src_addr, WLAN_TDLS_SETUP_RESPONSE,
+                                  dtoken, 0, 0, rbuf, pos - rbuf);
        os_free(rbuf);
 
-       return 0;
+       return status;
 }
 
 
@@ -1076,6 +1291,8 @@ static int wpa_tdls_send_tpk_m3(struct wpa_sm *sm,
        struct wpa_tdls_ftie *ftie;
        struct wpa_tdls_timeoutie timeoutie;
        u32 lifetime;
+       int status;
+       u32 peer_capab = 0;
 
        buf_len = 0;
        if (wpa_tdls_get_privacy(sm)) {
@@ -1137,179 +1354,551 @@ static int wpa_tdls_send_tpk_m3(struct wpa_sm *sm,
        /* compute MIC before sending */
        wpa_tdls_ftie_mic(peer->tpk.kck, 3, (u8 *) lnkid, peer->rsnie_p,
                          (u8 *) &timeoutie, (u8 *) ftie, ftie->mic);
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_WRONG_MIC) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - use wrong MIC");
+               ftie->mic[0] ^= 0x01;
+       }
+#endif /* CONFIG_TDLS_TESTING */
 
 skip_ies:
-       wpa_tdls_tpk_send(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM, dtoken, 0,
-                         rbuf, pos - rbuf);
+
+       if (peer->vht_capabilities)
+               peer_capab |= TDLS_PEER_VHT;
+       if (peer->ht_capabilities)
+               peer_capab |= TDLS_PEER_HT;
+       if (peer->wmm_capable)
+               peer_capab |= TDLS_PEER_WMM;
+
+       status = wpa_tdls_tpk_send(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM,
+                                  dtoken, 0, peer_capab, rbuf, pos - rbuf);
        os_free(rbuf);
 
-       return 0;
+       return status;
 }
 
 
-static int wpa_tdls_process_tpk_m1(struct wpa_sm *sm, const u8 *src_addr,
-                                  const u8 *buf, size_t len)
+static int wpa_tdls_send_discovery_response(struct wpa_sm *sm,
+                                           struct wpa_tdls_peer *peer,
+                                           u8 dialog_token)
 {
-       struct wpa_tdls_peer *peer;
-       struct wpa_eapol_ie_parse kde;
-       struct wpa_ie_data ie;
-       int cipher;
-       const u8 *cpos;
-       struct wpa_tdls_ftie *ftie = NULL;
-       struct wpa_tdls_timeoutie *timeoutie;
-       struct wpa_tdls_lnkid *lnkid;
-       u32 lifetime = 0;
-#if 0
-       struct rsn_ie_hdr *hdr;
-       u8 *pos;
-       u16 rsn_capab;
-       u16 rsn_ver;
-#endif
-       u8 dtoken;
-       u16 ielen;
+       wpa_printf(MSG_DEBUG, "TDLS: Sending TDLS Discovery Response "
+                  "(peer " MACSTR ")", MAC2STR(peer->addr));
 
-       cpos = buf;
-       cpos += 1 /* pkt_type */ + 1 /* Category */ + 1 /* Action */;
+       return wpa_tdls_tpk_send(sm, peer->addr, WLAN_TDLS_DISCOVERY_RESPONSE,
+                                dialog_token, 0, 0, NULL, 0);
+}
 
-       /* driver had already verified the frame format */
-       dtoken = *cpos++; /* dialog token */
 
-       wpa_printf(MSG_INFO, "TDLS: Dialog Token in TPK M1 %d", dtoken);
+static int
+wpa_tdls_process_discovery_request(struct wpa_sm *sm, const u8 *addr,
+                                  const u8 *buf, size_t len)
+{
+       struct wpa_eapol_ie_parse kde;
+       const struct wpa_tdls_lnkid *lnkid;
+       struct wpa_tdls_peer *peer;
+       size_t min_req_len = sizeof(struct wpa_tdls_frame) +
+               1 /* dialog token */ + sizeof(struct wpa_tdls_lnkid);
+       u8 dialog_token;
 
-       cpos += 2; /* capability information */
+       wpa_printf(MSG_DEBUG, "TDLS: Discovery Request from " MACSTR,
+                  MAC2STR(addr));
 
-       ielen = len - (cpos - buf); /* start of IE in buf */
-       if (wpa_supplicant_parse_ies(cpos, ielen, &kde) < 0) {
-               wpa_printf(MSG_INFO, "TDLS: Failed to parse KDEs in TPK M1");
+       if (len < min_req_len) {
+               wpa_printf(MSG_DEBUG, "TDLS Discovery Request is too short: "
+                          "%d", (int) len);
                return -1;
        }
 
-       if (kde.lnkid == NULL || kde.lnkid_len < 3 * ETH_ALEN) {
-               wpa_printf(MSG_INFO, "TDLS: No Link Identifier IE in TPK M1");
-               return -1;
+       dialog_token = buf[sizeof(struct wpa_tdls_frame)];
+
+       /*
+        * Some APs will tack on a weird IE to the end of a TDLS
+        * discovery request packet. This needn't fail the response,
+        * since the required IE are verified separately.
+        */
+       if (wpa_supplicant_parse_ies(buf + sizeof(struct wpa_tdls_frame) + 1,
+                                    len - (sizeof(struct wpa_tdls_frame) + 1),
+                                    &kde) < 0) {
+               wpa_printf(MSG_DEBUG,
+                          "TDLS: Failed to parse IEs in Discovery Request - ignore as an interop workaround");
        }
-       lnkid = (struct wpa_tdls_lnkid *) kde.lnkid;
-       if (os_memcmp(sm->bssid, lnkid->bssid, ETH_ALEN) != 0) {
-               wpa_printf(MSG_INFO, "TDLS: TPK M1 from diff BSS");
-               wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_RESPONSE,
-                                   dtoken, WLAN_STATUS_NOT_IN_SAME_BSS);
+
+       if (!kde.lnkid) {
+               wpa_printf(MSG_DEBUG, "TDLS: Link ID not found in Discovery "
+                          "Request");
                return -1;
        }
 
-       wpa_printf(MSG_DEBUG, "TDLS: TPK M1 - TPK initiator " MACSTR,
-                  MAC2STR(src_addr));
-
-       if (!wpa_tdls_get_privacy(sm))
-               goto skip_rsn;
+       lnkid = (const struct wpa_tdls_lnkid *) kde.lnkid;
 
-       if (kde.ftie == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No FTIE in TPK M1");
-               return -1;
-       }
-       ftie = (struct wpa_tdls_ftie *) kde.ftie;
-       if (kde.rsn_ie == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No RSN IE in TPK M1");
+       if (os_memcmp(sm->bssid, lnkid->bssid, ETH_ALEN) != 0) {
+               wpa_printf(MSG_DEBUG, "TDLS: Discovery Request from different "
+                          " BSS " MACSTR, MAC2STR(lnkid->bssid));
                return -1;
        }
 
-       if (kde.rsn_ie_len > TDLS_MAX_IE_LEN) {
-               wpa_printf(MSG_INFO, "TDLS: Too long Initiator RSN IE in "
-                          "TPK M1");
+       peer = wpa_tdls_add_peer(sm, addr, NULL);
+       if (peer == NULL)
                return -1;
-       }
 
-       if (wpa_parse_wpa_ie_rsn(kde.rsn_ie, kde.rsn_ie_len, &ie) < 0) {
-               wpa_printf(MSG_INFO, "TDLS: Failed to parse RSN IE in TPK M1");
+       return wpa_tdls_send_discovery_response(sm, peer, dialog_token);
+}
+
+
+int wpa_tdls_send_discovery_request(struct wpa_sm *sm, const u8 *addr)
+{
+       if (sm->tdls_disabled || !sm->tdls_supported)
                return -1;
-       }
 
-       cipher = ie.pairwise_cipher;
-       if (cipher & WPA_CIPHER_CCMP) {
-               wpa_printf(MSG_DEBUG, "TDLS: Using CCMP for direct link");
-               cipher = WPA_CIPHER_CCMP;
-       } else {
-               wpa_printf(MSG_INFO, "TDLS: No acceptable cipher in TPK M1");
-               wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_RESPONSE,
-                                   dtoken,
-                                   WLAN_STATUS_PAIRWISE_CIPHER_NOT_VALID);
+       wpa_printf(MSG_DEBUG, "TDLS: Sending Discovery Request to peer "
+                  MACSTR, MAC2STR(addr));
+       return wpa_tdls_tpk_send(sm, addr, WLAN_TDLS_DISCOVERY_REQUEST,
+                                1, 0, 0, NULL, 0);
+}
+
+
+static int copy_supp_rates(const struct wpa_eapol_ie_parse *kde,
+                          struct wpa_tdls_peer *peer)
+{
+       if (!kde->supp_rates) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported rates received");
                return -1;
        }
+       peer->supp_rates_len = merge_byte_arrays(
+               peer->supp_rates, sizeof(peer->supp_rates),
+               kde->supp_rates + 2, kde->supp_rates_len - 2,
+               kde->ext_supp_rates ? kde->ext_supp_rates + 2 : NULL,
+               kde->ext_supp_rates_len - 2);
+       return 0;
+}
 
-skip_rsn:
-       /* Find existing entry and if found, use that instead of adding
-        * a new one; how to handle the case where both ends initiate at the
-        * same time? */
-       for (peer = sm->tdls; peer; peer = peer->next) {
-               if (os_memcmp(peer->addr, src_addr, ETH_ALEN) == 0)
-                       break;
+
+static int copy_peer_ht_capab(const struct wpa_eapol_ie_parse *kde,
+                             struct wpa_tdls_peer *peer)
+{
+       if (!kde->ht_capabilities ||
+           kde->ht_capabilities_len <
+           sizeof(struct ieee80211_ht_capabilities) ) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported ht capabilities "
+                          "received");
+               return 0;
        }
 
-       if (peer == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No matching entry found for "
-                          "peer, creating one for " MACSTR,
-                          MAC2STR(src_addr));
-               peer = os_malloc(sizeof(*peer));
-               if (peer == NULL)
-                       return -1;
-               os_memset(peer, 0, sizeof(*peer));
-               os_memcpy(peer->addr, src_addr, ETH_ALEN);
-               peer->next = sm->tdls;
-               sm->tdls = peer;
-       } else {
-               /*
-                * An entry is already present, so check if a TPK_M1 Request
-                * had been sent.
-                * If so compare MAC address and let
-                *  - greater MAC continue to be initiator
-                *  - other MAC be Peer and process the Req.
-                */
-               if (peer->initiator) {
-                       if (os_memcmp(sm->own_addr, src_addr, ETH_ALEN) > 0) {
-                               wpa_printf(MSG_DEBUG, "TDLS: Dropping Request "
-                                          "from peer with smaller address "
-                                          MACSTR, MAC2STR(src_addr));
-                               return -1;
-                       } else {
-                               /*
-                                * If smaller node then accept the packet,
-                                * clear values and get ready to process this
-                                * Req.
-                                */
-                               wpa_printf(MSG_DEBUG, "TDLS: Accepting "
-                                          "Request from peer " MACSTR,
-                                          MAC2STR(src_addr));
-                               /* clear sm info and preserve the list */
-                               wpa_tdls_peer_free(sm, peer);
-                       }
-               }
+       if (!peer->ht_capabilities) {
+               peer->ht_capabilities =
+                        os_zalloc(sizeof(struct ieee80211_ht_capabilities));
+               if (peer->ht_capabilities == NULL)
+                        return -1;
        }
 
-       peer->initiator = 0; /* Need to check */
-       peer->dtoken = dtoken;
+       os_memcpy(peer->ht_capabilities, kde->ht_capabilities,
+                  sizeof(struct ieee80211_ht_capabilities));
+       wpa_hexdump(MSG_DEBUG, "TDLS: Peer HT capabilities",
+                   (u8 *) peer->ht_capabilities,
+                   sizeof(struct ieee80211_ht_capabilities));
 
-       if (!wpa_tdls_get_privacy(sm)) {
-               peer->rsnie_i_len = 0;
-               peer->rsnie_p_len = 0;
-               peer->cipher = WPA_CIPHER_NONE;
-               goto skip_rsn_check;
-       }
+       return 0;
+}
 
-       os_memcpy(peer->inonce, ftie->Snonce, WPA_NONCE_LEN);
-       os_memcpy(peer->rsnie_i, kde.rsn_ie, kde.rsn_ie_len);
-       peer->rsnie_i_len = kde.rsn_ie_len;
-       peer->cipher = cipher;
 
-       if (os_get_random(peer->rnonce, WPA_NONCE_LEN)) {
-               wpa_msg(sm->ctx->ctx, MSG_WARNING,
-                       "TDLS: Failed to get random data for responder nonce");
-               wpa_tdls_peer_free(sm, peer);
-               return -1;
+static int copy_peer_vht_capab(const struct wpa_eapol_ie_parse *kde,
+                             struct wpa_tdls_peer *peer)
+{
+       if (!kde->vht_capabilities ||
+           kde->vht_capabilities_len <
+           sizeof(struct ieee80211_vht_capabilities) ) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported vht capabilities "
+                          "received");
+               return 0;
        }
 
-#if 0
-       /* get version info from RSNIE received from Peer */
-       hdr = (struct rsn_ie_hdr *) kde.rsn_ie;
-       rsn_ver = WPA_GET_LE16(hdr->version);
+       if (!peer->vht_capabilities) {
+               peer->vht_capabilities =
+                        os_zalloc(sizeof(struct ieee80211_vht_capabilities));
+               if (peer->vht_capabilities == NULL)
+                        return -1;
+       }
+
+       os_memcpy(peer->vht_capabilities, kde->vht_capabilities,
+                  sizeof(struct ieee80211_vht_capabilities));
+       wpa_hexdump(MSG_DEBUG, "TDLS: Peer VHT capabilities",
+                   (u8 *) peer->vht_capabilities,
+                   sizeof(struct ieee80211_vht_capabilities));
+
+       return 0;
+}
+
+
+static int copy_peer_ext_capab(const struct wpa_eapol_ie_parse *kde,
+                              struct wpa_tdls_peer *peer)
+{
+       if (!kde->ext_capab) {
+               wpa_printf(MSG_DEBUG, "TDLS: No extended capabilities "
+                          "received");
+               return 0;
+       }
+
+       if (!peer->ext_capab || peer->ext_capab_len < kde->ext_capab_len - 2) {
+               /* Need to allocate buffer to fit the new information */
+               os_free(peer->ext_capab);
+               peer->ext_capab = os_zalloc(kde->ext_capab_len - 2);
+               if (peer->ext_capab == NULL)
+                       return -1;
+       }
+
+       peer->ext_capab_len = kde->ext_capab_len - 2;
+       os_memcpy(peer->ext_capab, kde->ext_capab + 2, peer->ext_capab_len);
+
+       return 0;
+}
+
+
+static int copy_peer_wmm_capab(const struct wpa_eapol_ie_parse *kde,
+                              struct wpa_tdls_peer *peer)
+{
+       struct wmm_information_element *wmm;
+
+       if (!kde->wmm) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported WMM capabilities received");
+               return 0;
+       }
+
+       if (kde->wmm_len < sizeof(struct wmm_information_element)) {
+               wpa_printf(MSG_DEBUG, "TDLS: Invalid supported WMM capabilities received");
+               return -1;
+       }
+
+       wmm = (struct wmm_information_element *) kde->wmm;
+       peer->qos_info = wmm->qos_info;
+
+       peer->wmm_capable = 1;
+
+       wpa_printf(MSG_DEBUG, "TDLS: Peer WMM QOS Info 0x%x", peer->qos_info);
+       return 0;
+}
+
+
+static int copy_peer_supp_channels(const struct wpa_eapol_ie_parse *kde,
+                                  struct wpa_tdls_peer *peer)
+{
+       if (!kde->supp_channels) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported channels received");
+               return 0;
+       }
+
+       if (!peer->supp_channels ||
+           peer->supp_channels_len < kde->supp_channels_len) {
+               os_free(peer->supp_channels);
+               peer->supp_channels = os_zalloc(kde->supp_channels_len);
+               if (peer->supp_channels == NULL)
+                       return -1;
+       }
+
+       peer->supp_channels_len = kde->supp_channels_len;
+
+       os_memcpy(peer->supp_channels, kde->supp_channels,
+                 peer->supp_channels_len);
+       wpa_hexdump(MSG_DEBUG, "TDLS: Peer Supported Channels",
+                   (u8 *) peer->supp_channels, peer->supp_channels_len);
+       return 0;
+}
+
+
+static int copy_peer_supp_oper_classes(const struct wpa_eapol_ie_parse *kde,
+                                      struct wpa_tdls_peer *peer)
+{
+       if (!kde->supp_oper_classes) {
+               wpa_printf(MSG_DEBUG, "TDLS: No supported operating classes received");
+               return 0;
+       }
+
+       if (!peer->supp_oper_classes ||
+           peer->supp_oper_classes_len < kde->supp_oper_classes_len) {
+               os_free(peer->supp_oper_classes);
+               peer->supp_oper_classes = os_zalloc(kde->supp_oper_classes_len);
+               if (peer->supp_oper_classes == NULL)
+                       return -1;
+       }
+
+       peer->supp_oper_classes_len = kde->supp_oper_classes_len;
+       os_memcpy(peer->supp_oper_classes, kde->supp_oper_classes,
+                 peer->supp_oper_classes_len);
+       wpa_hexdump(MSG_DEBUG, "TDLS: Peer Supported Operating Classes",
+                   (u8 *) peer->supp_oper_classes,
+                   peer->supp_oper_classes_len);
+       return 0;
+}
+
+
+static int wpa_tdls_process_tpk_m1(struct wpa_sm *sm, const u8 *src_addr,
+                                  const u8 *buf, size_t len)
+{
+       struct wpa_tdls_peer *peer;
+       struct wpa_eapol_ie_parse kde;
+       struct wpa_ie_data ie;
+       int cipher;
+       const u8 *cpos;
+       struct wpa_tdls_ftie *ftie = NULL;
+       struct wpa_tdls_timeoutie *timeoutie;
+       struct wpa_tdls_lnkid *lnkid;
+       u32 lifetime = 0;
+#if 0
+       struct rsn_ie_hdr *hdr;
+       u8 *pos;
+       u16 rsn_capab;
+       u16 rsn_ver;
+#endif
+       u8 dtoken;
+       u16 ielen;
+       u16 status = WLAN_STATUS_UNSPECIFIED_FAILURE;
+       int tdls_prohibited = sm->tdls_prohibited;
+       int existing_peer = 0;
+
+       if (len < 3 + 3)
+               return -1;
+
+       cpos = buf;
+       cpos += 1 /* pkt_type */ + 1 /* Category */ + 1 /* Action */;
+
+       /* driver had already verified the frame format */
+       dtoken = *cpos++; /* dialog token */
+
+       wpa_printf(MSG_INFO, "TDLS: Dialog Token in TPK M1 %d", dtoken);
+
+       peer = wpa_tdls_add_peer(sm, src_addr, &existing_peer);
+       if (peer == NULL)
+               goto error;
+
+       /* If found, use existing entry instead of adding a new one;
+        * how to handle the case where both ends initiate at the
+        * same time? */
+       if (existing_peer) {
+               if (peer->tpk_success) {
+                       wpa_printf(MSG_DEBUG, "TDLS: TDLS Setup Request while "
+                                  "direct link is enabled - tear down the "
+                                  "old link first");
+                       wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK, peer->addr);
+                       wpa_tdls_peer_clear(sm, peer);
+               } else if (peer->initiator) {
+                       /*
+                        * An entry is already present, so check if we already
+                        * sent a TDLS Setup Request. If so, compare MAC
+                        * addresses and let the STA with the lower MAC address
+                        * continue as the initiator. The other negotiation is
+                        * terminated.
+                        */
+                       if (os_memcmp(sm->own_addr, src_addr, ETH_ALEN) < 0) {
+                               wpa_printf(MSG_DEBUG, "TDLS: Discard request "
+                                          "from peer with higher address "
+                                          MACSTR, MAC2STR(src_addr));
+                               return -1;
+                       } else {
+                               wpa_printf(MSG_DEBUG, "TDLS: Accept request "
+                                          "from peer with lower address "
+                                          MACSTR " (terminate previously "
+                                          "initiated negotiation",
+                                          MAC2STR(src_addr));
+                               wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK,
+                                                peer->addr);
+                               wpa_tdls_peer_clear(sm, peer);
+                       }
+               }
+       }
+
+       /* capability information */
+       peer->capability = WPA_GET_LE16(cpos);
+       cpos += 2;
+
+       ielen = len - (cpos - buf); /* start of IE in buf */
+       if (wpa_supplicant_parse_ies(cpos, ielen, &kde) < 0) {
+               wpa_printf(MSG_INFO, "TDLS: Failed to parse IEs in TPK M1");
+               goto error;
+       }
+
+       if (kde.lnkid == NULL || kde.lnkid_len < 3 * ETH_ALEN) {
+               wpa_printf(MSG_INFO, "TDLS: No valid Link Identifier IE in "
+                          "TPK M1");
+               goto error;
+       }
+       wpa_hexdump(MSG_DEBUG, "TDLS: Link ID Received from TPK M1",
+                   kde.lnkid, kde.lnkid_len);
+       lnkid = (struct wpa_tdls_lnkid *) kde.lnkid;
+       if (os_memcmp(sm->bssid, lnkid->bssid, ETH_ALEN) != 0) {
+               wpa_printf(MSG_INFO, "TDLS: TPK M1 from diff BSS");
+               status = WLAN_STATUS_NOT_IN_SAME_BSS;
+               goto error;
+       }
+
+       wpa_printf(MSG_DEBUG, "TDLS: TPK M1 - TPK initiator " MACSTR,
+                  MAC2STR(src_addr));
+
+       if (copy_supp_rates(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_ht_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_vht_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_ext_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_supp_channels(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_supp_oper_classes(&kde, peer) < 0)
+               goto error;
+
+       peer->qos_info = kde.qosinfo;
+
+       /* Overwrite with the qos_info obtained in WMM IE */
+       if (copy_peer_wmm_capab(&kde, peer) < 0)
+               goto error;
+
+       peer->aid = kde.aid;
+
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_CONCURRENT_INIT) {
+               peer = wpa_tdls_add_peer(sm, src_addr, NULL);
+               if (peer == NULL)
+                       goto error;
+               wpa_printf(MSG_DEBUG, "TDLS: Testing concurrent initiation of "
+                          "TDLS setup - send own request");
+               peer->initiator = 1;
+               wpa_tdls_send_tpk_m1(sm, peer);
+       }
+
+       if ((tdls_testing & TDLS_TESTING_IGNORE_AP_PROHIBIT) &&
+           tdls_prohibited) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - ignore AP prohibition "
+                          "on TDLS");
+               tdls_prohibited = 0;
+       }
+#endif /* CONFIG_TDLS_TESTING */
+
+       if (tdls_prohibited) {
+               wpa_printf(MSG_INFO, "TDLS: TDLS prohibited in this BSS");
+               status = WLAN_STATUS_REQUEST_DECLINED;
+               goto error;
+       }
+
+       if (!wpa_tdls_get_privacy(sm)) {
+               if (kde.rsn_ie) {
+                       wpa_printf(MSG_INFO, "TDLS: RSN IE in TPK M1 while "
+                                  "security is disabled");
+                       status = WLAN_STATUS_SECURITY_DISABLED;
+                       goto error;
+               }
+               goto skip_rsn;
+       }
+
+       if (kde.ftie == NULL || kde.ftie_len < sizeof(*ftie) ||
+           kde.rsn_ie == NULL) {
+               wpa_printf(MSG_INFO, "TDLS: No FTIE or RSN IE in TPK M1");
+               status = WLAN_STATUS_INVALID_PARAMETERS;
+               goto error;
+       }
+
+       if (kde.rsn_ie_len > TDLS_MAX_IE_LEN) {
+               wpa_printf(MSG_INFO, "TDLS: Too long Initiator RSN IE in "
+                          "TPK M1");
+               status = WLAN_STATUS_INVALID_RSNIE;
+               goto error;
+       }
+
+       if (wpa_parse_wpa_ie_rsn(kde.rsn_ie, kde.rsn_ie_len, &ie) < 0) {
+               wpa_printf(MSG_INFO, "TDLS: Failed to parse RSN IE in TPK M1");
+               status = WLAN_STATUS_INVALID_RSNIE;
+               goto error;
+       }
+
+       cipher = ie.pairwise_cipher;
+       if (cipher & WPA_CIPHER_CCMP) {
+               wpa_printf(MSG_DEBUG, "TDLS: Using CCMP for direct link");
+               cipher = WPA_CIPHER_CCMP;
+       } else {
+               wpa_printf(MSG_INFO, "TDLS: No acceptable cipher in TPK M1");
+               status = WLAN_STATUS_PAIRWISE_CIPHER_NOT_VALID;
+               goto error;
+       }
+
+       if ((ie.capabilities &
+            (WPA_CAPABILITY_NO_PAIRWISE | WPA_CAPABILITY_PEERKEY_ENABLED)) !=
+           WPA_CAPABILITY_PEERKEY_ENABLED) {
+               wpa_printf(MSG_INFO, "TDLS: Invalid RSN Capabilities in "
+                          "TPK M1");
+               status = WLAN_STATUS_INVALID_RSN_IE_CAPAB;
+               goto error;
+       }
+
+       /* Lifetime */
+       if (kde.key_lifetime == NULL) {
+               wpa_printf(MSG_INFO, "TDLS: No Key Lifetime IE in TPK M1");
+               status = WLAN_STATUS_UNACCEPTABLE_LIFETIME;
+               goto error;
+       }
+       timeoutie = (struct wpa_tdls_timeoutie *) kde.key_lifetime;
+       lifetime = WPA_GET_LE32(timeoutie->value);
+       wpa_printf(MSG_DEBUG, "TDLS: TPK lifetime %u seconds", lifetime);
+       if (lifetime < 300) {
+               wpa_printf(MSG_INFO, "TDLS: Too short TPK lifetime");
+               status = WLAN_STATUS_UNACCEPTABLE_LIFETIME;
+               goto error;
+       }
+
+skip_rsn:
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_CONCURRENT_INIT) {
+               if (os_memcmp(sm->own_addr, peer->addr, ETH_ALEN) < 0) {
+                       /*
+                        * The request frame from us is going to win, so do not
+                        * replace information based on this request frame from
+                        * the peer.
+                        */
+                       goto skip_rsn_check;
+               }
+       }
+#endif /* CONFIG_TDLS_TESTING */
+
+       peer->initiator = 0; /* Need to check */
+       peer->dtoken = dtoken;
+
+       if (!wpa_tdls_get_privacy(sm)) {
+               peer->rsnie_i_len = 0;
+               peer->rsnie_p_len = 0;
+               peer->cipher = WPA_CIPHER_NONE;
+               goto skip_rsn_check;
+       }
+
+       ftie = (struct wpa_tdls_ftie *) kde.ftie;
+       os_memcpy(peer->rsnie_i, kde.rsn_ie, kde.rsn_ie_len);
+       peer->rsnie_i_len = kde.rsn_ie_len;
+       peer->cipher = cipher;
+
+       if (os_memcmp(peer->inonce, ftie->Snonce, WPA_NONCE_LEN) != 0) {
+               /*
+                * There is no point in updating the RNonce for every obtained
+                * TPK M1 frame (e.g., retransmission due to timeout) with the
+                * same INonce (SNonce in FTIE). However, if the TPK M1 is
+                * retransmitted with a different INonce, update the RNonce
+                * since this is for a new TDLS session.
+                */
+               wpa_printf(MSG_DEBUG,
+                          "TDLS: New TPK M1 INonce - generate new RNonce");
+               os_memcpy(peer->inonce, ftie->Snonce, WPA_NONCE_LEN);
+               if (os_get_random(peer->rnonce, WPA_NONCE_LEN)) {
+                       wpa_msg(sm->ctx->ctx, MSG_WARNING,
+                               "TDLS: Failed to get random data for responder nonce");
+                       goto error;
+               }
+       }
+
+#if 0
+       /* get version info from RSNIE received from Peer */
+       hdr = (struct rsn_ie_hdr *) kde.rsn_ie;
+       rsn_ver = WPA_GET_LE16(hdr->version);
 
        /* use min(peer's version, out version) */
        if (rsn_ver > RSN_VERSION)
@@ -1348,40 +1937,79 @@ skip_rsn:
        os_memcpy(peer->rsnie_p, peer->rsnie_i, peer->rsnie_i_len);
        peer->rsnie_p_len = peer->rsnie_i_len;
 
-       wpa_hexdump(MSG_DEBUG, "TDLS: RSN IE for PTK handshake",
+       wpa_hexdump(MSG_DEBUG, "TDLS: RSN IE for TPK handshake",
                    peer->rsnie_p, peer->rsnie_p_len);
 
-       /* Lifetime */
-       if (kde.key_lifetime == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No Key Lifetime IE in TPK M1");
-               return -1;
-       }
-       timeoutie = (struct wpa_tdls_timeoutie *) kde.key_lifetime;
-       lifetime = WPA_GET_LE32(timeoutie->value);
-       wpa_printf(MSG_DEBUG, "TDLS: TPK lifetime %u seconds", lifetime);
-       if (lifetime < 300)
-               lifetime = 300; /* minimum seconds */
        peer->lifetime = lifetime;
 
        wpa_tdls_generate_tpk(peer, sm->own_addr, sm->bssid);
 
 skip_rsn_check:
+       /* add the peer to the driver as a "setup in progress" peer */
+       if (wpa_sm_tdls_peer_addset(sm, peer->addr, 1, peer->aid,
+                                   peer->capability,
+                                   peer->supp_rates, peer->supp_rates_len,
+                                   peer->ht_capabilities,
+                                   peer->vht_capabilities,
+                                   peer->qos_info, peer->ext_capab,
+                                   peer->ext_capab_len,
+                                   peer->supp_channels,
+                                   peer->supp_channels_len,
+                                   peer->supp_oper_classes,
+                                   peer->supp_oper_classes_len))
+               goto error;
+
+       peer->tpk_in_progress = 1;
+
        wpa_printf(MSG_DEBUG, "TDLS: Sending TDLS Setup Response / TPK M2");
-       wpa_tdls_send_tpk_m2(sm, src_addr, dtoken, lnkid, peer);
+       if (wpa_tdls_send_tpk_m2(sm, src_addr, dtoken, lnkid, peer) < 0) {
+               wpa_sm_tdls_oper(sm, TDLS_DISABLE_LINK, peer->addr);
+               goto error;
+       }
 
        return 0;
+
+error:
+       wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_RESPONSE, dtoken,
+                           status);
+       if (peer)
+               wpa_tdls_peer_free(sm, peer);
+       return -1;
 }
 
 
-static void wpa_tdls_enable_link(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
+static int wpa_tdls_enable_link(struct wpa_sm *sm, struct wpa_tdls_peer *peer)
 {
        peer->tpk_success = 1;
+       peer->tpk_in_progress = 0;
        eloop_cancel_timeout(wpa_tdls_tpk_timeout, sm, peer);
        if (wpa_tdls_get_privacy(sm)) {
-               eloop_register_timeout(peer->lifetime, 0, wpa_tdls_tpk_timeout,
+               u32 lifetime = peer->lifetime;
+               /*
+                * Start the initiator process a bit earlier to avoid race
+                * condition with the responder sending teardown request.
+                */
+               if (lifetime > 3 && peer->initiator)
+                       lifetime -= 3;
+               eloop_register_timeout(lifetime, 0, wpa_tdls_tpk_timeout,
                                       sm, peer);
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_NO_TPK_EXPIRATION) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - disable TPK "
+                          "expiration");
+               eloop_cancel_timeout(wpa_tdls_tpk_timeout, sm, peer);
+       }
+#endif /* CONFIG_TDLS_TESTING */
+       }
+
+       if (peer->reconfig_key && wpa_tdls_set_key(sm, peer) < 0) {
+               wpa_printf(MSG_INFO, "TDLS: Could not configure key to the "
+                          "driver");
+               return -1;
        }
-       wpa_sm_tdls_oper(sm, TDLS_ENABLE_LINK, peer->addr);
+       peer->reconfig_key = 0;
+
+       return wpa_sm_tdls_oper(sm, TDLS_ENABLE_LINK, peer->addr);
 }
 
 
@@ -1400,6 +2028,7 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
        int ielen;
        u16 status;
        const u8 *pos;
+       int ret = 0;
 
        wpa_printf(MSG_DEBUG, "TDLS: Received TDLS Setup Response / TPK M2 "
                   "(Peer " MACSTR ")", MAC2STR(src_addr));
@@ -1412,40 +2041,69 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
                           "TPK M2: " MACSTR, MAC2STR(src_addr));
                return -1;
        }
+       if (!peer->initiator) {
+               /*
+                * This may happen if both devices try to initiate TDLS at the
+                * same time and we accept the TPK M1 from the peer in
+                * wpa_tdls_process_tpk_m1() and clear our previous state.
+                */
+               wpa_printf(MSG_INFO, "TDLS: We were not the initiator, so "
+                          "ignore TPK M2 from " MACSTR, MAC2STR(src_addr));
+               return -1;
+       }
        wpa_tdls_tpk_retry_timeout_cancel(sm, peer, WLAN_TDLS_SETUP_REQUEST);
 
-       if (len < 3 + 2 + 1)
+       if (len < 3 + 2 + 1) {
+               wpa_tdls_disable_peer_link(sm, peer);
                return -1;
+       }
+
        pos = buf;
        pos += 1 /* pkt_type */ + 1 /* Category */ + 1 /* Action */;
        status = WPA_GET_LE16(pos);
        pos += 2 /* status code */;
 
-       if (status != 0) {
+       if (status != WLAN_STATUS_SUCCESS) {
                wpa_printf(MSG_INFO, "TDLS: Status code in TPK M2: %u",
                           status);
+               wpa_tdls_disable_peer_link(sm, peer);
                return -1;
        }
 
+       status = WLAN_STATUS_UNSPECIFIED_FAILURE;
+
        /* TODO: need to verify dialog token matches here or in kernel */
        dtoken = *pos++; /* dialog token */
 
        wpa_printf(MSG_DEBUG, "TDLS: Dialog Token in TPK M2 %d", dtoken);
 
-       if (len < 3 + 2 + 1 + 2)
+       if (len < 3 + 2 + 1 + 2) {
+               wpa_tdls_disable_peer_link(sm, peer);
                return -1;
-       pos += 2; /* capability information */
+       }
+
+       /* capability information */
+       peer->capability = WPA_GET_LE16(pos);
+       pos += 2;
 
        ielen = len - (pos - buf); /* start of IE in buf */
        if (wpa_supplicant_parse_ies(pos, ielen, &kde) < 0) {
                wpa_printf(MSG_INFO, "TDLS: Failed to parse IEs in TPK M2");
-               return -1;
+               goto error;
+       }
+
+#ifdef CONFIG_TDLS_TESTING
+       if (tdls_testing & TDLS_TESTING_DECLINE_RESP) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - decline response");
+               status = WLAN_STATUS_REQUEST_DECLINED;
+               goto error;
        }
+#endif /* CONFIG_TDLS_TESTING */
 
        if (kde.lnkid == NULL || kde.lnkid_len < 3 * ETH_ALEN) {
                wpa_printf(MSG_INFO, "TDLS: No valid Link Identifier IE in "
                           "TPK M2");
-               return -1;
+               goto error;
        }
        wpa_hexdump(MSG_DEBUG, "TDLS: Link ID Received from TPK M2",
                    kde.lnkid, kde.lnkid_len);
@@ -1453,24 +2111,64 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
 
        if (os_memcmp(sm->bssid, lnkid->bssid, ETH_ALEN) != 0) {
                wpa_printf(MSG_INFO, "TDLS: TPK M2 from different BSS");
-               wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM,
-                                   dtoken, WLAN_STATUS_NOT_IN_SAME_BSS);
-               return -1;
+               status = WLAN_STATUS_NOT_IN_SAME_BSS;
+               goto error;
        }
 
+       if (copy_supp_rates(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_ht_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_vht_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_ext_capab(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_supp_channels(&kde, peer) < 0)
+               goto error;
+
+       if (copy_peer_supp_oper_classes(&kde, peer) < 0)
+               goto error;
+
+       peer->qos_info = kde.qosinfo;
+
+       /* Overwrite with the qos_info obtained in WMM IE */
+       if (copy_peer_wmm_capab(&kde, peer) < 0)
+               goto error;
+
+       peer->aid = kde.aid;
+
        if (!wpa_tdls_get_privacy(sm)) {
                peer->rsnie_p_len = 0;
                peer->cipher = WPA_CIPHER_NONE;
                goto skip_rsn;
        }
 
-       if (kde.rsn_ie == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No RSN IE in TPK M2");
-               return -1;
+       if (kde.ftie == NULL || kde.ftie_len < sizeof(*ftie) ||
+           kde.rsn_ie == NULL) {
+               wpa_printf(MSG_INFO, "TDLS: No FTIE or RSN IE in TPK M2");
+               status = WLAN_STATUS_INVALID_PARAMETERS;
+               goto error;
        }
-       wpa_hexdump(MSG_DEBUG, "TDLS: RSNIE Received from TPK M2",
+       wpa_hexdump(MSG_DEBUG, "TDLS: RSN IE Received from TPK M2",
                    kde.rsn_ie, kde.rsn_ie_len);
 
+       if (kde.rsn_ie_len > TDLS_MAX_IE_LEN) {
+               wpa_printf(MSG_INFO,
+                          "TDLS: Too long Responder RSN IE in TPK M2");
+               status = WLAN_STATUS_INVALID_RSNIE;
+               goto error;
+       }
+
+       /*
+        * FIX: bitwise comparison of RSN IE is not the correct way of
+        * validation this. It can be different, but certain fields must
+        * match. Since we list only a single pairwise cipher in TPK M1, the
+        * memcmp is likely to work in most cases, though.
+        */
        if (kde.rsn_ie_len != peer->rsnie_i_len ||
            os_memcmp(peer->rsnie_i, kde.rsn_ie, peer->rsnie_i_len) != 0) {
                wpa_printf(MSG_INFO, "TDLS: RSN IE in TPK M2 does "
@@ -1479,34 +2177,26 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
                            peer->rsnie_i, peer->rsnie_i_len);
                wpa_hexdump(MSG_DEBUG, "TDLS: RSN IE Received from TPK M2",
                            kde.rsn_ie, kde.rsn_ie_len);
-               wpa_tdls_send_error(sm, src_addr,
-                                   WLAN_TDLS_SETUP_CONFIRM, dtoken,
-                                   WLAN_STATUS_UNSUPPORTED_RSN_IE_VERSION);
-
-               return -1;
+               status = WLAN_STATUS_INVALID_RSNIE;
+               goto error;
        }
 
        if (wpa_parse_wpa_ie_rsn(kde.rsn_ie, kde.rsn_ie_len, &ie) < 0) {
                wpa_printf(MSG_INFO, "TDLS: Failed to parse RSN IE in TPK M2");
-               return -1;
+               status = WLAN_STATUS_INVALID_RSNIE;
+               goto error;
        }
 
        cipher = ie.pairwise_cipher;
-       if (cipher & WPA_CIPHER_CCMP) {
+       if (cipher == WPA_CIPHER_CCMP) {
                wpa_printf(MSG_DEBUG, "TDLS: Using CCMP for direct link");
                cipher = WPA_CIPHER_CCMP;
        } else {
                wpa_printf(MSG_INFO, "TDLS: No acceptable cipher in TPK M2");
-               wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM,
-                                   dtoken,
-                                   WLAN_STATUS_PAIRWISE_CIPHER_NOT_VALID);
-               return -1;
+               status = WLAN_STATUS_PAIRWISE_CIPHER_NOT_VALID;
+               goto error;
        }
 
-       if (kde.ftie == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No FTIE in TPK M2");
-               return -1;
-       }
        wpa_hexdump(MSG_DEBUG, "TDLS: FTIE Received from TPK M2",
                    kde.ftie, sizeof(*ftie));
        ftie = (struct wpa_tdls_ftie *) kde.ftie;
@@ -1514,6 +2204,7 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
        if (!os_memcmp(peer->inonce, ftie->Snonce, WPA_NONCE_LEN) == 0) {
                wpa_printf(MSG_INFO, "TDLS: FTIE SNonce in TPK M2 does "
                           "not match with FTIE SNonce used in TPK M1");
+               /* Silently discard the frame */
                return -1;
        }
 
@@ -1526,7 +2217,8 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
        /* Lifetime */
        if (kde.key_lifetime == NULL) {
                wpa_printf(MSG_INFO, "TDLS: No Key Lifetime IE in TPK M2");
-               return -1;
+               status = WLAN_STATUS_UNACCEPTABLE_LIFETIME;
+               goto error;
        }
        timeoutie = (struct wpa_tdls_timeoutie *) kde.key_lifetime;
        lifetime = WPA_GET_LE32(timeoutie->value);
@@ -1535,9 +2227,8 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
        if (lifetime != peer->lifetime) {
                wpa_printf(MSG_INFO, "TDLS: Unexpected TPK lifetime %u in "
                           "TPK M2 (expected %u)", lifetime, peer->lifetime);
-               wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM,
-                                   dtoken, WLAN_STATUS_UNACCEPTABLE_LIFETIME);
-               return -1;
+               status = WLAN_STATUS_UNACCEPTABLE_LIFETIME;
+               goto error;
        }
 
        wpa_tdls_generate_tpk(peer, sm->own_addr, sm->bssid);
@@ -1545,23 +2236,65 @@ static int wpa_tdls_process_tpk_m2(struct wpa_sm *sm, const u8 *src_addr,
        /* Process MIC check to see if TPK M2 is right */
        if (wpa_supplicant_verify_tdls_mic(2, peer, (u8 *) lnkid,
                                           (u8 *) timeoutie, ftie) < 0) {
+               /* Discard the frame */
                wpa_tdls_del_key(sm, peer);
-               wpa_tdls_peer_free(sm, peer);
+               wpa_tdls_disable_peer_link(sm, peer);
                return -1;
        }
 
-       wpa_tdls_set_key(sm, peer);
+       if (wpa_tdls_set_key(sm, peer) < 0) {
+               /*
+                * Some drivers may not be able to config the key prior to full
+                * STA entry having been configured.
+                */
+               wpa_printf(MSG_DEBUG, "TDLS: Try to configure TPK again after "
+                          "STA entry is complete");
+               peer->reconfig_key = 1;
+       }
 
 skip_rsn:
        peer->dtoken = dtoken;
 
+       /* add supported rates, capabilities, and qos_info to the TDLS peer */
+       if (wpa_sm_tdls_peer_addset(sm, peer->addr, 0, peer->aid,
+                                   peer->capability,
+                                   peer->supp_rates, peer->supp_rates_len,
+                                   peer->ht_capabilities,
+                                   peer->vht_capabilities,
+                                   peer->qos_info, peer->ext_capab,
+                                   peer->ext_capab_len,
+                                   peer->supp_channels,
+                                   peer->supp_channels_len,
+                                   peer->supp_oper_classes,
+                                   peer->supp_oper_classes_len) < 0)
+               goto error;
+
        wpa_printf(MSG_DEBUG, "TDLS: Sending TDLS Setup Confirm / "
                   "TPK Handshake Message 3");
-       wpa_tdls_send_tpk_m3(sm, src_addr, dtoken, lnkid, peer);
+       if (wpa_tdls_send_tpk_m3(sm, src_addr, dtoken, lnkid, peer) < 0)
+               goto error;
 
-       wpa_tdls_enable_link(sm, peer);
+       if (!peer->tpk_success) {
+               /*
+                * Enable Link only when tpk_success is 0, signifying that this
+                * processing of TPK M2 frame is not because of a retransmission
+                * during TDLS setup handshake.
+                */
+               ret = wpa_tdls_enable_link(sm, peer);
+               if (ret < 0) {
+                       wpa_printf(MSG_DEBUG, "TDLS: Could not enable link");
+                       wpa_tdls_do_teardown(
+                               sm, peer,
+                               WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED);
+               }
+       }
+       return ret;
 
-       return 0;
+error:
+       wpa_tdls_send_error(sm, src_addr, WLAN_TDLS_SETUP_CONFIRM, dtoken,
+                           status);
+       wpa_tdls_disable_peer_link(sm, peer);
+       return -1;
 }
 
 
@@ -1577,6 +2310,7 @@ static int wpa_tdls_process_tpk_m3(struct wpa_sm *sm, const u8 *src_addr,
        u16 status;
        const u8 *pos;
        u32 lifetime;
+       int ret = 0;
 
        wpa_printf(MSG_DEBUG, "TDLS: Received TDLS Setup Confirm / TPK M3 "
                   "(Peer " MACSTR ")", MAC2STR(src_addr));
@@ -1591,6 +2325,8 @@ static int wpa_tdls_process_tpk_m3(struct wpa_sm *sm, const u8 *src_addr,
        }
        wpa_tdls_tpk_retry_timeout_cancel(sm, peer, WLAN_TDLS_SETUP_RESPONSE);
 
+       if (len < 3 + 3)
+               goto error;
        pos = buf;
        pos += 1 /* pkt_type */ + 1 /* Category */ + 1 /* Action */;
 
@@ -1599,19 +2335,26 @@ static int wpa_tdls_process_tpk_m3(struct wpa_sm *sm, const u8 *src_addr,
        if (status != 0) {
                wpa_printf(MSG_INFO, "TDLS: Status code in TPK M3: %u",
                           status);
-               return -1;
+               goto error;
        }
        pos += 2 /* status code */ + 1 /* dialog token */;
 
        ielen = len - (pos - buf); /* start of IE in buf */
+
+       /*
+        * Don't reject the message if failing to parse IEs. The IEs we need are
+        * explicitly checked below. Some APs piggy-back broken IEs to the end
+        * of a TDLS Confirm packet, which will fail the link if we don't ignore
+        * this error.
+        */
        if (wpa_supplicant_parse_ies((const u8 *) pos, ielen, &kde) < 0) {
-               wpa_printf(MSG_INFO, "TDLS: Failed to parse KDEs in TPK M3");
-               return -1;
+               wpa_printf(MSG_DEBUG,
+                          "TDLS: Failed to parse KDEs in TPK M3 - ignore as an interop workaround");
        }
 
        if (kde.lnkid == NULL || kde.lnkid_len < 3 * ETH_ALEN) {
                wpa_printf(MSG_INFO, "TDLS: No Link Identifier IE in TPK M3");
-               return -1;
+               goto error;
        }
        wpa_hexdump(MSG_DEBUG, "TDLS: Link ID Received from TPK M3",
                    (u8 *) kde.lnkid, kde.lnkid_len);
@@ -1619,42 +2362,48 @@ static int wpa_tdls_process_tpk_m3(struct wpa_sm *sm, const u8 *src_addr,
 
        if (os_memcmp(sm->bssid, lnkid->bssid, ETH_ALEN) != 0) {
                wpa_printf(MSG_INFO, "TDLS: TPK M3 from diff BSS");
-               return -1;
+               goto error;
        }
 
        if (!wpa_tdls_get_privacy(sm))
                goto skip_rsn;
 
-       if (kde.ftie == NULL) {
+       if (kde.ftie == NULL || kde.ftie_len < sizeof(*ftie)) {
                wpa_printf(MSG_INFO, "TDLS: No FTIE in TPK M3");
-               return -1;
+               goto error;
        }
        wpa_hexdump(MSG_DEBUG, "TDLS: FTIE Received from TPK M3",
-                   (u8 *) ftie, sizeof(*ftie));
+                   kde.ftie, sizeof(*ftie));
        ftie = (struct wpa_tdls_ftie *) kde.ftie;
 
        if (kde.rsn_ie == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No RSN IE KDE in TPK M3");
-               return -1;
+               wpa_printf(MSG_INFO, "TDLS: No RSN IE in TPK M3");
+               goto error;
        }
-       wpa_hexdump(MSG_DEBUG, "TDLS: RSNIE Received from TPK M3",
+       wpa_hexdump(MSG_DEBUG, "TDLS: RSN IE Received from TPK M3",
                    kde.rsn_ie, kde.rsn_ie_len);
+       if (kde.rsn_ie_len != peer->rsnie_p_len ||
+           os_memcmp(kde.rsn_ie, peer->rsnie_p, peer->rsnie_p_len) != 0) {
+               wpa_printf(MSG_INFO, "TDLS: RSN IE in TPK M3 does not match "
+                          "with the one sent in TPK M2");
+               goto error;
+       }
 
        if (!os_memcmp(peer->rnonce, ftie->Anonce, WPA_NONCE_LEN) == 0) {
                wpa_printf(MSG_INFO, "TDLS: FTIE ANonce in TPK M3 does "
                           "not match with FTIE ANonce used in TPK M2");
-               return -1;
+               goto error;
        }
 
        if (!os_memcmp(peer->inonce, ftie->Snonce, WPA_NONCE_LEN) == 0) {
                wpa_printf(MSG_INFO, "TDLS: FTIE SNonce in TPK M3 does not "
                           "match with FTIE SNonce used in TPK M1");
-               return -1;
+               goto error;
        }
 
        if (kde.key_lifetime == NULL) {
                wpa_printf(MSG_INFO, "TDLS: No Key Lifetime IE in TPK M3");
-               return -1;
+               goto error;
        }
        timeoutie = (struct wpa_tdls_timeoutie *) kde.key_lifetime;
        wpa_hexdump(MSG_DEBUG, "TDLS: Timeout IE Received from TPK M3",
@@ -1665,23 +2414,58 @@ static int wpa_tdls_process_tpk_m3(struct wpa_sm *sm, const u8 *src_addr,
        if (lifetime != peer->lifetime) {
                wpa_printf(MSG_INFO, "TDLS: Unexpected TPK lifetime %u in "
                           "TPK M3 (expected %u)", lifetime, peer->lifetime);
-               return -1;
+               goto error;
        }
 
        if (wpa_supplicant_verify_tdls_mic(3, peer, (u8 *) lnkid,
                                           (u8 *) timeoutie, ftie) < 0) {
                wpa_tdls_del_key(sm, peer);
-               wpa_tdls_peer_free(sm, peer);
-               return -1;
+               goto error;
        }
 
-       if (wpa_tdls_set_key(sm, peer) < 0)
-               return -1;
+       if (wpa_tdls_set_key(sm, peer) < 0) {
+               /*
+                * Some drivers may not be able to config the key prior to full
+                * STA entry having been configured.
+                */
+               wpa_printf(MSG_DEBUG, "TDLS: Try to configure TPK again after "
+                          "STA entry is complete");
+               peer->reconfig_key = 1;
+       }
 
 skip_rsn:
-       wpa_tdls_enable_link(sm, peer);
-
-       return 0;
+       /* add supported rates, capabilities, and qos_info to the TDLS peer */
+       if (wpa_sm_tdls_peer_addset(sm, peer->addr, 0, peer->aid,
+                                   peer->capability,
+                                   peer->supp_rates, peer->supp_rates_len,
+                                   peer->ht_capabilities,
+                                   peer->vht_capabilities,
+                                   peer->qos_info, peer->ext_capab,
+                                   peer->ext_capab_len,
+                                   peer->supp_channels,
+                                   peer->supp_channels_len,
+                                   peer->supp_oper_classes,
+                                   peer->supp_oper_classes_len) < 0)
+               goto error;
+
+       if (!peer->tpk_success) {
+               /*
+                * Enable Link only when tpk_success is 0, signifying that this
+                * processing of TPK M3 frame is not because of a retransmission
+                * during TDLS setup handshake.
+                */
+               ret = wpa_tdls_enable_link(sm, peer);
+               if (ret < 0) {
+                       wpa_printf(MSG_DEBUG, "TDLS: Could not enable link");
+                       wpa_tdls_do_teardown(
+                               sm, peer,
+                               WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED);
+               }
+       }
+       return ret;
+error:
+       wpa_tdls_disable_peer_link(sm, peer);
+       return -1;
 }
 
 
@@ -1711,29 +2495,75 @@ static u8 * wpa_add_tdls_timeoutie(u8 *pos, u8 *ie, size_t ie_len, u32 tsecs)
 int wpa_tdls_start(struct wpa_sm *sm, const u8 *addr)
 {
        struct wpa_tdls_peer *peer;
+       int tdls_prohibited = sm->tdls_prohibited;
 
-       /* Find existing entry and if found, use that instead of adding
-        * a new one */
-       for (peer = sm->tdls; peer; peer = peer->next) {
-               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
-                       break;
+       if (sm->tdls_disabled || !sm->tdls_supported)
+               return -1;
+
+#ifdef CONFIG_TDLS_TESTING
+       if ((tdls_testing & TDLS_TESTING_IGNORE_AP_PROHIBIT) &&
+           tdls_prohibited) {
+               wpa_printf(MSG_DEBUG, "TDLS: Testing - ignore AP prohibition "
+                          "on TDLS");
+               tdls_prohibited = 0;
        }
+#endif /* CONFIG_TDLS_TESTING */
 
-       if (peer == NULL) {
-               wpa_printf(MSG_INFO, "TDLS: No matching entry found for "
-                          "peer, creating one for " MACSTR, MAC2STR(addr));
-               peer = os_malloc(sizeof(*peer));
-               if (peer == NULL)
-                       return -1;
-               os_memset(peer, 0, sizeof(*peer));
-               os_memcpy(peer->addr, addr, ETH_ALEN);
-               peer->next = sm->tdls;
-               sm->tdls = peer;
+       if (tdls_prohibited) {
+               wpa_printf(MSG_DEBUG, "TDLS: TDLS is prohibited in this BSS - "
+                          "reject request to start setup");
+               return -1;
+       }
+
+       peer = wpa_tdls_add_peer(sm, addr, NULL);
+       if (peer == NULL)
+               return -1;
+
+       if (peer->tpk_in_progress) {
+               wpa_printf(MSG_DEBUG, "TDLS: Setup is already in progress with the peer");
+               return 0;
        }
 
        peer->initiator = 1;
 
-       return wpa_tdls_send_tpk_m1(sm, peer);
+       /* add the peer to the driver as a "setup in progress" peer */
+       wpa_sm_tdls_peer_addset(sm, peer->addr, 1, 0, 0, NULL, 0, NULL, NULL, 0,
+                               NULL, 0, NULL, 0, NULL, 0);
+
+       peer->tpk_in_progress = 1;
+
+       if (wpa_tdls_send_tpk_m1(sm, peer) < 0) {
+               wpa_tdls_disable_peer_link(sm, peer);
+               return -1;
+       }
+
+       return 0;
+}
+
+
+void wpa_tdls_remove(struct wpa_sm *sm, const u8 *addr)
+{
+       struct wpa_tdls_peer *peer;
+
+       if (sm->tdls_disabled || !sm->tdls_supported)
+               return;
+
+       for (peer = sm->tdls; peer; peer = peer->next) {
+               if (os_memcmp(peer->addr, addr, ETH_ALEN) == 0)
+                       break;
+       }
+
+       if (peer == NULL || !peer->tpk_success)
+               return;
+
+       if (sm->tdls_external_setup) {
+               /*
+                * Disable previous link to allow renegotiation to be completed
+                * on AP path.
+                */
+               wpa_tdls_do_teardown(sm, peer,
+                                    WLAN_REASON_TDLS_TEARDOWN_UNSPECIFIED);
+       }
 }
 
 
@@ -1751,6 +2581,12 @@ static void wpa_supplicant_rx_tdls(void *ctx, const u8 *src_addr,
        wpa_hexdump(MSG_DEBUG, "TDLS: Received Data frame encapsulation",
                    buf, len);
 
+       if (sm->tdls_disabled || !sm->tdls_supported) {
+               wpa_printf(MSG_DEBUG, "TDLS: Discard message - TDLS disabled "
+                          "or unsupported by driver");
+               return;
+       }
+
        if (os_memcmp(src_addr, sm->own_addr, ETH_ALEN) == 0) {
                wpa_printf(MSG_DEBUG, "TDLS: Discard copy of own message");
                return;
@@ -1784,6 +2620,9 @@ static void wpa_supplicant_rx_tdls(void *ctx, const u8 *src_addr,
        case WLAN_TDLS_TEARDOWN:
                wpa_tdls_recv_teardown(sm, src_addr, buf, len);
                break;
+       case WLAN_TDLS_DISCOVERY_REQUEST:
+               wpa_tdls_process_discovery_request(sm, src_addr, buf, len);
+               break;
        default:
                /* Kernel code will process remaining frames */
                wpa_printf(MSG_DEBUG, "TDLS: Ignore TDLS frame action code %u",
@@ -1807,7 +2646,9 @@ int wpa_tdls_init(struct wpa_sm *sm)
        if (sm == NULL)
                return -1;
 
-       sm->l2_tdls = l2_packet_init(sm->ifname, sm->own_addr,
+       sm->l2_tdls = l2_packet_init(sm->bridge_ifname ? sm->bridge_ifname :
+                                    sm->ifname,
+                                    sm->own_addr,
                                     ETH_P_80211_ENCAP, wpa_supplicant_rx_tdls,
                                     sm, 0);
        if (sm->l2_tdls == NULL) {
@@ -1816,16 +2657,53 @@ int wpa_tdls_init(struct wpa_sm *sm)
                return -1;
        }
 
+       /*
+        * Drivers that support TDLS but don't implement the get_capa callback
+        * are assumed to perform everything internally
+        */
+       if (wpa_sm_tdls_get_capa(sm, &sm->tdls_supported,
+                                &sm->tdls_external_setup) < 0) {
+               sm->tdls_supported = 1;
+               sm->tdls_external_setup = 0;
+       }
+
+       wpa_printf(MSG_DEBUG, "TDLS: TDLS operation%s supported by "
+                  "driver", sm->tdls_supported ? "" : " not");
+       wpa_printf(MSG_DEBUG, "TDLS: Driver uses %s link setup",
+                  sm->tdls_external_setup ? "external" : "internal");
+
        return 0;
 }
 
 
+void wpa_tdls_teardown_peers(struct wpa_sm *sm)
+{
+       struct wpa_tdls_peer *peer, *tmp;
+
+       peer = sm->tdls;
+
+       wpa_printf(MSG_DEBUG, "TDLS: Tear down peers");
+
+       while (peer) {
+               tmp = peer->next;
+               wpa_printf(MSG_DEBUG, "TDLS: Tear down peer " MACSTR,
+                          MAC2STR(peer->addr));
+               if (sm->tdls_external_setup)
+                       wpa_tdls_do_teardown(sm, peer,
+                                            WLAN_REASON_DEAUTH_LEAVING);
+               else
+                       wpa_sm_tdls_oper(sm, TDLS_TEARDOWN, peer->addr);
+
+               peer = tmp;
+       }
+}
+
+
 static void wpa_tdls_remove_peers(struct wpa_sm *sm)
 {
        struct wpa_tdls_peer *peer, *tmp;
 
        peer = sm->tdls;
-       sm->tdls = NULL;
 
        while (peer) {
                int res;
@@ -1834,7 +2712,6 @@ static void wpa_tdls_remove_peers(struct wpa_sm *sm)
                wpa_printf(MSG_DEBUG, "TDLS: Remove peer " MACSTR " (res=%d)",
                           MAC2STR(peer->addr), res);
                wpa_tdls_peer_free(sm, peer);
-               os_free(peer);
                peer = tmp;
        }
 }
@@ -1871,3 +2748,52 @@ void wpa_tdls_disassoc(struct wpa_sm *sm)
        wpa_printf(MSG_DEBUG, "TDLS: Remove peers on disassociation");
        wpa_tdls_remove_peers(sm);
 }
+
+
+static int wpa_tdls_prohibited(const u8 *ies, size_t len)
+{
+       struct wpa_eapol_ie_parse elems;
+
+       if (ies == NULL)
+               return 0;
+
+       if (wpa_supplicant_parse_ies(ies, len, &elems) < 0)
+               return 0;
+
+       if (elems.ext_capab == NULL || elems.ext_capab_len < 2 + 5)
+               return 0;
+
+        /* bit 38 - TDLS Prohibited */
+       return !!(elems.ext_capab[2 + 4] & 0x40);
+}
+
+
+void wpa_tdls_ap_ies(struct wpa_sm *sm, const u8 *ies, size_t len)
+{
+       sm->tdls_prohibited = wpa_tdls_prohibited(ies, len);
+       wpa_printf(MSG_DEBUG, "TDLS: TDLS is %s in the target BSS",
+                  sm->tdls_prohibited ? "prohibited" : "allowed");
+}
+
+
+void wpa_tdls_assoc_resp_ies(struct wpa_sm *sm, const u8 *ies, size_t len)
+{
+       if (!sm->tdls_prohibited && wpa_tdls_prohibited(ies, len)) {
+               wpa_printf(MSG_DEBUG, "TDLS: TDLS prohibited based on "
+                          "(Re)Association Response IEs");
+               sm->tdls_prohibited = 1;
+       }
+}
+
+
+void wpa_tdls_enable(struct wpa_sm *sm, int enabled)
+{
+       wpa_printf(MSG_DEBUG, "TDLS: %s", enabled ? "enabled" : "disabled");
+       sm->tdls_disabled = !enabled;
+}
+
+
+int wpa_tdls_is_external_setup(struct wpa_sm *sm)
+{
+       return sm->tdls_external_setup;
+}