Suite B: PMKID derivation for AKM 00-0F-AC:11
[mech_eap.git] / src / rsn_supp / wpa.c
index 77d7991..9c840c6 100644 (file)
@@ -138,6 +138,24 @@ void wpa_sm_key_request(struct wpa_sm *sm, int error, int pairwise)
 }
 
 
+static void wpa_supplicant_key_mgmt_set_pmk(struct wpa_sm *sm)
+{
+#ifdef CONFIG_IEEE80211R
+       if (sm->key_mgmt == WPA_KEY_MGMT_FT_IEEE8021X) {
+               if (wpa_sm_key_mgmt_set_pmk(sm, sm->xxkey, sm->xxkey_len))
+                       wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
+                               "RSN: Cannot set low order 256 bits of MSK for key management offload");
+       } else {
+#endif /* CONFIG_IEEE80211R */
+               if (wpa_sm_key_mgmt_set_pmk(sm, sm->pmk, sm->pmk_len))
+                       wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
+                               "RSN: Cannot set PMK for key management offload");
+#ifdef CONFIG_IEEE80211R
+       }
+#endif /* CONFIG_IEEE80211R */
+}
+
+
 static int wpa_supplicant_get_pmk(struct wpa_sm *sm,
                                  const unsigned char *src_addr,
                                  const u8 *pmkid)
@@ -162,7 +180,7 @@ static int wpa_supplicant_get_pmk(struct wpa_sm *sm,
        }
 
        if (pmkid && sm->cur_pmksa &&
-           os_memcmp(pmkid, sm->cur_pmksa->pmkid, PMKID_LEN) == 0) {
+           os_memcmp_const(pmkid, sm->cur_pmksa->pmkid, PMKID_LEN) == 0) {
                wpa_hexdump(MSG_DEBUG, "RSN: matched PMKID", pmkid, PMKID_LEN);
                wpa_sm_set_pmk_from_pmksa(sm);
                wpa_hexdump_key(MSG_DEBUG, "RSN: PMK from PMKSA cache",
@@ -198,10 +216,13 @@ static int wpa_supplicant_get_pmk(struct wpa_sm *sm,
                        wpa_hexdump_key(MSG_DEBUG, "WPA: PMK from EAPOL state "
                                        "machines", sm->pmk, pmk_len);
                        sm->pmk_len = pmk_len;
+                       wpa_supplicant_key_mgmt_set_pmk(sm);
                        if (sm->proto == WPA_PROTO_RSN &&
+                           !wpa_key_mgmt_suite_b(sm->key_mgmt) &&
                            !wpa_key_mgmt_ft(sm->key_mgmt)) {
                                sa = pmksa_cache_add(sm->pmksa,
                                                     sm->pmk, pmk_len,
+                                                    NULL, 0,
                                                     src_addr, sm->own_addr,
                                                     sm->network_ctx,
                                                     sm->key_mgmt);
@@ -235,6 +256,7 @@ static int wpa_supplicant_get_pmk(struct wpa_sm *sm,
        }
 
        if (abort_cached && wpa_key_mgmt_wpa_ieee8021x(sm->key_mgmt) &&
+           !wpa_key_mgmt_suite_b(sm->key_mgmt) &&
            !wpa_key_mgmt_ft(sm->key_mgmt) && sm->key_mgmt != WPA_KEY_MGMT_OSEN)
        {
                /* Send EAPOL-Start to trigger full EAP authentication. */
@@ -379,11 +401,11 @@ static int wpa_derive_ptk(struct wpa_sm *sm, const unsigned char *src_addr,
 static void wpa_supplicant_process_1_of_4(struct wpa_sm *sm,
                                          const unsigned char *src_addr,
                                          const struct wpa_eapol_key *key,
-                                         u16 ver)
+                                         u16 ver, const u8 *key_data,
+                                         size_t key_data_len)
 {
        struct wpa_eapol_ie_parse ie;
        struct wpa_ptk *ptk;
-       u8 buf[8];
        int res;
        u8 *kde, *kde_buf = NULL;
        size_t kde_len;
@@ -402,10 +424,9 @@ static void wpa_supplicant_process_1_of_4(struct wpa_sm *sm,
 
        if (sm->proto == WPA_PROTO_RSN || sm->proto == WPA_PROTO_OSEN) {
                /* RSN: msg 1/4 should contain PMKID for the selected PMK */
-               const u8 *_buf = (const u8 *) (key + 1);
-               size_t len = WPA_GET_BE16(key->key_data_length);
-               wpa_hexdump(MSG_DEBUG, "RSN: msg 1/4 key data", _buf, len);
-               if (wpa_supplicant_parse_ies(_buf, len, &ie) < 0)
+               wpa_hexdump(MSG_DEBUG, "RSN: msg 1/4 key data",
+                           key_data, key_data_len);
+               if (wpa_supplicant_parse_ies(key_data, key_data_len, &ie) < 0)
                        goto failed;
                if (ie.pmkid) {
                        wpa_hexdump(MSG_DEBUG, "RSN: PMKID from "
@@ -438,10 +459,12 @@ static void wpa_supplicant_process_1_of_4(struct wpa_sm *sm,
        ptk = &sm->tptk;
        wpa_derive_ptk(sm, src_addr, key, ptk);
        if (sm->pairwise_cipher == WPA_CIPHER_TKIP) {
+               u8 buf[8];
                /* Supplicant: swap tx/rx Mic keys */
                os_memcpy(buf, ptk->u.auth.tx_mic_key, 8);
                os_memcpy(ptk->u.auth.tx_mic_key, ptk->u.auth.rx_mic_key, 8);
                os_memcpy(ptk->u.auth.rx_mic_key, buf, 8);
+               os_memset(buf, 0, sizeof(buf));
        }
        sm->tptk_set = 1;
 
@@ -657,6 +680,7 @@ static int wpa_supplicant_install_gtk(struct wpa_sm *sm,
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: Failed to set GTK to the driver "
                                "(Group only)");
+                       os_memset(gtk_buf, 0, sizeof(gtk_buf));
                        return -1;
                }
        } else if (wpa_sm_set_key(sm, gd->alg, broadcast_ether_addr,
@@ -666,8 +690,10 @@ static int wpa_supplicant_install_gtk(struct wpa_sm *sm,
                        "WPA: Failed to set GTK to "
                        "the driver (alg=%d keylen=%d keyidx=%d)",
                        gd->alg, gd->gtk_len, gd->keyidx);
+               os_memset(gtk_buf, 0, sizeof(gtk_buf));
                return -1;
        }
+       os_memset(gtk_buf, 0, sizeof(gtk_buf));
 
        return 0;
 }
@@ -729,8 +755,10 @@ static int wpa_supplicant_pairwise_gtk(struct wpa_sm *sm,
             wpa_supplicant_install_gtk(sm, &gd, key->key_rsc))) {
                wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
                        "RSN: Failed to install GTK");
+               os_memset(&gd, 0, sizeof(gd));
                return -1;
        }
+       os_memset(&gd, 0, sizeof(gd));
 
        wpa_supplicant_key_neg_complete(sm, sm->bssid,
                                        key_info & WPA_KEY_INFO_SECURE);
@@ -900,7 +928,8 @@ static int ft_validate_rsnie(struct wpa_sm *sm,
                return -1;
        }
 
-       if (os_memcmp(rsn.pmkid, sm->pmk_r1_name, WPA_PMK_NAME_LEN) != 0) {
+       if (os_memcmp_const(rsn.pmkid, sm->pmk_r1_name, WPA_PMK_NAME_LEN) != 0)
+       {
                wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
                        "FT: PMKR1Name mismatch in "
                        "FT 4-way handshake message 3/4");
@@ -1020,27 +1049,20 @@ static int wpa_supplicant_validate_ie(struct wpa_sm *sm,
  * @key: Pointer to the EAPOL-Key frame header
  * @ver: Version bits from EAPOL-Key Key Info
  * @key_info: Key Info
- * @kde: KDEs to include the EAPOL-Key frame
- * @kde_len: Length of KDEs
  * @ptk: PTK to use for keyed hash and encryption
  * Returns: 0 on success, -1 on failure
  */
 int wpa_supplicant_send_4_of_4(struct wpa_sm *sm, const unsigned char *dst,
                               const struct wpa_eapol_key *key,
                               u16 ver, u16 key_info,
-                              const u8 *kde, size_t kde_len,
                               struct wpa_ptk *ptk)
 {
        size_t rlen;
        struct wpa_eapol_key *reply;
        u8 *rbuf;
 
-       if (kde)
-               wpa_hexdump(MSG_DEBUG, "WPA: KDE for msg 4/4", kde, kde_len);
-
        rbuf = wpa_sm_alloc_eapol(sm, IEEE802_1X_TYPE_EAPOL_KEY, NULL,
-                                 sizeof(*reply) + kde_len,
-                                 &rlen, (void *) &reply);
+                                 sizeof(*reply), &rlen, (void *) &reply);
        if (rbuf == NULL)
                return -1;
 
@@ -1057,9 +1079,7 @@ int wpa_supplicant_send_4_of_4(struct wpa_sm *sm, const unsigned char *dst,
        os_memcpy(reply->replay_counter, key->replay_counter,
                  WPA_REPLAY_COUNTER_LEN);
 
-       WPA_PUT_BE16(reply->key_data_length, kde_len);
-       if (kde)
-               os_memcpy(reply + 1, kde, kde_len);
+       WPA_PUT_BE16(reply->key_data_length, 0);
 
        wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG, "WPA: Sending EAPOL-Key 4/4");
        wpa_eapol_key_send(sm, ptk->kck, ver, dst, ETH_P_EAPOL,
@@ -1071,10 +1091,10 @@ int wpa_supplicant_send_4_of_4(struct wpa_sm *sm, const unsigned char *dst,
 
 static void wpa_supplicant_process_3_of_4(struct wpa_sm *sm,
                                          const struct wpa_eapol_key *key,
-                                         u16 ver)
+                                         u16 ver, const u8 *key_data,
+                                         size_t key_data_len)
 {
-       u16 key_info, keylen, len;
-       const u8 *pos;
+       u16 key_info, keylen;
        struct wpa_eapol_ie_parse ie;
 
        wpa_sm_set_state(sm, WPA_4WAY_HANDSHAKE);
@@ -1083,10 +1103,8 @@ static void wpa_supplicant_process_3_of_4(struct wpa_sm *sm,
 
        key_info = WPA_GET_BE16(key->key_info);
 
-       pos = (const u8 *) (key + 1);
-       len = WPA_GET_BE16(key->key_data_length);
-       wpa_hexdump(MSG_DEBUG, "WPA: IE KeyData", pos, len);
-       if (wpa_supplicant_parse_ies(pos, len, &ie) < 0)
+       wpa_hexdump(MSG_DEBUG, "WPA: IE KeyData", key_data, key_data_len);
+       if (wpa_supplicant_parse_ies(key_data, key_data_len, &ie) < 0)
                goto failed;
        if (ie.gtk && !(key_info & WPA_KEY_INFO_ENCR_KEY_DATA)) {
                wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
@@ -1140,7 +1158,7 @@ static void wpa_supplicant_process_3_of_4(struct wpa_sm *sm,
 #endif /* CONFIG_P2P */
 
        if (wpa_supplicant_send_4_of_4(sm, sm->bssid, key, ver, key_info,
-                                      NULL, 0, &sm->ptk)) {
+                                      &sm->ptk)) {
                goto failed;
        }
 
@@ -1182,6 +1200,17 @@ static void wpa_supplicant_process_3_of_4(struct wpa_sm *sm,
        if (ie.gtk)
                wpa_sm_set_rekey_offload(sm);
 
+       if (sm->proto == WPA_PROTO_RSN && wpa_key_mgmt_suite_b(sm->key_mgmt)) {
+               struct rsn_pmksa_cache_entry *sa;
+
+               sa = pmksa_cache_add(sm->pmksa, sm->pmk, sm->pmk_len,
+                                    sm->ptk.kck, sizeof(sm->ptk.kck),
+                                    sm->bssid, sm->own_addr,
+                                    sm->network_ctx, sm->key_mgmt);
+               if (!sm->cur_pmksa)
+                       sm->cur_pmksa = sa;
+       }
+
        return;
 
 failed:
@@ -1241,22 +1270,14 @@ static int wpa_supplicant_process_1_of_2_rsn(struct wpa_sm *sm,
 
 static int wpa_supplicant_process_1_of_2_wpa(struct wpa_sm *sm,
                                             const struct wpa_eapol_key *key,
-                                            size_t keydatalen, int key_info,
-                                            size_t extra_len, u16 ver,
-                                            struct wpa_gtk_data *gd)
+                                            const u8 *key_data,
+                                            size_t key_data_len, u16 key_info,
+                                            u16 ver, struct wpa_gtk_data *gd)
 {
        size_t maxkeylen;
-       u8 ek[32];
 
        gd->gtk_len = WPA_GET_BE16(key->key_length);
-       maxkeylen = keydatalen;
-       if (keydatalen > extra_len) {
-               wpa_msg(sm->ctx->msg_ctx, MSG_INFO,
-                       "WPA: Truncated EAPOL-Key packet: "
-                       "key_data_length=%lu > extra_len=%lu",
-                       (unsigned long) keydatalen, (unsigned long) extra_len);
-               return -1;
-       }
+       maxkeylen = key_data_len;
        if (ver == WPA_KEY_INFO_TYPE_HMAC_SHA1_AES) {
                if (maxkeylen < 8) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_INFO,
@@ -1275,37 +1296,40 @@ static int wpa_supplicant_process_1_of_2_wpa(struct wpa_sm *sm,
        gd->keyidx = (key_info & WPA_KEY_INFO_KEY_INDEX_MASK) >>
                WPA_KEY_INFO_KEY_INDEX_SHIFT;
        if (ver == WPA_KEY_INFO_TYPE_HMAC_MD5_RC4) {
-               os_memcpy(ek, key->key_iv, 16);
-               os_memcpy(ek + 16, sm->ptk.kek, 16);
-               if (keydatalen > sizeof(gd->gtk)) {
+               u8 ek[32];
+               if (key_data_len > sizeof(gd->gtk)) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: RC4 key data too long (%lu)",
-                               (unsigned long) keydatalen);
+                               (unsigned long) key_data_len);
                        return -1;
                }
-               os_memcpy(gd->gtk, key + 1, keydatalen);
-               if (rc4_skip(ek, 32, 256, gd->gtk, keydatalen)) {
+               os_memcpy(ek, key->key_iv, 16);
+               os_memcpy(ek + 16, sm->ptk.kek, 16);
+               os_memcpy(gd->gtk, key_data, key_data_len);
+               if (rc4_skip(ek, 32, 256, gd->gtk, key_data_len)) {
+                       os_memset(ek, 0, sizeof(ek));
                        wpa_msg(sm->ctx->msg_ctx, MSG_ERROR,
                                "WPA: RC4 failed");
                        return -1;
                }
+               os_memset(ek, 0, sizeof(ek));
        } else if (ver == WPA_KEY_INFO_TYPE_HMAC_SHA1_AES) {
-               if (keydatalen % 8) {
+               if (maxkeylen % 8) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: Unsupported AES-WRAP len %lu",
-                               (unsigned long) keydatalen);
+                               (unsigned long) maxkeylen);
                        return -1;
                }
                if (maxkeylen > sizeof(gd->gtk)) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: AES-WRAP key data "
                                "too long (keydatalen=%lu maxkeylen=%lu)",
-                               (unsigned long) keydatalen,
+                               (unsigned long) key_data_len,
                                (unsigned long) maxkeylen);
                        return -1;
                }
-               if (aes_unwrap(sm->ptk.kek, maxkeylen / 8,
-                              (const u8 *) (key + 1), gd->gtk)) {
+               if (aes_unwrap(sm->ptk.kek, 16, maxkeylen / 8, key_data,
+                              gd->gtk)) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: AES unwrap failed - could not decrypt "
                                "GTK");
@@ -1361,9 +1385,10 @@ static int wpa_supplicant_send_2_of_2(struct wpa_sm *sm,
 static void wpa_supplicant_process_1_of_2(struct wpa_sm *sm,
                                          const unsigned char *src_addr,
                                          const struct wpa_eapol_key *key,
-                                         int extra_len, u16 ver)
+                                         const u8 *key_data,
+                                         size_t key_data_len, u16 ver)
 {
-       u16 key_info, keydatalen;
+       u16 key_info;
        int rekey, ret;
        struct wpa_gtk_data gd;
 
@@ -1374,17 +1399,15 @@ static void wpa_supplicant_process_1_of_2(struct wpa_sm *sm,
                "Handshake from " MACSTR " (ver=%d)", MAC2STR(src_addr), ver);
 
        key_info = WPA_GET_BE16(key->key_info);
-       keydatalen = WPA_GET_BE16(key->key_data_length);
 
        if (sm->proto == WPA_PROTO_RSN || sm->proto == WPA_PROTO_OSEN) {
-               ret = wpa_supplicant_process_1_of_2_rsn(sm,
-                                                       (const u8 *) (key + 1),
-                                                       keydatalen, key_info,
+               ret = wpa_supplicant_process_1_of_2_rsn(sm, key_data,
+                                                       key_data_len, key_info,
                                                        &gd);
        } else {
-               ret = wpa_supplicant_process_1_of_2_wpa(sm, key, keydatalen,
-                                                       key_info, extra_len,
-                                                       ver, &gd);
+               ret = wpa_supplicant_process_1_of_2_wpa(sm, key, key_data,
+                                                       key_data_len,
+                                                       key_info, ver, &gd);
        }
 
        wpa_sm_set_state(sm, WPA_GROUP_HANDSHAKE);
@@ -1430,7 +1453,7 @@ static int wpa_supplicant_verify_eapol_key_mic(struct wpa_sm *sm,
                os_memset(key->key_mic, 0, 16);
                wpa_eapol_key_mic(sm->tptk.kck, ver, buf, len,
                                  key->key_mic);
-               if (os_memcmp(mic, key->key_mic, 16) != 0) {
+               if (os_memcmp_const(mic, key->key_mic, 16) != 0) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: Invalid EAPOL-Key MIC "
                                "when using TPTK - ignoring TPTK");
@@ -1439,6 +1462,7 @@ static int wpa_supplicant_verify_eapol_key_mic(struct wpa_sm *sm,
                        sm->tptk_set = 0;
                        sm->ptk_set = 1;
                        os_memcpy(&sm->ptk, &sm->tptk, sizeof(sm->ptk));
+                       os_memset(&sm->tptk, 0, sizeof(sm->tptk));
                }
        }
 
@@ -1446,7 +1470,7 @@ static int wpa_supplicant_verify_eapol_key_mic(struct wpa_sm *sm,
                os_memset(key->key_mic, 0, 16);
                wpa_eapol_key_mic(sm->ptk.kck, ver, buf, len,
                                  key->key_mic);
-               if (os_memcmp(mic, key->key_mic, 16) != 0) {
+               if (os_memcmp_const(mic, key->key_mic, 16) != 0) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: Invalid EAPOL-Key MIC - "
                                "dropping packet");
@@ -1471,12 +1495,11 @@ static int wpa_supplicant_verify_eapol_key_mic(struct wpa_sm *sm,
 
 /* Decrypt RSN EAPOL-Key key data (RC4 or AES-WRAP) */
 static int wpa_supplicant_decrypt_key_data(struct wpa_sm *sm,
-                                          struct wpa_eapol_key *key, u16 ver)
+                                          struct wpa_eapol_key *key, u16 ver,
+                                          u8 *key_data, size_t *key_data_len)
 {
-       u16 keydatalen = WPA_GET_BE16(key->key_data_length);
-
        wpa_hexdump(MSG_DEBUG, "RSN: encrypted key data",
-                   (u8 *) (key + 1), keydatalen);
+                   key_data, *key_data_len);
        if (!sm->ptk_set) {
                wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                        "WPA: PTK not available, cannot decrypt EAPOL-Key Key "
@@ -1490,46 +1513,48 @@ static int wpa_supplicant_decrypt_key_data(struct wpa_sm *sm,
                u8 ek[32];
                os_memcpy(ek, key->key_iv, 16);
                os_memcpy(ek + 16, sm->ptk.kek, 16);
-               if (rc4_skip(ek, 32, 256, (u8 *) (key + 1), keydatalen)) {
+               if (rc4_skip(ek, 32, 256, key_data, *key_data_len)) {
+                       os_memset(ek, 0, sizeof(ek));
                        wpa_msg(sm->ctx->msg_ctx, MSG_ERROR,
                                "WPA: RC4 failed");
                        return -1;
                }
+               os_memset(ek, 0, sizeof(ek));
        } else if (ver == WPA_KEY_INFO_TYPE_HMAC_SHA1_AES ||
                   ver == WPA_KEY_INFO_TYPE_AES_128_CMAC ||
                   sm->key_mgmt == WPA_KEY_MGMT_OSEN) {
                u8 *buf;
-               if (keydatalen % 8) {
+               if (*key_data_len < 8 || *key_data_len % 8) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
-                               "WPA: Unsupported AES-WRAP len %d",
-                               keydatalen);
+                               "WPA: Unsupported AES-WRAP len %u",
+                               (unsigned int) *key_data_len);
                        return -1;
                }
-               keydatalen -= 8; /* AES-WRAP adds 8 bytes */
-               buf = os_malloc(keydatalen);
+               *key_data_len -= 8; /* AES-WRAP adds 8 bytes */
+               buf = os_malloc(*key_data_len);
                if (buf == NULL) {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: No memory for AES-UNWRAP buffer");
                        return -1;
                }
-               if (aes_unwrap(sm->ptk.kek, keydatalen / 8,
-                              (u8 *) (key + 1), buf)) {
+               if (aes_unwrap(sm->ptk.kek, 16, *key_data_len / 8,
+                              key_data, buf)) {
                        os_free(buf);
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: AES unwrap failed - "
                                "could not decrypt EAPOL-Key key data");
                        return -1;
                }
-               os_memcpy(key + 1, buf, keydatalen);
+               os_memcpy(key_data, buf, *key_data_len);
                os_free(buf);
-               WPA_PUT_BE16(key->key_data_length, keydatalen);
+               WPA_PUT_BE16(key->key_data_length, *key_data_len);
        } else {
                wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                        "WPA: Unsupported key_info type %d", ver);
                return -1;
        }
        wpa_hexdump_key(MSG_DEBUG, "WPA: decrypted EAPOL-Key key data",
-                       (u8 *) (key + 1), keydatalen);
+                       key_data, *key_data_len);
        return 0;
 }
 
@@ -1603,13 +1628,14 @@ static void wpa_eapol_key_dump(struct wpa_sm *sm,
 int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                    const u8 *buf, size_t len)
 {
-       size_t plen, data_len, extra_len;
-       struct ieee802_1x_hdr *hdr;
+       size_t plen, data_len, key_data_len;
+       const struct ieee802_1x_hdr *hdr;
        struct wpa_eapol_key *key;
        u16 key_info, ver;
-       u8 *tmp;
+       u8 *tmp = NULL;
        int ret = -1;
        struct wpa_peerkey *peerkey = NULL;
+       u8 *key_data;
 
 #ifdef CONFIG_IEEE80211R
        sm->ft_completed = 0;
@@ -1624,13 +1650,7 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                return 0;
        }
 
-       tmp = os_malloc(len);
-       if (tmp == NULL)
-               return -1;
-       os_memcpy(tmp, buf, len);
-
-       hdr = (struct ieee802_1x_hdr *) tmp;
-       key = (struct wpa_eapol_key *) (hdr + 1);
+       hdr = (const struct ieee802_1x_hdr *) buf;
        plen = be_to_host16(hdr->length);
        data_len = plen + sizeof(*hdr);
        wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
@@ -1647,6 +1667,7 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                ret = 0;
                goto out;
        }
+       wpa_hexdump(MSG_MSGDUMP, "WPA: RX EAPOL-Key", buf, len);
        if (plen > len - sizeof(*hdr) || plen < sizeof(*key)) {
                wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
                        "WPA: EAPOL frame payload size %lu "
@@ -1655,6 +1676,22 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                ret = 0;
                goto out;
        }
+       if (data_len < len) {
+               wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
+                       "WPA: ignoring %lu bytes after the IEEE 802.1X data",
+                       (unsigned long) len - data_len);
+       }
+
+       /*
+        * Make a copy of the frame since we need to modify the buffer during
+        * MAC validation and Key Data decryption.
+        */
+       tmp = os_malloc(data_len);
+       if (tmp == NULL)
+               goto out;
+       os_memcpy(tmp, buf, data_len);
+       key = (struct wpa_eapol_key *) (tmp + sizeof(struct ieee802_1x_hdr));
+       key_data = (u8 *) (key + 1);
 
        if (key->type != EAPOL_KEY_TYPE_WPA && key->type != EAPOL_KEY_TYPE_RSN)
        {
@@ -1666,13 +1703,16 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
        }
        wpa_eapol_key_dump(sm, key);
 
-       eapol_sm_notify_lower_layer_success(sm->eapol, 0);
-       wpa_hexdump(MSG_MSGDUMP, "WPA: RX EAPOL-Key", tmp, len);
-       if (data_len < len) {
-               wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG,
-                       "WPA: ignoring %lu bytes after the IEEE 802.1X data",
-                       (unsigned long) len - data_len);
+       key_data_len = WPA_GET_BE16(key->key_data_length);
+       if (key_data_len > plen - sizeof(struct wpa_eapol_key)) {
+               wpa_msg(sm->ctx->msg_ctx, MSG_INFO, "WPA: Invalid EAPOL-Key "
+                       "frame - key_data overflow (%u > %u)",
+                       (unsigned int) key_data_len,
+                       (unsigned int) (plen - sizeof(struct wpa_eapol_key)));
+               goto out;
        }
+
+       eapol_sm_notify_lower_layer_success(sm->eapol, 0);
        key_info = WPA_GET_BE16(key->key_info);
        ver = key_info & WPA_KEY_INFO_TYPE_MASK;
        if (ver != WPA_KEY_INFO_TYPE_HMAC_MD5_RC4 &&
@@ -1730,11 +1770,13 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                        wpa_msg(sm->ctx->msg_ctx, MSG_INFO,
                                "WPA: Backwards compatibility: allow invalid "
                                "version for non-CCMP group keys");
+               } else if (ver == WPA_KEY_INFO_TYPE_AES_128_CMAC) {
+                       wpa_msg(sm->ctx->msg_ctx, MSG_INFO,
+                               "WPA: Interoperability workaround: allow incorrect (should have been HMAC-SHA1), but stronger (is AES-128-CMAC), descriptor version to be used");
                } else
                        goto out;
-       }
-       if (sm->pairwise_cipher == WPA_CIPHER_GCMP &&
-           ver != WPA_KEY_INFO_TYPE_HMAC_SHA1_AES) {
+       } else if (sm->pairwise_cipher == WPA_CIPHER_GCMP &&
+                  ver != WPA_KEY_INFO_TYPE_HMAC_SHA1_AES) {
                wpa_msg(sm->ctx->msg_ctx, MSG_INFO,
                        "WPA: GCMP is used, but EAPOL-Key "
                        "descriptor version (%d) is not 2", ver);
@@ -1813,22 +1855,11 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                goto out;
 #endif /* CONFIG_PEERKEY */
 
-       extra_len = data_len - sizeof(*hdr) - sizeof(*key);
-
-       if (WPA_GET_BE16(key->key_data_length) > extra_len) {
-               wpa_msg(sm->ctx->msg_ctx, MSG_INFO, "WPA: Invalid EAPOL-Key "
-                       "frame - key_data overflow (%d > %lu)",
-                       WPA_GET_BE16(key->key_data_length),
-                       (unsigned long) extra_len);
-               goto out;
-       }
-       extra_len = WPA_GET_BE16(key->key_data_length);
-
        if ((sm->proto == WPA_PROTO_RSN || sm->proto == WPA_PROTO_OSEN) &&
            (key_info & WPA_KEY_INFO_ENCR_KEY_DATA)) {
-               if (wpa_supplicant_decrypt_key_data(sm, key, ver))
+               if (wpa_supplicant_decrypt_key_data(sm, key, ver, key_data,
+                                                   &key_data_len))
                        goto out;
-               extra_len = WPA_GET_BE16(key->key_data_length);
        }
 
        if (key_info & WPA_KEY_INFO_KEY_TYPE) {
@@ -1840,24 +1871,28 @@ int wpa_sm_rx_eapol(struct wpa_sm *sm, const u8 *src_addr,
                }
                if (peerkey) {
                        /* PeerKey 4-Way Handshake */
-                       peerkey_rx_eapol_4way(sm, peerkey, key, key_info, ver);
+                       peerkey_rx_eapol_4way(sm, peerkey, key, key_info, ver,
+                                             key_data, key_data_len);
                } else if (key_info & WPA_KEY_INFO_MIC) {
                        /* 3/4 4-Way Handshake */
-                       wpa_supplicant_process_3_of_4(sm, key, ver);
+                       wpa_supplicant_process_3_of_4(sm, key, ver, key_data,
+                                                     key_data_len);
                } else {
                        /* 1/4 4-Way Handshake */
                        wpa_supplicant_process_1_of_4(sm, src_addr, key,
-                                                     ver);
+                                                     ver, key_data,
+                                                     key_data_len);
                }
        } else if (key_info & WPA_KEY_INFO_SMK_MESSAGE) {
                /* PeerKey SMK Handshake */
-               peerkey_rx_eapol_smk(sm, src_addr, key, extra_len, key_info,
+               peerkey_rx_eapol_smk(sm, src_addr, key, key_data_len, key_info,
                                     ver);
        } else {
                if (key_info & WPA_KEY_INFO_MIC) {
                        /* 1/2 Group Key Handshake */
                        wpa_supplicant_process_1_of_2(sm, src_addr, key,
-                                                     extra_len, ver);
+                                                     key_data, key_data_len,
+                                                     ver);
                } else {
                        wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
                                "WPA: EAPOL-Key (Group) without Mic bit - "
@@ -1904,6 +1939,8 @@ static u32 wpa_key_mgmt_suite(struct wpa_sm *sm)
                        WPA_AUTH_KEY_MGMT_CCKM);
        case WPA_KEY_MGMT_WPA_NONE:
                return WPA_AUTH_KEY_MGMT_NONE;
+       case WPA_KEY_MGMT_IEEE8021X_SUITE_B:
+               return RSN_AUTH_KEY_MGMT_802_1X_SUITE_B;
        default:
                return 0;
        }
@@ -2142,7 +2179,9 @@ void wpa_sm_notify_assoc(struct wpa_sm *sm, const u8 *bssid)
                 */
                wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG, "WPA: Clear old PTK");
                sm->ptk_set = 0;
+               os_memset(&sm->ptk, 0, sizeof(sm->ptk));
                sm->tptk_set = 0;
+               os_memset(&sm->tptk, 0, sizeof(sm->tptk));
        }
 
 #ifdef CONFIG_TDLS
@@ -2180,10 +2219,12 @@ void wpa_sm_notify_disassoc(struct wpa_sm *sm)
  * @sm: Pointer to WPA state machine data from wpa_sm_init()
  * @pmk: The new PMK
  * @pmk_len: The length of the new PMK in bytes
+ * @bssid: AA to add into PMKSA cache or %NULL to not cache the PMK
  *
  * Configure the PMK for WPA state machine.
  */
-void wpa_sm_set_pmk(struct wpa_sm *sm, const u8 *pmk, size_t pmk_len)
+void wpa_sm_set_pmk(struct wpa_sm *sm, const u8 *pmk, size_t pmk_len,
+                   const u8 *bssid)
 {
        if (sm == NULL)
                return;
@@ -2196,6 +2237,12 @@ void wpa_sm_set_pmk(struct wpa_sm *sm, const u8 *pmk, size_t pmk_len)
        sm->xxkey_len = pmk_len;
        os_memcpy(sm->xxkey, pmk, pmk_len);
 #endif /* CONFIG_IEEE80211R */
+
+       if (bssid) {
+               pmksa_cache_add(sm->pmksa, pmk, pmk_len, NULL, 0,
+                               bssid, sm->own_addr,
+                               sm->network_ctx, sm->key_mgmt);
+       }
 }
 
 
@@ -2396,44 +2443,6 @@ int wpa_sm_set_param(struct wpa_sm *sm, enum wpa_sm_conf_params param,
 
 
 /**
- * wpa_sm_get_param - Get WPA state machine parameters
- * @sm: Pointer to WPA state machine data from wpa_sm_init()
- * @param: Parameter field
- * Returns: Parameter value
- */
-unsigned int wpa_sm_get_param(struct wpa_sm *sm, enum wpa_sm_conf_params param)
-{
-       if (sm == NULL)
-               return 0;
-
-       switch (param) {
-       case RSNA_PMK_LIFETIME:
-               return sm->dot11RSNAConfigPMKLifetime;
-       case RSNA_PMK_REAUTH_THRESHOLD:
-               return sm->dot11RSNAConfigPMKReauthThreshold;
-       case RSNA_SA_TIMEOUT:
-               return sm->dot11RSNAConfigSATimeout;
-       case WPA_PARAM_PROTO:
-               return sm->proto;
-       case WPA_PARAM_PAIRWISE:
-               return sm->pairwise_cipher;
-       case WPA_PARAM_GROUP:
-               return sm->group_cipher;
-       case WPA_PARAM_KEY_MGMT:
-               return sm->key_mgmt;
-#ifdef CONFIG_IEEE80211W
-       case WPA_PARAM_MGMT_GROUP:
-               return sm->mgmt_group_cipher;
-#endif /* CONFIG_IEEE80211W */
-       case WPA_PARAM_RSN_ENABLED:
-               return sm->rsn_enabled;
-       default:
-               return 0;
-       }
-}
-
-
-/**
  * wpa_sm_get_status - Get WPA state machine
  * @sm: Pointer to WPA state machine data from wpa_sm_init()
  * @buf: Buffer for status information
@@ -2674,6 +2683,7 @@ int wpa_sm_pmksa_cache_list(struct wpa_sm *sm, char *buf, size_t len)
 }
 
 
+#ifdef CONFIG_TESTING_OPTIONS
 void wpa_sm_drop_sa(struct wpa_sm *sm)
 {
        wpa_dbg(sm->ctx->msg_ctx, MSG_DEBUG, "WPA: Clear old PMK and PTK");
@@ -2683,6 +2693,7 @@ void wpa_sm_drop_sa(struct wpa_sm *sm)
        os_memset(&sm->ptk, 0, sizeof(sm->ptk));
        os_memset(&sm->tptk, 0, sizeof(sm->tptk));
 }
+#endif /* CONFIG_TESTING_OPTIONS */
 
 
 int wpa_sm_has_ptk(struct wpa_sm *sm)
@@ -2708,29 +2719,22 @@ void wpa_sm_pmksa_cache_flush(struct wpa_sm *sm, void *network_ctx)
 #ifdef CONFIG_WNM
 int wpa_wnmsleep_install_key(struct wpa_sm *sm, u8 subelem_id, u8 *buf)
 {
-       struct wpa_gtk_data gd;
-#ifdef CONFIG_IEEE80211W
-       struct wpa_igtk_kde igd;
-       u16 keyidx;
-#endif /* CONFIG_IEEE80211W */
        u16 keyinfo;
        u8 keylen;  /* plaintext key len */
        u8 *key_rsc;
 
-       os_memset(&gd, 0, sizeof(gd));
-#ifdef CONFIG_IEEE80211W
-       os_memset(&igd, 0, sizeof(igd));
-#endif /* CONFIG_IEEE80211W */
-
-       keylen = wpa_cipher_key_len(sm->group_cipher);
-       gd.key_rsc_len = wpa_cipher_rsc_len(sm->group_cipher);
-       gd.alg = wpa_cipher_to_alg(sm->group_cipher);
-       if (gd.alg == WPA_ALG_NONE) {
-               wpa_printf(MSG_DEBUG, "Unsupported group cipher suite");
-               return -1;
-       }
-
        if (subelem_id == WNM_SLEEP_SUBELEM_GTK) {
+               struct wpa_gtk_data gd;
+
+               os_memset(&gd, 0, sizeof(gd));
+               keylen = wpa_cipher_key_len(sm->group_cipher);
+               gd.key_rsc_len = wpa_cipher_rsc_len(sm->group_cipher);
+               gd.alg = wpa_cipher_to_alg(sm->group_cipher);
+               if (gd.alg == WPA_ALG_NONE) {
+                       wpa_printf(MSG_DEBUG, "Unsupported group cipher suite");
+                       return -1;
+               }
+
                key_rsc = buf + 5;
                keyinfo = WPA_GET_LE16(buf + 2);
                gd.gtk_len = keylen;
@@ -2748,12 +2752,18 @@ int wpa_wnmsleep_install_key(struct wpa_sm *sm, u8 subelem_id, u8 *buf)
                wpa_hexdump_key(MSG_DEBUG, "Install GTK (WNM SLEEP)",
                                gd.gtk, gd.gtk_len);
                if (wpa_supplicant_install_gtk(sm, &gd, key_rsc)) {
+                       os_memset(&gd, 0, sizeof(gd));
                        wpa_printf(MSG_DEBUG, "Failed to install the GTK in "
                                   "WNM mode");
                        return -1;
                }
+               os_memset(&gd, 0, sizeof(gd));
 #ifdef CONFIG_IEEE80211W
        } else if (subelem_id == WNM_SLEEP_SUBELEM_IGTK) {
+               struct wpa_igtk_kde igd;
+               u16 keyidx;
+
+               os_memset(&igd, 0, sizeof(igd));
                keylen = wpa_cipher_key_len(sm->mgmt_group_cipher);
                os_memcpy(igd.keyid, buf + 2, 2);
                os_memcpy(igd.pn, buf + 4, 6);
@@ -2769,8 +2779,10 @@ int wpa_wnmsleep_install_key(struct wpa_sm *sm, u8 subelem_id, u8 *buf)
                                   igd.igtk, keylen) < 0) {
                        wpa_printf(MSG_DEBUG, "Failed to install the IGTK in "
                                   "WNM mode");
+                       os_memset(&igd, 0, sizeof(igd));
                        return -1;
                }
+               os_memset(&igd, 0, sizeof(igd));
 #endif /* CONFIG_IEEE80211W */
        } else {
                wpa_printf(MSG_DEBUG, "Unknown element id");
@@ -2814,3 +2826,30 @@ int wpa_sm_get_p2p_ip_addr(struct wpa_sm *sm, u8 *buf)
 }
 
 #endif /* CONFIG_P2P */
+
+
+void wpa_sm_set_rx_replay_ctr(struct wpa_sm *sm, const u8 *rx_replay_counter)
+{
+       if (rx_replay_counter == NULL)
+               return;
+
+       os_memcpy(sm->rx_replay_counter, rx_replay_counter,
+                 WPA_REPLAY_COUNTER_LEN);
+       sm->rx_replay_counter_set = 1;
+       wpa_printf(MSG_DEBUG, "Updated key replay counter");
+}
+
+
+void wpa_sm_set_ptk_kck_kek(struct wpa_sm *sm, const u8 *ptk_kck,
+                           const u8 *ptk_kek)
+{
+       if (ptk_kck) {
+               os_memcpy(sm->ptk.kck, ptk_kck, 16);
+               wpa_printf(MSG_DEBUG, "Updated PTK KCK");
+       }
+       if (ptk_kek) {
+               os_memcpy(sm->ptk.kek, ptk_kek, 16);
+               wpa_printf(MSG_DEBUG, "Updated PTK KEK");
+       }
+       sm->ptk_set = 1;
+}