#include "dbus_common.h"
#include "dbus_common_i.h"
-/**
- * wpas_dbus_set_path - Assign a dbus path to an interface
- * @wpa_s: wpa_supplicant interface structure
- * @path: dbus path to set on the interface
- * Returns: 0 on success, -1 on error
- */
-static int wpas_dbus_set_path(struct wpa_supplicant *wpa_s,
- const char *path)
-{
- u32 len = os_strlen(path);
- if (len >= WPAS_DBUS_OBJECT_PATH_MAX)
- return -1;
- if (wpa_s->dbus_new_path)
- return -1;
- wpa_s->dbus_new_path = os_strdup(path);
- return 0;
-}
-
/**
* wpas_dbus_signal_interface - Send a interface related event signal
* @wpa_s: %wpa_supplicant network interface data
* @sig_name: signal name - InterfaceAdded or InterfaceRemoved
- * @properties: determines if add second argument with object properties
+ * @properties: Whether to add second argument with object properties
*
* Notify listeners about event related with interface
*/
const char *sig_name, int properties)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal;
+ DBusMessage *msg;
DBusMessageIter iter, iter_dict;
- const char *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_interface[dbus]: "
- "Interface doesn't have a dbus path. "
- "Can't send signal.");
- return;
- }
- _signal = dbus_message_new_signal(WPAS_DBUS_NEW_PATH,
- WPAS_DBUS_NEW_INTERFACE, sig_name);
- if (_signal == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_interface[dbus]: "
- "enough memory to send scan results signal.");
+ msg = dbus_message_new_signal(WPAS_DBUS_NEW_PATH,
+ WPAS_DBUS_NEW_INTERFACE, sig_name);
+ if (msg == NULL)
return;
- }
-
- dbus_message_iter_init_append(_signal, &iter);
- if(!dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH,
- &path))
+ dbus_message_iter_init_append(msg, &iter);
+ if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH,
+ &wpa_s->dbus_new_path))
goto err;
if (properties) {
if (!wpa_dbus_dict_open_write(&iter, &iter_dict))
goto err;
- wpa_dbus_get_object_properties(iface, path,
+ wpa_dbus_get_object_properties(iface, wpa_s->dbus_new_path,
WPAS_DBUS_NEW_IFACE_INTERFACE,
&iter_dict);
goto err;
}
- dbus_connection_send(iface->con, _signal, NULL);
-
- dbus_message_unref(_signal);
+ dbus_connection_send(iface->con, msg, NULL);
+ dbus_message_unref(msg);
return;
err:
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_interface[dbus]: "
- "not enough memory to construct signal.");
- dbus_message_unref(_signal);
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ dbus_message_unref(msg);
}
void wpas_dbus_signal_scan_done(struct wpa_supplicant *wpa_s, int success)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal;
- const char *path;
+ DBusMessage *msg;
dbus_bool_t succ;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_scan_done[dbus]: "
- "Interface doesn't have a dbus path. "
- "Can't send signal.");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE,
+ "ScanDone");
+ if (msg == NULL)
return;
- }
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_INTERFACE,
- "ScanDone");
- if (_signal == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_scan_done[dbus]: "
- "enough memory to send signal.");
- return;
- }
succ = success ? TRUE : FALSE;
- if (dbus_message_append_args(_signal, DBUS_TYPE_BOOLEAN, &succ,
- DBUS_TYPE_INVALID)) {
- dbus_connection_send(iface->con, _signal, NULL);
- } else {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_scan_done[dbus]: "
- "not enough memory to construct signal.");
- }
- dbus_message_unref(_signal);
+ if (dbus_message_append_args(msg, DBUS_TYPE_BOOLEAN, &succ,
+ DBUS_TYPE_INVALID))
+ dbus_connection_send(iface->con, msg, NULL);
+ else
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ dbus_message_unref(msg);
}
* @wpa_s: %wpa_supplicant network interface data
* @bss_obj_path: BSS object path
* @sig_name: signal name - BSSAdded or BSSRemoved
- * @properties: determines if add second argument with object properties
+ * @properties: Whether to add second argument with object properties
*
* Notify listeners about event related with BSS
*/
const char *sig_name, int properties)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal;
+ DBusMessage *msg;
DBusMessageIter iter, iter_dict;
- const char *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_bss[dbus]: "
- "Interface doesn't have a dbus path. "
- "Can't send signal.");
- return;
- }
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_INTERFACE,
- sig_name);
- if (_signal == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_bss[dbus]: "
- "enough memory to send signal.");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE,
+ sig_name);
+ if (msg == NULL)
return;
- }
-
- dbus_message_iter_init_append(_signal, &iter);
+ dbus_message_iter_init_append(msg, &iter);
if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH,
&bss_obj_path))
goto err;
goto err;
}
- dbus_connection_send(iface->con, _signal, NULL);
-
- dbus_message_unref(_signal);
+ dbus_connection_send(iface->con, msg, NULL);
+ dbus_message_unref(msg);
return;
err:
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_bss[dbus]: "
- "not enough memory to construct signal.");
- dbus_message_unref(_signal);
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ dbus_message_unref(msg);
}
const char *name, const char *sig_name)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal;
- const char *path;
+ DBusMessage *msg;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_blob[dbus]: "
- "Interface doesn't have a dbus path. "
- "Can't send signal.");
- return;
- }
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_INTERFACE,
- sig_name);
- if (_signal == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_blob[dbus]: "
- "enough memory to send signal.");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE,
+ sig_name);
+ if (msg == NULL)
return;
- }
- if (dbus_message_append_args(_signal, DBUS_TYPE_STRING, &name,
- DBUS_TYPE_INVALID)) {
- dbus_connection_send(iface->con, _signal, NULL);
- } else {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_blob[dbus]: "
- "not enough memory to construct signal.");
- }
- dbus_message_unref(_signal);
+ if (dbus_message_append_args(msg, DBUS_TYPE_STRING, &name,
+ DBUS_TYPE_INVALID))
+ dbus_connection_send(iface->con, msg, NULL);
+ else
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ dbus_message_unref(msg);
}
int properties)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal;
+ DBusMessage *msg;
DBusMessageIter iter, iter_dict;
- const char *path;
- char *net_obj_path;
+ char net_obj_path[WPAS_DBUS_OBJECT_PATH_MAX], *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_network[dbus]: "
- "Interface doesn't have a dbus path. "
- "Can't send signal.");
- return;
- }
-
- net_obj_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (net_obj_path == NULL)
- return;
os_snprintf(net_obj_path, WPAS_DBUS_OBJECT_PATH_MAX,
- "%s/" WPAS_DBUS_NEW_NETWORKS_PART "/%u", path, id);
-
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_INTERFACE,
- sig_name);
- if (_signal == NULL) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_network[dbus]: "
- "enough memory to send signal.");
- os_free(net_obj_path);
- return;
- }
+ "%s/" WPAS_DBUS_NEW_NETWORKS_PART "/%u",
+ wpa_s->dbus_new_path, id);
- dbus_message_iter_init_append(_signal, &iter);
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE,
+ sig_name);
+ if (msg == NULL)
+ return;
+ dbus_message_iter_init_append(msg, &iter);
+ path = net_obj_path;
if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH,
- &net_obj_path))
+ &path))
goto err;
if (properties) {
goto err;
}
- dbus_connection_send(iface->con, _signal, NULL);
+ dbus_connection_send(iface->con, msg, NULL);
- os_free(net_obj_path);
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
return;
err:
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_network[dbus]: "
- "not enough memory to construct signal.");
- os_free(net_obj_path);
- dbus_message_unref(_signal);
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ dbus_message_unref(msg);
}
}
+static void str_to_lower(char *s)
+{
+ while (*s) {
+ *s = tolower(*s);
+ s++;
+ }
+}
+
+
/**
* wpas_dbus_signal_state_changed - Send a state changed signal
* @wpa_s: %wpa_supplicant network interface data
enum wpa_states old_state)
{
struct wpas_dbus_priv *iface;
- DBusMessage *_signal = NULL;
- const char *path;
+ DBusMessage *msg;
char *new_state_str, *old_state_str;
- char *tmp;
/* Do nothing if the control interface is not turned on */
if (wpa_s->global == NULL)
if (new_state == old_state)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (path == NULL) {
- perror("wpas_dbus_signal_state_changed[dbus]: "
- "interface didn't have a dbus path");
- wpa_printf(MSG_ERROR,
- "wpas_dbus_signal_state_changed[dbus]: "
- "interface didn't have a dbus path; can't send "
- "signal.");
- return;
- }
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_INTERFACE,
- "StateChanged");
- if (_signal == NULL) {
- perror("wpas_dbus_signal_state_changed[dbus]: "
- "couldn't create dbus signal; likely out of memory");
- wpa_printf(MSG_ERROR,
- "wpas_dbus_signal_state_changed[dbus]: "
- "couldn't create dbus signal; likely out of "
- "memory.");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE,
+ "StateChanged");
+ if (msg == NULL)
return;
- }
new_state_str = os_strdup(wpa_supplicant_state_txt(new_state));
old_state_str = os_strdup(wpa_supplicant_state_txt(old_state));
- if (new_state_str == NULL || old_state_str == NULL) {
- perror("wpas_dbus_signal_state_changed[dbus]: "
- "couldn't convert state strings");
- wpa_printf(MSG_ERROR,
- "wpas_dbus_signal_state_changed[dbus]: "
- "couldn't convert state strings.");
+ if (new_state_str == NULL || old_state_str == NULL)
goto out;
- }
/* make state string lowercase to fit new DBus API convention */
- tmp = new_state_str;
- while (*tmp) {
- *tmp = tolower(*tmp);
- tmp++;
- }
- tmp = old_state_str;
- while (*tmp) {
- *tmp = tolower(*tmp);
- tmp++;
- }
+ str_to_lower(new_state_str);
+ str_to_lower(old_state_str);
- if (!dbus_message_append_args(_signal,
+ if (!dbus_message_append_args(msg,
DBUS_TYPE_STRING, &new_state_str,
DBUS_TYPE_STRING, &old_state_str,
DBUS_TYPE_INVALID)) {
- perror("wpas_dbus_signal_state_changed[dbus]: "
- "not enough memory to construct state change signal.");
- wpa_printf(MSG_ERROR,
- "wpas_dbus_signal_state_changed[dbus]: "
- "not enough memory to construct state change "
- "signal.");
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct state change "
+ "signal");
goto out;
}
- dbus_connection_send(iface->con, _signal, NULL);
+ dbus_connection_send(iface->con, msg, NULL);
out:
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
os_free(new_state_str);
os_free(old_state_str);
}
struct wpa_ssid *ssid)
{
- struct network_handler_args args = {wpa_s, ssid};
-
+ struct network_handler_args args = { wpa_s, ssid };
char path[WPAS_DBUS_OBJECT_PATH_MAX];
os_snprintf(path, WPAS_DBUS_OBJECT_PATH_MAX,
"%s/" WPAS_DBUS_NEW_NETWORKS_PART "/%d",
- wpas_dbus_get_path(wpa_s), ssid->id);
+ wpa_s->dbus_new_path, ssid->id);
wpa_dbus_signal_property_changed(wpa_s->global->dbus,
(WPADBusPropertyAccessor)
void wpas_dbus_signal_wps_event_success(struct wpa_supplicant *wpa_s)
{
- DBusMessage *_signal = NULL;
+ DBusMessage *msg;
DBusMessageIter iter, dict_iter;
struct wpas_dbus_priv *iface;
char *key = "success";
- const char *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (!path) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_success"
- "[dbus]: interface has no dbus path set");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_WPS, "Event");
+ if (msg == NULL)
return;
- }
-
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_WPS,
- "Event");
- if (!_signal) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_success"
- "[dbus]: out of memory when creating a signal");
- return;
- }
- dbus_message_iter_init_append(_signal, &iter);
+ dbus_message_iter_init_append(msg, &iter);
if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &key) ||
!wpa_dbus_dict_open_write(&iter, &dict_iter) ||
- !wpa_dbus_dict_close_write(&iter, &dict_iter)) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_success"
- "[dbus]: out of memory");
- goto out;
- }
+ !wpa_dbus_dict_close_write(&iter, &dict_iter))
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ else
+ dbus_connection_send(iface->con, msg, NULL);
- dbus_connection_send(iface->con, _signal, NULL);
-out:
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
}
struct wps_event_fail *fail)
{
- DBusMessage *_signal = NULL;
+ DBusMessage *msg;
DBusMessageIter iter, dict_iter;
struct wpas_dbus_priv *iface;
char *key = "fail";
- const char *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (!path) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_fail[dbus]: "
- "interface has no dbus path set");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_WPS, "Event");
+ if (msg == NULL)
return;
- }
-
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_WPS,
- "Event");
- if (!_signal) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_fail[dbus]: "
- "out of memory when creating a signal");
- return;
- }
- dbus_message_iter_init_append(_signal, &iter);
+ dbus_message_iter_init_append(msg, &iter);
if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &key) ||
!wpa_dbus_dict_open_write(&iter, &dict_iter) ||
!wpa_dbus_dict_append_int32(&dict_iter, "msg", fail->msg) ||
- !wpa_dbus_dict_close_write(&iter, &dict_iter)) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_fail[dbus]: "
- "out of memory");
- goto out;
- }
+ !wpa_dbus_dict_close_write(&iter, &dict_iter))
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ else
+ dbus_connection_send(iface->con, msg, NULL);
- dbus_connection_send(iface->con, _signal, NULL);
-out:
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
}
struct wps_event_m2d *m2d)
{
- DBusMessage *_signal = NULL;
+ DBusMessage *msg;
DBusMessageIter iter, dict_iter;
struct wpas_dbus_priv *iface;
char *key = "m2d";
- const char *path;
iface = wpa_s->global->dbus;
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (!path) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_m2d[dbus]: "
- "interface has no dbus path set");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_WPS, "Event");
+ if (msg == NULL)
return;
- }
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_WPS,
- "Event");
- if (!_signal) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_m2d[dbus]: "
- "out of memory when creating a signal");
- return;
- }
+ dbus_message_iter_init_append(msg, &iter);
- dbus_message_iter_init_append(_signal, &iter);
-
- if (!(dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &key) &&
- wpa_dbus_dict_open_write(&iter, &dict_iter) &&
- wpa_dbus_dict_append_uint16(&dict_iter, "config_methods",
- m2d->config_methods) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "manufacturer",
- (const char *) m2d->manufacturer,
- m2d->manufacturer_len) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "model_name",
- (const char *) m2d->model_name,
- m2d->model_name_len) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "model_number",
- (const char *) m2d->model_number,
- m2d->model_number_len) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "serial_number",
- (const char *)
- m2d->serial_number,
- m2d->serial_number_len) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "dev_name",
- (const char *) m2d->dev_name,
- m2d->dev_name_len) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "primary_dev_type",
- (const char *)
- m2d->primary_dev_type, 8) &&
- wpa_dbus_dict_append_uint16(&dict_iter, "config_error",
- m2d->config_error) &&
- wpa_dbus_dict_append_uint16(&dict_iter, "dev_password_id",
- m2d->dev_password_id) &&
- wpa_dbus_dict_close_write(&iter, &dict_iter))) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_event_m2d[dbus]: "
- "out of memory");
- goto out;
- }
+ if (!dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &key) ||
+ !wpa_dbus_dict_open_write(&iter, &dict_iter) ||
+ !wpa_dbus_dict_append_uint16(&dict_iter, "config_methods",
+ m2d->config_methods) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "manufacturer",
+ (const char *) m2d->manufacturer,
+ m2d->manufacturer_len) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "model_name",
+ (const char *) m2d->model_name,
+ m2d->model_name_len) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "model_number",
+ (const char *) m2d->model_number,
+ m2d->model_number_len) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "serial_number",
+ (const char *)
+ m2d->serial_number,
+ m2d->serial_number_len) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "dev_name",
+ (const char *) m2d->dev_name,
+ m2d->dev_name_len) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "primary_dev_type",
+ (const char *)
+ m2d->primary_dev_type, 8) ||
+ !wpa_dbus_dict_append_uint16(&dict_iter, "config_error",
+ m2d->config_error) ||
+ !wpa_dbus_dict_append_uint16(&dict_iter, "dev_password_id",
+ m2d->dev_password_id) ||
+ !wpa_dbus_dict_close_write(&iter, &dict_iter))
+ wpa_printf(MSG_ERROR, "dbus: Failed to construct signal");
+ else
+ dbus_connection_send(iface->con, msg, NULL);
- dbus_connection_send(iface->con, _signal, NULL);
-out:
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
}
void wpas_dbus_signal_wps_cred(struct wpa_supplicant *wpa_s,
const struct wps_credential *cred)
{
- DBusMessage *_signal = NULL;
+ DBusMessage *msg;
DBusMessageIter iter, dict_iter;
struct wpas_dbus_priv *iface;
- const char *path;
char *auth_type[6]; /* we have six possible authorization types */
int at_num = 0;
char *encr_type[4]; /* we have four possible encryption types */
if (iface == NULL)
return;
- path = wpas_dbus_get_path(wpa_s);
- if (!path) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_cred[dbus]: "
- "interface has no dbus path set");
- return;
- }
-
- _signal = dbus_message_new_signal(path, WPAS_DBUS_NEW_IFACE_WPS,
- "Credentials");
- if (!_signal) {
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_wps_cred[dbus]: "
- "out of memory when creating a signal");
+ msg = dbus_message_new_signal(wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_WPS,
+ "Credentials");
+ if (msg == NULL)
return;
- }
-
- dbus_message_iter_init_append(_signal, &iter);
- if (!wpa_dbus_dict_open_write(&iter, &dict_iter)) {
- perror("wpas_dbus_signal_wps_cred[dbus]: out of memory "
- "when opening a dictionary");
+ dbus_message_iter_init_append(msg, &iter);
+ if (!wpa_dbus_dict_open_write(&iter, &dict_iter))
goto nomem;
- }
if (cred->auth_type & WPS_AUTH_OPEN)
auth_type[at_num++] = "open";
if (!wpa_dbus_dict_append_byte_array(
&dict_iter, "BSSID",
(const char *) wpa_s->current_ssid->bssid,
- ETH_ALEN)) {
- perror("wpas_dbus_signal_wps_cred[dbus]: out of "
- "memory when appending bssid to dictionary");
+ ETH_ALEN))
goto nomem;
- }
- }
-
- if (!(wpa_dbus_dict_append_byte_array(&dict_iter, "SSID",
- (const char *) cred->ssid,
- cred->ssid_len) &&
- wpa_dbus_dict_append_string_array(&dict_iter, "AuthType",
- (const char **) auth_type,
- at_num) &&
- wpa_dbus_dict_append_string_array(&dict_iter, "EncrType",
- (const char **) encr_type,
- et_num) &&
- wpa_dbus_dict_append_byte_array(&dict_iter, "Key",
- (const char *) cred->key,
- cred->key_len) &&
- wpa_dbus_dict_append_uint32(&dict_iter, "KeyIndex",
- cred->key_idx))) {
- perror("wpas_dbus_signal_wps_cred[dbus]: out of memory "
- "when appending to dictionary");
- goto nomem;
}
- if (!wpa_dbus_dict_close_write(&iter, &dict_iter)) {
- perror("wpas_dbus_signal_wps_cred[dbus]: out of memory "
- "when closing a dictionary");
+ if (!wpa_dbus_dict_append_byte_array(&dict_iter, "SSID",
+ (const char *) cred->ssid,
+ cred->ssid_len) ||
+ !wpa_dbus_dict_append_string_array(&dict_iter, "AuthType",
+ (const char **) auth_type,
+ at_num) ||
+ !wpa_dbus_dict_append_string_array(&dict_iter, "EncrType",
+ (const char **) encr_type,
+ et_num) ||
+ !wpa_dbus_dict_append_byte_array(&dict_iter, "Key",
+ (const char *) cred->key,
+ cred->key_len) ||
+ !wpa_dbus_dict_append_uint32(&dict_iter, "KeyIndex",
+ cred->key_idx) ||
+ !wpa_dbus_dict_close_write(&iter, &dict_iter))
goto nomem;
- }
- dbus_connection_send(iface->con, _signal, NULL);
+ dbus_connection_send(iface->con, msg, NULL);
nomem:
- dbus_message_unref(_signal);
+ dbus_message_unref(msg);
}
#endif /* CONFIG_WPS */
enum wpas_dbus_prop property)
{
WPADBusPropertyAccessor getter;
- char *iface;
char *prop;
- void *arg;
switch (property) {
case WPAS_DBUS_PROP_AP_SCAN:
getter = (WPADBusPropertyAccessor) wpas_dbus_getter_ap_scan;
- arg = wpa_s;
- iface = WPAS_DBUS_NEW_IFACE_INTERFACE;
prop = "ApScan";
break;
case WPAS_DBUS_PROP_SCANNING:
getter = (WPADBusPropertyAccessor) wpas_dbus_getter_scanning;
- arg = wpa_s;
- iface = WPAS_DBUS_NEW_IFACE_INTERFACE;
prop = "Scanning";
break;
case WPAS_DBUS_PROP_CURRENT_BSS:
getter = (WPADBusPropertyAccessor)
wpas_dbus_getter_current_bss;
- arg = wpa_s;
- iface = WPAS_DBUS_NEW_IFACE_INTERFACE;
prop = "CurrentBSS";
break;
case WPAS_DBUS_PROP_CURRENT_NETWORK:
getter = (WPADBusPropertyAccessor)
wpas_dbus_getter_current_network;
- arg = wpa_s;
- iface = WPAS_DBUS_NEW_IFACE_INTERFACE;
prop = "CurrentNetwork";
break;
default:
- wpa_printf(MSG_ERROR, "wpas_dbus_signal_prop_changed[dbus]: "
- "Unknown Property enum value %d", property);
+ wpa_printf(MSG_ERROR, "dbus: %s: Unknown Property value %d",
+ __func__, property);
return;
}
wpa_dbus_signal_property_changed(wpa_s->global->dbus,
- getter, arg,
- wpas_dbus_get_path(wpa_s), iface,
- prop);
+ getter, wpa_s, wpa_s->dbus_new_path,
+ WPAS_DBUS_NEW_IFACE_INTERFACE, prop);
}
}
-struct wpas_dbus_method {
- const char *name;
- const char *iface;
- WPADBusMethodHandler handler;
- struct wpa_dbus_argument args[3];
-};
-
-struct wpas_dbus_property {
- const char *name;
- const char *iface;
- const char *type;
- WPADBusPropertyAccessor getter;
- WPADBusPropertyAccessor setter;
- enum dbus_prop_access _access;
-};
-
-struct wpas_dbus_signal {
- const char *name;
- const char *iface;
- struct wpa_dbus_argument args[3];
-};
-
-
static void wpas_dbus_register(struct wpa_dbus_object_desc *obj_desc,
void *priv,
WPADBusArgumentFreeFunction priv_free,
- const struct wpas_dbus_method *methods,
- const struct wpas_dbus_property *properties,
- const struct wpas_dbus_signal *signals)
+ const struct wpa_dbus_method_desc *methods,
+ const struct wpa_dbus_property_desc *properties,
+ const struct wpa_dbus_signal_desc *signals)
{
- int i;
-
obj_desc->user_data = priv;
obj_desc->user_data_free_func = priv_free;
-
- for (i = 0; methods && methods[i].name; i++) {
- wpa_dbus_method_register(obj_desc, methods[i].iface,
- methods[i].name, methods[i].handler,
- methods[i].args);
- }
-
- for (i = 0; properties && properties[i].name; i++) {
- wpa_dbus_property_register(obj_desc, properties[i].iface,
- properties[i].name,
- properties[i].type,
- properties[i].getter,
- properties[i].setter,
- properties[i]._access);
- }
-
- for (i = 0; signals && signals[i].name; i++) {
- wpa_dbus_signal_register(obj_desc, signals[i].iface,
- signals[i].name, signals[i].args);
- }
+ obj_desc->methods = methods;
+ obj_desc->properties = properties;
+ obj_desc->signals = signals;
}
-static const struct wpas_dbus_method wpas_dbus_global_methods[] = {
+static const struct wpa_dbus_method_desc wpas_dbus_global_methods[] = {
{ "CreateInterface", WPAS_DBUS_NEW_INTERFACE,
(WPADBusMethodHandler) &wpas_dbus_handler_create_interface,
{
{ NULL, NULL, NULL, { END_ARGS } }
};
-static const struct wpas_dbus_property wpas_dbus_global_properties[] = {
+static const struct wpa_dbus_property_desc wpas_dbus_global_properties[] = {
{ "DebugLevel", WPAS_DBUS_NEW_INTERFACE, "y",
(WPADBusPropertyAccessor) wpas_dbus_getter_debug_level,
(WPADBusPropertyAccessor) wpas_dbus_setter_debug_level,
{ NULL, NULL, NULL, NULL, NULL, 0 }
};
-static const struct wpas_dbus_signal wpas_dbus_global_signals[] = {
+static const struct wpa_dbus_signal_desc wpas_dbus_global_signals[] = {
{ "InterfaceAdded", WPAS_DBUS_NEW_INTERFACE,
{
{ "path", "o", ARG_OUT },
}
-static const struct wpas_dbus_property wpas_dbus_network_properties[] = {
+static const struct wpa_dbus_property_desc wpas_dbus_network_properties[] = {
{ "Properties", WPAS_DBUS_NEW_IFACE_NETWORK, "a{sv}",
(WPADBusPropertyAccessor) wpas_dbus_getter_network_properties,
(WPADBusPropertyAccessor) wpas_dbus_setter_network_properties,
};
-static const struct wpas_dbus_signal wpas_dbus_network_signals[] = {
+static const struct wpa_dbus_signal_desc wpas_dbus_network_signals[] = {
{ "PropertiesChanged", WPAS_DBUS_NEW_IFACE_NETWORK,
{
{ "properties", "a{sv}", ARG_OUT },
{
struct wpas_dbus_priv *ctrl_iface;
struct wpa_dbus_object_desc *obj_desc;
-
struct network_handler_args *arg = NULL;
-
- char *net_obj_path;
+ char net_obj_path[WPAS_DBUS_OBJECT_PATH_MAX];
/* Do nothing if the control interface is not turned on */
if (wpa_s == NULL || wpa_s->global == NULL)
if (ctrl_iface == NULL)
return 0;
- net_obj_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (net_obj_path == NULL)
- return -1;
os_snprintf(net_obj_path, WPAS_DBUS_OBJECT_PATH_MAX,
"%s/" WPAS_DBUS_NEW_NETWORKS_PART "/%u",
- wpas_dbus_get_path(wpa_s), ssid->id);
+ wpa_s->dbus_new_path, ssid->id);
wpa_printf(MSG_DEBUG, "dbus: Register network object '%s'",
net_obj_path);
wpas_dbus_signal_network_added(wpa_s, ssid->id);
- os_free(net_obj_path);
return 0;
err:
- os_free(net_obj_path);
os_free(obj_desc);
os_free(arg);
return -1;
int wpas_dbus_unregister_network(struct wpa_supplicant *wpa_s, int nid)
{
struct wpas_dbus_priv *ctrl_iface;
- char *net_obj_path;
+ char net_obj_path[WPAS_DBUS_OBJECT_PATH_MAX];
int ret;
/* Do nothing if the control interface is not turned on */
if (ctrl_iface == NULL)
return 0;
- net_obj_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (net_obj_path == NULL)
- return -1;
os_snprintf(net_obj_path, WPAS_DBUS_OBJECT_PATH_MAX,
"%s/" WPAS_DBUS_NEW_NETWORKS_PART "/%u",
- wpas_dbus_get_path(wpa_s), nid);
+ wpa_s->dbus_new_path, nid);
wpa_printf(MSG_DEBUG, "dbus: Unregister network object '%s'",
net_obj_path);
if (!ret)
wpas_dbus_signal_network_removed(wpa_s, nid);
- os_free(net_obj_path);
return ret;
}
-static const struct wpas_dbus_property wpas_dbus_bss_properties[] = {
+static const struct wpa_dbus_property_desc wpas_dbus_bss_properties[] = {
{ "SSID", WPAS_DBUS_NEW_IFACE_BSSID, "ay",
(WPADBusPropertyAccessor) wpas_dbus_getter_bss_ssid,
NULL,
};
-static const struct wpas_dbus_signal wpas_dbus_bss_signals[] = {
+static const struct wpa_dbus_signal_desc wpas_dbus_bss_signals[] = {
{ "PropertiesChanged", WPAS_DBUS_NEW_IFACE_BSSID,
{
{ "properties", "a{sv}", ARG_OUT },
u8 bssid[ETH_ALEN], unsigned int id)
{
struct wpas_dbus_priv *ctrl_iface;
- char *bss_obj_path;
+ char bss_obj_path[WPAS_DBUS_OBJECT_PATH_MAX];
/* Do nothing if the control interface is not turned on */
if (wpa_s == NULL || wpa_s->global == NULL)
if (ctrl_iface == NULL)
return 0;
- bss_obj_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (bss_obj_path == NULL)
- return -1;
-
os_snprintf(bss_obj_path, WPAS_DBUS_OBJECT_PATH_MAX,
"%s/" WPAS_DBUS_NEW_BSSIDS_PART "/%u",
- wpas_dbus_get_path(wpa_s), id);
+ wpa_s->dbus_new_path, id);
wpa_printf(MSG_DEBUG, "dbus: Unregister BSS object '%s'",
bss_obj_path);
if (wpa_dbus_unregister_object_per_iface(ctrl_iface, bss_obj_path)) {
- wpa_printf(MSG_ERROR,
- "Cannot unregister BSSID dbus object %s.",
+ wpa_printf(MSG_ERROR, "dbus: Cannot unregister BSS object %s",
bss_obj_path);
- os_free(bss_obj_path);
return -1;
}
wpas_dbus_signal_bss_removed(wpa_s, bss_obj_path);
- os_free(bss_obj_path);
return 0;
}
{
struct wpas_dbus_priv *ctrl_iface;
struct wpa_dbus_object_desc *obj_desc;
- char *bss_obj_path;
-
+ char bss_obj_path[WPAS_DBUS_OBJECT_PATH_MAX];
struct bss_handler_args *arg = NULL;
/* Do nothing if the control interface is not turned on */
if (ctrl_iface == NULL)
return 0;
- bss_obj_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (bss_obj_path == NULL)
- return -1;
-
os_snprintf(bss_obj_path, WPAS_DBUS_OBJECT_PATH_MAX,
"%s/" WPAS_DBUS_NEW_BSSIDS_PART "/%u",
- wpas_dbus_get_path(wpa_s), id);
+ wpa_s->dbus_new_path, id);
obj_desc = os_zalloc(sizeof(struct wpa_dbus_object_desc));
if (!obj_desc) {
wpas_dbus_signal_bss_added(wpa_s, bss_obj_path);
- os_free(bss_obj_path);
return 0;
err:
- os_free(bss_obj_path);
os_free(obj_desc);
os_free(arg);
return -1;
}
-static const struct wpas_dbus_method wpas_dbus_interface_methods[] = {
+static const struct wpa_dbus_method_desc wpas_dbus_interface_methods[] = {
{ "Scan", WPAS_DBUS_NEW_IFACE_INTERFACE,
(WPADBusMethodHandler) &wpas_dbus_handler_scan,
{
{ NULL, NULL, NULL, { END_ARGS } }
};
-static const struct wpas_dbus_property wpas_dbus_interface_properties[] = {
+static const struct wpa_dbus_property_desc wpas_dbus_interface_properties[] = {
{ "Capabilities", WPAS_DBUS_NEW_IFACE_INTERFACE, "a{sv}",
(WPADBusPropertyAccessor) wpas_dbus_getter_capabilities,
NULL, R
{ NULL, NULL, NULL, NULL, NULL, 0 }
};
-static const struct wpas_dbus_signal wpas_dbus_interface_signals[] = {
+static const struct wpa_dbus_signal_desc wpas_dbus_interface_signals[] = {
{ "ScanDone", WPAS_DBUS_NEW_IFACE_INTERFACE,
{
{ "success", "b", ARG_OUT },
{
struct wpa_dbus_object_desc *obj_desc = NULL;
- char *path;
struct wpas_dbus_priv *ctrl_iface = wpa_s->global->dbus;
int next;
return 0;
/* Create and set the interface's object path */
- path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
- if (path == NULL)
+ wpa_s->dbus_new_path = os_zalloc(WPAS_DBUS_OBJECT_PATH_MAX);
+ if (wpa_s->dbus_new_path == NULL)
return -1;
next = ctrl_iface->next_objid++;
- os_snprintf(path, WPAS_DBUS_OBJECT_PATH_MAX,
+ os_snprintf(wpa_s->dbus_new_path, WPAS_DBUS_OBJECT_PATH_MAX,
WPAS_DBUS_NEW_PATH_INTERFACES "/%u",
next);
- if (wpas_dbus_set_path(wpa_s, path)) {
- wpa_printf(MSG_DEBUG,
- "Failed to set dbus path for interface %s",
- wpa_s->ifname);
- goto err;
- }
obj_desc = os_zalloc(sizeof(struct wpa_dbus_object_desc));
if (!obj_desc) {
wpas_dbus_interface_properties,
wpas_dbus_interface_signals);
- wpa_printf(MSG_DEBUG, "dbus: Register interface object '%s'", path);
- if (wpa_dbus_register_object_per_iface(ctrl_iface, path, wpa_s->ifname,
- obj_desc))
+ wpa_printf(MSG_DEBUG, "dbus: Register interface object '%s'",
+ wpa_s->dbus_new_path);
+ if (wpa_dbus_register_object_per_iface(ctrl_iface,
+ wpa_s->dbus_new_path,
+ wpa_s->ifname, obj_desc))
goto err;
wpas_dbus_signal_interface_added(wpa_s);
- os_free(path);
return 0;
err:
+ os_free(wpa_s->dbus_new_path);
+ wpa_s->dbus_new_path = NULL;
os_free(obj_desc);
- os_free(path);
return -1;
}
return 0;
wpa_printf(MSG_DEBUG, "dbus: Unregister interface object '%s'",
- wpas_dbus_get_path(wpa_s));
+ wpa_s->dbus_new_path);
if (wpa_dbus_unregister_object_per_iface(ctrl_iface,
- wpas_dbus_get_path(wpa_s)))
+ wpa_s->dbus_new_path))
return -1;
wpas_dbus_signal_interface_removed(wpa_s);
return 0;
}
-
-
-/**
- * wpas_dbus_get_path - Get an interface's dbus path
- * @wpa_s: %wpa_supplicant interface structure
- * Returns: Interface's dbus object path, or %NULL on error
- */
-const char * wpas_dbus_get_path(struct wpa_supplicant *wpa_s)
-{
- return wpa_s->dbus_new_path;
-}
projects / libeap.git / blobdiff