D-Bus: Fix P2P Group PSK property getter
[mech_eap.git] / wpa_supplicant / dbus / dbus_old_handlers.c
index 588042b..504de2a 100644 (file)
@@ -37,9 +37,9 @@ DBusMessage * wpas_dbus_new_invalid_opts_error(DBusMessage *message,
 {
        DBusMessage *reply;
 
-       reply = dbus_message_new_error(message, WPAS_ERROR_INVALID_OPTS,
-                                      "Did not receive correct message "
-                                      "arguments.");
+       reply = dbus_message_new_error(
+               message, WPAS_ERROR_INVALID_OPTS,
+               "Did not receive correct message arguments.");
        if (arg != NULL)
                dbus_message_append_args(reply, DBUS_TYPE_STRING, &arg,
                                         DBUS_TYPE_INVALID);
@@ -112,28 +112,28 @@ DBusMessage * wpas_dbus_global_add_interface(DBusMessage *message,
                        if (!wpa_dbus_dict_get_entry(&iter_dict, &entry))
                                goto error;
                        if (!strcmp(entry.key, "driver") &&
-                           (entry.type == DBUS_TYPE_STRING)) {
+                           entry.type == DBUS_TYPE_STRING) {
                                os_free(driver);
                                driver = os_strdup(entry.str_value);
                                wpa_dbus_dict_entry_clear(&entry);
                                if (driver == NULL)
                                        goto error;
                        } else if (!strcmp(entry.key, "driver-params") &&
-                                  (entry.type == DBUS_TYPE_STRING)) {
+                                  entry.type == DBUS_TYPE_STRING) {
                                os_free(driver_param);
                                driver_param = os_strdup(entry.str_value);
                                wpa_dbus_dict_entry_clear(&entry);
                                if (driver_param == NULL)
                                        goto error;
                        } else if (!strcmp(entry.key, "config-file") &&
-                                  (entry.type == DBUS_TYPE_STRING)) {
+                                  entry.type == DBUS_TYPE_STRING) {
                                os_free(confname);
                                confname = os_strdup(entry.str_value);
                                wpa_dbus_dict_entry_clear(&entry);
                                if (confname == NULL)
                                        goto error;
                        } else if (!strcmp(entry.key, "bridge-ifname") &&
-                                  (entry.type == DBUS_TYPE_STRING)) {
+                                  entry.type == DBUS_TYPE_STRING) {
                                os_free(bridge_ifname);
                                bridge_ifname = os_strdup(entry.str_value);
                                wpa_dbus_dict_entry_clear(&entry);
@@ -151,13 +151,13 @@ DBusMessage * wpas_dbus_global_add_interface(DBusMessage *message,
         * an error if we already control it.
         */
        if (wpa_supplicant_get_iface(global, ifname) != NULL) {
-               reply = dbus_message_new_error(message,
-                                              WPAS_ERROR_EXISTS_ERROR,
-                                              "wpa_supplicant already "
-                                              "controls this interface.");
+               reply = dbus_message_new_error(
+                       message, WPAS_ERROR_EXISTS_ERROR,
+                       "wpa_supplicant already controls this interface.");
        } else {
                struct wpa_supplicant *wpa_s;
                struct wpa_interface iface;
+
                os_memset(&iface, 0, sizeof(iface));
                iface.ifname = ifname;
                iface.driver = driver;
@@ -165,17 +165,17 @@ DBusMessage * wpas_dbus_global_add_interface(DBusMessage *message,
                iface.confname = confname;
                iface.bridge_ifname = bridge_ifname;
                /* Otherwise, have wpa_supplicant attach to it. */
-               if ((wpa_s = wpa_supplicant_add_iface(global, &iface))) {
+               wpa_s = wpa_supplicant_add_iface(global, &iface);
+               if (wpa_s) {
                        const char *path = wpa_s->dbus_path;
+
                        reply = dbus_message_new_method_return(message);
                        dbus_message_append_args(reply, DBUS_TYPE_OBJECT_PATH,
-                                                &path, DBUS_TYPE_INVALID);
+                                                &path, DBUS_TYPE_INVALID);
                } else {
-                       reply = dbus_message_new_error(message,
-                                                      WPAS_ERROR_ADD_ERROR,
-                                                      "wpa_supplicant "
-                                                      "couldn't grab this "
-                                                      "interface.");
+                       reply = dbus_message_new_error(
+                               message, WPAS_ERROR_ADD_ERROR,
+                               "wpa_supplicant couldn't grab this interface.");
                }
        }
 
@@ -226,10 +226,9 @@ DBusMessage * wpas_dbus_global_remove_interface(DBusMessage *message,
        if (!wpa_supplicant_remove_iface(global, wpa_s, 0)) {
                reply = wpas_dbus_new_success_reply(message);
        } else {
-               reply = dbus_message_new_error(message,
-                                              WPAS_ERROR_REMOVE_ERROR,
-                                              "wpa_supplicant couldn't "
-                                              "remove this interface.");
+               reply = dbus_message_new_error(
+                       message, WPAS_ERROR_REMOVE_ERROR,
+                       "wpa_supplicant couldn't remove this interface.");
        }
 
 out:
@@ -256,8 +255,8 @@ DBusMessage * wpas_dbus_global_get_interface(DBusMessage *message,
        struct wpa_supplicant *wpa_s;
 
        if (!dbus_message_get_args(message, NULL,
-                                  DBUS_TYPE_STRING, &ifname,
-                                  DBUS_TYPE_INVALID)) {
+                                  DBUS_TYPE_STRING, &ifname,
+                                  DBUS_TYPE_INVALID)) {
                reply = wpas_dbus_new_invalid_opts_error(message, NULL);
                goto out;
        }
@@ -271,8 +270,8 @@ DBusMessage * wpas_dbus_global_get_interface(DBusMessage *message,
        path = wpa_s->dbus_path;
        reply = dbus_message_new_method_return(message);
        dbus_message_append_args(reply,
-                                DBUS_TYPE_OBJECT_PATH, &path,
-                                DBUS_TYPE_INVALID);
+                                DBUS_TYPE_OBJECT_PATH, &path,
+                                DBUS_TYPE_INVALID);
 
 out:
        return reply;
@@ -298,10 +297,10 @@ DBusMessage * wpas_dbus_global_set_debugparams(DBusMessage *message,
        dbus_bool_t debug_show_keys;
 
        if (!dbus_message_get_args(message, NULL,
-                                  DBUS_TYPE_INT32, &debug_level,
-                                  DBUS_TYPE_BOOLEAN, &debug_timestamp,
-                                  DBUS_TYPE_BOOLEAN, &debug_show_keys,
-                                  DBUS_TYPE_INVALID)) {
+                                  DBUS_TYPE_INT32, &debug_level,
+                                  DBUS_TYPE_BOOLEAN, &debug_timestamp,
+                                  DBUS_TYPE_BOOLEAN, &debug_show_keys,
+                                  DBUS_TYPE_INVALID)) {
                return wpas_dbus_new_invalid_opts_error(message, NULL);
        }
 
@@ -409,84 +408,56 @@ DBusMessage * wpas_dbus_bssid_properties(DBusMessage *message,
 {
        DBusMessage *reply;
        DBusMessageIter iter, iter_dict;
-       const u8 *ie;
+       const u8 *wpa_ie, *rsn_ie, *wps_ie;
 
        /* Dump the properties into a dbus message */
        reply = dbus_message_new_method_return(message);
 
-       dbus_message_iter_init_append(reply, &iter);
-       if (!wpa_dbus_dict_open_write(&iter, &iter_dict))
-               goto error;
+       wpa_ie = wpa_bss_get_vendor_ie(bss, WPA_IE_VENDOR_TYPE);
+       rsn_ie = wpa_bss_get_ie(bss, WLAN_EID_RSN);
+       wps_ie = wpa_bss_get_vendor_ie(bss, WPS_IE_VENDOR_TYPE);
 
-       if (!wpa_dbus_dict_append_byte_array(&iter_dict, "bssid",
+       dbus_message_iter_init_append(reply, &iter);
+       if (!wpa_dbus_dict_open_write(&iter, &iter_dict) ||
+           !wpa_dbus_dict_append_byte_array(&iter_dict, "bssid",
                                             (const char *) bss->bssid,
-                                            ETH_ALEN))
-               goto error;
-
-       ie = wpa_bss_get_ie(bss, WLAN_EID_SSID);
-       if (ie) {
-               if (!wpa_dbus_dict_append_byte_array(&iter_dict, "ssid",
-                                                    (const char *) (ie + 2),
-                                                    ie[1]))
-                       goto error;
+                                            ETH_ALEN) ||
+           !wpa_dbus_dict_append_byte_array(&iter_dict, "ssid",
+                                            (const char *) bss->ssid,
+                                            bss->ssid_len) ||
+           (wpa_ie &&
+            !wpa_dbus_dict_append_byte_array(&iter_dict, "wpaie",
+                                             (const char *) wpa_ie,
+                                             wpa_ie[1] + 2)) ||
+           (rsn_ie &&
+            !wpa_dbus_dict_append_byte_array(&iter_dict, "rsnie",
+                                             (const char *) rsn_ie,
+                                             rsn_ie[1] + 2)) ||
+           (wps_ie &&
+            !wpa_dbus_dict_append_byte_array(&iter_dict, "wpsie",
+                                            (const char *) wps_ie,
+                                             wps_ie[1] + 2)) ||
+           (bss->freq &&
+            !wpa_dbus_dict_append_int32(&iter_dict, "frequency", bss->freq)) ||
+           !wpa_dbus_dict_append_uint16(&iter_dict, "capabilities",
+                                        bss->caps) ||
+           (!(bss->flags & WPA_BSS_QUAL_INVALID) &&
+            !wpa_dbus_dict_append_int32(&iter_dict, "quality", bss->qual)) ||
+           (!(bss->flags & WPA_BSS_NOISE_INVALID) &&
+            !wpa_dbus_dict_append_int32(&iter_dict, "noise", bss->noise)) ||
+           (!(bss->flags & WPA_BSS_LEVEL_INVALID) &&
+            !wpa_dbus_dict_append_int32(&iter_dict, "level", bss->level)) ||
+           !wpa_dbus_dict_append_int32(&iter_dict, "maxrate",
+                                       wpa_bss_get_max_rate(bss) * 500000) ||
+           !wpa_dbus_dict_close_write(&iter, &iter_dict)) {
+               if (reply)
+                       dbus_message_unref(reply);
+               reply = dbus_message_new_error(
+                       message, WPAS_ERROR_INTERNAL_ERROR,
+                       "an internal error occurred returning BSSID properties.");
        }
 
-       ie = wpa_bss_get_vendor_ie(bss, WPA_IE_VENDOR_TYPE);
-       if (ie) {
-               if (!wpa_dbus_dict_append_byte_array(&iter_dict, "wpaie",
-                                                    (const char *) ie,
-                                                    ie[1] + 2))
-                       goto error;
-       }
-
-       ie = wpa_bss_get_ie(bss, WLAN_EID_RSN);
-       if (ie) {
-               if (!wpa_dbus_dict_append_byte_array(&iter_dict, "rsnie",
-                                                    (const char *) ie,
-                                                    ie[1] + 2))
-                       goto error;
-       }
-
-       ie = wpa_bss_get_vendor_ie(bss, WPS_IE_VENDOR_TYPE);
-       if (ie) {
-               if (!wpa_dbus_dict_append_byte_array(&iter_dict, "wpsie",
-                                                    (const char *) ie,
-                                                    ie[1] + 2))
-                       goto error;
-       }
-
-       if (bss->freq) {
-               if (!wpa_dbus_dict_append_int32(&iter_dict, "frequency",
-                                               bss->freq))
-                       goto error;
-       }
-       if (!wpa_dbus_dict_append_uint16(&iter_dict, "capabilities",
-                                        bss->caps))
-               goto error;
-       if (!(bss->flags & WPA_BSS_QUAL_INVALID) &&
-           !wpa_dbus_dict_append_int32(&iter_dict, "quality", bss->qual))
-               goto error;
-       if (!(bss->flags & WPA_BSS_NOISE_INVALID) &&
-           !wpa_dbus_dict_append_int32(&iter_dict, "noise", bss->noise))
-               goto error;
-       if (!(bss->flags & WPA_BSS_LEVEL_INVALID) &&
-           !wpa_dbus_dict_append_int32(&iter_dict, "level", bss->level))
-               goto error;
-       if (!wpa_dbus_dict_append_int32(&iter_dict, "maxrate",
-                                       wpa_bss_get_max_rate(bss) * 500000))
-               goto error;
-
-       if (!wpa_dbus_dict_close_write(&iter, &iter_dict))
-               goto error;
-
        return reply;
-
-error:
-       if (reply)
-               dbus_message_unref(reply);
-       return dbus_message_new_error(message, WPAS_ERROR_INTERNAL_ERROR,
-                                     "an internal error occurred returning "
-                                     "BSSID properties.");
 }
 
 
@@ -546,6 +517,7 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
        if (res < 0) {
                if (!strict) {
                        const char *args[] = {"CCMP", "TKIP", "NONE"};
+
                        if (!wpa_dbus_dict_append_string_array(
                                    &iter_dict, "pairwise", args,
                                    ARRAY_SIZE(args)))
@@ -555,28 +527,17 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                if (!wpa_dbus_dict_begin_string_array(&iter_dict, "pairwise",
                                                      &iter_dict_entry,
                                                      &iter_dict_val,
-                                                     &iter_array))
-                       goto error;
-
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_CCMP) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "CCMP"))
-                               goto error;
-               }
-
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_TKIP) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "TKIP"))
-                               goto error;
-               }
-
-               if (capa.key_mgmt & WPA_DRIVER_CAPA_KEY_MGMT_WPA_NONE) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "NONE"))
-                               goto error;
-               }
-
-               if (!wpa_dbus_dict_end_string_array(&iter_dict,
+                                                     &iter_array) ||
+                   ((capa.enc & WPA_DRIVER_CAPA_ENC_CCMP) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "CCMP")) ||
+                   ((capa.enc & WPA_DRIVER_CAPA_ENC_TKIP) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "TKIP")) ||
+                   ((capa.key_mgmt & WPA_DRIVER_CAPA_KEY_MGMT_WPA_NONE) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "NONE")) ||
+                   !wpa_dbus_dict_end_string_array(&iter_dict,
                                                    &iter_dict_entry,
                                                    &iter_dict_val,
                                                    &iter_array))
@@ -589,6 +550,7 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                        const char *args[] = {
                                "CCMP", "TKIP", "WEP104", "WEP40"
                        };
+
                        if (!wpa_dbus_dict_append_string_array(
                                    &iter_dict, "group", args,
                                    ARRAY_SIZE(args)))
@@ -601,31 +563,19 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                                                      &iter_array))
                        goto error;
 
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_CCMP) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "CCMP"))
-                               goto error;
-               }
-
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_TKIP) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "TKIP"))
-                               goto error;
-               }
-
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_WEP104) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WEP104"))
-                               goto error;
-               }
-
-               if (capa.enc & WPA_DRIVER_CAPA_ENC_WEP40) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WEP40"))
-                               goto error;
-               }
-
-               if (!wpa_dbus_dict_end_string_array(&iter_dict,
+               if (((capa.enc & WPA_DRIVER_CAPA_ENC_CCMP) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "CCMP")) ||
+                   ((capa.enc & WPA_DRIVER_CAPA_ENC_TKIP) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "TKIP")) ||
+                   ((capa.enc & WPA_DRIVER_CAPA_ENC_WEP104) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WEP104")) ||
+                   ((capa.enc & WPA_DRIVER_CAPA_ENC_WEP40) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WEP40")) ||
+                   !wpa_dbus_dict_end_string_array(&iter_dict,
                                                    &iter_dict_entry,
                                                    &iter_dict_val,
                                                    &iter_array))
@@ -648,38 +598,23 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                if (!wpa_dbus_dict_begin_string_array(&iter_dict, "key_mgmt",
                                                      &iter_dict_entry,
                                                      &iter_dict_val,
-                                                     &iter_array))
-                       goto error;
-
-               if (!wpa_dbus_dict_string_array_add_element(&iter_array,
-                                                           "NONE"))
-                       goto error;
-
-               if (!wpa_dbus_dict_string_array_add_element(&iter_array,
-                                                           "IEEE8021X"))
-                       goto error;
-
-               if (capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA |
-                                    WPA_DRIVER_CAPA_KEY_MGMT_WPA2)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WPA-EAP"))
-                               goto error;
-               }
-
-               if (capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA_PSK |
-                                    WPA_DRIVER_CAPA_KEY_MGMT_WPA2_PSK)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WPA-PSK"))
-                               goto error;
-               }
-
-               if (capa.key_mgmt & WPA_DRIVER_CAPA_KEY_MGMT_WPA_NONE) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WPA-NONE"))
-                               goto error;
-               }
-
-               if (!wpa_dbus_dict_end_string_array(&iter_dict,
+                                                     &iter_array) ||
+                   !wpa_dbus_dict_string_array_add_element(&iter_array,
+                                                           "NONE") ||
+                   !wpa_dbus_dict_string_array_add_element(&iter_array,
+                                                           "IEEE8021X") ||
+                   ((capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA |
+                                      WPA_DRIVER_CAPA_KEY_MGMT_WPA2)) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WPA-EAP")) ||
+                   ((capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA_PSK |
+                                      WPA_DRIVER_CAPA_KEY_MGMT_WPA2_PSK)) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WPA-PSK")) ||
+                   ((capa.key_mgmt & WPA_DRIVER_CAPA_KEY_MGMT_WPA_NONE) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WPA-NONE")) ||
+                   !wpa_dbus_dict_end_string_array(&iter_dict,
                                                    &iter_dict_entry,
                                                    &iter_dict_val,
                                                    &iter_array))
@@ -690,6 +625,7 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
        if (res < 0) {
                if (!strict) {
                        const char *args[] = { "RSN", "WPA" };
+
                        if (!wpa_dbus_dict_append_string_array(
                                    &iter_dict, "proto", args,
                                    ARRAY_SIZE(args)))
@@ -699,24 +635,16 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                if (!wpa_dbus_dict_begin_string_array(&iter_dict, "proto",
                                                      &iter_dict_entry,
                                                      &iter_dict_val,
-                                                     &iter_array))
-                       goto error;
-
-               if (capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA2 |
-                                    WPA_DRIVER_CAPA_KEY_MGMT_WPA2_PSK)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "RSN"))
-                               goto error;
-               }
-
-               if (capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA |
-                                    WPA_DRIVER_CAPA_KEY_MGMT_WPA_PSK)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "WPA"))
-                               goto error;
-               }
-
-               if (!wpa_dbus_dict_end_string_array(&iter_dict,
+                                                     &iter_array) ||
+                   ((capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA2 |
+                                      WPA_DRIVER_CAPA_KEY_MGMT_WPA2_PSK)) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "RSN")) ||
+                   ((capa.key_mgmt & (WPA_DRIVER_CAPA_KEY_MGMT_WPA |
+                                      WPA_DRIVER_CAPA_KEY_MGMT_WPA_PSK)) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "WPA")) ||
+                   !wpa_dbus_dict_end_string_array(&iter_dict,
                                                    &iter_dict_entry,
                                                    &iter_dict_val,
                                                    &iter_array))
@@ -727,6 +655,7 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
        if (res < 0) {
                if (!strict) {
                        const char *args[] = { "OPEN", "SHARED", "LEAP" };
+
                        if (!wpa_dbus_dict_append_string_array(
                                    &iter_dict, "auth_alg", args,
                                    ARRAY_SIZE(args)))
@@ -736,28 +665,17 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
                if (!wpa_dbus_dict_begin_string_array(&iter_dict, "auth_alg",
                                                      &iter_dict_entry,
                                                      &iter_dict_val,
-                                                     &iter_array))
-                       goto error;
-
-               if (capa.auth & (WPA_DRIVER_AUTH_OPEN)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "OPEN"))
-                               goto error;
-               }
-
-               if (capa.auth & (WPA_DRIVER_AUTH_SHARED)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "SHARED"))
-                               goto error;
-               }
-
-               if (capa.auth & (WPA_DRIVER_AUTH_LEAP)) {
-                       if (!wpa_dbus_dict_string_array_add_element(
-                                   &iter_array, "LEAP"))
-                               goto error;
-               }
-
-               if (!wpa_dbus_dict_end_string_array(&iter_dict,
+                                                     &iter_array) ||
+                   ((capa.auth & WPA_DRIVER_AUTH_OPEN) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "OPEN")) ||
+                   ((capa.auth & WPA_DRIVER_AUTH_SHARED) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "SHARED")) ||
+                   ((capa.auth & WPA_DRIVER_AUTH_LEAP) &&
+                    !wpa_dbus_dict_string_array_add_element(
+                            &iter_array, "LEAP")) ||
+                   !wpa_dbus_dict_end_string_array(&iter_dict,
                                                    &iter_dict_entry,
                                                    &iter_dict_val,
                                                    &iter_array))
@@ -772,9 +690,9 @@ DBusMessage * wpas_dbus_iface_capabilities(DBusMessage *message,
 error:
        if (reply)
                dbus_message_unref(reply);
-       return dbus_message_new_error(message, WPAS_ERROR_INTERNAL_ERROR,
-                                     "an internal error occurred returning "
-                                     "interface capabilities.");
+       return dbus_message_new_error(
+               message, WPAS_ERROR_INTERNAL_ERROR,
+               "an internal error occurred returning interface capabilities.");
 }
 
 
@@ -795,10 +713,9 @@ DBusMessage * wpas_dbus_iface_add_network(DBusMessage *message,
 
        ssid = wpa_config_add_network(wpa_s->conf);
        if (ssid == NULL) {
-               reply = dbus_message_new_error(message,
-                                              WPAS_ERROR_ADD_NETWORK_ERROR,
-                                              "wpa_supplicant could not add "
-                                              "a network on this interface.");
+               reply = dbus_message_new_error(
+                       message, WPAS_ERROR_ADD_NETWORK_ERROR,
+                       "wpa_supplicant could not add a network on this interface.");
                goto out;
        }
        wpas_notify_network_added(wpa_s, ssid);
@@ -838,8 +755,8 @@ DBusMessage * wpas_dbus_iface_remove_network(DBusMessage *message,
        struct wpa_ssid *ssid;
 
        if (!dbus_message_get_args(message, NULL,
-                                  DBUS_TYPE_OBJECT_PATH, &op,
-                                  DBUS_TYPE_INVALID)) {
+                                  DBUS_TYPE_OBJECT_PATH, &op,
+                                  DBUS_TYPE_INVALID)) {
                reply = wpas_dbus_new_invalid_opts_error(message, NULL);
                goto out;
        }
@@ -866,17 +783,17 @@ DBusMessage * wpas_dbus_iface_remove_network(DBusMessage *message,
 
        wpas_notify_network_removed(wpa_s, ssid);
 
+       if (ssid == wpa_s->current_ssid)
+               wpa_supplicant_deauthenticate(wpa_s,
+                                             WLAN_REASON_DEAUTH_LEAVING);
+
        if (wpa_config_remove_network(wpa_s->conf, id) < 0) {
-               reply = dbus_message_new_error(message,
-                                              WPAS_ERROR_REMOVE_NETWORK_ERROR,
-                                              "error removing the specified "
-                                              "on this interface.");
+               reply = dbus_message_new_error(
+                       message, WPAS_ERROR_REMOVE_NETWORK_ERROR,
+                       "error removing the specified on this interface.");
                goto out;
        }
 
-       if (ssid == wpa_s->current_ssid)
-               wpa_supplicant_deauthenticate(wpa_s,
-                                             WLAN_REASON_DEAUTH_LEAVING);
        reply = wpas_dbus_new_success_reply(message);
 
 out:
@@ -886,7 +803,7 @@ out:
 }
 
 
-static const char *dont_quote[] = {
+static const char  const *dont_quote[] = {
        "key_mgmt", "proto", "pairwise", "auth_alg", "group", "eap",
        "opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path",
        "bssid", NULL
@@ -896,8 +813,9 @@ static const char *dont_quote[] = {
 static dbus_bool_t should_quote_opt(const char *key)
 {
        int i = 0;
+
        while (dont_quote[i] != NULL) {
-               if (strcmp(key, dont_quote[i]) == 0)
+               if (os_strcmp(key, dont_quote[i]) == 0)
                        return FALSE;
                i++;
        }
@@ -1213,19 +1131,19 @@ DBusMessage * wpas_dbus_iface_set_smartcard_modules(
                if (!wpa_dbus_dict_get_entry(&iter_dict, &entry))
                        goto error;
                if (!strcmp(entry.key, "opensc_engine_path") &&
-                   (entry.type == DBUS_TYPE_STRING)) {
+                   entry.type == DBUS_TYPE_STRING) {
                        os_free(opensc_engine_path);
                        opensc_engine_path = os_strdup(entry.str_value);
                        if (opensc_engine_path == NULL)
                                goto error;
                } else if (!strcmp(entry.key, "pkcs11_engine_path") &&
-                          (entry.type == DBUS_TYPE_STRING)) {
+                          entry.type == DBUS_TYPE_STRING) {
                        os_free(pkcs11_engine_path);
                        pkcs11_engine_path = os_strdup(entry.str_value);
                        if (pkcs11_engine_path == NULL)
                                goto error;
                } else if (!strcmp(entry.key, "pkcs11_module_path") &&
-                                (entry.type == DBUS_TYPE_STRING)) {
+                                entry.type == DBUS_TYPE_STRING) {
                        os_free(pkcs11_module_path);
                        pkcs11_module_path = os_strdup(entry.str_value);
                        if (pkcs11_module_path == NULL)
@@ -1305,8 +1223,8 @@ DBusMessage * wpas_dbus_iface_get_scanning(DBusMessage *message,
                dbus_message_append_args(reply, DBUS_TYPE_BOOLEAN, &scanning,
                                         DBUS_TYPE_INVALID);
        } else {
-               wpa_printf(MSG_ERROR, "dbus: Not enough memory to return "
-                          "scanning state");
+               wpa_printf(MSG_ERROR,
+                          "dbus: Not enough memory to return scanning state");
        }
 
        return reply;
@@ -1379,7 +1297,7 @@ DBusMessage * wpas_dbus_iface_set_blobs(DBusMessage *message,
                blob->len = entry.array_len;
                os_memcpy(blob->data, (u8 *) entry.bytearray_value,
                                entry.array_len);
-               if (blob->name == NULL || blob->data == NULL) {
+               if (blob->name == NULL) {
                        wpa_config_free_blob(blob);
                        reply = dbus_message_new_error(
                                message, WPAS_ERROR_ADD_ERROR,
@@ -1418,8 +1336,8 @@ DBusMessage * wpas_dbus_iface_remove_blobs(DBusMessage *message,
 
        dbus_message_iter_init(message, &iter);
 
-       if ((dbus_message_iter_get_arg_type (&iter) != DBUS_TYPE_ARRAY) ||
-           (dbus_message_iter_get_element_type (&iter) != DBUS_TYPE_STRING))
+       if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY ||
+           dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRING)
                return wpas_dbus_new_invalid_opts_error(message, NULL);
 
        dbus_message_iter_recurse(&iter, &array);