X-Git-Url: http://www.project-moonshot.org/gitweb/?a=blobdiff_plain;f=shibsp%2Fimpl%2FXMLServiceProvider.cpp;h=231039fbb12b40c86cc025e6ad723594b3bd38e4;hb=73514022d6a44deb8da9be57c8ed9d7e823d3b6b;hp=2c1e147124e858095656560aaac6ec38b96b56a5;hpb=15f7448b8edf7b5ea02fdec8c76f09d418c4a726;p=shibboleth%2Fsp.git diff --git a/shibsp/impl/XMLServiceProvider.cpp b/shibsp/impl/XMLServiceProvider.cpp index 2c1e147..231039f 100644 --- a/shibsp/impl/XMLServiceProvider.cpp +++ b/shibsp/impl/XMLServiceProvider.cpp @@ -1,6 +1,6 @@ /* - * Copyright 2001-2007 Internet2 - * + * Copyright 2001-2010 Internet2 + * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at @@ -17,11 +17,12 @@ /** * XMLServiceProvider.cpp * - * XML-based SP configuration and mgmt + * XML-based SP configuration and mgmt. */ #include "internal.h" #include "exceptions.h" +#include "version.h" #include "AccessControl.h" #include "Application.h" #include "RequestMapper.h" @@ -34,12 +35,21 @@ #include "util/DOMPropertySet.h" #include "util/SPConstants.h" -#include -#include +#if defined(XMLTOOLING_LOG4SHIB) +# include +#elif defined(XMLTOOLING_LOG4CPP) +# include +#else +# error "Supported logging library not available." +#endif +#include #include #include +#include #include #include +#include +#include #include #ifndef SHIBSP_LITE @@ -48,25 +58,39 @@ # include "attribute/resolver/AttributeExtractor.h" # include "attribute/resolver/AttributeResolver.h" # include "security/PKIXTrustEngine.h" +# include "security/SecurityPolicyProvider.h" # include +# include # include # include # include +# include # include -# include -# include +# include +# include +# include +# include +# include +# include # include +# include +# include using namespace opensaml::saml2; using namespace opensaml::saml2p; using namespace opensaml::saml2md; using namespace opensaml; +#else +# include "lite/SAMLConstants.h" #endif using namespace shibsp; using namespace xmltooling; -using namespace log4cpp; using namespace std; +#ifndef min +# define min(a,b) (((a) < (b)) ? (a) : (b)) +#endif + namespace { #if defined (_MSC_VER) @@ -80,12 +104,9 @@ namespace { class SHIBSP_DLLLOCAL XMLApplication : public Application, public Remoted, public DOMPropertySet, public DOMNodeFilter { public: - XMLApplication(const ServiceProvider*, const DOMElement* e, const XMLApplication* base=NULL); + XMLApplication(const ServiceProvider*, const DOMElement* e, const XMLApplication* base=nullptr); ~XMLApplication() { cleanup(); } - - // Application - const ServiceProvider& getServiceProvider() const {return *m_sp;} - const char* getId() const {return getString("id").second;} + const char* getHash() const {return m_hash.c_str();} #ifndef SHIBSP_LITE @@ -95,11 +116,14 @@ namespace { SAML2Artifact* generateSAML2Artifact(const EntityDescriptor* relyingParty) const { pair index = make_pair(false,0); const PropertySet* props = getRelyingParty(relyingParty); - if (props) - index = getInt("artifactEndpointIndex"); + index = props->getInt("artifactEndpointIndex"); if (!index.first) index = getArtifactEndpointIndex(); - return new SAML2ArtifactType0004(SAMLConfig::getConfig().hashSHA1(getString("entityID").second),index.first ? index.second : 1); + pair entityID = props->getString("entityID"); + return new SAML2ArtifactType0004( + SecurityHelper::doHash("SHA1", entityID.second, strlen(entityID.second), false), + index.first ? index.second : 1 + ); } MetadataProvider* getMetadataProvider(bool required=true) const { @@ -125,28 +149,33 @@ namespace { return (!m_credResolver && m_base) ? m_base->getCredentialResolver() : m_credResolver; } const PropertySet* getRelyingParty(const EntityDescriptor* provider) const; - const vector& getAudiences() const { - return (m_audiences.empty() && m_base) ? m_base->getAudiences() : m_audiences; + const PropertySet* getRelyingParty(const XMLCh* entityID) const; + const vector* getAudiences() const { + return (m_audiences.empty() && m_base) ? m_base->getAudiences() : &m_audiences; } #endif - string getLogoutNotification(const HTTPRequest& request, bool front, unsigned int index) const; + string getNotificationURL(const char* resource, bool front, unsigned int index) const; - const set& getRemoteUserAttributeIds() const { + const vector& getRemoteUserAttributeIds() const { return (m_remoteUsers.empty() && m_base) ? m_base->getRemoteUserAttributeIds() : m_remoteUsers; } - void clearAttributeHeaders(SPRequest& request) const; + void clearHeader(SPRequest& request, const char* rawname, const char* cginame) const; + void setHeader(SPRequest& request, const char* name, const char* value) const; + string getSecureHeader(const SPRequest& request, const char* name) const; + const SessionInitiator* getDefaultSessionInitiator() const; const SessionInitiator* getSessionInitiatorById(const char* id) const; const Handler* getDefaultAssertionConsumerService() const; const Handler* getAssertionConsumerServiceByIndex(unsigned short index) const; const vector& getAssertionConsumerServicesByBinding(const XMLCh* binding) const; const Handler* getHandler(const char* path) const; + void getHandlers(vector& handlers) const; void receive(DDF& in, ostream& out) { // Only current function is to return the headers to clear. DDF header; - DDF ret=DDF(NULL).list(); + DDF ret=DDF(nullptr).list(); DDFJanitor jret(ret); for (vector< pair >::const_iterator i = m_unsetHeaders.begin(); i!=m_unsetHeaders.end(); ++i) { header = DDF(i->first.c_str()).string(i->second.c_str()); @@ -156,13 +185,18 @@ namespace { } // Provides filter to exclude special config elements. - short acceptNode(const DOMNode* node) const; - +#ifdef SHIBSP_XERCESC_SHORT_ACCEPTNODE + short +#else + FilterAction +#endif + acceptNode(const DOMNode* node) const; + private: void cleanup(); - const ServiceProvider* m_sp; // this is ok because its locking scope includes us const XMLApplication* m_base; string m_hash; + std::pair m_attributePrefix; #ifndef SHIBSP_LITE MetadataProvider* m_metadata; TrustEngine* m_trust; @@ -173,17 +207,9 @@ namespace { vector m_audiences; // RelyingParty properties - DOMPropertySet* m_partyDefault; -#ifdef HAVE_GOOD_STL map m_partyMap; -#else - map m_partyMap; -#endif #endif - vector m_frontLogout,m_backLogout; - set m_remoteUsers; - mutable vector< pair > m_unsetHeaders; - RWLock* m_unsetLock; + vector m_remoteUsers,m_frontLogout,m_backLogout; // manage handler objects vector m_handlers; @@ -193,16 +219,12 @@ namespace { // maps unique indexes to consumer services map m_acsIndexMap; - + // pointer to default consumer service const Handler* m_acsDefault; // maps binding strings to supporting consumer service(s) -#ifdef HAVE_GOOD_STL typedef map > ACSBindingMap; -#else - typedef map > ACSBindingMap; -#endif ACSBindingMap m_acsBindingMap; // pointer to default session initiator @@ -227,15 +249,21 @@ namespace { public: XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* outer, Category& log); ~XMLConfigImpl(); - + RequestMapper* m_requestMapper; map m_appmap; #ifndef SHIBSP_LITE - map< string,pair< PropertySet*,vector > > m_policyMap; + SecurityPolicyProvider* m_policy; + vector< pair< string, pair > > m_transportOptions; #endif - + // Provides filter to exclude special config elements. - short acceptNode(const DOMNode* node) const; +#ifdef SHIBSP_XERCESC_SHORT_ACCEPTNODE + short +#else + FilterAction +#endif + acceptNode(const DOMNode* node) const; void setDocument(DOMDocument* doc) { m_document = doc; @@ -249,48 +277,69 @@ namespace { DOMDocument* m_document; }; - class SHIBSP_DLLLOCAL XMLConfig : public ServiceProvider, public ReloadableXMLFile, public Remoted + class SHIBSP_DLLLOCAL XMLConfig : public ServiceProvider, public ReloadableXMLFile +#ifndef SHIBSP_LITE + ,public Remoted +#endif { public: XMLConfig(const DOMElement* e) : ReloadableXMLFile(e, Category::getInstance(SHIBSP_LOGCAT".Config")), - m_impl(NULL), m_listener(NULL), m_sessionCache(NULL) + m_impl(nullptr), m_listener(nullptr), m_sessionCache(nullptr) #ifndef SHIBSP_LITE - , m_tranLog(NULL) + , m_tranLog(nullptr) #endif { } - + void init() { - load(); + background_load(); } ~XMLConfig() { + shutdown(); delete m_impl; delete m_sessionCache; delete m_listener; #ifndef SHIBSP_LITE delete m_tranLog; - SAMLConfig::getConfig().setArtifactMap(NULL); - XMLToolingConfig::getConfig().setReplayCache(NULL); + SAMLConfig::getConfig().setArtifactMap(nullptr); + XMLToolingConfig::getConfig().setReplayCache(nullptr); for_each(m_storage.begin(), m_storage.end(), cleanup_pair()); #endif } +#ifndef SHIBSP_LITE + // Lockable + Lockable* lock() { + ReloadableXMLFile::lock(); + if (m_impl->m_policy) + m_impl->m_policy->lock(); + return this; + } + void unlock() { + if (m_impl->m_policy) + m_impl->m_policy->unlock(); + ReloadableXMLFile::unlock(); + } +#endif + // PropertySet + const PropertySet* getParent() const { return m_impl->getParent(); } void setParent(const PropertySet* parent) {return m_impl->setParent(parent);} - pair getBool(const char* name, const char* ns=NULL) const {return m_impl->getBool(name,ns);} - pair getString(const char* name, const char* ns=NULL) const {return m_impl->getString(name,ns);} - pair getXMLString(const char* name, const char* ns=NULL) const {return m_impl->getXMLString(name,ns);} - pair getUnsignedInt(const char* name, const char* ns=NULL) const {return m_impl->getUnsignedInt(name,ns);} - pair getInt(const char* name, const char* ns=NULL) const {return m_impl->getInt(name,ns);} + pair getBool(const char* name, const char* ns=nullptr) const {return m_impl->getBool(name,ns);} + pair getString(const char* name, const char* ns=nullptr) const {return m_impl->getString(name,ns);} + pair getXMLString(const char* name, const char* ns=nullptr) const {return m_impl->getXMLString(name,ns);} + pair getUnsignedInt(const char* name, const char* ns=nullptr) const {return m_impl->getUnsignedInt(name,ns);} + pair getInt(const char* name, const char* ns=nullptr) const {return m_impl->getInt(name,ns);} + void getAll(map& properties) const {return m_impl->getAll(properties);} const PropertySet* getPropertySet(const char* name, const char* ns="urn:mace:shibboleth:2.0:native:sp:config") const {return m_impl->getPropertySet(name,ns);} const DOMElement* getElement() const {return m_impl->getElement();} + // ServiceProvider +#ifndef SHIBSP_LITE // Remoted void receive(DDF& in, ostream& out); - // ServiceProvider -#ifndef SHIBSP_LITE TransactionLog* getTransactionLog() const { if (m_tranLog) return m_tranLog; @@ -303,7 +352,7 @@ namespace { if (i!=m_storage.end()) return i->second; } - return NULL; + return nullptr; } #endif @@ -327,27 +376,39 @@ namespace { const Application* getApplication(const char* applicationId) const { map::const_iterator i=m_impl->m_appmap.find(applicationId); - return (i!=m_impl->m_appmap.end()) ? i->second : NULL; + return (i!=m_impl->m_appmap.end()) ? i->second : nullptr; } #ifndef SHIBSP_LITE + SecurityPolicyProvider* getSecurityPolicyProvider(bool required=true) const { + if (required && !m_impl->m_policy) + throw ConfigurationException("No SecurityPolicyProvider available."); + return m_impl->m_policy; + } + const PropertySet* getPolicySettings(const char* id) const { - map > >::const_iterator i = m_impl->m_policyMap.find(id); - if (i!=m_impl->m_policyMap.end()) - return i->second.first; - throw ConfigurationException("Security Policy ($1) not found, check element.", params(1,id)); + return getSecurityPolicyProvider()->getPolicySettings(id); } const vector& getPolicyRules(const char* id) const { - map > >::const_iterator i = m_impl->m_policyMap.find(id); - if (i!=m_impl->m_policyMap.end()) - return i->second.second; - throw ConfigurationException("Security Policy ($1) not found, check element.", params(1,id)); + return getSecurityPolicyProvider()->getPolicyRules(id); + } + + bool setTransportOptions(SOAPTransport& transport) const { + bool ret = true; + vector< pair< string, pair > >::const_iterator opt; + for (opt = m_impl->m_transportOptions.begin(); opt != m_impl->m_transportOptions.end(); ++opt) { + if (!transport.setProviderOption(opt->first.c_str(), opt->second.first.c_str(), opt->second.second.c_str())) { + m_log.error("failed to set SOAPTransport option (%s)", opt->second.first.c_str()); + ret = false; + } + } + return ret; } #endif protected: - pair load(); + pair background_load(); private: friend class XMLConfigImpl; @@ -364,8 +425,8 @@ namespace { #pragma warning( pop ) #endif - static const XMLCh _Application[] = UNICODE_LITERAL_11(A,p,p,l,i,c,a,t,i,o,n); - static const XMLCh Applications[] = UNICODE_LITERAL_12(A,p,p,l,i,c,a,t,i,o,n,s); + static const XMLCh ApplicationOverride[] = UNICODE_LITERAL_19(A,p,p,l,i,c,a,t,i,o,n,O,v,e,r,r,i,d,e); + static const XMLCh ApplicationDefaults[] = UNICODE_LITERAL_19(A,p,p,l,i,c,a,t,i,o,n,D,e,f,a,u,l,t,s); static const XMLCh _ArtifactMap[] = UNICODE_LITERAL_11(A,r,t,i,f,a,c,t,M,a,p); static const XMLCh _AttributeExtractor[] = UNICODE_LITERAL_18(A,t,t,r,i,b,u,t,e,E,x,t,r,a,c,t,o,r); static const XMLCh _AttributeFilter[] = UNICODE_LITERAL_15(A,t,t,r,i,b,u,t,e,F,i,l,t,e,r); @@ -376,48 +437,38 @@ namespace { static const XMLCh Binding[] = UNICODE_LITERAL_7(B,i,n,d,i,n,g); static const XMLCh Channel[]= UNICODE_LITERAL_7(C,h,a,n,n,e,l); static const XMLCh _CredentialResolver[] = UNICODE_LITERAL_18(C,r,e,d,e,n,t,i,a,l,R,e,s,o,l,v,e,r); - static const XMLCh DefaultRelyingParty[] = UNICODE_LITERAL_19(D,e,f,a,u,l,t,R,e,l,y,i,n,g,P,a,r,t,y); static const XMLCh _Extensions[] = UNICODE_LITERAL_10(E,x,t,e,n,s,i,o,n,s); static const XMLCh _fatal[] = UNICODE_LITERAL_5(f,a,t,a,l); static const XMLCh _Handler[] = UNICODE_LITERAL_7(H,a,n,d,l,e,r); static const XMLCh _id[] = UNICODE_LITERAL_2(i,d); - static const XMLCh Implementation[] = UNICODE_LITERAL_14(I,m,p,l,e,m,e,n,t,a,t,i,o,n); static const XMLCh InProcess[] = UNICODE_LITERAL_9(I,n,P,r,o,c,e,s,s); static const XMLCh Library[] = UNICODE_LITERAL_7(L,i,b,r,a,r,y); static const XMLCh Listener[] = UNICODE_LITERAL_8(L,i,s,t,e,n,e,r); static const XMLCh Location[] = UNICODE_LITERAL_8(L,o,c,a,t,i,o,n); static const XMLCh logger[] = UNICODE_LITERAL_6(l,o,g,g,e,r); + static const XMLCh _LogoutInitiator[] = UNICODE_LITERAL_15(L,o,g,o,u,t,I,n,i,t,i,a,t,o,r); static const XMLCh _ManageNameIDService[] = UNICODE_LITERAL_19(M,a,n,a,g,e,N,a,m,e,I,D,S,e,r,v,i,c,e); - static const XMLCh MemoryListener[] = UNICODE_LITERAL_14(M,e,m,o,r,y,L,i,s,t,e,n,e,r); static const XMLCh _MetadataProvider[] = UNICODE_LITERAL_16(M,e,t,a,d,a,t,a,P,r,o,v,i,d,e,r); - static const XMLCh NotifyOnLogout[] = UNICODE_LITERAL_14(N,o,t,i,f,y,O,n,L,o,g,o,u,t); + static const XMLCh Notify[] = UNICODE_LITERAL_6(N,o,t,i,f,y); + static const XMLCh _option[] = UNICODE_LITERAL_6(o,p,t,i,o,n); static const XMLCh OutOfProcess[] = UNICODE_LITERAL_12(O,u,t,O,f,P,r,o,c,e,s,s); static const XMLCh _path[] = UNICODE_LITERAL_4(p,a,t,h); - static const XMLCh Policy[] = UNICODE_LITERAL_6(P,o,l,i,c,y); + static const XMLCh _provider[] = UNICODE_LITERAL_8(p,r,o,v,i,d,e,r); static const XMLCh RelyingParty[] = UNICODE_LITERAL_12(R,e,l,y,i,n,g,P,a,r,t,y); static const XMLCh _ReplayCache[] = UNICODE_LITERAL_11(R,e,p,l,a,y,C,a,c,h,e); static const XMLCh _RequestMapper[] = UNICODE_LITERAL_13(R,e,q,u,e,s,t,M,a,p,p,e,r); - static const XMLCh Rule[] = UNICODE_LITERAL_4(R,u,l,e); static const XMLCh SecurityPolicies[] = UNICODE_LITERAL_16(S,e,c,u,r,i,t,y,P,o,l,i,c,i,e,s); + static const XMLCh SecurityPolicyProvider[] = UNICODE_LITERAL_22(S,e,c,u,r,i,t,y,P,o,l,i,c,y,P,r,o,v,i,d,e,r); static const XMLCh _SessionCache[] = UNICODE_LITERAL_12(S,e,s,s,i,o,n,C,a,c,h,e); static const XMLCh _SessionInitiator[] = UNICODE_LITERAL_16(S,e,s,s,i,o,n,I,n,i,t,i,a,t,o,r); static const XMLCh _SingleLogoutService[] = UNICODE_LITERAL_19(S,i,n,g,l,e,L,o,g,o,u,t,S,e,r,v,i,c,e); + static const XMLCh Site[] = UNICODE_LITERAL_4(S,i,t,e); static const XMLCh _StorageService[] = UNICODE_LITERAL_14(S,t,o,r,a,g,e,S,e,r,v,i,c,e); static const XMLCh TCPListener[] = UNICODE_LITERAL_11(T,C,P,L,i,s,t,e,n,e,r); + static const XMLCh TransportOption[] = UNICODE_LITERAL_15(T,r,a,n,s,p,o,r,t,O,p,t,i,o,n); static const XMLCh _TrustEngine[] = UNICODE_LITERAL_11(T,r,u,s,t,E,n,g,i,n,e); static const XMLCh _type[] = UNICODE_LITERAL_4(t,y,p,e); static const XMLCh UnixListener[] = UNICODE_LITERAL_12(U,n,i,x,L,i,s,t,e,n,e,r); - - - class SHIBSP_DLLLOCAL PolicyNodeFilter : public DOMNodeFilter - { - public: - short acceptNode(const DOMNode* node) const { - if (XMLHelper::isNodeNamed(node,shibspconstants::SHIB2SPCONFIG_NS,Rule)) - return FILTER_REJECT; - return FILTER_ACCEPT; - } - }; }; namespace shibsp { @@ -431,13 +482,13 @@ XMLApplication::XMLApplication( const ServiceProvider* sp, const DOMElement* e, const XMLApplication* base - ) : m_sp(sp), m_base(base), + ) : Application(sp), m_base(base), #ifndef SHIBSP_LITE - m_metadata(NULL), m_trust(NULL), - m_attrExtractor(NULL), m_attrFilter(NULL), m_attrResolver(NULL), - m_credResolver(NULL), m_partyDefault(NULL), + m_metadata(nullptr), m_trust(nullptr), + m_attrExtractor(nullptr), m_attrFilter(nullptr), m_attrResolver(nullptr), + m_credResolver(nullptr), #endif - m_unsetLock(NULL), m_acsDefault(NULL), m_sessionInitDefault(NULL), m_artifactResolutionDefault(NULL) + m_acsDefault(nullptr), m_sessionInitDefault(nullptr), m_artifactResolutionDefault(nullptr) { #ifdef _DEBUG xmltooling::NDC ndc("XMLApplication"); @@ -446,7 +497,7 @@ XMLApplication::XMLApplication( try { // First load any property sets. - load(e,log,this); + load(e,nullptr,this); if (base) setParent(base); @@ -465,6 +516,18 @@ XMLApplication::XMLApplication( m_hash += (DIGITS[0x0F & *ch]); } + // Populate prefix pair. + m_attributePrefix.second = "HTTP_"; + pair prefix = getString("attributePrefix"); + if (prefix.first) { + m_attributePrefix.first = prefix.second; + const char* pch = prefix.second; + while (*pch) { + m_attributePrefix.second += (isalnum(*pch) ? toupper(*pch) : '_'); + pch++; + } + } + // Load attribute ID lists for REMOTE_USER and header clearing. if (conf.isEnabled(SPConfig::InProcess)) { pair attributes = getString("REMOTE_USER"); @@ -480,14 +543,24 @@ XMLApplication::XMLApplication( pos = strchr(start,' '); if (pos) *pos=0; - m_remoteUsers.insert(start); - start = pos ? pos+1 : NULL; + m_remoteUsers.push_back(start); + start = pos ? pos+1 : nullptr; } free(dup); } attributes = getString("unsetHeaders"); if (attributes.first) { + string transformedprefix(m_attributePrefix.second); + const char* pch; + prefix = getString("metadataAttributePrefix"); + if (prefix.first) { + pch = prefix.second; + while (*pch) { + transformedprefix += (isalnum(*pch) ? toupper(*pch) : '_'); + pch++; + } + } char* dup = strdup(attributes.second); char* pos; char* start = dup; @@ -500,31 +573,46 @@ XMLApplication::XMLApplication( if (pos) *pos=0; - string transformed("HTTP_"); - const char* pch = start; + string transformed; + pch = start; while (*pch) { transformed += (isalnum(*pch) ? toupper(*pch) : '_'); pch++; } - m_unsetHeaders.push_back(pair(start,transformed)); - start = pos ? pos+1 : NULL; + + m_unsetHeaders.push_back(pair(m_attributePrefix.first + start, m_attributePrefix.second + transformed)); + if (prefix.first) + m_unsetHeaders.push_back(pair(m_attributePrefix.first + prefix.second + start, transformedprefix + transformed)); + start = pos ? pos+1 : nullptr; } free(dup); - m_unsetHeaders.push_back(pair("Shib-Application-ID","HTTP_SHIB_APPLICATION_ID")); + m_unsetHeaders.push_back(pair(m_attributePrefix.first + "Shib-Application-ID", m_attributePrefix.second + "SHIB_APPLICATION_ID")); } } - Handler* handler=NULL; + Handler* handler=nullptr; const PropertySet* sessions = getPropertySet("Sessions"); // Process assertion export handler. - pair location = sessions ? sessions->getString("exportLocation") : pair(false,NULL); + pair location = sessions ? sessions->getString("exportLocation") : pair(false,nullptr); if (location.first) { try { - handler = conf.HandlerManager.newPlugin(samlconstants::SAML20_BINDING_URI, make_pair(sessions->getElement(), getId())); + DOMElement* exportElement = e->getOwnerDocument()->createElementNS(shibspconstants::SHIB2SPCONFIG_NS,_Handler); + exportElement->setAttributeNS(nullptr,Location,sessions->getXMLString("exportLocation").second); + pair exportACL = sessions->getXMLString("exportACL"); + if (exportACL.first) { + static const XMLCh _acl[] = UNICODE_LITERAL_9(e,x,p,o,r,t,A,C,L); + exportElement->setAttributeNS(nullptr,_acl,exportACL.second); + } + handler = conf.HandlerManager.newPlugin( + samlconstants::SAML20_BINDING_URI, pair(exportElement, getId()) + ); m_handlers.push_back(handler); - // Insert into location map. + // Insert into location map. If it contains the handlerURL, we skip past that part. + const char* pch = strstr(location.second, sessions->getString("handlerURL").second); + if (pch) + location.second = pch + strlen(sessions->getString("handlerURL").second); if (*location.second == '/') m_handlerMap[location.second]=handler; else @@ -537,13 +625,17 @@ XMLApplication::XMLApplication( // Process other handlers. bool hardACS=false, hardSessionInit=false, hardArt=false; - const DOMElement* child = sessions ? XMLHelper::getFirstChildElement(sessions->getElement()) : NULL; + const DOMElement* child = sessions ? XMLHelper::getFirstChildElement(sessions->getElement()) : nullptr; while (child) { + if (!child->hasAttributeNS(nullptr, Location)) { + auto_ptr_char hclass(child->getLocalName()); + log.error("%s handler with no Location property cannot be processed", hclass.get()); + child = XMLHelper::getNextSiblingElement(child); + continue; + } try { - // A handler is based on the Binding property in conjunction with the element name. - // If it's an ACS or SI, also handle index/id mappings and defaulting. if (XMLString::equals(child->getLocalName(),_AssertionConsumerService)) { - auto_ptr_char bindprop(child->getAttributeNS(NULL,Binding)); + auto_ptr_char bindprop(child->getAttributeNS(nullptr,Binding)); if (!bindprop.get() || !*(bindprop.get())) { log.warn("md:AssertionConsumerService element has no Binding attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); @@ -551,13 +643,9 @@ XMLApplication::XMLApplication( } handler=conf.AssertionConsumerServiceManager.newPlugin(bindprop.get(),make_pair(child, getId())); // Map by binding (may be > 1 per binding, e.g. SAML 1.0 vs 1.1) -#ifdef HAVE_GOOD_STL m_acsBindingMap[handler->getXMLString("Binding").second].push_back(handler); -#else - m_acsBindingMap[handler->getString("Binding").second].push_back(handler); -#endif m_acsIndexMap[handler->getUnsignedInt("index").second]=handler; - + if (!hardACS) { pair defprop=handler->getBool("isDefault"); if (defprop.first) { @@ -571,7 +659,7 @@ XMLApplication::XMLApplication( } } else if (XMLString::equals(child->getLocalName(),_SessionInitiator)) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); if (!type.get() || !*(type.get())) { log.warn("SessionInitiator element has no type attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); @@ -594,15 +682,24 @@ XMLApplication::XMLApplication( m_sessionInitDefault=sihandler; } } + else if (XMLString::equals(child->getLocalName(),_LogoutInitiator)) { + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); + if (!type.get() || !*(type.get())) { + log.warn("LogoutInitiator element has no type attribute, skipping it..."); + child = XMLHelper::getNextSiblingElement(child); + continue; + } + handler=conf.LogoutInitiatorManager.newPlugin(type.get(),make_pair(child, getId())); + } else if (XMLString::equals(child->getLocalName(),_ArtifactResolutionService)) { - auto_ptr_char bindprop(child->getAttributeNS(NULL,Binding)); + auto_ptr_char bindprop(child->getAttributeNS(nullptr,Binding)); if (!bindprop.get() || !*(bindprop.get())) { log.warn("md:ArtifactResolutionService element has no Binding attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); continue; } handler=conf.ArtifactResolutionServiceManager.newPlugin(bindprop.get(),make_pair(child, getId())); - + if (!hardArt) { pair defprop=handler->getBool("isDefault"); if (defprop.first) { @@ -616,7 +713,7 @@ XMLApplication::XMLApplication( } } else if (XMLString::equals(child->getLocalName(),_SingleLogoutService)) { - auto_ptr_char bindprop(child->getAttributeNS(NULL,Binding)); + auto_ptr_char bindprop(child->getAttributeNS(nullptr,Binding)); if (!bindprop.get() || !*(bindprop.get())) { log.warn("md:SingleLogoutService element has no Binding attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); @@ -625,7 +722,7 @@ XMLApplication::XMLApplication( handler=conf.SingleLogoutServiceManager.newPlugin(bindprop.get(),make_pair(child, getId())); } else if (XMLString::equals(child->getLocalName(),_ManageNameIDService)) { - auto_ptr_char bindprop(child->getAttributeNS(NULL,Binding)); + auto_ptr_char bindprop(child->getAttributeNS(nullptr,Binding)); if (!bindprop.get() || !*(bindprop.get())) { log.warn("md:ManageNameIDService element has no Binding attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); @@ -634,7 +731,7 @@ XMLApplication::XMLApplication( handler=conf.ManageNameIDServiceManager.newPlugin(bindprop.get(),make_pair(child, getId())); } else { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); if (!type.get() || !*(type.get())) { log.warn("Handler element has no type attribute, skipping it..."); child = XMLHelper::getNextSiblingElement(child); @@ -656,16 +753,16 @@ XMLApplication::XMLApplication( catch (exception& ex) { log.error("caught exception processing handler element: %s", ex.what()); } - + child = XMLHelper::getNextSiblingElement(child); } - // Logout notification. - DOMNodeList* nlist=e->getElementsByTagNameNS(shibspconstants::SHIB2SPCONFIG_NS,NotifyOnLogout); + // Notification. + DOMNodeList* nlist=e->getElementsByTagNameNS(shibspconstants::SHIB2SPCONFIG_NS,Notify); for (XMLSize_t i=0; nlist && igetLength(); i++) { if (nlist->item(i)->getParentNode()->isSameNode(e)) { - const XMLCh* channel = static_cast(nlist->item(i))->getAttributeNS(NULL,Channel); - auto_ptr_char loc(static_cast(nlist->item(i))->getAttributeNS(NULL,Location)); + const XMLCh* channel = static_cast(nlist->item(i))->getAttributeNS(nullptr,Channel); + auto_ptr_char loc(static_cast(nlist->item(i))->getAttributeNS(nullptr,Location)); if (loc.get() && *loc.get()) { if (channel && *channel == chLatin_f) m_frontLogout.push_back(loc.get()); @@ -677,17 +774,17 @@ XMLApplication::XMLApplication( #ifndef SHIBSP_LITE nlist=e->getElementsByTagNameNS(samlconstants::SAML20_NS,Audience::LOCAL_NAME); - for (XMLSize_t i=0; nlist && igetLength(); i++) - if (nlist->item(i)->getParentNode()->isSameNode(e) && nlist->item(i)->hasChildNodes()) - m_audiences.push_back(nlist->item(i)->getFirstChild()->getNodeValue()); - - // Always include our own entityID as an audience. - m_audiences.push_back(getXMLString("entityID").second); + if (nlist && nlist->getLength()) { + log.warn("use of elements outside of a Security Policy Rule is deprecated"); + for (XMLSize_t i=0; igetLength(); i++) + if (nlist->item(i)->getParentNode()->isSameNode(e) && nlist->item(i)->hasChildNodes()) + m_audiences.push_back(nlist->item(i)->getFirstChild()->getNodeValue()); + } if (conf.isEnabled(SPConfig::Metadata)) { child = XMLHelper::getFirstChildElement(e,_MetadataProvider); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building MetadataProvider of type %s...",type.get()); try { auto_ptr mp(samlConf.MetadataProviderManager.newPlugin(type.get(),child)); @@ -703,7 +800,7 @@ XMLApplication::XMLApplication( if (conf.isEnabled(SPConfig::Trust)) { child = XMLHelper::getFirstChildElement(e,_TrustEngine); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building TrustEngine of type %s...",type.get()); try { m_trust = xmlConf.TrustEngineManager.newPlugin(type.get(),child); @@ -717,7 +814,7 @@ XMLApplication::XMLApplication( if (conf.isEnabled(SPConfig::AttributeResolution)) { child = XMLHelper::getFirstChildElement(e,_AttributeExtractor); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building AttributeExtractor of type %s...",type.get()); try { m_attrExtractor = conf.AttributeExtractorManager.newPlugin(type.get(),child); @@ -729,7 +826,7 @@ XMLApplication::XMLApplication( child = XMLHelper::getFirstChildElement(e,_AttributeFilter); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building AttributeFilter of type %s...",type.get()); try { m_attrFilter = conf.AttributeFilterManager.newPlugin(type.get(),child); @@ -741,7 +838,7 @@ XMLApplication::XMLApplication( child = XMLHelper::getFirstChildElement(e,_AttributeResolver); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building AttributeResolver of type %s...",type.get()); try { m_attrResolver = conf.AttributeResolverManager.newPlugin(type.get(),child); @@ -757,35 +854,49 @@ XMLApplication::XMLApplication( Locker extlock(m_attrExtractor); m_attrExtractor->getAttributeIds(unsetHeaders); } + else if (m_base && m_base->m_attrExtractor) { + Locker extlock(m_base->m_attrExtractor); + m_base->m_attrExtractor->getAttributeIds(unsetHeaders); + } if (m_attrResolver) { Locker reslock(m_attrResolver); m_attrResolver->getAttributeIds(unsetHeaders); } - if (unsetHeaders.empty()) { - if (m_base) - m_unsetHeaders.insert(m_unsetHeaders.end(), m_base->m_unsetHeaders.begin(), m_base->m_unsetHeaders.end()); - else - m_unsetHeaders.push_back(pair("Shib-Application-ID","HTTP_SHIB_APPLICATION_ID")); + else if (m_base && m_base->m_attrResolver) { + Locker extlock(m_base->m_attrResolver); + m_base->m_attrResolver->getAttributeIds(unsetHeaders); } - else { + if (!unsetHeaders.empty()) { + string transformedprefix(m_attributePrefix.second); + const char* pch; + pair prefix = getString("metadataAttributePrefix"); + if (prefix.first) { + pch = prefix.second; + while (*pch) { + transformedprefix += (isalnum(*pch) ? toupper(*pch) : '_'); + pch++; + } + } for (vector::const_iterator hdr = unsetHeaders.begin(); hdr!=unsetHeaders.end(); ++hdr) { - string transformed("HTTP_"); - const char* pch = hdr->c_str(); + string transformed; + pch = hdr->c_str(); while (*pch) { transformed += (isalnum(*pch) ? toupper(*pch) : '_'); pch++; } - m_unsetHeaders.push_back(pair(*hdr,transformed)); + m_unsetHeaders.push_back(pair(m_attributePrefix.first + *hdr, m_attributePrefix.second + transformed)); + if (prefix.first) + m_unsetHeaders.push_back(pair(m_attributePrefix.first + prefix.second + *hdr, transformedprefix + transformed)); } - m_unsetHeaders.push_back(pair("Shib-Application-ID","HTTP_SHIB_APPLICATION_ID")); } + m_unsetHeaders.push_back(pair(m_attributePrefix.first + "Shib-Application-ID", m_attributePrefix.second + "SHIB_APPLICATION_ID")); } } if (conf.isEnabled(SPConfig::Credentials)) { child = XMLHelper::getFirstChildElement(e,_CredentialResolver); if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building CredentialResolver of type %s...",type.get()); try { m_credResolver = xmlConf.CredentialResolverManager.newPlugin(type.get(),child); @@ -797,26 +908,18 @@ XMLApplication::XMLApplication( } // Finally, load relying parties. - child = XMLHelper::getFirstChildElement(e,DefaultRelyingParty); - if (child) { - m_partyDefault=new DOMPropertySet(); - m_partyDefault->load(child,log,this); - child = XMLHelper::getFirstChildElement(child,RelyingParty); - while (child) { - auto_ptr rp(new DOMPropertySet()); - rp->load(child,log,this); - rp->setParent(m_partyDefault); - m_partyMap[child->getAttributeNS(NULL,saml2::Attribute::NAME_ATTRIB_NAME)]=rp.release(); - child = XMLHelper::getNextSiblingElement(child,RelyingParty); - } + child = XMLHelper::getFirstChildElement(e,RelyingParty); + while (child) { + auto_ptr rp(new DOMPropertySet()); + rp->load(child,nullptr,this); + rp->setParent(this); + m_partyMap[child->getAttributeNS(nullptr,saml2::Attribute::NAME_ATTRIB_NAME)]=rp.release(); + child = XMLHelper::getNextSiblingElement(child,RelyingParty); } #endif - // In process only, we need a shared lock around accessing the header clearing list. - if (!conf.isEnabled(SPConfig::OutOfProcess)) { - m_unsetLock = RWLock::create(); - } - else if (!conf.isEnabled(SPConfig::InProcess)) { + // Out of process only, we register a listener endpoint. + if (!conf.isEnabled(SPConfig::InProcess)) { ListenerService* listener = sp->getListenerService(false); if (listener) { string addr=string(getId()) + "::getHeaders::Application"; @@ -845,46 +948,44 @@ void XMLApplication::cleanup() string addr=string(getId()) + "::getHeaders::Application"; listener->unregListener(addr.c_str(),this); } - delete m_unsetLock; - m_unsetLock = NULL; for_each(m_handlers.begin(),m_handlers.end(),xmltooling::cleanup()); m_handlers.clear(); #ifndef SHIBSP_LITE - delete m_partyDefault; - m_partyDefault = NULL; -#ifdef HAVE_GOOD_STL for_each(m_partyMap.begin(),m_partyMap.end(),cleanup_pair()); -#else - for_each(m_partyMap.begin(),m_partyMap.end(),cleanup_pair()); -#endif m_partyMap.clear(); delete m_credResolver; - m_credResolver = NULL; + m_credResolver = nullptr; delete m_attrResolver; - m_attrResolver = NULL; + m_attrResolver = nullptr; delete m_attrFilter; - m_attrFilter = NULL; + m_attrFilter = nullptr; delete m_attrExtractor; - m_attrExtractor = NULL; + m_attrExtractor = nullptr; delete m_trust; - m_trust = NULL; + m_trust = nullptr; delete m_metadata; - m_metadata = NULL; + m_metadata = nullptr; #endif } -short XMLApplication::acceptNode(const DOMNode* node) const +#ifdef SHIBSP_XERCESC_SHORT_ACCEPTNODE +short +#else +DOMNodeFilter::FilterAction +#endif +XMLApplication::acceptNode(const DOMNode* node) const { const XMLCh* name=node->getLocalName(); - if (XMLString::equals(name,_Application) || + if (XMLString::equals(name,ApplicationOverride) || XMLString::equals(name,_Audience) || - XMLString::equals(name,NotifyOnLogout) || + XMLString::equals(name,Notify) || + XMLString::equals(name,_Handler) || XMLString::equals(name,_AssertionConsumerService) || XMLString::equals(name,_ArtifactResolutionService) || - XMLString::equals(name,_SingleLogoutService) || + XMLString::equals(name,_LogoutInitiator) || XMLString::equals(name,_ManageNameIDService) || XMLString::equals(name,_SessionInitiator) || - XMLString::equals(name,DefaultRelyingParty) || + XMLString::equals(name,_SingleLogoutService) || XMLString::equals(name,RelyingParty) || XMLString::equals(name,_MetadataProvider) || XMLString::equals(name,_TrustEngine) || @@ -901,12 +1002,9 @@ short XMLApplication::acceptNode(const DOMNode* node) const const PropertySet* XMLApplication::getRelyingParty(const EntityDescriptor* provider) const { - if (!m_partyDefault && m_base) - return m_base->getRelyingParty(provider); - else if (!provider) - return m_partyDefault; - -#ifdef HAVE_GOOD_STL + if (!provider) + return this; + map::const_iterator i=m_partyMap.find(provider->getEntityID()); if (i!=m_partyMap.end()) return i->second; @@ -919,33 +1017,30 @@ const PropertySet* XMLApplication::getRelyingParty(const EntityDescriptor* provi } group=dynamic_cast(group->getParent()); } -#else - map::const_iterator i=m_partyMap.begin(); - for (; i!=m_partyMap.end(); i++) { - if (XMLString::equals(i->first,provider->getId())) - return i->second; - const EntitiesDescriptor* group=dynamic_cast(provider->getParent()); - while (group) { - if (XMLString::equals(i->first,group->getName())) - return i->second; - group=dynamic_cast(group->getParent()); - } - } -#endif - return m_partyDefault; + return this; +} + +const PropertySet* XMLApplication::getRelyingParty(const XMLCh* entityID) const +{ + if (!entityID) + return this; + + map::const_iterator i=m_partyMap.find(entityID); + if (i!=m_partyMap.end()) + return i->second; + return this; } #endif -string XMLApplication::getLogoutNotification(const HTTPRequest& request, bool front, unsigned int index) const +string XMLApplication::getNotificationURL(const char* resource, bool front, unsigned int index) const { const vector& locs = front ? m_frontLogout : m_backLogout; if (locs.empty()) - return m_base ? m_base->getLogoutNotification(request, front, index) : string(); + return m_base ? m_base->getNotificationURL(resource, front, index) : string(); else if (index >= locs.size()) return string(); - const char* resource = request.getRequestURL(); #ifdef HAVE_STRCASECMP if (!resource || (strncasecmp(resource,"http://",7) && strncasecmp(resource,"https://",8))) #else @@ -954,11 +1049,11 @@ string XMLApplication::getLogoutNotification(const HTTPRequest& request, bool fr throw ConfigurationException("Request URL was not absolute."); const char* handler=locs[index].c_str(); - + // Should never happen... if (!handler || (*handler!='/' && strncmp(handler,"http:",5) && strncmp(handler,"https:",6))) throw ConfigurationException( - "Invalid Location property ($1) in logout notification for Application ($2)", + "Invalid Location property ($1) in Notify element for Application ($2)", params(2, handler ? handler : "null", getId()) ); @@ -973,7 +1068,7 @@ string XMLApplication::getLogoutNotification(const HTTPRequest& request, bool fr // 2 handler resource handler // 3 resource resource handler - const char* path = NULL; + const char* path = nullptr; // Decide whether to use the handler or the resource for the "protocol" const char* prot; @@ -1010,40 +1105,78 @@ string XMLApplication::getLogoutNotification(const HTTPRequest& request, bool fr return notifyURL; } +void XMLApplication::clearHeader(SPRequest& request, const char* rawname, const char* cginame) const +{ + if (!m_attributePrefix.first.empty()) { + string temp = m_attributePrefix.first + rawname; + string temp2 = m_attributePrefix.second + (cginame + 5); + request.clearHeader(temp.c_str(), temp2.c_str()); + } + else if (m_base) { + m_base->clearHeader(request, rawname, cginame); + } + else { + request.clearHeader(rawname, cginame); + } +} + +void XMLApplication::setHeader(SPRequest& request, const char* name, const char* value) const +{ + if (!m_attributePrefix.first.empty()) { + string temp = m_attributePrefix.first + name; + request.setHeader(temp.c_str(), value); + } + else if (m_base) { + m_base->setHeader(request, name, value); + } + else { + request.setHeader(name, value); + } +} + +string XMLApplication::getSecureHeader(const SPRequest& request, const char* name) const +{ + if (!m_attributePrefix.first.empty()) { + string temp = m_attributePrefix.first + name; + return request.getSecureHeader(temp.c_str()); + } + else if (m_base) { + return m_base->getSecureHeader(request,name); + } + else { + return request.getSecureHeader(name); + } +} + const SessionInitiator* XMLApplication::getDefaultSessionInitiator() const { if (m_sessionInitDefault) return m_sessionInitDefault; - return m_base ? m_base->getDefaultSessionInitiator() : NULL; + return m_base ? m_base->getDefaultSessionInitiator() : nullptr; } const SessionInitiator* XMLApplication::getSessionInitiatorById(const char* id) const { map::const_iterator i=m_sessionInitMap.find(id); if (i!=m_sessionInitMap.end()) return i->second; - return m_base ? m_base->getSessionInitiatorById(id) : NULL; + return m_base ? m_base->getSessionInitiatorById(id) : nullptr; } const Handler* XMLApplication::getDefaultAssertionConsumerService() const { if (m_acsDefault) return m_acsDefault; - return m_base ? m_base->getDefaultAssertionConsumerService() : NULL; + return m_base ? m_base->getDefaultAssertionConsumerService() : nullptr; } const Handler* XMLApplication::getAssertionConsumerServiceByIndex(unsigned short index) const { map::const_iterator i=m_acsIndexMap.find(index); if (i!=m_acsIndexMap.end()) return i->second; - return m_base ? m_base->getAssertionConsumerServiceByIndex(index) : NULL; + return m_base ? m_base->getAssertionConsumerServiceByIndex(index) : nullptr; } const vector& XMLApplication::getAssertionConsumerServicesByBinding(const XMLCh* binding) const { -#ifdef HAVE_GOOD_STL ACSBindingMap::const_iterator i=m_acsBindingMap.find(binding); -#else - auto_ptr_char temp(binding); - ACSBindingMap::const_iterator i=m_acsBindingMap.find(temp.get()); -#endif if (i!=m_acsBindingMap.end()) return i->second; return m_base ? m_base->getAssertionConsumerServicesByBinding(binding) : g_noHandlers; @@ -1052,68 +1185,47 @@ const vector& XMLApplication::getAssertionConsumerServicesByBind const Handler* XMLApplication::getHandler(const char* path) const { string wrap(path); + wrap = wrap.substr(0,wrap.find(';')); map::const_iterator i=m_handlerMap.find(wrap.substr(0,wrap.find('?'))); if (i!=m_handlerMap.end()) return i->second; - return m_base ? m_base->getHandler(path) : NULL; + return m_base ? m_base->getHandler(path) : nullptr; } -void XMLApplication::clearAttributeHeaders(SPRequest& request) const +void XMLApplication::getHandlers(vector& handlers) const { - if (SPConfig::getConfig().isEnabled(SPConfig::OutOfProcess)) { - for (vector< pair >::const_iterator i = m_unsetHeaders.begin(); i!=m_unsetHeaders.end(); ++i) - request.clearHeader(i->first.c_str(), i->second.c_str()); - return; - } - - m_unsetLock->rdlock(); - if (m_unsetHeaders.empty()) { - // No headers yet, so we have to request them from the remote half. - m_unsetLock->unlock(); - m_unsetLock->wrlock(); - if (m_unsetHeaders.empty()) { - SharedLock wrlock(m_unsetLock, false); - string addr=string(getId()) + "::getHeaders::Application"; - DDF out,in = DDF(addr.c_str()); - DDFJanitor jin(in),jout(out); - out = getServiceProvider().getListenerService()->send(in); - if (out.islist()) { - DDF header = out.first(); - while (header.isstring()) { - m_unsetHeaders.push_back(pair(header.name(),header.string())); - header = out.next(); - } - } - } - else { - m_unsetLock->unlock(); + handlers.insert(handlers.end(), m_handlers.begin(), m_handlers.end()); + if (m_base) { + for (map::const_iterator h = m_base->m_handlerMap.begin(); h != m_base->m_handlerMap.end(); ++h) { + if (m_handlerMap.count(h->first) == 0) + handlers.push_back(h->second); } - m_unsetLock->rdlock(); } - - // Now holding read lock. - SharedLock unsetLock(m_unsetLock, false); - for (vector< pair >::const_iterator i = m_unsetHeaders.begin(); i!=m_unsetHeaders.end(); ++i) - request.clearHeader(i->first.c_str(), i->second.c_str()); } -short XMLConfigImpl::acceptNode(const DOMNode* node) const +#ifdef SHIBSP_XERCESC_SHORT_ACCEPTNODE +short +#else +DOMNodeFilter::FilterAction +#endif +XMLConfigImpl::acceptNode(const DOMNode* node) const { if (!XMLString::equals(node->getNamespaceURI(),shibspconstants::SHIB2SPCONFIG_NS)) return FILTER_ACCEPT; const XMLCh* name=node->getLocalName(); - if (XMLString::equals(name,Applications) || + if (XMLString::equals(name,ApplicationDefaults) || XMLString::equals(name,_ArtifactMap) || XMLString::equals(name,_Extensions) || - XMLString::equals(name,Implementation) || XMLString::equals(name,Listener) || - XMLString::equals(name,MemoryListener) || - XMLString::equals(name,Policy) || XMLString::equals(name,_RequestMapper) || XMLString::equals(name,_ReplayCache) || + XMLString::equals(name,SecurityPolicies) || + XMLString::equals(name,SecurityPolicyProvider) || XMLString::equals(name,_SessionCache) || + XMLString::equals(name,Site) || XMLString::equals(name,_StorageService) || XMLString::equals(name,TCPListener) || + XMLString::equals(name,TransportOption) || XMLString::equals(name,UnixListener)) return FILTER_REJECT; @@ -1126,15 +1238,16 @@ void XMLConfigImpl::doExtensions(const DOMElement* e, const char* label, Categor if (exts) { exts=XMLHelper::getFirstChildElement(exts,Library); while (exts) { - auto_ptr_char path(exts->getAttributeNS(NULL,_path)); + auto_ptr_char path(exts->getAttributeNS(nullptr,_path)); try { if (path.get()) { - XMLToolingConfig::getConfig().load_library(path.get(),(void*)exts); + if (!XMLToolingConfig::getConfig().load_library(path.get(),(void*)exts)) + throw ConfigurationException("XMLToolingConfig::load_library failed."); log.debug("loaded %s extension library (%s)", label, path.get()); } } catch (exception& e) { - const XMLCh* fatal=exts->getAttributeNS(NULL,_fatal); + const XMLCh* fatal=exts->getAttributeNS(nullptr,_fatal); if (fatal && (*fatal==chLatin_t || *fatal==chDigit_1)) { log.fatal("unable to load mandatory %s extension library %s: %s", label, path.get(), e.what()); throw; @@ -1149,7 +1262,11 @@ void XMLConfigImpl::doExtensions(const DOMElement* e, const char* label, Categor } XMLConfigImpl::XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* outer, Category& log) - : m_requestMapper(NULL), m_outer(outer), m_document(NULL) + : m_requestMapper(nullptr), +#ifndef SHIBSP_LITE + m_policy(nullptr), +#endif + m_outer(outer), m_document(nullptr) { #ifdef _DEBUG xmltooling::NDC ndc("XMLConfigImpl"); @@ -1166,29 +1283,44 @@ XMLConfigImpl::XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* o // Initialize log4cpp manually in order to redirect log messages as soon as possible. if (conf.isEnabled(SPConfig::Logging)) { - const XMLCh* logconf=NULL; + const XMLCh* logconf=nullptr; if (conf.isEnabled(SPConfig::OutOfProcess)) - logconf=SHAR->getAttributeNS(NULL,logger); + logconf=SHAR->getAttributeNS(nullptr,logger); else if (conf.isEnabled(SPConfig::InProcess)) - logconf=SHIRE->getAttributeNS(NULL,logger); + logconf=SHIRE->getAttributeNS(nullptr,logger); if (!logconf || !*logconf) - logconf=e->getAttributeNS(NULL,logger); + logconf=e->getAttributeNS(nullptr,logger); if (logconf && *logconf) { auto_ptr_char logpath(logconf); log.debug("loading new logging configuration from (%s), check log destination for status of configuration",logpath.get()); - XMLToolingConfig::getConfig().log_config(logpath.get()); + if (!XMLToolingConfig::getConfig().log_config(logpath.get())) + log.crit("failed to load new logging configuration from (%s)", logpath.get()); } - + #ifndef SHIBSP_LITE if (first) m_outer->m_tranLog = new TransactionLog(); #endif } - + + // Re-log library versions now that logging is set up. + log.info("Shibboleth SP Version %s", PACKAGE_VERSION); +#ifndef SHIBSP_LITE + log.info( + "Library versions: Xerces-C %s, XML-Security-C %s, XMLTooling-C %s, OpenSAML-C %s, Shibboleth %s", + XERCES_FULLVERSIONDOT, XSEC_FULLVERSIONDOT, XMLTOOLING_FULLVERSIONDOT, OPENSAML_FULLVERSIONDOT, SHIBSP_FULLVERSIONDOT + ); +#else + log.info( + "Library versions: Xerces-C %s, XMLTooling-C %s, Shibboleth %s", + XERCES_FULLVERSIONDOT, XMLTOOLING_FULLVERSIONDOT, SHIBSP_FULLVERSIONDOT + ); +#endif + // First load any property sets. - load(e,log,this); + load(e,nullptr,this); - const DOMElement* child; + DOMElement* child; string plugtype; // Much of the processing can only occur on the first instantiation. @@ -1196,7 +1328,25 @@ XMLConfigImpl::XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* o // Set clock skew. pair skew=getUnsignedInt("clockSkew"); if (skew.first) - xmlConf.clock_skew_secs=skew.second; + xmlConf.clock_skew_secs=min(skew.second,(60*60*24*7*28)); + + pair unsafe = getString("unsafeChars"); + if (unsafe.first) + TemplateEngine::unsafe_chars = unsafe.second; + + unsafe = getString("allowedSchemes"); + if (unsafe.first) { + HTTPResponse::getAllowedSchemes().clear(); + string schemes=unsafe.second; + unsigned int j_sch=0; + for (unsigned int i_sch=0; i_sch < schemes.length(); i_sch++) { + if (schemes.at(i_sch)==' ') { + HTTPResponse::getAllowedSchemes().push_back(schemes.substr(j_sch, i_sch-j_sch)); + j_sch = i_sch + 1; + } + } + HTTPResponse::getAllowedSchemes().push_back(schemes.substr(j_sch, schemes.length()-j_sch)); + } // Extensions doExtensions(e, "global", log); @@ -1205,33 +1355,28 @@ XMLConfigImpl::XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* o if (conf.isEnabled(SPConfig::InProcess)) doExtensions(SHIRE, "in process", log); - + // Instantiate the ListenerService and SessionCache objects. if (conf.isEnabled(SPConfig::Listener)) { - child=XMLHelper::getFirstChildElement(SHAR,UnixListener); + child=XMLHelper::getFirstChildElement(e,UnixListener); if (child) plugtype=UNIX_LISTENER_SERVICE; else { - child=XMLHelper::getFirstChildElement(SHAR,TCPListener); + child=XMLHelper::getFirstChildElement(e,TCPListener); if (child) plugtype=TCP_LISTENER_SERVICE; else { - child=XMLHelper::getFirstChildElement(SHAR,MemoryListener); - if (child) - plugtype=MEMORY_LISTENER_SERVICE; - else { - child=XMLHelper::getFirstChildElement(SHAR,Listener); - if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); - if (type.get()) - plugtype=type.get(); - } + child=XMLHelper::getFirstChildElement(e,Listener); + if (child) { + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); + if (type.get()) + plugtype=type.get(); } } } if (child) { log.info("building ListenerService of type %s...", plugtype.c_str()); - m_outer->m_listener = conf.ListenerServiceManager.newPlugin(plugtype.c_str(),child); + m_outer->m_listener = conf.ListenerServiceManager.newPlugin(plugtype.c_str(), child); } else { log.fatal("can't build ListenerService, missing conf:Listener element?"); @@ -1239,176 +1384,171 @@ XMLConfigImpl::XMLConfigImpl(const DOMElement* e, bool first, const XMLConfig* o } } +#ifndef SHIBSP_LITE if (m_outer->m_listener && conf.isEnabled(SPConfig::OutOfProcess) && !conf.isEnabled(SPConfig::InProcess)) { - m_outer->m_listener->regListener("set::RelayState",m_outer->m_listener); - m_outer->m_listener->regListener("get::RelayState",m_outer->m_listener); + m_outer->m_listener->regListener("set::RelayState", const_cast(m_outer)); + m_outer->m_listener->regListener("get::RelayState", const_cast(m_outer)); + m_outer->m_listener->regListener("set::PostData", const_cast(m_outer)); + m_outer->m_listener->regListener("get::PostData", const_cast(m_outer)); } +#endif if (conf.isEnabled(SPConfig::Caching)) { if (conf.isEnabled(SPConfig::OutOfProcess)) { #ifndef SHIBSP_LITE // First build any StorageServices. - string inmemID; - child=XMLHelper::getFirstChildElement(SHAR,_StorageService); + child=XMLHelper::getFirstChildElement(e,_StorageService); while (child) { - auto_ptr_char id(child->getAttributeNS(NULL,_id)); - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + auto_ptr_char id(child->getAttributeNS(nullptr,_id)); + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); try { log.info("building StorageService (%s) of type %s...", id.get(), type.get()); m_outer->m_storage[id.get()] = xmlConf.StorageServiceManager.newPlugin(type.get(),child); - if (!strcmp(type.get(),MEMORY_STORAGE_SERVICE)) - inmemID = id.get(); } catch (exception& ex) { log.crit("failed to instantiate StorageService (%s): %s", id.get(), ex.what()); } child=XMLHelper::getNextSiblingElement(child,_StorageService); } - - child=XMLHelper::getFirstChildElement(SHAR,_SessionCache); - if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); - log.info("building SessionCache of type %s...",type.get()); - m_outer->m_sessionCache=conf.SessionCacheManager.newPlugin(type.get(),child); - } - else { - log.warn("SessionCache unspecified, building SessionCache of type %s...",STORAGESERVICE_SESSION_CACHE); - if (inmemID.empty()) { - inmemID = "memory"; - log.info("no StorageServices configured, providing in-memory version for session cache"); - m_outer->m_storage[inmemID] = xmlConf.StorageServiceManager.newPlugin(MEMORY_STORAGE_SERVICE,NULL); - } - child = e->getOwnerDocument()->createElementNS(NULL,_SessionCache); - auto_ptr_XMLCh ssid(inmemID.c_str()); - const_cast(child)->setAttributeNS(NULL,_StorageService,ssid.get()); - m_outer->m_sessionCache=conf.SessionCacheManager.newPlugin(STORAGESERVICE_SESSION_CACHE,child); - } // Replay cache. - StorageService* replaySS=NULL; - child=XMLHelper::getFirstChildElement(SHAR,_ReplayCache); + StorageService* replaySS=nullptr; + child=XMLHelper::getFirstChildElement(e,_ReplayCache); if (child) { - auto_ptr_char ssid(child->getAttributeNS(NULL,_StorageService)); + auto_ptr_char ssid(child->getAttributeNS(nullptr,_StorageService)); if (ssid.get() && *ssid.get()) { if (m_outer->m_storage.count(ssid.get())) replaySS = m_outer->m_storage[ssid.get()]; if (replaySS) log.info("building ReplayCache on top of StorageService (%s)...", ssid.get()); else - log.crit("unable to locate StorageService (%s) in configuration", ssid.get()); + log.warn("unable to locate StorageService (%s) for ReplayCache, using dedicated in-memory instance", ssid.get()); } + xmlConf.setReplayCache(new ReplayCache(replaySS)); } - if (!replaySS) { - log.info("building ReplayCache using in-memory StorageService..."); - if (inmemID.empty()) { - inmemID = "memory"; - log.info("no StorageServices configured, providing in-memory version for legacy config"); - m_outer->m_storage[inmemID] = xmlConf.StorageServiceManager.newPlugin(MEMORY_STORAGE_SERVICE,NULL); - } - replaySS = m_outer->m_storage[inmemID]; + else { + log.warn("no ReplayCache built, missing conf:ReplayCache element?"); } - xmlConf.setReplayCache(new ReplayCache(replaySS)); - + // ArtifactMap - child=XMLHelper::getFirstChildElement(SHAR,_ArtifactMap); + child=XMLHelper::getFirstChildElement(e,_ArtifactMap); if (child) { - auto_ptr_char ssid(child->getAttributeNS(NULL,_StorageService)); + auto_ptr_char ssid(child->getAttributeNS(nullptr,_StorageService)); if (ssid.get() && *ssid.get() && m_outer->m_storage.count(ssid.get())) { log.info("building ArtifactMap on top of StorageService (%s)...", ssid.get()); samlConf.setArtifactMap(new ArtifactMap(child, m_outer->m_storage[ssid.get()])); } } - if (samlConf.getArtifactMap()==NULL) { + if (samlConf.getArtifactMap()==nullptr) { log.info("building in-memory ArtifactMap..."); samlConf.setArtifactMap(new ArtifactMap(child)); } #endif } + child=XMLHelper::getFirstChildElement(e,_SessionCache); + if (child) { + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); + log.info("building SessionCache of type %s...",type.get()); + m_outer->m_sessionCache=conf.SessionCacheManager.newPlugin(type.get(), child); + } else { - child=XMLHelper::getFirstChildElement(SHIRE,_SessionCache); - if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); - log.info("building SessionCache of type %s...",type.get()); - m_outer->m_sessionCache=conf.SessionCacheManager.newPlugin(type.get(),child); - } - else { - log.warn("SessionCache unspecified, building SessionCache of type %s...",REMOTED_SESSION_CACHE); - m_outer->m_sessionCache=conf.SessionCacheManager.newPlugin(REMOTED_SESSION_CACHE,child); - } + log.fatal("can't build SessionCache, missing conf:SessionCache element?"); + throw ConfigurationException("Can't build SessionCache, missing conf:SessionCache element?"); } } } // end of first-time-only stuff - + // Back to the fully dynamic stuff...next up is the RequestMapper. if (conf.isEnabled(SPConfig::RequestMapping)) { - child=XMLHelper::getFirstChildElement(SHIRE,_RequestMapper); - if (child) { - auto_ptr_char type(child->getAttributeNS(NULL,_type)); + if (child = XMLHelper::getFirstChildElement(e,_RequestMapper)) { + auto_ptr_char type(child->getAttributeNS(nullptr,_type)); log.info("building RequestMapper of type %s...",type.get()); m_requestMapper=conf.RequestMapperManager.newPlugin(type.get(),child); } + else { + log.fatal("can't build RequestMapper, missing conf:RequestMapper element?"); + throw ConfigurationException("Can't build RequestMapper, missing conf:RequestMapper element?"); + } } - + #ifndef SHIBSP_LITE // Load security policies. - child = XMLHelper::getLastChildElement(e,SecurityPolicies); - if (child) { - PolicyNodeFilter filter; - child = XMLHelper::getFirstChildElement(child,Policy); - while (child) { - auto_ptr_char id(child->getAttributeNS(NULL,_id)); - pair< PropertySet*,vector >& rules = m_policyMap[id.get()]; - rules.first = NULL; - auto_ptr settings(new DOMPropertySet()); - settings->load(child, log, &filter); - rules.first = settings.release(); - const DOMElement* rule = XMLHelper::getFirstChildElement(child,Rule); - while (rule) { - auto_ptr_char type(rule->getAttributeNS(NULL,_type)); - try { - rules.second.push_back(samlConf.SecurityPolicyRuleManager.newPlugin(type.get(),rule)); - } - catch (exception& ex) { - log.crit("error instantiating policy rule (%s) in policy (%s): %s", type.get(), id.get(), ex.what()); - } - rule = XMLHelper::getNextSiblingElement(rule,Rule); + if (child = XMLHelper::getLastChildElement(e, SecurityPolicyProvider)) { + auto_ptr_char type(child->getAttributeNS(nullptr, _type)); + log.info("building SecurityPolicyProvider of type %s...", type.get()); + m_policy = conf.SecurityPolicyProviderManager.newPlugin(type.get(), child); + } + else if (child = XMLHelper::getLastChildElement(e, SecurityPolicies)) { + // For backward compatibility, wrap in a plugin element. + DOMElement* polwrapper = e->getOwnerDocument()->createElementNS(nullptr, SecurityPolicyProvider); + polwrapper->appendChild(child); + log.info("building SecurityPolicyProvider of type %s...", XML_SECURITYPOLICY_PROVIDER); + m_policy = conf.SecurityPolicyProviderManager.newPlugin(XML_SECURITYPOLICY_PROVIDER, polwrapper); + } + else { + log.fatal("can't build SecurityPolicyProvider, missing conf:SecurityPolicyProvider element?"); + throw ConfigurationException("Can't build SecurityPolicyProvider, missing conf:SecurityPolicyProvider element?"); + } + + if (first) { +#ifdef SHIBSP_XMLSEC_WHITELISTING + vector::const_iterator alg; + if (!m_policy->getAlgorithmBlacklist().empty()) { + for (alg = m_policy->getAlgorithmBlacklist().begin(); alg != m_policy->getAlgorithmBlacklist().end(); ++alg) + XSECPlatformUtils::blacklistAlgorithm(alg->c_str()); + } + else if (!m_policy->getAlgorithmWhitelist().empty()) { + for (alg = m_policy->getAlgorithmWhitelist().begin(); alg != m_policy->getAlgorithmWhitelist().end(); ++alg) + XSECPlatformUtils::whitelistAlgorithm(alg->c_str()); + } +#else + log.fatal("XML-Security-C library prior to 1.6.0 does not support algorithm white/blacklists"); + throw ConfigurationException("XML-Security-C library prior to 1.6.0 does not support algorithm white/blacklists."); +#endif + } + + // Process TransportOption elements. + child = XMLHelper::getLastChildElement(e,TransportOption); + while (child) { + if (child->hasChildNodes()) { + auto_ptr_char provider(child->getAttributeNS(nullptr,_provider)); + auto_ptr_char option(child->getAttributeNS(nullptr,_option)); + auto_ptr_char value(child->getFirstChild()->getNodeValue()); + if (provider.get() && *provider.get() && option.get() && *option.get() && value.get() && *value.get()) { + m_transportOptions.push_back(make_pair(string(provider.get()), make_pair(string(option.get()), string(value.get())))); } - child = XMLHelper::getNextSiblingElement(child,Policy); } + child = XMLHelper::getPreviousSiblingElement(child,TransportOption); } #endif // Load the default application. This actually has a fixed ID of "default". ;-) - child=XMLHelper::getLastChildElement(e,Applications); + child=XMLHelper::getLastChildElement(e,ApplicationDefaults); if (!child) { - log.fatal("can't build default Application object, missing conf:Applications element?"); - throw ConfigurationException("can't build default Application object, missing conf:Applications element?"); + log.fatal("can't build default Application object, missing conf:ApplicationDefaults element?"); + throw ConfigurationException("can't build default Application object, missing conf:ApplicationDefaults element?"); } XMLApplication* defapp=new XMLApplication(m_outer,child); m_appmap[defapp->getId()]=defapp; - + // Load any overrides. - child = XMLHelper::getFirstChildElement(child,_Application); + child = XMLHelper::getFirstChildElement(child,ApplicationOverride); while (child) { auto_ptr iapp(new XMLApplication(m_outer,child,defapp)); if (m_appmap.count(iapp->getId())) - log.crit("found conf:Application element with duplicate id attribute (%s), skipping it", iapp->getId()); - else - m_appmap[iapp->getId()]=iapp.release(); + log.crit("found conf:ApplicationOverride element with duplicate id attribute (%s), skipping it", iapp->getId()); + else { + const char* iappid=iapp->getId(); + m_appmap[iappid]=iapp.release(); + } - child = XMLHelper::getNextSiblingElement(child,_Application); + child = XMLHelper::getNextSiblingElement(child,ApplicationOverride); } } catch (exception&) { cleanup(); throw; } -#ifndef _DEBUG - catch (...) { - cleanup(); - throw; - } -#endif } XMLConfigImpl::~XMLConfigImpl() @@ -1421,22 +1561,19 @@ void XMLConfigImpl::cleanup() for_each(m_appmap.begin(),m_appmap.end(),cleanup_pair()); m_appmap.clear(); #ifndef SHIBSP_LITE - for (map< string,pair > >::iterator i=m_policyMap.begin(); i!=m_policyMap.end(); ++i) { - delete i->second.first; - for_each(i->second.second.begin(), i->second.second.end(), xmltooling::cleanup()); - } - m_policyMap.clear(); + delete m_policy; + m_policy = nullptr; #endif delete m_requestMapper; - m_requestMapper = NULL; + m_requestMapper = nullptr; if (m_document) m_document->release(); - m_document = NULL; + m_document = nullptr; } +#ifndef SHIBSP_LITE void XMLConfig::receive(DDF& in, ostream& out) { -#ifndef SHIBSP_LITE if (!strcmp(in.name(), "get::RelayState")) { const char* id = in["id"].string(); const char* key = in["key"].string(); @@ -1458,7 +1595,7 @@ void XMLConfig::receive(DDF& in, ostream& out) } // Repack for return to caller. - DDF ret=DDF(NULL).string(relayState.c_str()); + DDF ret=DDF(nullptr).unsafe_string(relayState.c_str()); DDFJanitor jret(ret); out << ret; } @@ -1473,7 +1610,7 @@ void XMLConfig::receive(DDF& in, ostream& out) if (storage) { SAMLConfig::getConfig().generateRandomBytes(rsKey,20); rsKey = SAMLArtifact::toHex(rsKey); - storage->createString("RelayState", rsKey.c_str(), value, time(NULL) + 600); + storage->createString("RelayState", rsKey.c_str(), value, time(nullptr) + 600); } else { Category::getInstance(SHIBSP_LOGCAT".ServiceProvider").error( @@ -1482,28 +1619,86 @@ void XMLConfig::receive(DDF& in, ostream& out) } // Repack for return to caller. - DDF ret=DDF(NULL).string(rsKey.c_str()); + DDF ret=DDF(nullptr).string(rsKey.c_str()); + DDFJanitor jret(ret); + out << ret; + } + else if (!strcmp(in.name(), "get::PostData")) { + const char* id = in["id"].string(); + const char* key = in["key"].string(); + if (!id || !key) + throw ListenerException("Required parameters missing for PostData recovery."); + + string postData; + StorageService* storage = getStorageService(id); + if (storage) { + if (storage->readString("PostData",key,&postData) > 0) { + storage->deleteString("PostData",key); + } + } + else { + Category::getInstance(SHIBSP_LOGCAT".ServiceProvider").error( + "Storage-backed PostData with invalid StorageService ID (%s)", id + ); + } + // If the data's empty, we'll send nothing back. + // If not, we don't need to round trip it, just send back the serialized DDF list. + if (postData.empty()) { + DDF ret(nullptr); + DDFJanitor jret(ret); + out << ret; + } + else { + out << postData; + } + } + else if (!strcmp(in.name(), "set::PostData")) { + const char* id = in["id"].string(); + if (!id || !in["parameters"].islist()) + throw ListenerException("Required parameters missing for PostData creation."); + + string rsKey; + StorageService* storage = getStorageService(id); + if (storage) { + SAMLConfig::getConfig().generateRandomBytes(rsKey,20); + rsKey = SAMLArtifact::toHex(rsKey); + ostringstream params; + params << in["parameters"]; + storage->createString("PostData", rsKey.c_str(), params.str().c_str(), time(nullptr) + 600); + } + else { + Category::getInstance(SHIBSP_LOGCAT".ServiceProvider").error( + "Storage-backed PostData with invalid StorageService ID (%s)", id + ); + } + + // Repack for return to caller. + DDF ret=DDF(nullptr).string(rsKey.c_str()); DDFJanitor jret(ret); out << ret; } -#endif } +#endif -pair XMLConfig::load() +pair XMLConfig::background_load() { // Load from source using base class. pair raw = ReloadableXMLFile::load(); - + // If we own it, wrap it. - XercesJanitor docjanitor(raw.first ? raw.second->getOwnerDocument() : NULL); + XercesJanitor docjanitor(raw.first ? raw.second->getOwnerDocument() : nullptr); + + XMLConfigImpl* impl = new XMLConfigImpl(raw.second, (m_impl==nullptr), this, m_log); - XMLConfigImpl* impl = new XMLConfigImpl(raw.second,(m_impl==NULL),this,m_log); - // If we held the document, transfer it to the impl. If we didn't, it's a no-op. impl->setDocument(docjanitor.release()); + // Perform the swap inside a lock. + if (m_lock) + m_lock->wrlock(); + SharedLock locker(m_lock, false); delete m_impl; m_impl = impl; - return make_pair(false,(DOMElement*)NULL); + return make_pair(false,(DOMElement*)nullptr); }