This fixes the following messages of cppcheck:
[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:290]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:492]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:573]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_passwd/rlm_passwd.c:284]: (style) Variable 'len' is assigned a value that is never used.
struct mypasswd * passwd;
struct mypasswd * hashentry;
char buffer[1024];
struct mypasswd * passwd;
struct mypasswd * hashentry;
char buffer[1024];
char *list, *nextlist;
if (ht->tablesize > 0) {
char *list, *nextlist;
if (ht->tablesize > 0) {
passwd = (struct mypasswd *) ht->buffer;
while (fgets(buffer, 1024,ht->fp)) {
passwd = (struct mypasswd *) ht->buffer;
while (fgets(buffer, 1024,ht->fp)) {
- if(*buffer && *buffer!='\n' && (len = string_to_entry(buffer, ht->nfields, ht->delimiter, passwd, sizeof(ht->buffer)-1)) &&
+ if(*buffer && *buffer!='\n' && string_to_entry(buffer, ht->nfields, ht->delimiter, passwd, sizeof(ht->buffer)-1) &&
(!ht->ignorenis || (*buffer !='-' && *buffer != '+') ) ){
if(!ht->islist) {
if(!strcmp(passwd->field[ht->keyfield], name))
(!ht->ignorenis || (*buffer !='-' && *buffer != '+') ) ){
if(!ht->islist) {
if(!strcmp(passwd->field[ht->keyfield], name))
{
rlm_sql_freetds_conn_t *conn = handle->conn;
{
rlm_sql_freetds_conn_t *conn = handle->conn;
- CS_RETCODE ret, results_ret;
+ CS_RETCODE results_ret;
CS_INT result_type;
if (ct_cmd_alloc(conn->db, &conn->command) != CS_SUCCEED) {
CS_INT result_type;
if (ct_cmd_alloc(conn->db, &conn->command) != CS_SUCCEED) {
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
- if ((ret = ct_cancel(NULL, conn->command, CS_CANCEL_ALL)) == CS_FAIL) {
+ if (ct_cancel(NULL, conn->command, CS_CANCEL_ALL) == CS_FAIL) {
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
switch (results_ret) {
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
switch (results_ret) {
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
- if ((ret = ct_cancel(NULL, conn->command, CS_CANCEL_ALL)) == CS_FAIL) {
+ if (ct_cancel(NULL, conn->command, CS_CANCEL_ALL) == CS_FAIL) {
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
switch (results_ret) {
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
switch (results_ret) {
case CS_FAIL: /* Serious failure, freetds requires us to cancel and maybe even close db */
ERROR("rlm_sql_freetds: failure retrieving query results");
- if ((ret = ct_cancel(NULL, conn->command, CS_CANCEL_ALL)) == CS_FAIL) {
+ if (ct_cancel(NULL, conn->command, CS_CANCEL_ALL) == CS_FAIL) {
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
INFO("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
{
rlm_sql_freetds_conn_t *conn = handle->conn;
{
rlm_sql_freetds_conn_t *conn = handle->conn;
- CS_RETCODE ret, results_ret;
+ CS_RETCODE results_ret;
CS_INT result_type;
CS_DATAFMT descriptor;
CS_INT result_type;
CS_DATAFMT descriptor;
ERROR("rlm_sql_freetds: failure retrieving query results");
ERROR("rlm_sql_freetds: failure retrieving query results");
- if ((ret = ct_cancel(NULL, conn->command, CS_CANCEL_ALL)) == CS_FAIL) {
+ if (ct_cancel(NULL, conn->command, CS_CANCEL_ALL) == CS_FAIL) {
ERROR("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
ERROR("rlm_sql_freetds: cleaning up");
return RLM_SQL_RECONNECT;
* Serious failure, freetds requires us to cancel the results and maybe even close the db.
*/
ERROR("rlm_sql_freetds: failure fetching row data");
* Serious failure, freetds requires us to cancel the results and maybe even close the db.
*/
ERROR("rlm_sql_freetds: failure fetching row data");
- if ((ret = ct_cancel(NULL, conn->command, CS_CANCEL_ALL)) == CS_FAIL) {
+ if (ct_cancel(NULL, conn->command, CS_CANCEL_ALL) == CS_FAIL) {
ERROR("rlm_sql_freetds: cleaning up");
} else {
conn->command = NULL;
ERROR("rlm_sql_freetds: cleaning up");
} else {
conn->command = NULL;