Quiet the compiler
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 22 Aug 2012 17:40:36 +0000 (18:40 +0100)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 22 Aug 2012 17:43:09 +0000 (18:43 +0100)
src/modules/rlm_sql/sql.c

index f4a7aed..ce576c8 100644 (file)
@@ -429,13 +429,15 @@ void rlm_sql_query_log(SQL_INST *inst, REQUEST *request,
 
        fd = open(filename, O_WRONLY | O_APPEND | O_CREAT, 0666);
        if (fd < 0) {
-               radlog(L_ERR, "rlm_sql (%s): Couldn't open file %s: %s",
+               radlog(L_ERR, "rlm_sql (%s): Couldn't open logfile %s: %s",
                       inst->config->xlat_name, buffer, strerror(errno));
                return;
        }
 
        rad_lockfd(fd, MAX_QUERY_LEN);
-       write(fd, query, strlen(query));
-       write(fd, ";\n", 2);
+       if ((write(fd, query, strlen(query) < 0) || (write(fd, ";\n", 2) < 0)))
+               radlog(L_ERR, "rlm_sql (%s): Failed writing to logfile %s: %s",
+                      inst->config->xlat_name, buffer, strerror(errno));
+
        close(fd);              /* and release the lock */
 }