EAP-TLS: Merge common error paths
authorJouni Malinen <j@w1.fi>
Sun, 20 Dec 2015 15:25:04 +0000 (17:25 +0200)
committerJouni Malinen <j@w1.fi>
Sun, 20 Dec 2015 15:25:41 +0000 (17:25 +0200)
There is no need to keep these identical error paths separate.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/eap_peer/eap_tls_common.c

index 4b994fd..67a0956 100644 (file)
@@ -356,10 +356,8 @@ u8 * eap_peer_tls_derive_session_id(struct eap_sm *sm,
        struct tls_random keys;
        u8 *out;
 
-       if (tls_connection_get_random(sm->ssl_ctx, data->conn, &keys))
-               return NULL;
-
-       if (keys.client_random == NULL || keys.server_random == NULL)
+       if (tls_connection_get_random(sm->ssl_ctx, data->conn, &keys) ||
+           keys.client_random == NULL || keys.server_random == NULL)
                return NULL;
 
        *len = 1 + keys.client_random_len + keys.server_random_len;