Use %u in sprintf when printing unsigned integers

This fixes the following messages of cppcheck:

[src/modules/rlm_eap/libeap/eapcrypto.c:108]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:119]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:126]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:133]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_detail/rlm_detail.c:236]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
index ecaaeef..8ee246d 100644 (file)
--- a/src/modules/rlm_detail/rlm_detail.c
+++ b/src/modules/rlm_detail/rlm_detail.c
@@ -233,7 +233,7 @@ static int detail_write(FILE *out, detail_instance_t *inst, REQUEST *request, RA
                if (is_radius_code(packet->code)) {
                        WRITE("\tPacket-Type = %s\n", fr_packet_codes[packet->code]);
                } else {
-                       WRITE("\tPacket-Type = %d\n", packet->code);
+                       WRITE("\tPacket-Type = %u\n", packet->code);
                }
        }
 

diff --git a/src/modules/rlm_eap/libeap/eapcrypto.c b/src/modules/rlm_eap/libeap/eapcrypto.c
index 95fa1e3..9c1c06d 100644 (file)
--- a/src/modules/rlm_eap/libeap/eapcrypto.c
+++ b/src/modules/rlm_eap/libeap/eapcrypto.c
@@ -105,7 +105,7 @@ void eapsim_dump_mk(struct eapsim_keys *ek)
        unsigned int i, j, k;
 
        printf("Input was: \n");
-       printf("   identity: (len=%d)", ek->identitylen);
+       printf("   identity: (len=%u)", ek->identitylen);
        for (i = 0; i < ek->identitylen; i++) {
                printf("%02x", ek->identity[i]);
        }
@@ -116,21 +116,21 @@ void eapsim_dump_mk(struct eapsim_keys *ek)
        }
 
        for (k = 0; k<3; k++) {
-               printf("\n   rand%d: ", k);
+               printf("\n   rand%u: ", k);
                for (i = 0; i < EAPSIM_RAND_SIZE; i++) {
                        printf("%02x", ek->rand[k][i]);
                }
        }
 
        for (k = 0; k<3; k++) {
-               printf("\n   sres%d: ", k);
+               printf("\n   sres%u: ", k);
                for (i = 0; i < EAPSIM_SRES_SIZE; i++) {
                        printf("%02x", ek->sres[k][i]);
                }
        }
 
        for (k = 0; k<3; k++) {
-               printf("\n   Kc%d: ", k);
+               printf("\n   Kc%u: ", k);
                for (i = 0; i < EAPSIM_KC_SIZE; i++) {
                        printf("%02x", ek->Kc[k][i]);
                }