GAS server: Explicitly check that home realm is available
authorJouni Malinen <j@w1.fi>
Sat, 7 Jun 2014 16:05:33 +0000 (19:05 +0300)
committerJouni Malinen <j@w1.fi>
Sat, 7 Jun 2014 16:05:33 +0000 (19:05 +0300)
This makes the code easier to understand for static analyzers to avoid
false reports.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/ap/gas_serv.c

index 53e11dd..52d1b24 100644 (file)
@@ -414,7 +414,7 @@ static void anqp_add_nai_realm(struct hostapd_data *hapd, struct wpabuf *buf,
                        gas_anqp_set_element_len(buf, realm_data_len);
                }
                gas_anqp_set_element_len(buf, len);
-       } else if (nai_home_realm && hapd->conf->nai_realm_data) {
+       } else if (nai_home_realm && hapd->conf->nai_realm_data && home_realm) {
                hs20_add_nai_home_realm_matches(hapd, buf, home_realm,
                                                home_realm_len);
        }