WPS: Use strdup to initialize dev_password for PBC
authorJouni Malinen <j@w1.fi>
Thu, 17 Nov 2011 17:58:33 +0000 (19:58 +0200)
committerJouni Malinen <j@w1.fi>
Thu, 17 Nov 2011 17:58:33 +0000 (19:58 +0200)
Some static analyzers complain about memset with '0' value. This was
used correctly here, but since use of strdup is about as good an option,
use that to silence the invalid warnings.

Signed-hostap: Jouni Malinen <j@w1.fi>

src/wps/wps.c

index 9413ece..2ba3d4b 100644 (file)
@@ -67,12 +67,11 @@ struct wps_data * wps_init(const struct wps_config *cfg)
                /* Use special PIN '00000000' for PBC */
                data->dev_pw_id = DEV_PW_PUSHBUTTON;
                os_free(data->dev_password);
-               data->dev_password = os_malloc(8);
+               data->dev_password = (u8 *) os_strdup("00000000");
                if (data->dev_password == NULL) {
                        os_free(data);
                        return NULL;
                }
-               os_memset(data->dev_password, '0', 8);
                data->dev_password_len = 8;
        }