sprintf -> snprintf

diff --git a/src/lib/valuepair.c b/src/lib/valuepair.c
index 1915d71..56cb386 100644 (file)
--- a/src/lib/valuepair.c
+++ b/src/lib/valuepair.c
@@ -121,18 +121,20 @@ VALUE_PAIR *paircreate(int attr, int type)
         */
        if (!da) {
                if (VENDOR(attr) == 0) {
-                       sprintf(vp->name, "Attr-%u", attr);
+                       snprintf(vp->name, sizeof(vp->name), "Attr-%u", attr);
 
                } else {
                        DICT_VENDOR *v;
 
                        v = dict_vendorbyvalue(VENDOR(attr));
                        if (v) {
-                               sprintf(vp->name, "%s-Attr-%u",
-                                       v->name, attr & 0xffff);
+                               snprintf(vp->name, sizeof(vp->name),
+                                        "%s-Attr-%u",
+                                        v->name, attr & 0xffff);
                        } else {
-                               sprintf(vp->name, "Vendor-%u-Attr-%u",
-                                       VENDOR(attr), attr & 0xffff);
+                               snprintf(vp->name, sizeof(vp->name),
+                                        "Vendor-%u-Attr-%u",
+                                        VENDOR(attr), attr & 0xffff);
                        }
                }
                vp->type = type;

diff --git a/src/main/event.c b/src/main/event.c
index b044d7a..7eceaa2 100644 (file)
--- a/src/main/event.c
+++ b/src/main/event.c
@@ -1263,7 +1263,8 @@ static int successfully_proxied_request(REQUEST *request)
         */
        vp = radius_paircreate(request, &request->proxy->vps,
                               PW_PROXY_STATE, PW_TYPE_OCTETS);
-       sprintf(vp->vp_strvalue, "%d", request->packet->id);
+       snprintf(vp->vp_strvalue, sizeof(vp->vp_strvalue), "%d",
+                request->packet->id);
        vp->length = strlen(vp->vp_strvalue);
 
        /*

diff --git a/src/modules/rlm_eap/libeap/tls.c b/src/modules/rlm_eap/libeap/tls.c
index 99d21dd..711b7ad 100644 (file)
--- a/src/modules/rlm_eap/libeap/tls.c
+++ b/src/modules/rlm_eap/libeap/tls.c
@@ -550,8 +550,11 @@ void tls_session_information(tls_session_t *tls_session)
                }
        }
 
-       sprintf(tls_session->info.info_description, "%s %s%s [length %04lx]%s%s\n",
-               str_write_p, str_version, str_content_type,
-               (unsigned long)tls_session->info.record_len, str_details1, str_details2);
+       snprintf(tls_session->info.info_description, 
+                sizeof(tls_session->info.info_description),
+                "%s %s%s [length %04lx]%s%s\n",
+                str_write_p, str_version, str_content_type,
+                (unsigned long)tls_session->info.record_len,
+                str_details1, str_details2);
        DEBUG2("  rlm_eap_tls: %s\n", tls_session->info.info_description);
 }

diff --git a/src/modules/rlm_pap/rlm_pap.c b/src/modules/rlm_pap/rlm_pap.c
index a1184b6..f37f96b 100644 (file)
--- a/src/modules/rlm_pap/rlm_pap.c
+++ b/src/modules/rlm_pap/rlm_pap.c
@@ -706,7 +706,7 @@ static int pap_authenticate(void *instance, REQUEST *request)
                        goto make_msg;
                }
 
-               sprintf(buff2,"%%{mschap:NT-Hash %s}",
+               snprintf(buff2, sizeof(buff2), "%%{mschap:NT-Hash %s}",
                        request->password->vp_strvalue);
                if (!radius_xlat(digest,sizeof(digest),buff2,request,NULL)){
                        DEBUG("rlm_pap: mschap xlat failed");
@@ -731,7 +731,7 @@ static int pap_authenticate(void *instance, REQUEST *request)
                        snprintf(module_fmsg,sizeof(module_fmsg),"rlm_pap: Configured LM-Password has incorrect length");
                        goto make_msg;
                }
-               sprintf(buff2,"%%{mschap:LM-Hash %s}",
+               snprintf(buff2, sizeof(buff2), "%%{mschap:LM-Hash %s}",
                        request->password->vp_strvalue);
                if (!radius_xlat(digest,sizeof(digest),buff2,request,NULL)){
                        DEBUG("rlm_pap: mschap xlat failed");