No need to sprintf "%s"

Use strlcpy instead

diff --git a/src/modules/rlm_ldap/rlm_ldap.c b/src/modules/rlm_ldap/rlm_ldap.c
index 5c1f4ab..3caa97c 100644 (file)
--- a/src/modules/rlm_ldap/rlm_ldap.c
+++ b/src/modules/rlm_ldap/rlm_ldap.c
@@ -1076,8 +1076,8 @@ static int ldap_groupcmp(void *instance, REQUEST *req,
 
        if (strchr((char *)check->vp_strvalue,',') != NULL) {
                /* This looks like a DN */
-               snprintf(filter,sizeof(filter), "%s",gr_filter);
-               snprintf(basedn,sizeof(basedn), "%s",(char *)check->vp_strvalue);
+               strlcpy(filter, gr_filter, sizeof(filter));
+               strlcpy(basedn, check->vp_strvalue, sizeof(basedn));
        } else
                snprintf(filter,sizeof(filter), "(&(%s=%s)%s)",
                         inst->groupname_attr,