mark arguments as UNUSED.

diff --git a/src/main/modcall.c b/src/main/modcall.c
index c5042df..ed8b290 100644 (file)
--- a/src/main/modcall.c
+++ b/src/main/modcall.c
@@ -355,7 +355,7 @@ static void dump_tree(int comp, modcallable *c)
        dump_mc(c, 0);
 }
 #else
-static void dump_tree(int comp, modcallable *c)
+static void dump_tree(int comp UNUSED, modcallable *c UNUSED)
 {
        return;
 }

diff --git a/src/main/radiusd.c b/src/main/radiusd.c
index e995713..67cb01d 100644 (file)
--- a/src/main/radiusd.c
+++ b/src/main/radiusd.c
@@ -1373,7 +1373,7 @@ static void rfc_clean(RADIUS_PACKET *packet)
 /*
  *  Lowercase the string value of a pair.
  */
-static int rad_lowerpair(REQUEST *request, VALUE_PAIR *vp) {
+static int rad_lowerpair(REQUEST *request UNUSED, VALUE_PAIR *vp) {
        if (vp == NULL) {
                return -1;
        }
@@ -1386,7 +1386,7 @@ static int rad_lowerpair(REQUEST *request, VALUE_PAIR *vp) {
 /*
  *  Remove spaces in a pair.
  */
-static int rad_rmspace_pair(REQUEST *request, VALUE_PAIR *vp) {
+static int rad_rmspace_pair(REQUEST *request UNUSED, VALUE_PAIR *vp) {
        if (vp == NULL) {
                return -1;
        }

diff --git a/src/main/valuepair.c b/src/main/valuepair.c
index 7fec870..6df3b50 100644 (file)
--- a/src/main/valuepair.c
+++ b/src/main/valuepair.c
@@ -383,8 +383,12 @@ int simplepaircmp(REQUEST *req, VALUE_PAIR *first, VALUE_PAIR *second)
 /*
  *     Compare a Connect-Info and a Connect-Rate
  */
-static int connectcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
-               VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
+static int connectcmp(void *instance,
+                     REQUEST *req UNUSED,
+                     VALUE_PAIR *request,
+                     VALUE_PAIR *check,
+                     VALUE_PAIR *check_pairs,
+                     VALUE_PAIR **reply_pairs)
 {
        int rate;
 
@@ -400,7 +404,8 @@ static int connectcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_P
 /*
  *     Compare a portno with a range.
  */
-static int portcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
+static int portcmp(void *instance,
+                  REQUEST *req UNUSED, VALUE_PAIR *request, VALUE_PAIR *check,
        VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
 {
        char buf[MAX_STRING_LEN];
@@ -446,7 +451,9 @@ static int portcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR
  *     - if PW_STRIP_USER_NAME is not present in check_pairs,
  *       add a PW_STRIPPED_USER_NAME to the request.
  */
-static int presufcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
+static int presufcmp(void *instance,
+                    REQUEST *req UNUSED,
+                    VALUE_PAIR *request, VALUE_PAIR *check,
        VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
 {
        VALUE_PAIR *vp;
@@ -516,7 +523,9 @@ static int presufcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PA
  *     do the comparison against when the packet came in, not now,
  *     and have one less system call to do.
  */
-static int timecmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
+static int timecmp(void *instance,
+                  REQUEST *req UNUSED, 
+                  VALUE_PAIR *request, VALUE_PAIR *check,
        VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
 {
        instance = instance;
@@ -539,8 +548,10 @@ static int timecmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR
  *     doing the lookup only ONCE, and storing the result
  *     in check->lvalue...
  */
-static int attrcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
-       VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
+static int attrcmp(void *instance,
+                  REQUEST *req UNUSED,
+                  VALUE_PAIR *request, VALUE_PAIR *check,
+                  VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
 {
        VALUE_PAIR *pair;
        DICT_ATTR  *dict;
@@ -575,7 +586,8 @@ static int attrcmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR
 /*
  *     Compare the expiration date.
  */
-static int expirecmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PAIR *check,
+static int expirecmp(void *instance, REQUEST *req UNUSED,
+                    VALUE_PAIR *request, VALUE_PAIR *check,
                     VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
 {
        time_t now;
@@ -590,7 +602,7 @@ static int expirecmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PA
         */
        now = time(NULL);
 
-       if (now <= check->lvalue) {
+       if (now <= (signed)check->lvalue) {
                return 0;
        }
 
@@ -600,9 +612,11 @@ static int expirecmp(void *instance, REQUEST *req, VALUE_PAIR *request, VALUE_PA
 /*
  *     Compare the request packet type.
  */
-static int packetcmp(void *instance, REQUEST *req, VALUE_PAIR *request,
+static int packetcmp(void *instance UNUSED, REQUEST *req,
+                    VALUE_PAIR *request UNUSED,
                     VALUE_PAIR *check,
-                    VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
+                    VALUE_PAIR *check_pairs UNUSED,
+                    VALUE_PAIR **reply_pairs UNUSED)
 {
        if (req->packet->code == check->lvalue) {
                return 0;
@@ -614,9 +628,12 @@ static int packetcmp(void *instance, REQUEST *req, VALUE_PAIR *request,
 /*
  *     Compare the response packet type.
  */
-static int responsecmp(void *instance, REQUEST *req, VALUE_PAIR *request,
-                    VALUE_PAIR *check,
-                    VALUE_PAIR *check_pairs, VALUE_PAIR **reply_pairs)
+static int responsecmp(void *instance UNUSED,
+                      REQUEST *req,
+                      VALUE_PAIR *request UNUSED,
+                      VALUE_PAIR *check,
+                      VALUE_PAIR *check_pairs UNUSED,
+                      VALUE_PAIR **reply_pairs UNUSED)
 {
        if (req->reply->code == check->lvalue) {
                return 0;