Don't allocate structure twice.

This fixes Coverity #78

diff --git a/src/modules/rlm_policy/parse.c b/src/modules/rlm_policy/parse.c
index 7fd74b3..ae201ab 100644 (file)
--- a/src/modules/rlm_policy/parse.c
+++ b/src/modules/rlm_policy/parse.c
@@ -1002,8 +1002,12 @@ static int parse_attribute_block(policy_lex_file_t *lexer,
        }
        memset(this, 0, sizeof(*this));
        this->item.type = POLICY_TYPE_ATTRIBUTE_LIST;
+       this->item.lineno = lexer->lineno;
+       this->where = where;
 
        token = policy_lex_file(lexer, 0, buffer, sizeof(buffer));
+       this->how = token;
+
        switch (token) {
        case POLICY_LEX_BEFORE_WHERE_EQUALS:
        case POLICY_LEX_AFTER_WHERE_EQUALS:
@@ -1030,14 +1034,6 @@ static int parse_attribute_block(policy_lex_file_t *lexer,
                return 0;       /* unknown */
        }
 
-       this = rad_malloc(sizeof(*this));
-       memset(this, 0, sizeof(*this));
-
-       this->item.type = POLICY_TYPE_ATTRIBUTE_LIST;
-       this->item.lineno = lexer->lineno;
-       this->where = where;
-       this->how = token;
-
        if (!parse_block(lexer, &(this->attributes))) {
                rlm_policy_free_item((policy_item_t *) this);
                return 0;