Use pairmove to add SQL-User-Name
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 4 Dec 2013 14:54:31 +0000 (14:54 +0000)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 4 Dec 2013 15:08:35 +0000 (15:08 +0000)
src/modules/rlm_sql/rlm_sql.c

index 84ab03e..d9d9fb3 100644 (file)
@@ -434,11 +434,11 @@ int sql_set_user(rlm_sql_t *inst, REQUEST *request, char const *username)
                talloc_free(expanded);
                return -1;
        }
-       pairstrsteal(vp, expanded);
-       vp->op = T_OP_SET;
-       pairadd(&request->packet->vps, vp);
 
        RDEBUG2("SQL-User-Name set to \"%s\"", vp->vp_strvalue);
+       pairstrsteal(vp, expanded);
+       vp->op = T_OP_SET;
+       pairmove(request, &request->packet->vps, &vp);  /* needs to be pair move else op is not respected */
 
        return 0;
 }