'exit 1' to 'exit $?', which is better

diff --git a/Makefile b/Makefile
index 119a3a0..fe2d9c8 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -62,7 +62,7 @@ install:
 common:
        @for dir in $(SUBDIRS); do \
                echo "Making $(WHAT_TO_MAKE) in $$dir..."; \
-               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1;\
+               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?;\
        done
 
 distclean: clean

diff --git a/doc/Makefile b/doc/Makefile
index 7edb262..937720f 100644 (file)
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -30,5 +30,5 @@ install:
 common:
        @for dir in $(SUBDIRS); do \
                echo "Making $(WHAT_TO_MAKE) in $$dir..."; \
-               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1;\
+               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?;\
        done

diff --git a/src/Makefile b/src/Makefile
index 19dee9c..09b70f7 100644 (file)
--- a/src/Makefile
+++ b/src/Makefile
@@ -22,6 +22,6 @@ install:
 common:
        @for dir in $(SUBDIRS); do \
                echo "Making $(WHAT_TO_MAKE) in $$dir..."; \
-               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1;\
+               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?;\
        done
 

diff --git a/src/modules/Makefile b/src/modules/Makefile
index 97ac8ff..8b2e84c 100644 (file)
--- a/src/modules/Makefile
+++ b/src/modules/Makefile
@@ -41,6 +41,6 @@ common:
                [ "$$what" = "all" ] && what="$(TARGET_LIBS)"; \
                if [ -d $$mod ] && [ -f $$mod/Makefile ]; then \
                        echo "Making $$what in $$mod..."; \
-                       (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit 1;\
+                       (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit $?;\
                fi; \
        done

diff --git a/src/modules/rlm_eap/Makefile.in b/src/modules/rlm_eap/Makefile.in
index 901baa8..5bc3922 100644 (file)
--- a/src/modules/rlm_eap/Makefile.in
+++ b/src/modules/rlm_eap/Makefile.in
@@ -26,7 +26,7 @@ all:
        @$(MAKE) $(MFLAGS) radeapclient
 
 radeapclient: radeapclient.o ../../lib/libradius.a
-       (cd libeap && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1
+       (cd libeap && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?
        $(LIBTOOL) --mode=link $(CC) $(CFLAGS) ${RLM_CFLAGS} $(LDFLAGS) -o radeapclient radeapclient.o $(CLIENTLIBS) $(LIBS) $(LCRYPT)
 
 radeapclient.o: radeapclient.c $(INCLUDES)
@@ -39,7 +39,7 @@ install-types:
 common:
        @for dir in $(RLM_SUBDIRS); do  \
                echo "Making $(WHAT_TO_MAKE) in $$dir..."; \
-               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1;\
+               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?;\
        done
 
 ## this uses the RLM_CFLAGS and RLM_LIBS and SRCS defs to make TARGET.

diff --git a/src/modules/rlm_eap/types/Makefile b/src/modules/rlm_eap/types/Makefile
index 99fae99..6dcdd52 100644 (file)
--- a/src/modules/rlm_eap/types/Makefile
+++ b/src/modules/rlm_eap/types/Makefile
@@ -21,7 +21,7 @@ common:
                [ "$$what" = "all" ] && what="$(TARGET_LIBS)"; \
                if [ -d $$mod ] && [ -f $$mod/Makefile ]; then \
                        echo "Making $$what in $$mod..."; \
-                       (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit 1; \
+                       (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit $?; \
                fi; \
        done
 

diff --git a/src/modules/rlm_sql/Makefile.in b/src/modules/rlm_sql/Makefile.in
index e1f1f98..fffdc9a 100644 (file)
--- a/src/modules/rlm_sql/Makefile.in
+++ b/src/modules/rlm_sql/Makefile.in
@@ -32,7 +32,7 @@ install-drivers:
 common: 
        @for dir in $(RLM_SUBDIRS); do \
                echo "Making $(WHAT_TO_MAKE) in $$dir..."; \
-               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit 1;\
+               (cd $$dir && $(MAKE) $(MFLAGS) $(WHAT_TO_MAKE)) || exit $?;\
        done
 
 include ../rules.mak

diff --git a/src/modules/rlm_sql/drivers/Makefile.in b/src/modules/rlm_sql/drivers/Makefile.in
index 3597884..372b09b 100644 (file)
--- a/src/modules/rlm_sql/drivers/Makefile.in
+++ b/src/modules/rlm_sql/drivers/Makefile.in
@@ -22,6 +22,6 @@ common:
                what=$(WHAT_TO_MAKE); \
                [ "$$what" = "all" ] && what="$(TARGET_LIBS)"; \
                echo "Making $$what in $$mod..."; \
-               (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit 1;\
+               (cd $$mod && $(MAKE) $(MFLAGS) $$what) || exit $?;\
        done