vp_print should add a "\n" to the end

All callers already do this, so it's best to move that code
into vp_print

diff --git a/src/lib/print.c b/src/lib/print.c
index 7ea155f..f22fd3c 100644 (file)
--- a/src/lib/print.c
+++ b/src/lib/print.c
@@ -479,6 +479,7 @@ void vp_print(FILE *fp, VALUE_PAIR *vp)
 
        vp_prints(buf, sizeof(buf), vp);
        fputs(buf, fp);
+       fputc('\n', fp);
 }
 
 
@@ -491,7 +492,6 @@ void vp_printlist(FILE *fp, VALUE_PAIR *vp)
        for (; vp; vp = vp->next) {
                fprintf(fp, "\t");
                vp_print(fp, vp);
-               fprintf(fp, "\n");
        }
 }
 

diff --git a/src/main/valuepair.c b/src/main/valuepair.c
index 601d212..a5c099d 100644 (file)
--- a/src/main/valuepair.c
+++ b/src/main/valuepair.c
@@ -740,7 +740,6 @@ void debug_pair(VALUE_PAIR *vp)
 
        fputc('\t', fr_log_fp);
        vp_print(fr_log_fp, vp);
-       fputc('\n', fr_log_fp);
 }
 
 void debug_pair_list(VALUE_PAIR *vp)
@@ -750,7 +749,6 @@ void debug_pair_list(VALUE_PAIR *vp)
        while (vp) {
                fputc('\t', fr_log_fp);
                vp_print(fr_log_fp, vp);
-               fputc('\n', fr_log_fp);
                vp = vp->next;
        }
        fflush(fr_log_fp);

diff --git a/src/modules/rlm_digest/rlm_digest.c b/src/modules/rlm_digest/rlm_digest.c
index 7ca3ee5..193270e 100644 (file)
--- a/src/modules/rlm_digest/rlm_digest.c
+++ b/src/modules/rlm_digest/rlm_digest.c
@@ -160,7 +160,6 @@ static int digest_fix(REQUEST *request)
                        if ((debug_flag > 1) && fr_log_fp) {
                          fputc('\t', fr_log_fp);
                          vp_print(fr_log_fp, sub);
-                         fputc('\n', fr_log_fp);
                        }
 
                        /*