From: kouril <kouril>
Date: Mon, 29 Sep 2003 16:23:15 +0000 (+0000)
Subject: Warning about bad use of strcat
X-Git-Tag: v5.0-rc3~27
X-Git-Url: http://www.project-moonshot.org/gitweb/?a=commitdiff_plain;ds=sidebyside;h=f95ce6a8fce8eca40b6954a78b591cf724caa4f8;p=mod_auth_kerb.git

Warning about bad use of strcat
---

diff --git a/src/mod_auth_kerb.c b/src/mod_auth_kerb.c
index 3f5bb84..6393c02 100644
--- a/src/mod_auth_kerb.c
+++ b/src/mod_auth_kerb.c
@@ -866,6 +866,7 @@ authenticate_user_gss(request_rec *r,
   if (conf->krb_5_keytab)
      /* use really strcat(), since the string passed to putenv() will become
       * part of the enviroment and shouldn't be free()ed by apache */
+     /* XXX space isn't allocated !!! */
      putenv(strcat("KRB5_KTNAME=", conf->krb_5_keytab));
 
   if (gss_connection->server_creds == GSS_C_NO_CREDENTIAL) {