From: aland <aland>
Date: Tue, 29 May 2001 15:35:45 +0000 (+0000)
Subject: 	If we've already sent a reply to the NAS, then do NOT process
X-Git-Tag: release_0_2_0~84
X-Git-Url: http://www.project-moonshot.org/gitweb/?a=commitdiff_plain;h=4216d881a8537f7446d2818b1332799fd450d216;p=freeradius.git

	If we've already sent a reply to the NAS, then do NOT process
	a proxy reply through the server again.  Instead, we simply drop
	the duplicate proxy reply.

	Based on input from Vesselin Atanasov <vesselin@bgnet.bg>
---

diff --git a/src/main/radiusd.c b/src/main/radiusd.c
index 8b2454a..427e636 100644
--- a/src/main/radiusd.c
+++ b/src/main/radiusd.c
@@ -1159,6 +1159,7 @@ int rad_process(REQUEST *request, int dospawn)
 	}
 	
 	assert(request->magic == REQUEST_MAGIC);
+	assert(request->reply == NULL);
 
 	/*
 	 *  The request passes many of our sanity checks.  From
@@ -2136,7 +2137,16 @@ static REQUEST *proxy_check_list(REQUEST *request)
 				request_free(&request);
 				return NULL;
 			}
-		} /* else there's no reply yet. */
+		} else if (oldreq->reply) {
+		  /*
+		   *  Maybe we've already sent a reply to the NAS, in
+		   *  which case the new 'request' is really a
+		   *  duplicate, that should just be dropped.
+		   */
+			DEBUG2("Ignoring proxy reply, after we've sent a reply to the NAS");
+			request_free(&request);
+			return NULL;
+		}
 
 	} else {
 		/*