From: kouril <kouril>
Date: Fri, 17 Oct 2003 09:29:05 +0000 (+0000)
Subject: Log error messages on krb4 failures
X-Git-Tag: v5.0-rc3~26
X-Git-Url: http://www.project-moonshot.org/gitweb/?a=commitdiff_plain;h=7e57402ef2ccb0830b8b842718bfb06b43c8ba10;hp=f95ce6a8fce8eca40b6954a78b591cf724caa4f8;p=mod_auth_kerb.git

Log error messages on krb4 failures
---

diff --git a/src/mod_auth_kerb.c b/src/mod_auth_kerb.c
index 6393c02..b18bad0 100644
--- a/src/mod_auth_kerb.c
+++ b/src/mod_auth_kerb.c
@@ -271,15 +271,21 @@ verify_krb4_user(request_rec *r, char *name, char *instance, char *realm,
 
    ret = krb_get_pw_in_tkt(name, instance, realm, "krbtgt", realm, 
 	 		   DEFAULT_TKT_LIFE, password);
-   if (ret)
-      /* log(krb_err_txt[ret]) */
+   if (ret) {
+      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
+	         "Cannot get krb4 ticket: krb_get_pw_in_tkt() failed: %s",
+		 krb_get_err_text(ret));
       return ret;
+   }
 
    hostname = ap_get_server_name(r);
 
    hp = gethostbyname(hostname);
    if (hp == NULL) {
       dest_tkt();
+      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
+	         "Cannot verify krb4 ticket: gethostbyname() failed: %s",
+		 hstrerror(h_errno));
       return h_errno;
    }
    memcpy(&addr, hp->h_addr, sizeof(addr));
@@ -290,13 +296,20 @@ verify_krb4_user(request_rec *r, char *name, char *instance, char *realm,
 
    ret = krb_mk_req(&ticket, linstance, phost, lrealm, 0);
    if (ret) {
+      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
+	         "Cannot verify krb4 ticket: krb_mk_req() failed: %s",
+		 krb_get_err_text(ret));
       dest_tkt();
       return ret;
    }
 
    ret = krb_rd_req(&ticket, linstance, phost, addr, &authdata, srvtab);
-   if (ret)
+   if (ret) {
+      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
+	         "Cannot verify krb4 ticket: krb_rd_req() failed: %s",
+		 krb_get_err_text(ret));
       dest_tkt();
+   }
 
    return ret;
 }
@@ -380,8 +393,7 @@ authenticate_user_krb4pwd(request_rec *r,
    } while (realms && *realms);
 
    if (ret) {
-      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
-	         "Verifying krb4 password failed (%d)", ret);
+      log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "Verifying krb4 password failed");
       ret = HTTP_UNAUTHORIZED;
       goto end;
    }