From: Luke Howard <lukeh@padl.com>
Date: Tue, 15 Mar 2011 06:12:14 +0000 (+1100)
Subject: Ensure credentials are initialized before calling initBegin()
X-Git-Tag: tr-beta1~347
X-Git-Url: http://www.project-moonshot.org/gitweb/?a=commitdiff_plain;h=927e502c29b88c14adcff94b1622a6d023c55e5d;hp=eb144275b17e28b949075e4db82e795bb42a7b0d;p=moonshot.git

Ensure credentials are initialized before calling initBegin()
---

diff --git a/mech_eap/init_sec_context.c b/mech_eap/init_sec_context.c
index 951ea2b..a7d17b5 100644
--- a/mech_eap/init_sec_context.c
+++ b/mech_eap/init_sec_context.c
@@ -898,6 +898,7 @@ gss_init_sec_context(OM_uint32 *minor,
 {
     OM_uint32 major, tmpMinor;
     gss_ctx_id_t ctx = *context_handle;
+    int initialContextToken = 0;
 
     *minor = 0;
 
@@ -915,13 +916,7 @@ gss_init_sec_context(OM_uint32 *minor,
             return major;
 
         ctx->flags |= CTX_FLAG_INITIATOR;
-
-        major = initBegin(minor, cred, ctx, target_name, mech_type,
-                          req_flags, time_req, input_chan_bindings);
-        if (GSS_ERROR(major)) {
-            gssEapReleaseContext(minor, &ctx);
-            return major;
-        }
+        initialContextToken = 1;
 
         *context_handle = ctx;
     }
@@ -948,13 +943,21 @@ gss_init_sec_context(OM_uint32 *minor,
 
     GSSEAP_MUTEX_LOCK(&cred->mutex);
 
-
     if ((cred->flags & CRED_FLAG_INITIATE) == 0) {
         major = GSS_S_NO_CRED;
         *minor = GSSEAP_CRED_USAGE_MISMATCH;
         goto cleanup;
     }
 
+    if (initialContextToken) {
+        major = initBegin(minor, cred, ctx, target_name, mech_type,
+                          req_flags, time_req, input_chan_bindings);
+        if (GSS_ERROR(major)) {
+            gssEapReleaseContext(minor, &ctx);
+            return major;
+        }
+    }
+
     major = gssEapSmStep(minor,
                          cred,
                          ctx,