freeradius.git
9 years agoQuit clang analyzer
Alan T. DeKok [Mon, 17 Nov 2014 20:41:40 +0000 (15:41 -0500)]
Quit clang analyzer

9 years agoMore CPPFLAGS fixes for clang analyzer
Alan T. DeKok [Mon, 17 Nov 2014 20:37:37 +0000 (15:37 -0500)]
More CPPFLAGS fixes for clang analyzer

9 years agoShut up clang analyzer
Alan T. DeKok [Mon, 17 Nov 2014 20:35:51 +0000 (15:35 -0500)]
Shut up clang analyzer

9 years agoDereferencing NULL is bad
Alan T. DeKok [Mon, 17 Nov 2014 20:35:18 +0000 (15:35 -0500)]
Dereferencing NULL is bad

9 years agoDon't pollute the global CPPFLAGS with crap just for version.c
Alan T. DeKok [Mon, 17 Nov 2014 20:31:48 +0000 (15:31 -0500)]
Don't pollute the global CPPFLAGS with crap just for version.c

9 years agoFix new parser for commas, missed in previous commit
Alan T. DeKok [Mon, 17 Nov 2014 20:31:37 +0000 (15:31 -0500)]
Fix new parser for commas, missed in previous commit

9 years agoRemove cppcheck warning
Alan T. DeKok [Mon, 17 Nov 2014 20:27:50 +0000 (15:27 -0500)]
Remove cppcheck warning

9 years agotmpl_da, not da
Alan T. DeKok [Mon, 17 Nov 2014 20:26:29 +0000 (15:26 -0500)]
tmpl_da, not da

9 years agovp->da, not da
Alan T. DeKok [Mon, 17 Nov 2014 20:22:20 +0000 (15:22 -0500)]
vp->da, not da

9 years agoMake cppcheck work again.
Alan T. DeKok [Mon, 17 Nov 2014 20:20:35 +0000 (15:20 -0500)]
Make cppcheck work again.

For some unknown reason CPPFLAGS is getting set from CFLAGS.
So... fix the symptom, not the cause

9 years agoBetter rlm_sql errors
Arran Cudbard-Bell [Mon, 17 Nov 2014 15:14:38 +0000 (10:14 -0500)]
Better rlm_sql errors

9 years agoMore error messages
Alan T. DeKok [Mon, 17 Nov 2014 14:28:53 +0000 (09:28 -0500)]
More error messages

9 years agoBe more forgiving for bare words in the new parser
Alan T. DeKok [Mon, 17 Nov 2014 14:15:18 +0000 (09:15 -0500)]
Be more forgiving for bare words in the new parser

If we have a bare word, just parse everything until space,
CR / LF, or comma.  That allows parser special characters
such as braces...

9 years agoMove radius_event_init and modules_init to after the fork
Arran Cudbard-Bell [Mon, 17 Nov 2014 06:35:19 +0000 (01:35 -0500)]
Move radius_event_init and modules_init to after the fork

The kqueue used as the main event loop isn't inherited by the child process, and we get weird errors

9 years agoBetter debug messages for kqueue event insertion and signal pipes
Arran Cudbard-Bell [Mon, 17 Nov 2014 06:23:02 +0000 (01:23 -0500)]
Better debug messages for kqueue event insertion and signal pipes

9 years agoFormatting
Arran Cudbard-Bell [Mon, 17 Nov 2014 03:20:09 +0000 (22:20 -0500)]
Formatting

9 years agoExplicitly free children of rlm_sql and rlm_cache instances, before calling dlclose...
Arran Cudbard-Bell [Mon, 17 Nov 2014 02:15:08 +0000 (21:15 -0500)]
Explicitly free children of rlm_sql and rlm_cache instances, before calling dlclose on the driver

Prevents SEGV when talloc tries to call destructors that have already been unloaded

9 years agolldb doesn't like this
Arran Cudbard-Bell [Mon, 17 Nov 2014 02:07:25 +0000 (21:07 -0500)]
lldb doesn't like this

9 years agoMore reformatting
Arran Cudbard-Bell [Sun, 16 Nov 2014 19:16:13 +0000 (14:16 -0500)]
More reformatting

9 years agodlclose driver handles on mod_detach (rlm_sql and rlm_cache)
Arran Cudbard-Bell [Sun, 16 Nov 2014 19:07:12 +0000 (14:07 -0500)]
dlclose driver handles on mod_detach (rlm_sql and rlm_cache)

9 years agoMake tlsv1.2 and tlsv1.2 conditional on having them
Alan T. DeKok [Sun, 16 Nov 2014 15:01:00 +0000 (10:01 -0500)]
Make tlsv1.2 and tlsv1.2 conditional on having them

9 years agoAllow for selective disabling of TLSv1.1 and TLSv1.2
Alan T. DeKok [Sun, 16 Nov 2014 14:43:50 +0000 (09:43 -0500)]
Allow for selective disabling of TLSv1.1 and TLSv1.2

9 years agoMinor formatting fixups
Arran Cudbard-Bell [Sun, 16 Nov 2014 04:49:21 +0000 (23:49 -0500)]
Minor formatting fixups

9 years agoA better name
Alan T. DeKok [Sat, 15 Nov 2014 20:24:58 +0000 (15:24 -0500)]
A better name

9 years agoFix typo
Alan T. DeKok [Sat, 15 Nov 2014 14:26:20 +0000 (09:26 -0500)]
Fix typo

9 years agoDocument retry_delay
Alan T. DeKok [Sat, 15 Nov 2014 13:47:05 +0000 (08:47 -0500)]
Document retry_delay

9 years agoUse C99 field labels when initialising driver structs
Arran Cudbard-Bell [Sat, 15 Nov 2014 06:34:31 +0000 (01:34 -0500)]
Use C99 field labels when initialising driver structs

Means it's possible to add new callback functions in the module structs without having to go through and add NULL field initialisers to every module

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 14 Nov 2014 21:54:43 +0000 (16:54 -0500)]
Update ChangeLog

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 14 Nov 2014 21:54:06 +0000 (16:54 -0500)]
Update ChangeLog

9 years agoBackport rlm_cache merge fixes from master
Arran Cudbard-Bell [Fri, 14 Nov 2014 21:51:00 +0000 (16:51 -0500)]
Backport rlm_cache merge fixes from master

9 years agoRename LDAP connection functions to be consistent with sql and cache
Arran Cudbard-Bell [Fri, 14 Nov 2014 21:46:22 +0000 (16:46 -0500)]
Rename LDAP connection functions to be consistent with sql and cache

9 years agoRemove redundant connection pool indirection in rlm_sql
Arran Cudbard-Bell [Fri, 14 Nov 2014 21:46:04 +0000 (16:46 -0500)]
Remove redundant connection pool indirection in rlm_sql

9 years agoAdd note on status-server behaviour
Arran Cudbard-Bell [Fri, 14 Nov 2014 18:43:37 +0000 (13:43 -0500)]
Add note on status-server behaviour

9 years agoCheck sections in "instantiate"
Alan T. DeKok [Fri, 14 Nov 2014 16:55:02 +0000 (11:55 -0500)]
Check sections in "instantiate"

For more load-time syntax checking.

9 years agoMake map_afrom_attr_str more caller friendly
Arran Cudbard-Bell [Thu, 13 Nov 2014 19:30:45 +0000 (14:30 -0500)]
Make map_afrom_attr_str more caller friendly

9 years agoShould be vp_aprints not vp_aprint
Arran Cudbard-Bell [Thu, 13 Nov 2014 16:26:27 +0000 (11:26 -0500)]
Should be vp_aprints not vp_aprint

9 years agoCleanups and better tests for foreach / return
Alan T. DeKok [Thu, 13 Nov 2014 14:40:13 +0000 (09:40 -0500)]
Cleanups and better tests for foreach / return

9 years agoIn foreach, check "next" stack for break / return
Alan T. DeKok [Thu, 13 Nov 2014 14:39:38 +0000 (09:39 -0500)]
In foreach, check "next" stack for break / return

Instead of our stack

9 years agoTest for "return" in a "foreach" loop
Alan T. DeKok [Wed, 12 Nov 2014 21:42:49 +0000 (16:42 -0500)]
Test for "return" in a "foreach" loop

9 years agoEnable kqueue for the main event loop
Alan T. DeKok [Tue, 11 Nov 2014 19:28:19 +0000 (14:28 -0500)]
Enable kqueue for the main event loop

Which should be faster than select() for lots of sockets

9 years agoLook for kqueue() and sys/event.h
Alan T. DeKok [Tue, 11 Nov 2014 19:27:46 +0000 (14:27 -0500)]
Look for kqueue() and sys/event.h

9 years agoDon't leak memory on exit
Alan T. DeKok [Tue, 11 Nov 2014 19:23:17 +0000 (14:23 -0500)]
Don't leak memory on exit

9 years agoRemove the listener when the last request is done with it
Alan T. DeKok [Tue, 11 Nov 2014 19:16:54 +0000 (14:16 -0500)]
Remove the listener when the last request is done with it

9 years agoMerge pull request #831 from mcnewton/patch-ocsp-host-header
Arran Cudbard-Bell [Tue, 11 Nov 2014 01:31:33 +0000 (20:31 -0500)]
Merge pull request #831 from mcnewton/patch-ocsp-host-header

option to add HTTP Host: header in OCSP request

9 years agoMerge pull request #832 from mcnewton/patch-softfail-default
Arran Cudbard-Bell [Tue, 11 Nov 2014 01:30:50 +0000 (20:30 -0500)]
Merge pull request #832 from mcnewton/patch-softfail-default

disable softfail by default (in line with documentation)

9 years agoadd HTTP Host: header in OCSP request
Matthew Newton [Mon, 10 Nov 2014 14:21:29 +0000 (14:21 +0000)]
add HTTP Host: header in OCSP request

9 years agodisable softfail by default (in line with documentation)
Matthew Newton [Mon, 10 Nov 2014 23:39:09 +0000 (23:39 +0000)]
disable softfail by default (in line with documentation)

9 years agopairfind_da -> pairfind_by_da
Arran Cudbard-Bell [Mon, 10 Nov 2014 17:46:14 +0000 (12:46 -0500)]
pairfind_da -> pairfind_by_da

9 years agoConvert some pairfind calls to pairfind_da calls
Arran Cudbard-Bell [Mon, 10 Nov 2014 17:44:07 +0000 (12:44 -0500)]
Convert some pairfind calls to pairfind_da calls

9 years agoFix header file layout
Alan T. DeKok [Mon, 10 Nov 2014 17:20:32 +0000 (12:20 -0500)]
Fix header file layout

9 years agoCompiler warning
Alan T. DeKok [Sun, 9 Nov 2014 13:59:32 +0000 (08:59 -0500)]
Compiler warning

9 years agoGlue state into more places
Alan T. DeKok [Sun, 9 Nov 2014 13:26:07 +0000 (08:26 -0500)]
Glue state into more places

9 years agoFix link / cleanup code
Alan T. DeKok [Sun, 9 Nov 2014 13:21:28 +0000 (08:21 -0500)]
Fix link / cleanup code

9 years agoVerify the state, too
Alan T. DeKok [Sat, 8 Nov 2014 19:30:45 +0000 (14:30 -0500)]
Verify the state, too

9 years agoMore debugging
Alan T. DeKok [Fri, 7 Nov 2014 21:58:17 +0000 (16:58 -0500)]
More debugging

9 years agoDisplay CFLAGS etal with -xv
Arran Cudbard-Bell [Fri, 7 Nov 2014 04:48:07 +0000 (23:48 -0500)]
Display CFLAGS etal with -xv

9 years agoFix evaluating IP type check items in the users file
Arran Cudbard-Bell [Thu, 6 Nov 2014 20:12:37 +0000 (15:12 -0500)]
Fix evaluating IP type check items in the users file

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Thu, 6 Nov 2014 19:27:43 +0000 (14:27 -0500)]
Update ChangeLog

9 years agoAdd not on why we return invalid if there are no cached groups
Arran Cudbard-Bell [Thu, 6 Nov 2014 19:14:33 +0000 (14:14 -0500)]
Add not on why we return invalid if there are no cached groups

9 years agoMake cached group checks work when the user is the member of a single group
Arran Cudbard-Bell [Thu, 6 Nov 2014 16:24:15 +0000 (11:24 -0500)]
Make cached group checks work when the user is the member of a single group

9 years agoFix initialization check
Alan T. DeKok [Thu, 6 Nov 2014 16:06:15 +0000 (11:06 -0500)]
Fix initialization check

9 years agoUse paircmp_op for comparing cached group memberships
Arran Cudbard-Bell [Thu, 6 Nov 2014 15:43:28 +0000 (10:43 -0500)]
Use paircmp_op for comparing cached group memberships

9 years agoSlightly better checks which include "pending"
Alan T. DeKok [Thu, 6 Nov 2014 15:38:42 +0000 (10:38 -0500)]
Slightly better checks which include "pending"

9 years agoAllow multiple creates at the same time
Alan T. DeKok [Thu, 6 Nov 2014 14:56:28 +0000 (09:56 -0500)]
Allow multiple creates at the same time

limited only by max

9 years agoSet correct type for vpt->name
Arran Cudbard-Bell [Thu, 6 Nov 2014 04:05:08 +0000 (23:05 -0500)]
Set correct type for vpt->name

9 years agoFix expanded switch value being freed before it's done being used
Arran Cudbard-Bell [Thu, 6 Nov 2014 04:04:48 +0000 (23:04 -0500)]
Fix expanded switch value being freed before it's done being used

9 years agoFormatting
Arran Cudbard-Bell [Thu, 6 Nov 2014 04:03:56 +0000 (23:03 -0500)]
Formatting

9 years agoAdd support for DEBUG environmental variable
Arran Cudbard-Bell [Thu, 6 Nov 2014 03:47:52 +0000 (22:47 -0500)]
Add support for DEBUG environmental variable

yes - don't install fault_action signal handlers
no - don't install fault_action signal handlers
auto - if the server is running under a debugger, don't install fault_action signal handlers

9 years agoParent vpt->name correctly
Arran Cudbard-Bell [Thu, 6 Nov 2014 03:46:44 +0000 (22:46 -0500)]
Parent vpt->name correctly

9 years agoBuild on travis WITH_EVAL_DEBUG
Arran Cudbard-Bell [Thu, 6 Nov 2014 02:24:25 +0000 (21:24 -0500)]
Build on travis WITH_EVAL_DEBUG

9 years agoTypo
Arran Cudbard-Bell [Wed, 5 Nov 2014 22:40:06 +0000 (17:40 -0500)]
Typo

9 years agoCheck number strings fed into dynamic regular expressions work
Arran Cudbard-Bell [Wed, 5 Nov 2014 22:35:53 +0000 (17:35 -0500)]
Check number strings fed into dynamic regular expressions work

9 years agoAdd test for paircmp
Arran Cudbard-Bell [Wed, 5 Nov 2014 21:07:02 +0000 (16:07 -0500)]
Add test for paircmp

9 years agoReturn string 0 for &Attr[#] where no attributes exist
Arran Cudbard-Bell [Wed, 5 Nov 2014 18:18:22 +0000 (13:18 -0500)]
Return string 0 for &Attr[#] where no attributes exist

9 years agoSplit apart some integer tests
Arran Cudbard-Bell [Wed, 5 Nov 2014 18:17:22 +0000 (13:17 -0500)]
Split apart some integer tests

9 years agoFix printing of tmpl_num in tmpl_prints
Arran Cudbard-Bell [Wed, 5 Nov 2014 05:49:14 +0000 (00:49 -0500)]
Fix printing of tmpl_num in tmpl_prints

9 years agoUpdated a check in cbtls_msg
Herwin Weststrate [Tue, 4 Nov 2014 19:28:45 +0000 (20:28 +0100)]
Updated a check in cbtls_msg

The check does exactly the same thing as before, but this silences a cppcheck warning.

9 years agoRemoved some redundant not-null checks
Herwin Weststrate [Tue, 4 Nov 2014 19:24:30 +0000 (20:24 +0100)]
Removed some redundant not-null checks

9 years agoFixed potential null pointer dereferences
Herwin Weststrate [Tue, 4 Nov 2014 19:20:52 +0000 (20:20 +0100)]
Fixed potential null pointer dereferences

9 years agoRemove old example
Alan T. DeKok [Tue, 4 Nov 2014 21:12:55 +0000 (16:12 -0500)]
Remove old example

9 years agoSQL, not MySQL
Alan T. DeKok [Tue, 4 Nov 2014 17:07:05 +0000 (12:07 -0500)]
SQL, not MySQL

9 years agoTie "originate coa" into the session-state handler
Alan T. DeKok [Tue, 4 Nov 2014 17:05:30 +0000 (12:05 -0500)]
Tie "originate coa" into the session-state handler

any state added by originate-coa will be available to the next
Access-Request.

9 years agoNote TLS 1.1 and 1.2
Alan T. DeKok [Tue, 4 Nov 2014 12:48:43 +0000 (07:48 -0500)]
Note TLS 1.1 and 1.2

9 years agoCleanup formatting in radiusd.c
Arran Cudbard-Bell [Tue, 4 Nov 2014 16:34:27 +0000 (11:34 -0500)]
Cleanup formatting in radiusd.c

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 4 Nov 2014 15:54:15 +0000 (10:54 -0500)]
Update ChangeLog

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 4 Nov 2014 13:56:46 +0000 (08:56 -0500)]
Update ChangeLog

9 years agoFormatting
Arran Cudbard-Bell [Tue, 4 Nov 2014 06:23:52 +0000 (01:23 -0500)]
Formatting

9 years agoFix assumption in radius_compare_vps that the check item is always a string (oops)
Arran Cudbard-Bell [Tue, 4 Nov 2014 06:01:02 +0000 (01:01 -0500)]
Fix assumption in radius_compare_vps that the check item is always a string (oops)

9 years agoProcess the *expanded* check items for rlm_files
Arran Cudbard-Bell [Tue, 4 Nov 2014 06:00:29 +0000 (01:00 -0500)]
Process the *expanded* check items for rlm_files

9 years agoFixup mysql driver script to work with libmysqlclient >= 5.6
Arran Cudbard-Bell [Tue, 4 Nov 2014 05:08:38 +0000 (00:08 -0500)]
Fixup mysql driver script to work with libmysqlclient >= 5.6

9 years agoFormatting in mysql driver
Arran Cudbard-Bell [Tue, 4 Nov 2014 05:08:16 +0000 (00:08 -0500)]
Formatting in mysql driver

9 years agoHelpful if it's info so it shows up in the main log
Arran Cudbard-Bell [Tue, 4 Nov 2014 03:27:01 +0000 (22:27 -0500)]
Helpful if it's info so it shows up in the main log

9 years agoMerge pull request #827 from leprechau/tokener-cleanup
Arran Cudbard-Bell [Tue, 4 Nov 2014 03:05:33 +0000 (22:05 -0500)]
Merge pull request #827 from leprechau/tokener-cleanup

minor cleanups

9 years agoLink to libcap to determine process capabilities
Arran Cudbard-Bell [Mon, 3 Nov 2014 20:00:04 +0000 (15:00 -0500)]
Link to libcap to determine process capabilities

This lets us know whether the debugger attach check is failing because
we don't have CAP_SYS_PTRACE or because there really is another
debugger attached already.

9 years agoAdd libcap-dev dependency for travis and debian packages
Arran Cudbard-Bell [Mon, 3 Nov 2014 22:08:46 +0000 (17:08 -0500)]
Add libcap-dev dependency for travis and debian packages

9 years agoFix fr_utf8_strchar() and tests
Alan T. DeKok [Mon, 3 Nov 2014 20:35:58 +0000 (15:35 -0500)]
Fix fr_utf8_strchar() and tests

allowed characters shouldn't be escaped in the test.

the function returns const

it checks for fr_utf8_char() of str, not char the second time
around

9 years ago* use the same json token parsing function everywhere
Aaron Hurt [Mon, 3 Nov 2014 21:24:16 +0000 (15:24 -0600)]
* use the same json token parsing function everywhere
* cleanup now un-used functions in jsonc_missing
* minor function naming cleanup in mod.c
* add missing prototype to mod.h

9 years agoFix fr_utf8_strchar() and tests
Alan T. DeKok [Mon, 3 Nov 2014 20:35:58 +0000 (15:35 -0500)]
Fix fr_utf8_strchar() and tests

allowed characters shouldn't be escaped in the test.

the function returns const

it checks for fr_utf8_char() of str, not char the second time
around

9 years agoAllow TLS 1.1 and 1.2
Alan T. DeKok [Mon, 3 Nov 2014 19:37:59 +0000 (14:37 -0500)]
Allow TLS 1.1 and 1.2

9 years agoAnother typo
Arran Cudbard-Bell [Mon, 3 Nov 2014 16:46:59 +0000 (11:46 -0500)]
Another typo