freeradius.git
11 years agoRFC 6911 and dictionary
Alan T. DeKok [Thu, 9 May 2013 17:43:51 +0000 (13:43 -0400)]
RFC 6911 and dictionary

11 years agoUse correctly sized buffer for MD5
Alan T. DeKok [Thu, 9 May 2013 14:07:38 +0000 (10:07 -0400)]
Use correctly sized buffer for MD5

and use a time-invariant comparison

11 years agoRemove length limitations on names
Alan T. DeKok [Thu, 9 May 2013 14:00:29 +0000 (10:00 -0400)]
Remove length limitations on names

11 years agore-arrange code to make it clearer what's going on
Alan T. DeKok [Thu, 9 May 2013 13:46:42 +0000 (09:46 -0400)]
re-arrange code to make it clearer what's going on

11 years agoRemove more fixed-size buffers
Alan T. DeKok [Wed, 8 May 2013 18:28:55 +0000 (14:28 -0400)]
Remove more fixed-size buffers

11 years agoRemove extraneous strlcpy && buffer
Alan T. DeKok [Wed, 8 May 2013 18:20:49 +0000 (14:20 -0400)]
Remove extraneous strlcpy && buffer

11 years agoFix wypo in WITH_ macro. At worst it left an unused label in the code.
skids [Sun, 5 May 2013 01:32:37 +0000 (21:32 -0400)]
Fix wypo in WITH_ macro.  At worst it left an unused label in the code.

11 years agoTypo in comments
skids [Sun, 5 May 2013 02:58:39 +0000 (22:58 -0400)]
Typo in comments

11 years agoAdjust comment to direct users to newer doc file, README.failover nonexistant
skids [Sun, 5 May 2013 03:23:07 +0000 (23:23 -0400)]
Adjust comment to direct users to newer doc file, README.failover nonexistant

11 years agoFix typos in comments
skids [Sun, 5 May 2013 15:20:22 +0000 (11:20 -0400)]
Fix typos in comments

11 years agoRemove UNUSED from a used parameter
skids [Tue, 7 May 2013 23:44:00 +0000 (19:44 -0400)]
Remove UNUSED from a used parameter

11 years agogrammar correction in comments
skids [Wed, 8 May 2013 23:04:27 +0000 (19:04 -0400)]
grammar correction in comments

11 years agoWhitespace
Arran Cudbard-Bell [Thu, 9 May 2013 01:21:47 +0000 (21:21 -0400)]
Whitespace

11 years agoSimpler way to validate URI
Arran Cudbard-Bell [Thu, 9 May 2013 01:16:44 +0000 (21:16 -0400)]
Simpler way to validate URI

11 years agoDecoded VPs are associated with the packet
Alan T. DeKok [Wed, 8 May 2013 14:30:04 +0000 (10:30 -0400)]
Decoded VPs are associated with the packet

11 years agoMade decoder handle concatenated attributes
Alan T. DeKok [Wed, 8 May 2013 14:24:03 +0000 (10:24 -0400)]
Made decoder handle concatenated attributes

11 years agoMore checks for concatenated attrs
Alan T. DeKok [Wed, 8 May 2013 14:20:37 +0000 (10:20 -0400)]
More checks for concatenated attrs

11 years agotalloc_steal next pointer, too
Alan T. DeKok [Wed, 8 May 2013 14:20:14 +0000 (10:20 -0400)]
talloc_steal next pointer, too

11 years agoRefer to smbpasswd module, not etc_smbpasswd
Alan T. DeKok [Wed, 8 May 2013 13:24:17 +0000 (09:24 -0400)]
Refer to smbpasswd module, not etc_smbpasswd

11 years agoTypo
Arran Cudbard-Bell [Tue, 7 May 2013 21:27:54 +0000 (17:27 -0400)]
Typo

11 years agoAnd this is now an error
Arran Cudbard-Bell [Tue, 7 May 2013 20:10:17 +0000 (16:10 -0400)]
And this is now an error

11 years agoNotes on 253 octets and TTLS
Alan T. DeKok [Tue, 7 May 2013 19:55:00 +0000 (15:55 -0400)]
Notes on 253 octets and TTLS

11 years agoMake eap_compose routine for EAP is now RADIUS un-aware
Alan T. DeKok [Tue, 7 May 2013 19:51:25 +0000 (15:51 -0400)]
Make eap_compose routine for EAP is now RADIUS un-aware

It relies on the packet encoder to chop the EAP packet into
attributes

11 years ago"concatenated" attributes get split when encoded
Alan T. DeKok [Tue, 7 May 2013 19:48:29 +0000 (15:48 -0400)]
"concatenated" attributes get split when encoded

But only if they're more than 253 octets long.
The dictionary parser enforces the limitation that only
"RFC" attributes can be concatenated

11 years agoUse correct variable when decoding inner tunnel things
Alan T. DeKok [Tue, 7 May 2013 19:40:24 +0000 (15:40 -0400)]
Use correct variable when decoding inner tunnel things

11 years agoAdd the "concat" flag
Alan T. DeKok [Tue, 7 May 2013 19:00:34 +0000 (15:00 -0400)]
Add the "concat" flag

For EAP-Message, and RFC 5904 attributes.  It means that the
encoder/decoder takes care of splitting / concatenating
the attributes

11 years agoUse libldap default values for require_cert
Arran Cudbard-Bell [Tue, 7 May 2013 20:04:55 +0000 (16:04 -0400)]
Use libldap default values for require_cert

11 years agoDon't need to warn about rebind as it's checked on startup
Arran Cudbard-Bell [Tue, 7 May 2013 19:59:16 +0000 (15:59 -0400)]
Don't need to warn about rebind as it's checked on startup

11 years agoFixes #236 - Use correct interface for setting cert validation options - Original...
Arran Cudbard-Bell [Tue, 7 May 2013 19:49:48 +0000 (15:49 -0400)]
Fixes #236 - Use correct interface for setting cert validation options - Original fix by John Dennis

11 years agoRemove unnecessary cast
Alan T. DeKok [Mon, 6 May 2013 20:34:21 +0000 (16:34 -0400)]
Remove unnecessary cast

11 years agoDon't mangle strings in place
Alan T. DeKok [Mon, 6 May 2013 20:33:27 +0000 (16:33 -0400)]
Don't mangle strings in place

11 years agoDon't mangle strings in place
Alan T. DeKok [Mon, 6 May 2013 20:33:27 +0000 (16:33 -0400)]
Don't mangle strings in place

11 years agoRemove unnecessary cast
Alan T. DeKok [Mon, 6 May 2013 20:25:22 +0000 (16:25 -0400)]
Remove unnecessary cast

11 years agoconst issues
Alan T. DeKok [Mon, 6 May 2013 20:24:12 +0000 (16:24 -0400)]
const issues

11 years agoFix compiler warnings
Alan T. DeKok [Mon, 6 May 2013 20:00:47 +0000 (16:00 -0400)]
Fix compiler warnings

11 years agoRe-organized
Alan T. DeKok [Mon, 6 May 2013 14:43:43 +0000 (10:43 -0400)]
Re-organized

11 years agoRemove length limitations on certificate names, etc.
Alan T. DeKok [Mon, 6 May 2013 13:05:47 +0000 (09:05 -0400)]
Remove length limitations on certificate names, etc.

11 years agoCheck length, not strlen
Alan T. DeKok [Mon, 6 May 2013 12:48:47 +0000 (08:48 -0400)]
Check length, not strlen

11 years agoMove vp_octets and vp_strvalue to pointer
Alan T. DeKok [Thu, 2 May 2013 16:29:01 +0000 (12:29 -0400)]
Move vp_octets and vp_strvalue to pointer

which shrinks the VALUE_PAIR structure, and removes
all length limitations on the attributes.

The code audit still needs to be finished.

11 years agoAdvance ptr
Arran Cudbard-Bell [Sun, 5 May 2013 22:28:18 +0000 (18:28 -0400)]
Advance ptr

11 years agoDoxygen
Arran Cudbard-Bell [Sun, 5 May 2013 22:15:11 +0000 (18:15 -0400)]
Doxygen

11 years agoGCC fix
Arran Cudbard-Bell [Sun, 5 May 2013 22:13:26 +0000 (18:13 -0400)]
GCC fix

11 years agoStandardise return codes
Arran Cudbard-Bell [Sun, 5 May 2013 22:05:15 +0000 (18:05 -0400)]
Standardise return codes

11 years agoTLS section must appear higher in the config
Arran Cudbard-Bell [Sun, 5 May 2013 21:34:28 +0000 (17:34 -0400)]
TLS section must appear higher in the config

11 years agoDelete conf stuff first
Arran Cudbard-Bell [Sun, 5 May 2013 21:32:04 +0000 (17:32 -0400)]
Delete conf stuff first

11 years agoTypo
Arran Cudbard-Bell [Sun, 5 May 2013 21:31:42 +0000 (17:31 -0400)]
Typo

11 years agoHack for section references
Arran Cudbard-Bell [Sun, 5 May 2013 21:31:30 +0000 (17:31 -0400)]
Hack for section references

11 years agoFix url expansion
Arran Cudbard-Bell [Sun, 5 May 2013 18:11:21 +0000 (14:11 -0400)]
Fix url expansion

11 years agoFix eroneous complaint about default auth type in rlm_rest
Arran Cudbard-Bell [Sun, 5 May 2013 01:04:31 +0000 (21:04 -0400)]
Fix eroneous complaint about default auth type in rlm_rest

11 years agoTypo
Arran Cudbard-Bell [Sun, 5 May 2013 00:37:34 +0000 (20:37 -0400)]
Typo

11 years ago0 Length xlat strings should not trigger asserts
Arran Cudbard-Bell [Sun, 5 May 2013 00:29:26 +0000 (20:29 -0400)]
0 Length xlat strings should not trigger asserts

11 years agoFix regex checks
Alan T. DeKok [Sat, 4 May 2013 12:26:38 +0000 (08:26 -0400)]
Fix regex checks

11 years agodoxygen
Alan T. DeKok [Sat, 4 May 2013 12:22:31 +0000 (08:22 -0400)]
doxygen

11 years agoThere's light at the end of the tunnel
Alan T. DeKok [Wed, 1 May 2013 18:45:39 +0000 (14:45 -0400)]
There's light at the end of the tunnel

11 years agoWorry about sign overflow in comparisons
Alan T. DeKok [Fri, 3 May 2013 18:12:21 +0000 (14:12 -0400)]
Worry about sign overflow in comparisons

11 years agoCorrectly encode WiMAX "signed" integer type
Alan T. DeKok [Fri, 3 May 2013 14:42:17 +0000 (10:42 -0400)]
Correctly encode WiMAX "signed" integer type

11 years agoAdded pairsprintf()
Alan T. DeKok [Tue, 30 Apr 2013 22:47:06 +0000 (18:47 -0400)]
Added pairsprintf()

Which prints a format string to the vp_strvalue of a VALUE_PAIR

11 years agoAdded pairstrcpy()
Alan T. DeKok [Tue, 30 Apr 2013 21:56:05 +0000 (17:56 -0400)]
Added pairstrcpy()

which copies a 'char const *' to a VALUE_PAIR

11 years agoAdded pairmemcpy()
Alan T. DeKok [Tue, 30 Apr 2013 17:03:30 +0000 (13:03 -0400)]
Added pairmemcpy()

So that no one is writing to vp->vp_octets

Some still are... i.e. the 3 "network to VP" decoding functions.
But that can be fixed fairly simply, later

11 years agoMinor cleanups to text
Alan T. DeKok [Tue, 30 Apr 2013 13:09:21 +0000 (09:09 -0400)]
Minor cleanups to text

11 years agoHack for stupid GCC warnings
Arran Cudbard-Bell [Tue, 30 Apr 2013 16:54:25 +0000 (12:54 -0400)]
Hack for stupid GCC warnings

11 years agoFix -Werror causing test scripts to fail
Arran Cudbard-Bell [Tue, 30 Apr 2013 16:40:05 +0000 (12:40 -0400)]
Fix -Werror causing test scripts to fail

11 years agoFix warnings from GCC 4.8
Arran Cudbard-Bell [Tue, 30 Apr 2013 16:19:33 +0000 (12:19 -0400)]
Fix warnings from GCC 4.8

11 years ago-Werror
Arran Cudbard-Bell [Tue, 30 Apr 2013 16:14:42 +0000 (12:14 -0400)]
-Werror

11 years agoAdd missing parenthesies
Arran Cudbard-Bell [Tue, 30 Apr 2013 16:08:09 +0000 (12:08 -0400)]
Add missing parenthesies

11 years agoFrom Runcom
Alan T. DeKok [Mon, 29 Apr 2013 18:20:17 +0000 (14:20 -0400)]
From Runcom

11 years agoLess complaints about old-style use of attribute references
Alan T. DeKok [Sun, 28 Apr 2013 14:37:53 +0000 (10:37 -0400)]
Less complaints about old-style use of attribute references

11 years agoUse WARN / ERROR for debug messages
Alan T. DeKok [Sun, 28 Apr 2013 14:35:44 +0000 (10:35 -0400)]
Use WARN / ERROR for debug messages

11 years agoRearrange dhcp / vqp dictionary things.
Alan T. DeKok [Sun, 28 Apr 2013 14:31:43 +0000 (10:31 -0400)]
Rearrange dhcp / vqp dictionary things.

The new conf file parser requires that the dictionaries are
loaded BEFORE parsing the config files.  So we can't dynamically
load dictionaries based on the conf-file contents

11 years agoFix typo in define
Alan T. DeKok [Sat, 27 Apr 2013 14:58:39 +0000 (10:58 -0400)]
Fix typo in define

11 years agoFix typo, add more documentation
Arran Cudbard-Bell [Sat, 27 Apr 2013 18:14:16 +0000 (14:14 -0400)]
Fix typo, add more documentation

11 years agoMerge pull request #283 from olivierbeytrison/master
Arran Cudbard-Bell [Sat, 27 Apr 2013 14:58:04 +0000 (07:58 -0700)]
Merge pull request #283 from olivierbeytrison/master

rlm_ldap : fix wrong filter in group check

11 years agofix incorrect filter
Olivier Beytrison [Sat, 27 Apr 2013 06:04:06 +0000 (08:04 +0200)]
fix incorrect filter

11 years agoAdded better error messages for bad "update" sections
Alan T. DeKok [Fri, 26 Apr 2013 21:06:21 +0000 (17:06 -0400)]
Added better error messages for bad "update" sections

and

change

too

many

whitespace

because

it's

really

annoying.

why is it

annoying?

Because.

11 years agoCloses #280
Arran Cudbard-Bell [Fri, 26 Apr 2013 13:47:47 +0000 (09:47 -0400)]
Closes #280

11 years agoUse consistent macro names for logging
Arran Cudbard-Bell [Thu, 25 Apr 2013 23:28:03 +0000 (19:28 -0400)]
Use consistent macro names for logging

Use types where appropriate

Move radlog_request definition into log.h and update it's types also.

11 years agoMove function prototypes into log.h
Arran Cudbard-Bell [Thu, 25 Apr 2013 22:25:25 +0000 (18:25 -0400)]
Move function prototypes into log.h

11 years agoMerge pull request #279 from alanbuxey/master
Arran Cudbard-Bell [Thu, 25 Apr 2013 22:22:08 +0000 (15:22 -0700)]
Merge pull request #279 from alanbuxey/master

added SHA1 to the expr engine

11 years agoadded sha1 to the expr engine
Alan Buxey [Thu, 25 Apr 2013 22:11:51 +0000 (23:11 +0100)]
added sha1 to the expr engine

welcome %{sha1:….} to the party. may md5 rest in peace.

11 years agoMove more log related things to log.c
Arran Cudbard-Bell [Thu, 25 Apr 2013 22:04:22 +0000 (18:04 -0400)]
Move more log related things to log.c

11 years agoLoop over ALL maps in the "update" section
Alan T. DeKok [Thu, 25 Apr 2013 21:23:04 +0000 (17:23 -0400)]
Loop over ALL maps in the "update" section

11 years agoClean up radius_list_name again
Alan T. DeKok [Thu, 25 Apr 2013 21:15:29 +0000 (17:15 -0400)]
Clean up radius_list_name again

11 years agoFree *head, not head
Alan T. DeKok [Thu, 25 Apr 2013 21:11:00 +0000 (17:11 -0400)]
Free *head, not head

11 years agoUse correct macros for log messages with WARNING: ERROR: DEBUG: embedded in the forma...
Arran Cudbard-Bell [Thu, 25 Apr 2013 20:34:29 +0000 (16:34 -0400)]
Use correct macros for log messages with WARNING: ERROR: DEBUG: embedded in the format string

11 years agoReplace all radlog/radlog_request calls with macros
Arran Cudbard-Bell [Thu, 25 Apr 2013 19:50:55 +0000 (15:50 -0400)]
Replace all radlog/radlog_request calls with macros

11 years agoSanitise logging macro names, and move the logging macros to log.h
Arran Cudbard-Bell [Thu, 25 Apr 2013 19:31:19 +0000 (15:31 -0400)]
Sanitise logging macro names, and move the logging macros to log.h

This removes support for compilers which do not support C99 variadic macros, but as the server now uses many other features of C99 this should not be an issue.

11 years agoFix typos and incorrect documentation format in log.h
Arran Cudbard-Bell [Thu, 25 Apr 2013 19:29:32 +0000 (15:29 -0400)]
Fix typos and incorrect documentation format in log.h

11 years agoOnly set dictionary_dir if it wasn't already set
Alan T. DeKok [Thu, 25 Apr 2013 13:39:22 +0000 (15:39 +0200)]
Only set dictionary_dir if it wasn't already set

11 years agoUse "-D share", now that we need it
Alan T. DeKok [Thu, 25 Apr 2013 13:35:50 +0000 (15:35 +0200)]
Use "-D share", now that we need it

11 years agoMove log configuration to structure in log.c
Alan T. DeKok [Thu, 25 Apr 2013 13:33:08 +0000 (15:33 +0200)]
Move log configuration to structure in log.c

So that other programs can now use / link to it.

This is the first step in creating a library around the
common server source files

11 years agoFix compile warning
Alan T. DeKok [Thu, 25 Apr 2013 13:31:55 +0000 (15:31 +0200)]
Fix compile warning

11 years agoRevert "Replace some globals with library specific static variables"
Alan T. DeKok [Thu, 25 Apr 2013 13:03:36 +0000 (15:03 +0200)]
Revert "Replace some globals with library specific static variables"

This reverts commit 2804cde754c5c42a55271139e23be28a279fcffc.

Getters and setters cause name-space and code explosion.
They are evil beyond compare

11 years agoMove common code into macros
Alan T. DeKok [Wed, 24 Apr 2013 18:42:33 +0000 (14:42 -0400)]
Move common code into macros

11 years agoRemove COND_DEBUG now that it works
Alan T. DeKok [Wed, 24 Apr 2013 18:34:37 +0000 (14:34 -0400)]
Remove COND_DEBUG now that it works

11 years agoMore normalizaton for conditions
Alan T. DeKok [Wed, 24 Apr 2013 18:04:10 +0000 (14:04 -0400)]
More normalizaton for conditions

11 years agoIf we can't find the VPs for a map, the comparison is always false
Alan T. DeKok [Wed, 24 Apr 2013 17:50:04 +0000 (13:50 -0400)]
If we can't find the VPs for a map, the comparison is always false

11 years agoFix xlat functions to NOT call radius_xlat
Alan T. DeKok [Wed, 24 Apr 2013 17:18:06 +0000 (13:18 -0400)]
Fix xlat functions to NOT call radius_xlat

As this is now called by the server core

11 years agoWord smithing
Alan T. DeKok [Wed, 24 Apr 2013 16:08:47 +0000 (12:08 -0400)]
Word smithing

11 years agoNote other deleted modules
Alan T. DeKok [Wed, 24 Apr 2013 16:04:48 +0000 (12:04 -0400)]
Note other deleted modules

11 years agoMake integer comparisons work again
Alan T. DeKok [Wed, 24 Apr 2013 15:56:31 +0000 (11:56 -0400)]
Make integer comparisons work again