freeradius.git
23 years ago* Updated checkrad.pl.in - no need to edit Portmaster settings anymore
miquels [Thu, 22 Mar 2001 13:44:15 +0000 (13:44 +0000)]
* Updated checkrad.pl.in - no need to edit Portmaster settings anymore

23 years agoRemoved fatal-looking error and added descriptive comment to client_find()
cmiller [Tue, 20 Mar 2001 12:41:32 +0000 (12:41 +0000)]
Removed fatal-looking error and added descriptive comment to client_find()
function.

23 years ago * Add some additional debugging code to show what IP address
hartwick [Tue, 20 Mar 2001 03:01:59 +0000 (03:01 +0000)]
* Add some additional debugging code to show what IP address
  couldn't be found in the clients list.

23 years agoBug. Forgot to check a pointer before dereferencing it.
jcarneal [Mon, 19 Mar 2001 20:52:19 +0000 (20:52 +0000)]
Bug.  Forgot to check a pointer before dereferencing it.

23 years ago Corrected functionality of Exec-Program-Wait, as the FreeRADIUS
aland [Mon, 19 Mar 2001 01:02:14 +0000 (01:02 +0000)]
Corrected functionality of Exec-Program-Wait, as the FreeRADIUS
'userparse' function returns slightly different values than the old
Cistron function.

Added a sample script, to show how it works.

Bug found by Stephan von Krawczynski <skraw@ithnet.com>

23 years ago Removed attempt to build drivers. gmake isn't cooperating.
aland [Sun, 18 Mar 2001 18:50:57 +0000 (18:50 +0000)]
Removed attempt to build drivers.  gmake isn't cooperating.

23 years agoAdded cool sanity checks for oft-changing stuff (man pages and conf files).
cmiller [Sun, 18 Mar 2001 05:14:05 +0000 (05:14 +0000)]
Added cool sanity checks for oft-changing stuff (man pages and conf files).
Removed radclient.1 from undocumented list.

23 years ago If NOT using shared libraries, add '-dlpreopen' to the RLM_LIBS
aland [Sat, 17 Mar 2001 15:32:44 +0000 (15:32 +0000)]
If NOT using shared libraries, add '-dlpreopen' to the RLM_LIBS
line, so that any built drivers will be statically linked to the
main sql driver.

23 years agoRemoved new manpages from 'undocumented' list. Added clients.conf .
cmiller [Sat, 17 Mar 2001 14:41:28 +0000 (14:41 +0000)]
Removed new manpages from 'undocumented' list.  Added clients.conf .
Now, shows only
check-radiusd-config.1.gz
checkrad.1.gz
radclient.1.gz
hints.5.gz
huntgroups.5.gz
proxy.conf.5.gz
clients.conf.5.gz
Updated directory usage.

23 years agoRemoved doc/ traversal.
cmiller [Sat, 17 Mar 2001 00:48:47 +0000 (00:48 +0000)]
Removed doc/ traversal.

23 years agoMinor tweaks.
cmiller [Sat, 17 Mar 2001 00:48:06 +0000 (00:48 +0000)]
Minor tweaks.

23 years agoUnneeded file.
cmiller [Sat, 17 Mar 2001 00:47:03 +0000 (00:47 +0000)]
Unneeded file.

23 years agoRemoved bogus build-dep.
cmiller [Sat, 17 Mar 2001 00:07:02 +0000 (00:07 +0000)]
Removed bogus build-dep.
Added 3 dictionaries to conffiles.

23 years ago Updated tests & set for regex.h
aland [Fri, 16 Mar 2001 20:27:50 +0000 (20:27 +0000)]
Updated tests & set for regex.h

23 years agoFixed up some whitespace.
cmiller [Fri, 16 Mar 2001 04:46:19 +0000 (04:46 +0000)]
Fixed up some whitespace.

23 years ago Added file from Jochen Friedrich <jochen@scram.de>
aland [Thu, 15 Mar 2001 21:40:09 +0000 (21:40 +0000)]
Added file from Jochen Friedrich <jochen@scram.de>

23 years ago Added documentation for Cisco VSA hack.
aland [Thu, 15 Mar 2001 20:20:01 +0000 (20:20 +0000)]
Added documentation for Cisco VSA hack.

23 years ago Patch to include function sql_destroy_socket(), from
aland [Thu, 15 Mar 2001 18:06:12 +0000 (18:06 +0000)]
Patch to include function sql_destroy_socket(), from
Bernhard Reiter <bernhard@intevation.de>

23 years ago If RLM_SUBDIRS is defined, then recursively make 'common' for the
aland [Thu, 15 Mar 2001 18:03:10 +0000 (18:03 +0000)]
If RLM_SUBDIRS is defined, then recursively make 'common' for the
targets static, dynamic, and clean.

This allows the SQL module to build it's sub-modules.

Some minor changes to the SQL module build internals were made
to help this process.

23 years ago Use $(INCLTDL) in the RLM_CFLAGS lines, so that we can find the
aland [Thu, 15 Mar 2001 17:56:45 +0000 (17:56 +0000)]
Use $(INCLTDL) in the RLM_CFLAGS lines, so that we can find the
ltdl.h header file, where ever it is.

23 years ago Fix checks for regular expressions, found by
aland [Thu, 15 Mar 2001 15:04:52 +0000 (15:04 +0000)]
Fix checks for regular expressions, found by
"Sergey Kodentsev" <sergk@vmail.ru>

23 years ago Include <inttypes.h> for Tru64 Unix.
aland [Thu, 15 Mar 2001 14:47:29 +0000 (14:47 +0000)]
Include <inttypes.h> for Tru64 Unix.

Bug found by "Simon L. Jackson" <simon.jackson@sysworks.com.au>

23 years ago Implemented callbacks for escape function.
aland [Wed, 14 Mar 2001 20:25:25 +0000 (20:25 +0000)]
Implemented callbacks for escape function.

Wrote escape function for shell characters, on exec.

23 years ago Renamed radius_xlat2 to radius_xlat, as the old radius_xlat is now
aland [Wed, 14 Mar 2001 20:08:42 +0000 (20:08 +0000)]
Renamed radius_xlat2 to radius_xlat, as the old radius_xlat is now
gone.

New typedef for function callback, to escape the attribute string
values, when doing the radius_xlat.  This is so that SQL, shell, etc
can escape their magic values, and the user sending RADIUS attributes
can't play games with them.

Made radius_xlat take this new function, but it doesn't currently
do anything with it.

23 years agoUpdated the configure option listing.
cmiller [Wed, 14 Mar 2001 19:45:11 +0000 (19:45 +0000)]
Updated the configure option listing.

23 years ago More attributes from the newer RFC's, from
aland [Wed, 14 Mar 2001 16:48:13 +0000 (16:48 +0000)]
More attributes from the newer RFC's, from
Kostas Kalevras <kkalev@noc.ntua.gr>

23 years agoJust another round of "quiet the gcc warnings"
pacman [Wed, 14 Mar 2001 06:54:54 +0000 (06:54 +0000)]
Just another round of "quiet the gcc warnings"

23 years ago * Fix a spelling error
hartwick [Wed, 14 Mar 2001 00:23:06 +0000 (00:23 +0000)]
* Fix a spelling error

23 years ago added RLM_INSTALL target, so that the modules can tell the
aland [Tue, 13 Mar 2001 23:19:36 +0000 (23:19 +0000)]
added RLM_INSTALL target, so that the modules can tell the
upper-layer install rules to call module-specific install targets.

23 years agoFixed #include referring to renamed file.
cmiller [Tue, 13 Mar 2001 21:13:29 +0000 (21:13 +0000)]
Fixed #include referring to renamed file.

23 years agoAdded libiodbc2-dev to Build-depends.
cmiller [Tue, 13 Mar 2001 20:15:04 +0000 (20:15 +0000)]
Added libiodbc2-dev to Build-depends.

23 years ago new 'with cisco VSA hack', based on a patch by
aland [Tue, 13 Mar 2001 19:09:06 +0000 (19:09 +0000)]
new 'with cisco VSA hack', based on a patch by
Administrator <admin@postel.sk>

Cisco sends VSA's like: H323-Attribute = "h323-attribute=value"
This is stupid.

The patch was modified to re-write *only* Cisco VSA's.

23 years ago Copied from Cistron 1.6.5, with minor changes for FreeRADIUS
aland [Tue, 13 Mar 2001 18:11:11 +0000 (18:11 +0000)]
Copied from Cistron 1.6.5, with minor changes for FreeRADIUS

23 years ago Added comments on '-l stderr'
aland [Tue, 13 Mar 2001 18:04:07 +0000 (18:04 +0000)]
Added comments on '-l stderr'

23 years ago Copied from Cistron, with minor touch-ups for FreeRADIUS.
aland [Tue, 13 Mar 2001 18:02:20 +0000 (18:02 +0000)]
Copied from Cistron, with minor touch-ups for FreeRADIUS.

23 years ago * Add a check that prevents the server from seg faulting if
hartwick [Tue, 13 Mar 2001 17:35:43 +0000 (17:35 +0000)]
* Add a check that prevents the server from seg faulting if
  row[0] happens to be NULL.

23 years ago Patch from Bernhard Reiter <bernhard@intevation.de>
aland [Tue, 13 Mar 2001 17:20:41 +0000 (17:20 +0000)]
Patch from Bernhard Reiter <bernhard@intevation.de>

Add '-I' to the include directory, to turn it into something we
can use for CFLAGS.

23 years ago Patches from Yury Bokhoncovich <byg@center-f1.ru>
aland [Tue, 13 Mar 2001 17:19:05 +0000 (17:19 +0000)]
Patches from Yury Bokhoncovich <byg@center-f1.ru>

Just to compile the driver.

23 years ago Patch from Yury Bokhoncovich <byg@center-f1.ru>
aland [Tue, 13 Mar 2001 17:08:31 +0000 (17:08 +0000)]
Patch from Yury Bokhoncovich <byg@center-f1.ru>

The following patch change all "default 'now'" construction for
"default now()". This is more correct. 'now' expression leads us to
troubles in PgSQL v6.53 anyway.

23 years agoFixed double hyphen in mysql-lib location def.
cmiller [Tue, 13 Mar 2001 15:31:51 +0000 (15:31 +0000)]
Fixed double hyphen in mysql-lib location def.

23 years agoReadded 'clean' as dep in build-indep.
cmiller [Tue, 13 Mar 2001 04:53:18 +0000 (04:53 +0000)]
Readded 'clean' as dep in build-indep.

23 years ago Minor code re-arrangements, to strip the user name for realms
aland [Mon, 12 Mar 2001 22:00:42 +0000 (22:00 +0000)]
Minor code re-arrangements, to strip the user name for realms
which are NOT proxied.

23 years ago Enable logging to do to stderr, just like stdout.
aland [Mon, 12 Mar 2001 19:25:28 +0000 (19:25 +0000)]
Enable logging to do to stderr, just like stdout.

Change request by Antonio Dias <accdias@sst.com.br>

23 years agoMade logfile rotater $logdir aware.
cmiller [Mon, 12 Mar 2001 17:07:18 +0000 (17:07 +0000)]
Made logfile rotater $logdir aware.

23 years ago Removed 'clean' dep from build-indep rule.
cmiller [Mon, 12 Mar 2001 17:01:10 +0000 (17:01 +0000)]
Removed 'clean' dep from build-indep rule.
Added lib/freeradius and log/freeradius dirs to list.
Updated changelog.

23 years ago Replaced sprintf with snprintf
aland [Mon, 12 Mar 2001 16:52:03 +0000 (16:52 +0000)]
Replaced sprintf with snprintf

23 years ago Changed sprintf's to snprintf's, now that we have snprintf in the
aland [Mon, 12 Mar 2001 16:48:14 +0000 (16:48 +0000)]
Changed sprintf's to snprintf's, now that we have snprintf in the
source tree.

23 years ago Define exec_prefix, as noted by Administrator <admin@postel.sk>
aland [Mon, 12 Mar 2001 16:36:17 +0000 (16:36 +0000)]
Define exec_prefix, as noted by Administrator <admin@postel.sk>

23 years ago Massive changes to get SNMP auto-configured && working.
aland [Mon, 12 Mar 2001 15:56:33 +0000 (15:56 +0000)]
Massive changes to get SNMP auto-configured && working.

23 years ago Copied MySQL checks to similar code for Oracle && ODBC.
aland [Mon, 12 Mar 2001 15:06:47 +0000 (15:06 +0000)]
Copied MySQL checks to similar code for Oracle && ODBC.

23 years agoFixed bug which caused module to fail, if after ldap server transition through
pam [Sun, 11 Mar 2001 15:48:57 +0000 (15:48 +0000)]
Fixed bug which caused module to fail, if after ldap server transition through
up->down->up states.

23 years ago - added Build-depends for SQL and gdbm libraries
cmiller [Sat, 10 Mar 2001 17:08:06 +0000 (17:08 +0000)]
 - added Build-depends for SQL and gdbm libraries
 - put modules in own directory, instead of system /usr/lib/

23 years agoAdded author of first LDAP patch to the credit/reference comments.
pam [Sat, 10 Mar 2001 14:20:20 +0000 (14:20 +0000)]
Added author of first LDAP patch to the credit/reference comments.
Small formatting changes in comments

23 years agoModified the rlm_sql driver Makefiles to use the new autoconf values. Removed rlm_sql...
mmachado [Sat, 10 Mar 2001 01:49:04 +0000 (01:49 +0000)]
Modified the rlm_sql driver Makefiles to use the new autoconf values. Removed rlm_sql specific checkconfig.

23 years ago Added code back to make Password && CHAP-Password work together.
aland [Fri, 9 Mar 2001 20:16:38 +0000 (20:16 +0000)]
Added code back to make Password && CHAP-Password work together.

Bug found by Erik Heinz <erik@iks-jena.de>

23 years ago Corrected location of 'readme' file, noted by
aland [Fri, 9 Mar 2001 20:10:46 +0000 (20:10 +0000)]
Corrected location of 'readme' file, noted by
Hans Grobler <grobh@sun.ac.za>

23 years ago If an 'authorize' module returns REJECT, then presume that IT
aland [Fri, 9 Mar 2001 19:57:27 +0000 (19:57 +0000)]
If an 'authorize' module returns REJECT, then presume that IT
is smart enough to re-write the reply pairs.

The main server no longer deletes them.

Based on a report from "spirn" <spirn@21cn.com>

23 years ago One more pass at MySQL configuration.
aland [Fri, 9 Mar 2001 18:30:09 +0000 (18:30 +0000)]
One more pass at MySQL configuration.

23 years ago Updated to remove all references to GDBM_SYNC
aland [Fri, 9 Mar 2001 18:27:18 +0000 (18:27 +0000)]
Updated to remove all references to GDBM_SYNC

23 years ago One more try for getting configuration of mysql to work.
aland [Fri, 9 Mar 2001 16:44:45 +0000 (16:44 +0000)]
One more try for getting configuration of mysql to work.

23 years agoUpdated rlm_sql README. Fixed autoconf for sql drivers. Fixed typo in rules.mak which...
mmachado [Thu, 8 Mar 2001 23:05:53 +0000 (23:05 +0000)]
Updated rlm_sql README. Fixed autoconf for sql drivers. Fixed typo in rules.mak which prevented the drivers from linking to their database libraries.

23 years ago More checks for IODBC, MySQL, and Oracle. I have *no* clue
aland [Thu, 8 Mar 2001 21:50:35 +0000 (21:50 +0000)]
More checks for IODBC, MySQL, and Oracle.  I have *no* clue
if they work, but they're based on a pretty-much working template..

23 years ago Removed GDBM_SYNC, as only one module used it, and that module
aland [Thu, 8 Mar 2001 21:31:21 +0000 (21:31 +0000)]
Removed GDBM_SYNC, as only one module used it, and that module
didn't even need it.

23 years ago Preliminary checks for mysql libraries && header files.
aland [Thu, 8 Mar 2001 17:40:07 +0000 (17:40 +0000)]
Preliminary checks for mysql libraries && header files.

23 years ago Added example of how to use the script
aland [Thu, 8 Mar 2001 16:56:26 +0000 (16:56 +0000)]
Added example of how to use the script

23 years agoReordered "missing.h" after what it's #ifndef'ing for.
cmiller [Wed, 7 Mar 2001 22:30:52 +0000 (22:30 +0000)]
Reordered "missing.h" after what it's #ifndef'ing for.

23 years ago Look for REG_EXTENDED in regex.h.
aland [Wed, 7 Mar 2001 19:53:10 +0000 (19:53 +0000)]
Look for REG_EXTENDED in regex.h.

Also, define in 'radiusd.conf', whether or not we have regular
expressions, and if we have extended regular expressions.

Nothing currently uses these defines, though.

23 years ago Included a better fix for REG_EXTENDED
aland [Wed, 7 Mar 2001 17:25:09 +0000 (17:25 +0000)]
Included a better fix for REG_EXTENDED

23 years ago Minor fix for apparent bug # 108
aland [Wed, 7 Mar 2001 17:23:22 +0000 (17:23 +0000)]
Minor fix for apparent bug # 108

23 years agoSome GDBMs use synchronous access by default, it seems, and GDBM_SYNC
cmiller [Wed, 7 Mar 2001 16:55:31 +0000 (16:55 +0000)]
Some GDBMs use synchronous access by default, it seems, and GDBM_SYNC
isn't defined.  Fixed that.

23 years ago Try adding for -lcrypto, if we're trying to use SNMP, and linking
aland [Wed, 7 Mar 2001 15:21:33 +0000 (15:21 +0000)]
Try adding for -lcrypto, if we're trying to use SNMP, and linking
against the bare -lsnmp failed.

23 years ago If we have POSIX regular expressions, check if REG_EXTENDED
aland [Wed, 7 Mar 2001 15:15:12 +0000 (15:15 +0000)]
If we have POSIX regular expressions, check if REG_EXTENDED
is defined.  If so, use it.

If not, #define it to be (0), so that we can use it in the
main source.

From a patch by Erik Heinz <erik@iks-jena.de>

23 years agoChanged comments calling the code Cistron to FreeRADIUS. Corrected some
cmiller [Tue, 6 Mar 2001 23:44:50 +0000 (23:44 +0000)]
Changed comments calling the code Cistron to FreeRADIUS.  Corrected some
docs of factual errors.

23 years ago provide an easy way to move users from old cistron's config files
aland [Tue, 6 Mar 2001 20:48:51 +0000 (20:48 +0000)]
provide an easy way to move users from old cistron's config files
into LDAP (by creating a suitable ldif file that works with the
schema proposed in the Readme)

Submitted by

Javier Fernandez-Sanguino =?iso-8859-1?Q?Pe=F1a?= <jfernandez@sgi.es>

23 years ago PostgreSQL configure checks, from a patch by
aland [Tue, 6 Mar 2001 18:10:06 +0000 (18:10 +0000)]
PostgreSQL configure checks, from a patch by

Jason Slagle <raistlin@tacorp.net>

23 years ago Made the 'counter' module a little more useful, and added it's
aland [Tue, 6 Mar 2001 17:29:40 +0000 (17:29 +0000)]
Made the 'counter' module a little more useful, and added it's
configuration to the sample radiusd.conf.

23 years ago Explicit initialization of static variables.
aland [Tue, 6 Mar 2001 17:25:08 +0000 (17:25 +0000)]
Explicit initialization of static variables.

Allowed dict_addattr() to be given '-1' as an attribute value,
in which case it picks a new, unused attribute value.

23 years ago Updated with changes from:
aland [Tue, 6 Mar 2001 16:18:52 +0000 (16:18 +0000)]
Updated with changes from:

Emanuel Moura dos Santos <ems@unforgettable.com>

23 years ago Added preliminary code to re-set the database every hour/day/week.
aland [Mon, 5 Mar 2001 22:07:14 +0000 (22:07 +0000)]
Added preliminary code to re-set the database every hour/day/week.

Resetting it every month is harder, so I won't do that right now.

It still doesn't have configurable counter attributes.  We'd like to
be able to say:

DEFAULT My-Counter < value

and define 'My-Counter' in radiusd.conf.

23 years ago Added paircompare_register, so that we can examine the counter
aland [Mon, 5 Mar 2001 21:52:58 +0000 (21:52 +0000)]
Added paircompare_register, so that we can examine the counter
from the 'users' file.

23 years ago Initial stab at counting information.
aland [Mon, 5 Mar 2001 21:12:07 +0000 (21:12 +0000)]
Initial stab at counting information.

Use a GDBM file, key on a user-supplied attribute, and user another
user-supplied attribute as the count. Right now, it only does
accounting, and does no checks for authorization (e.g. count > value)

It also does little or no error checking.

It also doesn't reset it's count, ever.  It should do so automatically.

23 years agoQuoted the rlm_sql_mysql in the sql config file
mmachado [Mon, 5 Mar 2001 19:15:54 +0000 (19:15 +0000)]
Quoted the rlm_sql_mysql in the sql config file

23 years ago Added VOIP attributes from Cisco's web page.
aland [Mon, 5 Mar 2001 17:56:58 +0000 (17:56 +0000)]
Added VOIP attributes from Cisco's web page.

23 years ago Added pointer to Cisco's web page.
aland [Mon, 5 Mar 2001 17:53:32 +0000 (17:53 +0000)]
Added pointer to Cisco's web page.

23 years ago Corrected typo, noted by Administrator <admin@postel.sk>
aland [Mon, 5 Mar 2001 15:58:54 +0000 (15:58 +0000)]
Corrected typo, noted by  Administrator <admin@postel.sk>

23 years ago*** empty log message ***
cmiller [Mon, 5 Mar 2001 03:58:00 +0000 (03:58 +0000)]
*** empty log message ***

23 years ago Changed priority, added conffiles and tweaked config file output.
cmiller [Mon, 5 Mar 2001 03:51:58 +0000 (03:51 +0000)]
Changed priority, added conffiles and tweaked config file output.

23 years agoTweaks.
cmiller [Mon, 5 Mar 2001 03:48:53 +0000 (03:48 +0000)]
Tweaks.

23 years ago Code "cleanups." I confess that I sometimes went beyond the TODO
cmiller [Mon, 5 Mar 2001 03:42:10 +0000 (03:42 +0000)]
Code "cleanups."  I confess that I sometimes went beyond the TODO
suggestions with changes to brace styles and explicit testing.  :/

I tested it lightly, and I don't see any breakage.  I hope it's not
broken anywhere!

23 years ago Moved local #includes after global ones. (So "missing.h" is after
cmiller [Mon, 5 Mar 2001 03:32:35 +0000 (03:32 +0000)]
Moved local #includes after global ones.  (So "missing.h" is after
<netinet/in.h>, especially.  I get warnings otherwise.)

23 years ago Y2K readiness statements are no longer relevant
aland [Sun, 4 Mar 2001 20:18:59 +0000 (20:18 +0000)]
Y2K readiness statements are no longer relevant

23 years ago Removed dependence on pam_pwdb, as pam_unix_* does the same thing,
aland [Sun, 4 Mar 2001 16:39:55 +0000 (16:39 +0000)]
Removed dependence on pam_pwdb, as pam_unix_* does the same thing,
but in a MUCH more intelligent fashion.

23 years ago Allow environment variable expansion in the configuration file,
aland [Thu, 1 Mar 2001 22:34:10 +0000 (22:34 +0000)]
Allow environment variable expansion in the configuration file,
via $ENV{}   e.g. $ENV{PATH}

This is a low priority item, but was easy to add..

23 years ago Updated the $INCLUDE code to allow for included files
cparker [Thu, 1 Mar 2001 05:59:53 +0000 (05:59 +0000)]
Updated the $INCLUDE code to allow for included files
below the top level.  Tested with include 'sql.conf'
inside 'modules' sub-section successfully.

23 years ago Do not treat 'Password' attributes as special any more. The radius
aland [Wed, 28 Feb 2001 22:04:57 +0000 (22:04 +0000)]
Do not treat 'Password' attributes as special any more.  The radius
code decrypts them, so they now become attributes like any other.

Based on bug reported by "Sergey Kodentsev" <sergk@ic.vrn.ru>

23 years ago This file is no longer relevant. The rlm_ldap README describes
aland [Wed, 28 Feb 2001 16:14:59 +0000 (16:14 +0000)]
This file is no longer relevant.  The rlm_ldap README describes
it in more detail.

23 years agoAdded path to libltdl to find headers
mmachado [Wed, 28 Feb 2001 00:10:24 +0000 (00:10 +0000)]
Added path to libltdl to find headers

23 years ago Added a few more cisco attributes
aland [Tue, 27 Feb 2001 15:03:56 +0000 (15:03 +0000)]
Added a few more cisco attributes

23 years ago Added comment suggesting use of clients.conf instead.
cmiller [Mon, 26 Feb 2001 21:47:47 +0000 (21:47 +0000)]
Added comment suggesting use of clients.conf instead.

23 years ago Added two style hints.
cmiller [Mon, 26 Feb 2001 21:38:53 +0000 (21:38 +0000)]
Added two style hints.