freeradius.git
10 years agoAssume password src encoding is UTF8 and convert it to UCS2 before hashing with MD4
Arran Cudbard-Bell [Wed, 25 Sep 2013 22:48:08 +0000 (23:48 +0100)]
Assume password src encoding is UTF8 and convert it to UCS2 before hashing with MD4
Patch by Andrei Korostelev
Closes #437

10 years agoFix some typos/issues in rlm_rest json as posted by Kevin Hester. Closes #438
Arran Cudbard-Bell [Wed, 25 Sep 2013 21:03:23 +0000 (22:03 +0100)]
Fix some typos/issues in rlm_rest json as posted by Kevin Hester. Closes #438

10 years agoPacket data is talloc'd
Alan T. DeKok [Tue, 24 Sep 2013 15:18:03 +0000 (11:18 -0400)]
Packet data is talloc'd

10 years agoAdd comp128 functions
Arran Cudbard-Bell [Tue, 24 Sep 2013 11:49:23 +0000 (12:49 +0100)]
Add comp128 functions

10 years agoCleanup EAP-SIM code
Arran Cudbard-Bell [Tue, 24 Sep 2013 11:49:06 +0000 (12:49 +0100)]
Cleanup EAP-SIM code

10 years agoFix udpfromto bug on Mac OSX.
Alan T. DeKok [Mon, 23 Sep 2013 14:42:34 +0000 (10:42 -0400)]
Fix udpfromto bug on Mac OSX.

This is a NICE Mac OSX bug.  Create an interface with
two IP address, and then configure one listener for
each IP address.  Send thousands of packets to one
address, and some will show up on the OTHER socket.

This hack works ONLY if the clients are global.  If
each listener has the same client IP, but with
different secrets, then it will fail the rad_recv()
check above, and there's nothing you can do.

Linux does the right thing.

10 years agoClean up non-udpfromto code
Alan T. DeKok [Mon, 23 Sep 2013 01:52:47 +0000 (21:52 -0400)]
Clean up non-udpfromto code

So that it's simpler.  We also ALWAYS use udpfromto, as we assume
the library is used for IPv4 and IPv6 interfaces, not anything else.

10 years agocheck_cert_issuer in EAP-TLS broken in presence of X509v3 extensions
Alan T. DeKok [Sat, 21 Sep 2013 12:32:39 +0000 (08:32 -0400)]
check_cert_issuer in EAP-TLS broken in presence of X509v3 extensions

Patch from David Wood
Manual port of commit ce169385f

10 years agoMark request DONE when we start the cleanup delay
Alan T. DeKok [Fri, 20 Sep 2013 21:14:00 +0000 (17:14 -0400)]
Mark request DONE when we start the cleanup delay

10 years agoTypo
Arran Cudbard-Bell [Fri, 20 Sep 2013 19:41:36 +0000 (20:41 +0100)]
Typo

10 years agoOnly print EXIT info when ndef NDEBUG
Arran Cudbard-Bell [Mon, 16 Sep 2013 17:02:17 +0000 (18:02 +0100)]
Only print EXIT info when ndef NDEBUG

10 years agoWrap _exit and exit. Prints error message, and when running under GDB, raises SIGTRA...
Arran Cudbard-Bell [Mon, 16 Sep 2013 14:44:11 +0000 (15:44 +0100)]
Wrap _exit and exit.  Prints error message, and when running under GDB, raises SIGTRAP which causes debugger to break before exit.

10 years agoproxy_listener may be NULL. Closes #434
Alan T. DeKok [Fri, 20 Sep 2013 17:59:38 +0000 (13:59 -0400)]
proxy_listener may be NULL.  Closes #434

10 years agoDig src/billing out of more places
Arran Cudbard-Bell [Fri, 20 Sep 2013 16:02:22 +0000 (17:02 +0100)]
Dig src/billing out of more places

10 years agoRemove billing dir, those files don't belong there
Arran Cudbard-Bell [Fri, 20 Sep 2013 11:55:30 +0000 (12:55 +0100)]
Remove billing dir, those files don't belong there

10 years agoDon't delete the request if it's in the queue
Alan T. DeKok [Thu, 19 Sep 2013 18:10:17 +0000 (14:10 -0400)]
Don't delete the request if it's in the queue

request_done() should WAIT if the request is blocked in the queue.

It should also be callable by the child thread.  i.e. if the
master says "DONE" when it's in the queue, the child thread MAY
pick it up and call request->process().  Which should just say DONE
and stop

10 years agoPrint how many requests are blocked
Alan T. DeKok [Thu, 19 Sep 2013 18:09:43 +0000 (14:09 -0400)]
Print how many requests are blocked

So that the admin can see the queue grow over time

10 years agoShort-circuit "case"
Alan T. DeKok [Thu, 19 Sep 2013 01:54:25 +0000 (21:54 -0400)]
Short-circuit "case"

10 years agoRemove complaint for DHCP
Alan T. DeKok [Wed, 18 Sep 2013 14:36:52 +0000 (10:36 -0400)]
Remove complaint for DHCP

10 years agoTurn assert into talloc check.
Alan T. DeKok [Wed, 18 Sep 2013 14:12:24 +0000 (10:12 -0400)]
Turn assert into talloc check.

Which should get more information on error

10 years agoxlat expand profile filter
Arran Cudbard-Bell [Tue, 17 Sep 2013 22:03:01 +0000 (23:03 +0100)]
xlat expand profile filter

remove search for PW_USER_PROFILE and expand default profile instead. If people really want the old functionality they can just set default = "%{control:User-Profile}".

10 years agoDoxygen
Arran Cudbard-Bell [Tue, 17 Sep 2013 12:04:30 +0000 (13:04 +0100)]
Doxygen

10 years agoMake vp_prints_value_json behave the same as vp_prints_value
Arran Cudbard-Bell [Tue, 17 Sep 2013 11:23:09 +0000 (12:23 +0100)]
Make vp_prints_value_json behave the same as vp_prints_value

10 years agoFixup various functions in print.c to use common, consistent names for buffer pointer...
Arran Cudbard-Bell [Tue, 17 Sep 2013 10:02:13 +0000 (11:02 +0100)]
Fixup various functions in print.c to use common, consistent names for buffer pointers and lengths

10 years agoMake it build with GCD
Alan T. DeKok [Sun, 15 Sep 2013 17:18:29 +0000 (13:18 -0400)]
Make it build with GCD

10 years agoStupid doxygen
Arran Cudbard-Bell [Mon, 16 Sep 2013 16:04:46 +0000 (17:04 +0100)]
Stupid doxygen

10 years agoTypo
Arran Cudbard-Bell [Mon, 16 Sep 2013 15:59:20 +0000 (16:59 +0100)]
Typo

10 years agoPrint VP \t<name> <op> <value>\n as an atom to avoid issues when running with multipl...
Arran Cudbard-Bell [Mon, 16 Sep 2013 15:56:14 +0000 (16:56 +0100)]
Print VP \t<name> <op> <value>\n as an atom to avoid issues when running with multiple threads

10 years agoMinor typo in -h output
Arran Cudbard-Bell [Mon, 16 Sep 2013 10:45:41 +0000 (11:45 +0100)]
Minor typo in -h output

10 years agoShould be debug2
Arran Cudbard-Bell [Mon, 16 Sep 2013 10:34:47 +0000 (11:34 +0100)]
Should be debug2

10 years agoCleanup formatting in rlm_replicate
Arran Cudbard-Bell [Fri, 13 Sep 2013 12:57:51 +0000 (13:57 +0100)]
Cleanup formatting in rlm_replicate

10 years agoRemove extra debug
Alan T. DeKok [Fri, 13 Sep 2013 12:49:32 +0000 (08:49 -0400)]
Remove extra debug

10 years agoMake max_requests_per_server work
Alan T. DeKok [Fri, 13 Sep 2013 12:44:37 +0000 (08:44 -0400)]
Make max_requests_per_server work

10 years agoReplicated packet should be allocated in the request context
Arran Cudbard-Bell [Fri, 13 Sep 2013 12:32:20 +0000 (13:32 +0100)]
Replicated packet should be allocated in the request context

10 years agoUpdate file documentation and macro indentation in udpfromto
Arran Cudbard-Bell [Fri, 13 Sep 2013 12:29:10 +0000 (13:29 +0100)]
Update file documentation and macro indentation in udpfromto

10 years agoRevert "Simplify ID allocation so that we don't loop over all IDs"
Alan T. DeKok [Fri, 13 Sep 2013 11:51:12 +0000 (07:51 -0400)]
Revert "Simplify ID allocation so that we don't loop over all IDs"

This reverts commit a2ac633525c69a94ca3e1f91817a4b421f5375e6.

That commit (sadly) works only for one socket, not for multiple
ones.

10 years agoDocument libldap fail-over
Alan T. DeKok [Thu, 12 Sep 2013 15:07:57 +0000 (11:07 -0400)]
Document libldap fail-over

10 years agofree -> talloc_free in rlm_replicate
Arran Cudbard-Bell [Thu, 12 Sep 2013 14:47:19 +0000 (15:47 +0100)]
free -> talloc_free in rlm_replicate

10 years agoRemove extra \n
Alan T. DeKok [Wed, 11 Sep 2013 12:42:34 +0000 (08:42 -0400)]
Remove extra \n

10 years agoUse slightly better algorithm for random IDs
Alan T. DeKok [Wed, 11 Sep 2013 12:33:56 +0000 (08:33 -0400)]
Use slightly better algorithm for random IDs

10 years agoRemoved unused debugging messages
Alan T. DeKok [Wed, 11 Sep 2013 12:33:48 +0000 (08:33 -0400)]
Removed unused debugging messages

10 years agoUpdate radiusclients-openldap.ldif
Arran Cudbard-Bell [Wed, 11 Sep 2013 10:42:19 +0000 (06:42 -0400)]
Update radiusclients-openldap.ldif

10 years agoSingular
Arran Cudbard-Bell [Wed, 11 Sep 2013 10:40:22 +0000 (06:40 -0400)]
Singular

10 years agoInitialise server_ipaddr to 0
Arran Cudbard-Bell [Tue, 10 Sep 2013 15:21:44 +0000 (16:21 +0100)]
Initialise server_ipaddr to 0

Caused undefined behaviour if an auth section wasn't specified

10 years agoUse correct macros for defining IP string buffer lengths
Arran Cudbard-Bell [Tue, 10 Sep 2013 13:50:55 +0000 (14:50 +0100)]
Use correct macros for defining IP string buffer lengths

10 years agoUDP fromto should be on by default
Arran Cudbard-Bell [Tue, 10 Sep 2013 09:39:30 +0000 (10:39 +0100)]
UDP fromto should be on by default

10 years agoCorectly left justify helptext in configure
Arran Cudbard-Bell [Tue, 10 Sep 2013 09:37:40 +0000 (10:37 +0100)]
Corectly left justify helptext in configure

10 years agoWrap ASCTIME too
Arran Cudbard-Bell [Mon, 9 Sep 2013 23:41:50 +0000 (00:41 +0100)]
Wrap ASCTIME too

10 years agoFix typo
Alan T. DeKok [Mon, 9 Sep 2013 14:32:05 +0000 (10:32 -0400)]
Fix typo

10 years agoAllow for and document make -Draddbdir=/tmp/garbage install
Alan T. DeKok [Mon, 9 Sep 2013 14:19:11 +0000 (10:19 -0400)]
Allow for and document make -Draddbdir=/tmp/garbage install

10 years agoMake modconfdir expand in Makefile, not in the shell
Alan T. DeKok [Mon, 9 Sep 2013 14:17:18 +0000 (10:17 -0400)]
Make modconfdir expand in Makefile, not in the shell

10 years agoDon't copy cache control attributes when doing list copy. Closes #422
Arran Cudbard-Bell [Sun, 8 Sep 2013 17:02:33 +0000 (18:02 +0100)]
Don't copy cache control attributes when doing list copy.  Closes #422

10 years agoRemember the highest priority. Fixes #425
Alan T. DeKok [Sat, 7 Sep 2013 15:29:34 +0000 (11:29 -0400)]
Remember the highest priority.  Fixes #425

10 years agoUse typedef for components instead of "int"
Alan T. DeKok [Sat, 7 Sep 2013 15:01:04 +0000 (11:01 -0400)]
Use typedef for components instead of "int"

10 years agoClean up debug messages for open / close brace
Alan T. DeKok [Sat, 7 Sep 2013 15:04:46 +0000 (11:04 -0400)]
Clean up debug messages for open / close brace

10 years agoRevert "Use AUTZ rules for AUTH groups. Fixes #425"
Alan T. DeKok [Fri, 6 Sep 2013 21:08:42 +0000 (17:08 -0400)]
Revert "Use AUTZ rules for AUTH groups.  Fixes #425"

This reverts commit d57ce27f07552367d01210ff8b9f48fa88c11ea3.

Which apparently doesn't really work.  <sigh>

10 years agoMerge pull request #427 from annanymous2/patch-1
Arran Cudbard-Bell [Fri, 6 Sep 2013 11:12:44 +0000 (04:12 -0700)]
Merge pull request #427 from annanymous2/patch-1

Added endscript on logrotate

10 years agoFix doxygen release_3_0_0_rc1
Alan T. DeKok [Fri, 6 Sep 2013 14:37:33 +0000 (10:37 -0400)]
Fix doxygen

10 years agoUse AUTZ rules for AUTH groups. Fixes #425
Alan T. DeKok [Fri, 6 Sep 2013 14:05:57 +0000 (10:05 -0400)]
Use AUTZ rules for AUTH groups.  Fixes #425

10 years agoLog the first name of the group
Alan T. DeKok [Fri, 6 Sep 2013 14:05:25 +0000 (10:05 -0400)]
Log the first name of the group

So we see "Auth-Type foo {...}"
instead of "group foo {...}"

10 years agoRe-enable virtual attributes for comparison. Fixes #400
Alan T. DeKok [Thu, 5 Sep 2013 15:40:26 +0000 (11:40 -0400)]
Re-enable virtual attributes for comparison.  Fixes #400

10 years agoMissing newline
Arran Cudbard-Bell [Wed, 4 Sep 2013 21:23:51 +0000 (22:23 +0100)]
Missing newline

10 years agoFix shared-libs
Arran Cudbard-Bell [Wed, 4 Sep 2013 19:13:23 +0000 (20:13 +0100)]
Fix shared-libs

10 years agoIn debug builds, call assertion on panic
Alan T. DeKok [Wed, 4 Sep 2013 17:35:57 +0000 (13:35 -0400)]
In debug builds, call assertion on panic

10 years agoBe more careful about calling request_done(). Should fix #419
Alan T. DeKok [Wed, 4 Sep 2013 17:33:53 +0000 (13:33 -0400)]
Be more careful about calling request_done().  Should fix #419

10 years agoFixes for doxygen
Alan T. DeKok [Wed, 4 Sep 2013 17:07:45 +0000 (13:07 -0400)]
Fixes for doxygen

10 years agoUse the default request if there's no "." in the reference.
Alan T. DeKok [Wed, 4 Sep 2013 14:41:52 +0000 (10:41 -0400)]
Use the default request if there's no "." in the reference.

update outer.reply {
User-Name := foo
}

ends up parsing "User-Name" with a default list of "outer",
BUT because "User-Name" has no ".", the old code would return
a hard-coded CURRENT

10 years agoAdded %{debug_attr:...} from master
Alan T. DeKok [Wed, 4 Sep 2013 14:11:59 +0000 (10:11 -0400)]
Added %{debug_attr:...} from master

With some simplifications

10 years agoUse 'da' for DICT_ATTR*. "attribute' is for 'int'
Alan T. DeKok [Wed, 4 Sep 2013 13:44:36 +0000 (09:44 -0400)]
Use 'da' for DICT_ATTR*.  "attribute' is for 'int'

10 years agoSkip '&' on attribute maps. Closes #423
Alan T. DeKok [Wed, 4 Sep 2013 12:33:45 +0000 (08:33 -0400)]
Skip '&' on attribute maps.  Closes #423

And check return codes from request_name / list_name

10 years agoUpdate priority from child, too. Closes #424
Alan T. DeKok [Wed, 4 Sep 2013 12:22:28 +0000 (08:22 -0400)]
Update priority from child, too.  Closes #424

10 years agoDefine grouptype as an enum for debugging purposes
Arran Cudbard-Bell [Tue, 3 Sep 2013 23:18:29 +0000 (00:18 +0100)]
Define grouptype as an enum for debugging purposes

10 years agomap may return NULL
Alan T. DeKok [Tue, 3 Sep 2013 12:45:15 +0000 (08:45 -0400)]
map may return NULL

10 years agoDo a second pass over the conditions. Fixes #421
Alan T. DeKok [Tue, 3 Sep 2013 12:00:04 +0000 (08:00 -0400)]
Do a second pass over the conditions.  Fixes #421

Modules can register new attributes, so we may need to convert
literal comparisons to module comparisons.

The core can register new values for Auth-Type && friends
so we need to do a second pass to see if a failed lookup in pass1
is really a failure, or simply an early binding.

The next step is to add code to mark up late-registered paircompare
functions

10 years agoAllow for one/two-pass compilation of conditions.
Alan T. DeKok [Tue, 3 Sep 2013 01:32:48 +0000 (21:32 -0400)]
Allow for one/two-pass compilation of conditions.

If we allow two-pass compilation, certain errors are suppressed,
and the condition gets marked with a "pass2 flag"

10 years agoAdded "walk" function to conditions
Alan T. DeKok [Mon, 2 Sep 2013 13:30:51 +0000 (09:30 -0400)]
Added "walk" function to conditions

So that we can do post-processing

10 years agoFix ${value} expansion in backticked config pairs
Arran Cudbard-Bell [Tue, 3 Sep 2013 11:51:48 +0000 (12:51 +0100)]
Fix ${value} expansion in backticked config pairs

10 years agoOnly fallback to dynamic search if no attributes exist, or we have a failure of some...
Arran Cudbard-Bell [Tue, 3 Sep 2013 01:42:01 +0000 (02:42 +0100)]
Only fallback to dynamic search if no attributes exist, or we have a failure of some kind

10 years agoand another logic bug in ldap group code
Arran Cudbard-Bell [Tue, 3 Sep 2013 01:18:31 +0000 (02:18 +0100)]
and another logic bug in ldap group code

10 years agoLimit to -1, 0, 1 in normal operation so we can use -2 for error
Arran Cudbard-Bell [Tue, 3 Sep 2013 01:08:58 +0000 (02:08 +0100)]
Limit to -1, 0, 1 in normal operation so we can use -2 for error

10 years agoNot added to release branch
Arran Cudbard-Bell [Tue, 3 Sep 2013 00:36:34 +0000 (01:36 +0100)]
Not added to release branch

10 years agoFix broken group comparison logic
Arran Cudbard-Bell [Tue, 3 Sep 2013 00:35:11 +0000 (01:35 +0100)]
Fix broken group comparison logic

10 years agoPrint additional helpful group related debug
Arran Cudbard-Bell [Tue, 3 Sep 2013 00:06:41 +0000 (01:06 +0100)]
Print additional helpful group related debug

10 years agoTalloced strings get freed with talloc...?
Arran Cudbard-Bell [Mon, 2 Sep 2013 23:52:58 +0000 (00:52 +0100)]
Talloced strings get freed with talloc...?

10 years agoTypo
Arran Cudbard-Bell [Mon, 2 Sep 2013 23:36:35 +0000 (00:36 +0100)]
Typo

10 years agoDon't forget the NULL byte when copying VALUE_PAIR values
Arran Cudbard-Bell [Mon, 2 Sep 2013 23:32:50 +0000 (00:32 +0100)]
Don't forget the NULL byte when copying VALUE_PAIR values

10 years agoFix !* in update sections for non string attributes
Arran Cudbard-Bell [Mon, 2 Sep 2013 22:45:59 +0000 (23:45 +0100)]
Fix !* in update sections for non string attributes

10 years agoSet SQL username properly
Arran Cudbard-Bell [Mon, 2 Sep 2013 20:54:55 +0000 (21:54 +0100)]
Set SQL username properly

10 years agoRemove incorrect entry for membership_attribute
Arran Cudbard-Bell [Sun, 1 Sep 2013 15:07:18 +0000 (16:07 +0100)]
Remove incorrect entry for membership_attribute

10 years agounlang update sections support exec
Arran Cudbard-Bell [Sun, 1 Sep 2013 11:23:09 +0000 (12:23 +0100)]
unlang update sections support exec

10 years agoUse destructors to do the cleanup for VALUE_PAIRs
Arran Cudbard-Bell [Sat, 31 Aug 2013 16:56:49 +0000 (17:56 +0100)]
Use destructors to do the cleanup for VALUE_PAIRs

10 years agoFix -Wsometimes-uninitialized
Arran Cudbard-Bell [Fri, 30 Aug 2013 13:15:33 +0000 (14:15 +0100)]
Fix -Wsometimes-uninitialized

10 years agoRecord whether the server was built with NDEBUG in features.h
Arran Cudbard-Bell [Fri, 30 Aug 2013 13:14:20 +0000 (14:14 +0100)]
Record whether the server was built with NDEBUG in features.h

10 years agoSprinkle VERIFY_VP throughout the encoder
Arran Cudbard-Bell [Wed, 28 Aug 2013 13:38:32 +0000 (14:38 +0100)]
Sprinkle VERIFY_VP throughout the encoder

10 years agoCorrect typo. We should use foreach_depth as the request data index not stack depth.
Arran Cudbard-Bell [Tue, 27 Aug 2013 16:43:19 +0000 (17:43 +0100)]
Correct typo.  We should use foreach_depth as the request data index not stack depth.

Various whitespace fixes

10 years agoCorrect logic for "elsif"
Alan T. DeKok [Mon, 26 Aug 2013 12:25:40 +0000 (08:25 -0400)]
Correct logic for "elsif"

10 years agoClean up debug / info messages
Alan T. DeKok [Mon, 26 Aug 2013 12:16:46 +0000 (08:16 -0400)]
Clean up debug / info messages

10 years agoInitialize "found"
Alan T. DeKok [Mon, 26 Aug 2013 12:01:54 +0000 (08:01 -0400)]
Initialize "found"

10 years agoFix typo in debug message
Alan T. DeKok [Sun, 25 Aug 2013 14:34:27 +0000 (10:34 -0400)]
Fix typo in debug message

10 years agoFix placement of parse error in condition
Alan T. DeKok [Sat, 24 Aug 2013 14:23:01 +0000 (10:23 -0400)]
Fix placement of parse error in condition