freeradius.git
10 years agoDEBUG2 --> RDEBUG2 for messages
Alan T. DeKok [Sat, 24 May 2014 15:50:58 +0000 (11:50 -0400)]
DEBUG2 --> RDEBUG2 for messages

10 years agoCatch race condition in proxy_reply
Alan T. DeKok [Sat, 24 May 2014 15:49:46 +0000 (11:49 -0400)]
Catch race condition in proxy_reply

If we've decided there's no reply, then we don't use it, even
if one comes in

10 years agoAdd check for limits.h
Arran Cudbard-Bell [Sat, 24 May 2014 15:37:16 +0000 (16:37 +0100)]
Add check for limits.h

10 years agoAdd limits.h to libradius.h
Arran Cudbard-Bell [Sat, 24 May 2014 15:10:58 +0000 (16:10 +0100)]
Add limits.h to libradius.h

10 years agoChange num to int
Arran Cudbard-Bell [Sat, 24 May 2014 15:01:13 +0000 (16:01 +0100)]
Change num to int

10 years agoTypo
Arran Cudbard-Bell [Sat, 24 May 2014 14:49:17 +0000 (15:49 +0100)]
Typo

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sat, 24 May 2014 12:31:02 +0000 (13:31 +0100)]
Update ChangeLog

10 years agoAdd xlat to print the current tag of an attribute
Arran Cudbard-Bell [Sat, 24 May 2014 12:27:47 +0000 (13:27 +0100)]
Add xlat to print the current tag of an attribute

10 years ago#647 only appeared after 3.0.3 and #648 is so minor it doesn't need mentioning
Arran Cudbard-Bell [Sat, 24 May 2014 12:03:56 +0000 (13:03 +0100)]
#647 only appeared after 3.0.3 and #648 is so minor it doesn't need mentioning

10 years agoUpdate ChangeLog release_3_0_4_rc0
Arran Cudbard-Bell [Sat, 24 May 2014 11:52:17 +0000 (12:52 +0100)]
Update ChangeLog

10 years agoShould be signed
Arran Cudbard-Bell [Sat, 24 May 2014 11:12:49 +0000 (12:12 +0100)]
Should be signed

10 years agoVarious coverity fixes
Arran Cudbard-Bell [Sat, 24 May 2014 11:03:58 +0000 (12:03 +0100)]
Various coverity fixes

10 years agoDon't SEGV on parse error in unittest
Arran Cudbard-Bell [Sat, 24 May 2014 10:39:29 +0000 (11:39 +0100)]
Don't SEGV on parse error in unittest

10 years agoclang analyzer issue
Arran Cudbard-Bell [Sat, 24 May 2014 09:56:52 +0000 (10:56 +0100)]
clang analyzer issue

10 years agoReformatting
Arran Cudbard-Bell [Sat, 24 May 2014 09:48:23 +0000 (10:48 +0100)]
Reformatting

10 years agoTests for removal by tag and index
Arran Cudbard-Bell [Sat, 24 May 2014 09:43:35 +0000 (10:43 +0100)]
Tests for removal by tag and index

Make tag processing consistent everywhere

Make all internally created VALUE_PAIRs default to TAG_ANY so that when used as 'check'/'filter' vps they match all tagged and untagged attributes.

10 years agoVarious fixups in xlat_getvp
Arran Cudbard-Bell [Fri, 23 May 2014 22:05:51 +0000 (23:05 +0100)]
Various fixups in xlat_getvp

10 years agonumber xlat-attr-tag
Arran Cudbard-Bell [Fri, 23 May 2014 22:02:36 +0000 (23:02 +0100)]
number xlat-attr-tag

10 years agononnull declarations should go at the begining
Arran Cudbard-Bell [Fri, 23 May 2014 21:08:59 +0000 (22:08 +0100)]
nonnull declarations should go at the begining

10 years agoMinor fixes in pairmake
Arran Cudbard-Bell [Fri, 23 May 2014 22:01:26 +0000 (23:01 +0100)]
Minor fixes in pairmake

10 years agoFix tag filter debug
Arran Cudbard-Bell [Fri, 23 May 2014 22:00:23 +0000 (23:00 +0100)]
Fix tag filter debug

10 years agoUsing [*] [#] [0] on fake attributes should produce the same result as on the real...
Arran Cudbard-Bell [Fri, 23 May 2014 21:01:09 +0000 (22:01 +0100)]
Using [*] [#] [0] on fake attributes should produce the same result as on the real ones

10 years agoDon't assert on list copy (head should of been NULL after adding all it's pairs)
Arran Cudbard-Bell [Fri, 23 May 2014 21:08:43 +0000 (22:08 +0100)]
Don't assert on list copy (head should of been NULL after adding all it's pairs)

10 years agoFix more places where tags weren't respected correctly
Arran Cudbard-Bell [Fri, 23 May 2014 17:39:19 +0000 (18:39 +0100)]
Fix more places where tags weren't respected correctly

10 years agoFix ref to re-named test
Alan T. DeKok [Fri, 23 May 2014 17:14:27 +0000 (13:14 -0400)]
Fix ref to re-named test

10 years agoSimplify proxy no reply case. Closes #657
Alan T. DeKok [Fri, 23 May 2014 16:31:07 +0000 (12:31 -0400)]
Simplify proxy no reply case.  Closes #657

10 years agoAdd tag correction pass so update sections insert tagged attributes again
Arran Cudbard-Bell [Fri, 23 May 2014 16:18:31 +0000 (17:18 +0100)]
Add tag correction pass so update sections insert tagged attributes again

10 years agoAdd additional texts for index
Arran Cudbard-Bell [Fri, 23 May 2014 16:00:13 +0000 (17:00 +0100)]
Add additional texts for index

10 years agoAllow Post-Proxy-Type Fail. Closes #656
Alan T. DeKok [Fri, 23 May 2014 15:24:18 +0000 (11:24 -0400)]
Allow Post-Proxy-Type Fail.  Closes #656

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 23 May 2014 15:16:46 +0000 (16:16 +0100)]
Update ChangeLog

10 years agoTypo
Arran Cudbard-Bell [Fri, 23 May 2014 14:59:46 +0000 (15:59 +0100)]
Typo

10 years agoFix merge issue
Arran Cudbard-Bell [Fri, 23 May 2014 14:44:18 +0000 (15:44 +0100)]
Fix merge issue

10 years agoredhat: add rlm_unpack, remove rlm_unbound config
Fajar A. Nugraha [Fri, 23 May 2014 13:33:46 +0000 (20:33 +0700)]
redhat: add rlm_unpack, remove rlm_unbound config

10 years agoChange array index range back to between 0-1000
Arran Cudbard-Bell [Fri, 23 May 2014 14:00:06 +0000 (15:00 +0100)]
Change array index range back to between 0-1000

10 years agoFix corner case when using fr_cursor_remove and fr_cursor_next_by_da together
Arran Cudbard-Bell [Fri, 23 May 2014 13:49:49 +0000 (14:49 +0100)]
Fix corner case when using fr_cursor_remove and fr_cursor_next_by_da together

10 years agoFix array offsets to that offset 0 is differentiated from no offset
Arran Cudbard-Bell [Fri, 23 May 2014 13:14:23 +0000 (14:14 +0100)]
Fix array offsets to that offset 0 is differentiated from no offset

10 years agoRework map2request to process multiple attributes returned from func, correctly Fixes...
Arran Cudbard-Bell [Fri, 23 May 2014 13:06:54 +0000 (14:06 +0100)]
Rework map2request to process multiple attributes returned from func, correctly Fixes #652

10 years agoUse the same num/tag field widths and values in xlat and VPT code, this allows us...
Arran Cudbard-Bell [Fri, 23 May 2014 13:02:25 +0000 (14:02 +0100)]
Use the same num/tag field widths and values in xlat and VPT code, this allows us to optimised attribute and tag selection XLATs to VPTs in some instances.

10 years agoShould be using the macro to access attribute.num
Arran Cudbard-Bell [Fri, 23 May 2014 13:09:35 +0000 (14:09 +0100)]
Should be using the macro to access attribute.num

10 years agoFormatting and better error messages in radius_tmpl2str
Arran Cudbard-Bell [Fri, 23 May 2014 12:15:55 +0000 (13:15 +0100)]
Formatting and better error messages in radius_tmpl2str

10 years agoEnumerate failures in base64 test
Arran Cudbard-Bell [Fri, 23 May 2014 12:14:11 +0000 (13:14 +0100)]
Enumerate failures in base64 test

10 years agoAdd more tests for deletions
Arran Cudbard-Bell [Thu, 22 May 2014 21:44:37 +0000 (22:44 +0100)]
Add more tests for deletions

10 years agoUse sql_rcode_t
Arran Cudbard-Bell [Thu, 22 May 2014 18:52:31 +0000 (19:52 +0100)]
Use sql_rcode_t

10 years agoupdate-operator test should use += to add failures
Arran Cudbard-Bell [Thu, 22 May 2014 19:57:26 +0000 (20:57 +0100)]
update-operator test should use += to add failures

10 years agoNewer name for control list should have priority
Arran Cudbard-Bell [Thu, 22 May 2014 15:58:26 +0000 (16:58 +0100)]
Newer name for control list should have priority

10 years agomake rad_assert_fail call fr_fault(SIGABRT) (instead of abort) so we have a better...
Arran Cudbard-Bell [Thu, 22 May 2014 19:56:40 +0000 (20:56 +0100)]
make rad_assert_fail call fr_fault(SIGABRT) (instead of abort) so we have a better chance of entering the debugger with a valid stack

10 years agoFormatting
Arran Cudbard-Bell [Thu, 22 May 2014 21:16:20 +0000 (22:16 +0100)]
Formatting

10 years agoAdd fr_cursor_last
Arran Cudbard-Bell [Thu, 22 May 2014 19:55:54 +0000 (20:55 +0100)]
Add fr_cursor_last

10 years agoAllow Post-Proxy-Type Fail. Closes #653
Alan T. DeKok [Fri, 23 May 2014 12:51:40 +0000 (08:51 -0400)]
Allow Post-Proxy-Type Fail.  Closes #653

10 years agoRun pass2_cb on components once, not for each component
Alan T. DeKok [Thu, 22 May 2014 19:55:42 +0000 (15:55 -0400)]
Run pass2_cb on components once, not for each component

10 years agoDo pass2 only once. Closes #650
Alan T. DeKok [Thu, 22 May 2014 13:31:20 +0000 (09:31 -0400)]
Do pass2 only once.  Closes #650

A temporary fix until we can find out why it's loading the
same thing multiple times

10 years agoNeed to pass CPPFLAGS to the analyser too
Arran Cudbard-Bell [Thu, 22 May 2014 11:50:08 +0000 (12:50 +0100)]
Need to pass CPPFLAGS to the analyser too

10 years agoNeed to check that rlm_sql_select_query != RLM_SQL_OK, < 0 is not enough as it may...
Arran Cudbard-Bell [Thu, 22 May 2014 11:48:06 +0000 (12:48 +0100)]
Need to check that rlm_sql_select_query != RLM_SQL_OK, < 0 is not enough as it may return RLM_SQL_RECONNECT Fixes #651

10 years agoSection can sometimes be NULL
Arran Cudbard-Bell [Thu, 22 May 2014 11:47:04 +0000 (12:47 +0100)]
Section can sometimes be NULL

10 years agoRemove useless wrapper functions in the postgresql driver
Arran Cudbard-Bell [Thu, 22 May 2014 11:45:51 +0000 (12:45 +0100)]
Remove useless wrapper functions in the postgresql driver

10 years agoMarkup more SQL functions as nonnull
Arran Cudbard-Bell [Thu, 22 May 2014 11:19:05 +0000 (12:19 +0100)]
Markup more SQL functions as nonnull

10 years agoWhitespace
Arran Cudbard-Bell [Thu, 22 May 2014 11:08:50 +0000 (12:08 +0100)]
Whitespace

10 years agoFix dumb errors in the rlm_sql reconnection logic. Fixes #651
Arran Cudbard-Bell [Thu, 22 May 2014 11:07:18 +0000 (12:07 +0100)]
Fix dumb errors in the rlm_sql reconnection logic. Fixes #651

10 years agoBackport boiler.mk from master
Arran Cudbard-Bell [Thu, 22 May 2014 10:36:58 +0000 (11:36 +0100)]
Backport boiler.mk from master

10 years agoWhitespace
Arran Cudbard-Bell [Thu, 22 May 2014 10:36:47 +0000 (11:36 +0100)]
Whitespace

10 years agoPass pointer to the handle instead of handle in SQL group functions
Arran Cudbard-Bell [Thu, 22 May 2014 10:14:06 +0000 (11:14 +0100)]
Pass pointer to the handle instead of handle in SQL group functions

10 years agoAdd a few more enum types
Arran Cudbard-Bell [Wed, 21 May 2014 21:48:01 +0000 (22:48 +0100)]
Add a few more enum types

10 years agoAdd PW_TYPE_SIGNED and PW_TYPE_INTEGER64 to the conffile parser
Arran Cudbard-Bell [Wed, 21 May 2014 21:46:20 +0000 (22:46 +0100)]
Add PW_TYPE_SIGNED and PW_TYPE_INTEGER64 to the conffile parser

PW_TYPE_INTEGER was being used to create signed ints, which in the vast majority of places was wrong (they needed unsigned ints).

For anything which does need signed ints there's now PW_TYPE_SIGNED.

10 years agoFixup types in rlm_couchbase instance struct, and add type validation
Arran Cudbard-Bell [Wed, 21 May 2014 18:30:08 +0000 (19:30 +0100)]
Fixup types in rlm_couchbase instance struct, and add type validation

10 years agoNote recent changes
Alan T. DeKok [Thu, 22 May 2014 01:27:23 +0000 (21:27 -0400)]
Note recent changes

10 years agoClean up proxy reply handling. Fixes #637
Alan T. DeKok [Wed, 21 May 2014 20:36:24 +0000 (16:36 -0400)]
Clean up proxy reply handling.  Fixes #637

10 years agoActually set timevals
Alan T. DeKok [Wed, 21 May 2014 20:27:20 +0000 (16:27 -0400)]
Actually set timevals

10 years agoUse correct ip address for message
Alan T. DeKok [Wed, 21 May 2014 20:18:10 +0000 (16:18 -0400)]
Use correct ip address for message

10 years agoApply pointer type validation to config items which use direct pointers into structures
Arran Cudbard-Bell [Wed, 21 May 2014 17:34:41 +0000 (18:34 +0100)]
Apply pointer type validation to config items which use direct pointers into structures

10 years agoRemove unused config item
Arran Cudbard-Bell [Wed, 21 May 2014 16:33:41 +0000 (17:33 +0100)]
Remove unused config item

10 years agogcc fixes
Arran Cudbard-Bell [Wed, 21 May 2014 16:29:42 +0000 (17:29 +0100)]
gcc fixes

10 years agoMore talloc_steal
Alan T. DeKok [Wed, 21 May 2014 15:50:21 +0000 (11:50 -0400)]
More talloc_steal

10 years agoFix consting in rlm_unbound
Arran Cudbard-Bell [Wed, 21 May 2014 15:15:45 +0000 (16:15 +0100)]
Fix consting in rlm_unbound

10 years agoFix duplicate definition of mod_rcode_table
Arran Cudbard-Bell [Wed, 21 May 2014 14:51:28 +0000 (15:51 +0100)]
Fix duplicate definition of mod_rcode_table

10 years agoAdd autoconf checks for builtins, __has_builtin doesn't seem to work correctly with...
Arran Cudbard-Bell [Wed, 21 May 2014 14:31:02 +0000 (15:31 +0100)]
Add autoconf checks for builtins, __has_builtin doesn't seem to work correctly with clang 3.4 and __builtin_choose_expr/__builtin_types_compatible_p

10 years agoAdd "show module status"
Alan T. DeKok [Wed, 21 May 2014 14:28:46 +0000 (10:28 -0400)]
Add "show module status"

10 years agoAdd framework for compile time type checking
Arran Cudbard-Bell [Wed, 21 May 2014 10:57:00 +0000 (11:57 +0100)]
Add framework for compile time type checking

10 years agoCleanup some of the build macros and add __has_builtin
Arran Cudbard-Bell [Wed, 21 May 2014 10:56:17 +0000 (11:56 +0100)]
Cleanup some of the build macros and add __has_builtin

10 years agoDeal with boolean in more switch statements
Arran Cudbard-Bell [Wed, 21 May 2014 07:08:25 +0000 (08:08 +0100)]
Deal with boolean in more switch statements

10 years agoChange PW_TYPE_STRING_PTR to PW_TYPE_STRING
Arran Cudbard-Bell [Wed, 21 May 2014 06:55:07 +0000 (07:55 +0100)]
Change PW_TYPE_STRING_PTR to PW_TYPE_STRING

There's no point in distinguishing between the two

10 years agoAdd PW_TYPE_BOOLEAN as a proper type
Arran Cudbard-Bell [Wed, 21 May 2014 06:54:17 +0000 (07:54 +0100)]
Add PW_TYPE_BOOLEAN as a proper type

10 years agoMake PW_TYPE_FILE_INPUT and PW_TYPE_FILE_OUTPUT into string types
Arran Cudbard-Bell [Wed, 21 May 2014 06:53:11 +0000 (07:53 +0100)]
Make PW_TYPE_FILE_INPUT and PW_TYPE_FILE_OUTPUT into string types

10 years agoMerge pull request #648 from leprechau/feature-fix
Arran Cudbard-Bell [Wed, 21 May 2014 05:50:18 +0000 (06:50 +0100)]
Merge pull request #648 from leprechau/feature-fix

minor fixes for missing functions in old json-c

10 years agoMerge pull request #647 from leprechau/v3.0.x
Arran Cudbard-Bell [Wed, 21 May 2014 05:49:59 +0000 (06:49 +0100)]
Merge pull request #647 from leprechau/v3.0.x

add missing 'acct' option to struct

10 years agominor fixes for missing functions in old json-c
Aaron Hurt [Wed, 21 May 2014 03:11:56 +0000 (22:11 -0500)]
minor fixes for missing functions in old json-c
* upstream json_object_get_string_len returns 0 if object is not type string
* small indentation fix

10 years agoadd missing 'acct' option to struct
Aaron Hurt [Wed, 21 May 2014 03:00:58 +0000 (22:00 -0500)]
add missing 'acct' option to struct

10 years agocleanup comments
Arran Cudbard-Bell [Tue, 20 May 2014 18:59:54 +0000 (19:59 +0100)]
cleanup comments

10 years agoSet port in radclient 'auto' mode too
Arran Cudbard-Bell [Tue, 20 May 2014 18:54:19 +0000 (19:54 +0100)]
Set port in radclient 'auto' mode too

10 years agoMake response_window a struct timeval
Alan T. DeKok [Tue, 20 May 2014 15:00:53 +0000 (11:00 -0400)]
Make response_window a struct timeval

10 years agoAdd parser for PW_TYPE_TIMEVAL
Alan T. DeKok [Tue, 20 May 2014 14:45:46 +0000 (10:45 -0400)]
Add parser for PW_TYPE_TIMEVAL

10 years agoCreate new type PW_TYPE_TIMEVAL
Alan T. DeKok [Tue, 20 May 2014 14:33:22 +0000 (10:33 -0400)]
Create new type PW_TYPE_TIMEVAL

10 years agoOnly check if were building with libssl
Arran Cudbard-Bell [Tue, 20 May 2014 10:25:12 +0000 (11:25 +0100)]
Only check if were building with libssl

10 years agoFix potential NULL dereference found by scan
Arran Cudbard-Bell [Tue, 20 May 2014 10:21:18 +0000 (11:21 +0100)]
Fix potential NULL dereference found by scan

10 years agoWe need to initialise SSL before reading the main config Fixes #646
Arran Cudbard-Bell [Tue, 20 May 2014 09:00:29 +0000 (10:00 +0100)]
We need to initialise SSL before reading the main config Fixes #646

It was initialised before instantiating the modules, but that's probably not enough for RADSEC

10 years agodebian: debian/compat 9 -> 7
Fajar A. Nugraha [Mon, 19 May 2014 09:39:15 +0000 (16:39 +0700)]
debian: debian/compat 9 -> 7

10 years agodebian: changed required debhelper to (>= 7.4)
Fajar A. Nugraha [Mon, 19 May 2014 09:23:50 +0000 (16:23 +0700)]
debian: changed required debhelper to (>= 7.4)

10 years agodebian: update radiusd-to-freeradius.diff
Fajar A. Nugraha [Mon, 19 May 2014 08:27:09 +0000 (15:27 +0700)]
debian: update radiusd-to-freeradius.diff

10 years agoAdd some basic indenting
Arran Cudbard-Bell [Sun, 18 May 2014 16:49:00 +0000 (17:49 +0100)]
Add some basic indenting

10 years agoRemove trailing periods in log messages
Arran Cudbard-Bell [Sun, 18 May 2014 16:35:14 +0000 (17:35 +0100)]
Remove trailing periods in log messages

10 years agoAdd RINDENT and REXDENT macros
Arran Cudbard-Bell [Sun, 18 May 2014 16:31:21 +0000 (17:31 +0100)]
Add RINDENT and REXDENT macros