freeradius.git
10 years agoAdd more incoming DHCP packet types to config
Matthew Newton [Fri, 14 Mar 2014 14:21:46 +0000 (14:21 +0000)]
Add more incoming DHCP packet types to config

10 years agoUpdate documentation for DHCP unknown packet types
Alan T. DeKok [Fri, 14 Mar 2014 14:00:51 +0000 (10:00 -0400)]
Update documentation for DHCP unknown packet types

10 years agoCheck for client/home entries. Fixes #547
Alan T. DeKok [Fri, 14 Mar 2014 13:30:06 +0000 (09:30 -0400)]
Check for client/home entries.  Fixes #547

10 years agoRemove warnings that DHCP is experimental
Alan T. DeKok [Fri, 14 Mar 2014 13:21:19 +0000 (09:21 -0400)]
Remove warnings that DHCP is experimental

10 years agoIf relay IP is 0.0.0.0, don't use it
Alan T. DeKok [Thu, 13 Mar 2014 18:00:51 +0000 (14:00 -0400)]
If relay IP is 0.0.0.0, don't use it

10 years agoIf the request was unicast, the reply can be unicast, too
Alan T. DeKok [Thu, 13 Mar 2014 17:59:15 +0000 (13:59 -0400)]
If the request was unicast, the reply can be unicast, too

10 years agoRe-added missing line
Alan T. DeKok [Thu, 13 Mar 2014 15:39:08 +0000 (11:39 -0400)]
Re-added missing line

10 years agoNote recent changes
Alan T. DeKok [Thu, 13 Mar 2014 14:25:27 +0000 (10:25 -0400)]
Note recent changes

10 years agoDocument src_ipaddr
Alan T. DeKok [Thu, 13 Mar 2014 14:25:12 +0000 (10:25 -0400)]
Document src_ipaddr

10 years agoSet src IP on more situations.
Alan T. DeKok [Thu, 13 Mar 2014 14:17:00 +0000 (10:17 -0400)]
Set src IP on more situations.

If the admin set "ipaddr = *", and no "src_ipaddr = ...", then
we used to send packets from 0.0.0.0.  That's wrong.

We now look for server identifier or server IP address.
If one of those is found, we use that as the source IP

10 years agoFix new warnings emitted by clang
Arran Cudbard-Bell [Thu, 13 Mar 2014 12:36:55 +0000 (12:36 +0000)]
Fix new warnings emitted by clang

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Thu, 13 Mar 2014 08:33:27 +0000 (08:33 +0000)]
Update ChangeLog

10 years agoFormatting and extra debugging in rlm_attr_filter
Arran Cudbard-Bell [Wed, 12 Mar 2014 22:08:57 +0000 (22:08 +0000)]
Formatting and extra debugging in rlm_attr_filter

10 years agoCompare da not just attribute number (fix clashing vendor and RFC space attributes)
Arran Cudbard-Bell [Wed, 12 Mar 2014 22:08:22 +0000 (22:08 +0000)]
Compare da not just attribute number (fix clashing vendor and RFC space attributes)

10 years agoCorrect comment
Arran Cudbard-Bell [Wed, 12 Mar 2014 21:41:26 +0000 (21:41 +0000)]
Correct comment

10 years agoFix typos
Alan T. DeKok [Wed, 12 Mar 2014 21:36:55 +0000 (17:36 -0400)]
Fix typos

10 years agoRe-arrange normalization code in parser
Alan T. DeKok [Wed, 12 Mar 2014 18:34:51 +0000 (14:34 -0400)]
Re-arrange normalization code in parser

also make map return a valid map, no matter what the operator
having hacks in the map parser to deal with =* and ~* is wrong

10 years agoPrint out more information with -xx
Alan T. DeKok [Wed, 12 Mar 2014 18:16:38 +0000 (14:16 -0400)]
Print out more information with -xx

10 years agoNormalize literals in conditions
Alan T. DeKok [Wed, 12 Mar 2014 18:05:56 +0000 (14:05 -0400)]
Normalize literals in conditions

if ('') is false
if ("foo") is true
if (bar) is invalid, as the condition needs to be a module rcode

10 years agoUpdated example
Alan T. DeKok [Wed, 12 Mar 2014 15:04:00 +0000 (11:04 -0400)]
Updated example

10 years agoMerge pull request #546 from mcnewton/v3.0.x
Arran Cudbard-Bell [Wed, 12 Mar 2014 16:56:21 +0000 (16:56 +0000)]
Merge pull request #546 from mcnewton/v3.0.x

V3.0.x

10 years agodhcp config comments about mac2ip
Matthew Newton [Wed, 12 Mar 2014 16:44:19 +0000 (16:44 +0000)]
dhcp config comments about mac2ip

10 years agoadd comments about dhcp listen section
Matthew Newton [Wed, 12 Mar 2014 16:38:03 +0000 (16:38 +0000)]
add comments about dhcp listen section

10 years agoMerge pull request #545 from mcnewton/v3.0.x
Alan DeKok [Wed, 12 Mar 2014 16:27:29 +0000 (12:27 -0400)]
Merge pull request #545 from mcnewton/v3.0.x

V3.0.x

10 years agoadd DHCP-Do-Not-Respond value to make it easier to not respond
Matthew Newton [Wed, 12 Mar 2014 16:22:45 +0000 (16:22 +0000)]
add DHCP-Do-Not-Respond value to make it easier to not respond

10 years agoadd some dhcp comment documentation
Matthew Newton [Wed, 12 Mar 2014 16:20:57 +0000 (16:20 +0000)]
add some dhcp comment documentation

10 years agoMerge pull request #543 from mcnewton/v3.0.x
Arran Cudbard-Bell [Wed, 12 Mar 2014 13:42:53 +0000 (13:42 +0000)]
Merge pull request #543 from mcnewton/v3.0.x

set ht to null so we don't double free on initialisation error

10 years agodon't respond to dhcp if there is nowhere to respond to
Matthew Newton [Wed, 12 Mar 2014 13:24:04 +0000 (13:24 +0000)]
don't respond to dhcp if there is nowhere to respond to

10 years agoMinor formatting in dhcp.c
Arran Cudbard-Bell [Wed, 12 Mar 2014 09:16:33 +0000 (09:16 +0000)]
Minor formatting in dhcp.c

10 years agoClarify error message
Alan T. DeKok [Tue, 11 Mar 2014 23:51:03 +0000 (19:51 -0400)]
Clarify error message

10 years agoSpace for clarity
Alan T. DeKok [Tue, 11 Mar 2014 23:49:25 +0000 (19:49 -0400)]
Space for clarity

10 years agoLoad protocol-specific dictionaries if built with them.
Alan T. DeKok [Tue, 11 Mar 2014 23:36:25 +0000 (19:36 -0400)]
Load protocol-specific dictionaries if built with them.

The code in parser.c does static evaluation of things like

if (DHCP-foo == ...)

When the DHCP dictionaries aren't loaded, that turns into static
comparison of two strings, which is always false.  Changing it to

if (&DHCP-foo == ...)

makes it bail with an unknown attribute error.  This is because
we don't have pass2 fixups for that case.

10 years agoMore debugging for evaluation
Alan T. DeKok [Tue, 11 Mar 2014 23:30:18 +0000 (19:30 -0400)]
More debugging for evaluation

protected by a #ifdef, so normal people don't see it

10 years agoClarify comment
Alan T. DeKok [Tue, 11 Mar 2014 23:29:39 +0000 (19:29 -0400)]
Clarify comment

10 years agoSwitch some talloc_free's to TALLOC_FREE's
Arran Cudbard-Bell [Tue, 11 Mar 2014 20:23:56 +0000 (20:23 +0000)]
Switch some talloc_free's to TALLOC_FREE's

10 years agoLoad DHCP + VMPS dictionaries before loading any modules
Alan T. DeKok [Tue, 11 Mar 2014 14:20:53 +0000 (10:20 -0400)]
Load DHCP + VMPS dictionaries before loading any modules

So that the attribute definitions are available to the
modules and their configuration

10 years agoCopy pointer, not thing it's pointing to
Alan T. DeKok [Tue, 11 Mar 2014 14:08:39 +0000 (10:08 -0400)]
Copy pointer, not thing it's pointing to

10 years agoMerge pull request #544 from spaetow/v3.0.x
Arran Cudbard-Bell [Tue, 11 Mar 2014 12:07:06 +0000 (12:07 +0000)]
Merge pull request #544 from spaetow/v3.0.x

Update freeradius.spec

10 years agoUpdate freeradius.spec
Stefan Paetow [Tue, 11 Mar 2014 11:54:38 +0000 (11:54 +0000)]
Update freeradius.spec

Add the DHCP IPPOOL to the Oracle module.

10 years agoSet fields to NULL after free'ing them
Alan T. DeKok [Mon, 10 Mar 2014 22:37:22 +0000 (18:37 -0400)]
Set fields to NULL after free'ing them

10 years agoMerge pull request #542 from mcnewton/v3.0.x
Arran Cudbard-Bell [Mon, 10 Mar 2014 21:30:07 +0000 (21:30 +0000)]
Merge pull request #542 from mcnewton/v3.0.x

fixup comment on unix opening bracket

10 years agofixup comment on unix opening bracket
Matthew Newton [Mon, 10 Mar 2014 21:24:11 +0000 (21:24 +0000)]
fixup comment on unix opening bracket

10 years agoFix documentation in comments
Alan T. DeKok [Mon, 10 Mar 2014 18:36:37 +0000 (14:36 -0400)]
Fix documentation in comments

10 years agoDecoded passwords have to have {...}
Alan T. DeKok [Mon, 10 Mar 2014 12:26:59 +0000 (08:26 -0400)]
Decoded passwords have to have {...}

10 years agoNote recent changes
Alan T. DeKok [Mon, 10 Mar 2014 12:21:59 +0000 (08:21 -0400)]
Note recent changes

10 years agoFix many issues in rlm_sqlcounter
Arran Cudbard-Bell [Sat, 8 Mar 2014 11:35:52 +0000 (11:35 +0000)]
Fix many issues in rlm_sqlcounter

10 years agoFixup error logging in rlm_sql xlat
Arran Cudbard-Bell [Sat, 8 Mar 2014 11:34:30 +0000 (11:34 +0000)]
Fixup error logging in rlm_sql xlat

10 years agoNote recent changes
Alan T. DeKok [Fri, 7 Mar 2014 21:04:27 +0000 (21:04 +0000)]
Note recent changes

10 years agoAdded Oracle schema and queries files for use with dhcp_sqlippool
Ben Thompson [Fri, 7 Mar 2014 05:01:53 +0000 (09:01 +0400)]
Added Oracle schema and queries files for use with dhcp_sqlippool

10 years agoInitialize IPv6 scope in ip_ptonx
Nikolai Kondrashov [Thu, 6 Mar 2014 13:41:18 +0000 (15:41 +0200)]
Initialize IPv6 scope in ip_ptonx

Set IPv6 address scope ID (fr_ip_addr_t.scope) to zero in ip_ptonx.

This avoids possible random %{getclient:<ipaddr>.foo} IPv6 client lookup
failures due to the scope ID being uninitialized, but then used in
fr_ipaddr_cmp, invoked by client_find, used in xlat_getclient.

The issue was found during a Coverity scan of 3.0.1 and reported as
follows:

freeradius-server-3.0.1/src/main/mainconfig.c:374: var_decl: Declaring variable "ip" without initializer.
freeradius-server-3.0.1/src/main/mainconfig.c:394: uninit_use_in_call: Using uninitialized value "ip". Field "ip.scope" is uninitialized when calling "client_find(RADCLIENT_LIST const *, fr_ipaddr_t const *, int)".
freeradius-server-3.0.1/src/main/client.c:466:3: read_parm: Reading a parameter value.

10 years agoChange -include ordering
Arran Cudbard-Bell [Thu, 6 Mar 2014 12:35:52 +0000 (12:35 +0000)]
Change -include ordering

10 years agoThat's BIG_ENDIAN and LITTLE_ENDIAN
Arran Cudbard-Bell [Wed, 5 Mar 2014 17:40:14 +0000 (17:40 +0000)]
That's BIG_ENDIAN and LITTLE_ENDIAN

10 years agoBe more careful about decoding base-64 decoded passwords
Alan T. DeKok [Wed, 5 Mar 2014 16:28:01 +0000 (16:28 +0000)]
Be more careful about decoding base-64 decoded passwords

And update the tests for the case which failed

10 years agoWhen we have errors, show TONS of information
Alan T. DeKok [Wed, 5 Mar 2014 16:27:52 +0000 (16:27 +0000)]
When we have errors, show TONS of information

10 years agoRevert "Regenerated"
Arran Cudbard-Bell [Wed, 5 Mar 2014 16:00:44 +0000 (16:00 +0000)]
Revert "Regenerated"

This reverts commit 6036bc5b1ddfa569709f8319b80b34db31677aaf.

10 years agoRevert "Configure rules to look for <endian.h>"
Arran Cudbard-Bell [Wed, 5 Mar 2014 16:00:32 +0000 (16:00 +0000)]
Revert "Configure rules to look for <endian.h>"

This reverts commit fa16327226cdbc8e499f47fea997be065a8a5de7.

10 years agoChange names of endian definitions in autoconf
Arran Cudbard-Bell [Wed, 5 Mar 2014 15:55:00 +0000 (15:55 +0000)]
Change names of endian definitions in autoconf

10 years agoPrint out challenge, too
Alan T. DeKok [Wed, 5 Mar 2014 15:53:37 +0000 (15:53 +0000)]
Print out challenge, too

10 years agoPrint out more information in debug3
Alan T. DeKok [Wed, 5 Mar 2014 15:49:38 +0000 (15:49 +0000)]
Print out more information in debug3

10 years agoRegenerated
Alan T. DeKok [Wed, 5 Mar 2014 15:32:04 +0000 (15:32 +0000)]
Regenerated

As a separate commit, so it's easier to merge with master

10 years agoConfigure rules to look for <endian.h>
Alan T. DeKok [Wed, 5 Mar 2014 15:31:52 +0000 (15:31 +0000)]
Configure rules to look for <endian.h>

10 years agoFix typo
Alan T. DeKok [Wed, 5 Mar 2014 13:30:53 +0000 (13:30 +0000)]
Fix typo

10 years agoWrapper to make vp_print() work with VPs on the stack
Alan T. DeKok [Wed, 5 Mar 2014 13:11:29 +0000 (13:11 +0000)]
Wrapper to make vp_print() work with VPs on the stack

vp_print() does VERIFY(vp), which doesn't work for VPs on the stack

10 years agoAdd coverity integration (maybe)
Arran Cudbard-Bell [Tue, 4 Mar 2014 13:54:30 +0000 (13:54 +0000)]
Add coverity integration (maybe)

10 years agoMore tests
Alan T. DeKok [Wed, 5 Mar 2014 11:13:12 +0000 (11:13 +0000)]
More tests

10 years agoAdded test for CHAP and Password-With-Header
Alan T. DeKok [Wed, 5 Mar 2014 11:10:45 +0000 (11:10 +0000)]
Added test for CHAP and Password-With-Header

10 years agoFix handling of password without header
Alan T. DeKok [Tue, 4 Mar 2014 18:02:11 +0000 (18:02 +0000)]
Fix handling of password without header

and add unit tests

10 years agoNote recent changes
Alan T. DeKok [Tue, 4 Mar 2014 13:11:01 +0000 (13:11 +0000)]
Note recent changes

10 years agoExpanded must be set to NULL, else radius_axlat will attempt to use existing buffer...
Arran Cudbard-Bell [Tue, 4 Mar 2014 11:23:00 +0000 (11:23 +0000)]
Expanded must be set to NULL, else radius_axlat will attempt to use existing buffer (reported by colomboe)

10 years agoDon't display password at lower debug levels
Arran Cudbard-Bell [Mon, 3 Mar 2014 22:00:48 +0000 (22:00 +0000)]
Don't display password at lower debug levels

10 years agoProcess passwords without headers as Cleartext-Passwords
Arran Cudbard-Bell [Mon, 3 Mar 2014 21:58:01 +0000 (21:58 +0000)]
Process passwords without headers as Cleartext-Passwords

10 years agoProvide proper errors when we fail to insert events
Arran Cudbard-Bell [Mon, 3 Mar 2014 19:25:24 +0000 (19:25 +0000)]
Provide proper errors when we fail to insert events

10 years agoFormatting in rlm_sqlcounter
Arran Cudbard-Bell [Sat, 1 Mar 2014 22:51:57 +0000 (22:51 +0000)]
Formatting in rlm_sqlcounter

10 years agoFix broken query expansion in rlm_sqlcounter Fixes #537
Arran Cudbard-Bell [Sat, 1 Mar 2014 22:51:37 +0000 (22:51 +0000)]
Fix broken query expansion in rlm_sqlcounter Fixes #537

10 years agoWhitespace
Alan T. DeKok [Fri, 28 Feb 2014 19:15:25 +0000 (14:15 -0500)]
Whitespace

10 years agotrack listener->sock->home->limit.num_connections
Alan T. DeKok [Fri, 28 Feb 2014 16:48:50 +0000 (11:48 -0500)]
track listener->sock->home->limit.num_connections

So that the max_connections limit will be respected

10 years agoAdded 'const' casts as necessary
Alan T. DeKok [Fri, 28 Feb 2014 16:40:48 +0000 (11:40 -0500)]
Added 'const' casts as necessary

10 years agoZero out cbuf to stop complaints from valgrind
Arran Cudbard-Bell [Fri, 28 Feb 2014 19:05:02 +0000 (19:05 +0000)]
Zero out cbuf to stop complaints from valgrind

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 28 Feb 2014 18:32:18 +0000 (18:32 +0000)]
Update ChangeLog

10 years agoFix corner case in pairinsert/fr_cursor_insert
Arran Cudbard-Bell [Fri, 28 Feb 2014 18:27:31 +0000 (18:27 +0000)]
Fix corner case in pairinsert/fr_cursor_insert

If we previously inserted a value pair, with no next pointer, and iterated to the end of the list, then inserted another vp with a next pointer, pairnext would return NULL, even though there were more value pairs available.

10 years agoFix bug in decoding DHCP sub TLVs Fixes #536
Arran Cudbard-Bell [Fri, 28 Feb 2014 18:24:32 +0000 (18:24 +0000)]
Fix bug in decoding DHCP sub TLVs Fixes #536

10 years agoRemove branch status heading
Arran Cudbard-Bell [Fri, 28 Feb 2014 10:02:21 +0000 (10:02 +0000)]
Remove branch status heading

10 years agoCoverity badge image URL apparently requires a ? on the end
Arran Cudbard-Bell [Fri, 28 Feb 2014 08:50:56 +0000 (08:50 +0000)]
Coverity badge image URL apparently requires a ? on the end

10 years ago-imacros appears to cause issues with debugging symbol generation
Arran Cudbard-Bell [Fri, 28 Feb 2014 01:04:29 +0000 (01:04 +0000)]
-imacros appears to cause issues with debugging symbol generation

10 years agoOn bigendian systems byte order macros should just expand to a set of parentheses
Arran Cudbard-Bell [Thu, 27 Feb 2014 23:16:10 +0000 (23:16 +0000)]
On bigendian systems byte order macros should just expand to a set of parentheses

10 years agoUpdate README.rst
Arran Cudbard-Bell [Thu, 27 Feb 2014 22:50:24 +0000 (22:50 +0000)]
Update README.rst

10 years agoSimplify byte order macros
Arran Cudbard-Bell [Thu, 27 Feb 2014 21:50:07 +0000 (21:50 +0000)]
Simplify byte order macros

10 years agoIf error is set, list has been free'd, and is NULL
Alan T. DeKok [Thu, 27 Feb 2014 21:29:50 +0000 (16:29 -0500)]
If error is set, list has been free'd, and is NULL

10 years agoNote changes
Alan T. DeKok [Thu, 27 Feb 2014 21:24:13 +0000 (16:24 -0500)]
Note changes

10 years agouse rlm_rcode_t typedef for calling modules
Alan T. DeKok [Thu, 27 Feb 2014 21:23:45 +0000 (16:23 -0500)]
use rlm_rcode_t typedef for calling modules

10 years agoUse correct typedef for code
Alan T. DeKok [Thu, 27 Feb 2014 21:22:00 +0000 (16:22 -0500)]
Use correct typedef for code

10 years agoFix formatting and return codes in the mysql driver
Arran Cudbard-Bell [Thu, 27 Feb 2014 21:10:47 +0000 (21:10 +0000)]
Fix formatting and return codes in the mysql driver

10 years agoCall mysql library init early in prep for multiple parallel connection spawning
Arran Cudbard-Bell [Thu, 27 Feb 2014 21:08:10 +0000 (21:08 +0000)]
Call mysql library init early in prep for multiple parallel connection spawning

This only matters for the corner case where 0 connections are started during init

10 years agoUse correct logic for updating counter
Alan T. DeKok [Thu, 27 Feb 2014 17:40:45 +0000 (12:40 -0500)]
Use correct logic for updating counter

10 years agoAllow module status to be forced to any module code
Alan T. DeKok [Thu, 27 Feb 2014 16:12:55 +0000 (11:12 -0500)]
Allow module status to be forced to any module code

10 years agoAdd VERIFY_REQUEST to send() routines
Alan T. DeKok [Thu, 27 Feb 2014 15:28:53 +0000 (10:28 -0500)]
Add VERIFY_REQUEST to send() routines

10 years agoUse client port in shutdown debug message
Alan T. DeKok [Thu, 27 Feb 2014 15:28:37 +0000 (10:28 -0500)]
Use client port in shutdown debug message

10 years agoSend SSL_shutdown when we close an SSL socket
Alan T. DeKok [Thu, 27 Feb 2014 15:28:13 +0000 (10:28 -0500)]
Send SSL_shutdown when we close an SSL socket

10 years agoEnsure that tls_close_socket() is also protected by a mutex
Alan T. DeKok [Thu, 27 Feb 2014 14:45:40 +0000 (09:45 -0500)]
Ensure that tls_close_socket() is also protected by a mutex

10 years agoDon't use a while() around SSL_write()
Alan T. DeKok [Thu, 27 Feb 2014 14:38:27 +0000 (09:38 -0500)]
Don't use a while() around SSL_write()