freeradius.git
11 years agofix for default config
Alan Buxey [Sun, 21 Apr 2013 18:53:40 +0000 (19:53 +0100)]
fix for default config

small fixup to remove the following warnings:

WARNING: /etc/raddb/mods-enabled/cache_eap[10]: Please add '&' for
attribute reference 'reply: = &reply:'
WARNING: /etc/raddb/mods-enabled/cache_eap[11]: Please add '&' for
attribute reference 'control:State = &request:State'

11 years agosmall fixup as cannot have diagnostic in function
Alan Buxey [Sun, 21 Apr 2013 18:46:33 +0000 (19:46 +0100)]
small fixup as cannot have diagnostic in function

# make
CC src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c: In function
‘fb_error’:
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:112: error:
#pragma GCC diagnostic not allowed inside functions
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:113: warning:
‘isc_interprete’ is deprecated (declared at /usr/include/ibase.h:787)
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:114: error:
#pragma GCC diagnostic not allowed inside functions
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:117: error:
#pragma GCC diagnostic not allowed inside functions
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:118: warning:
‘isc_interprete’ is deprecated (declared at /usr/include/ibase.h:787)
src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c:119: error:
#pragma GCC diagnostic not allowed inside functions
make: ***
[build/objs/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.lo]
Error 1

11 years agoMore warnings in the SQL drivers
Arran Cudbard-Bell [Sat, 20 Apr 2013 16:36:08 +0000 (12:36 -0400)]
More warnings in the SQL drivers

11 years agoFormatting
Arran Cudbard-Bell [Sat, 20 Apr 2013 16:22:48 +0000 (12:22 -0400)]
Formatting

11 years agoUpdate rlm_sql_db2 configure file
Arran Cudbard-Bell [Sat, 20 Apr 2013 15:46:31 +0000 (11:46 -0400)]
Update rlm_sql_db2 configure file

11 years agoFix warnings in securid
Arran Cudbard-Bell [Sat, 20 Apr 2013 15:35:11 +0000 (11:35 -0400)]
Fix warnings in securid

11 years agoFix warnings in ikev2
Arran Cudbard-Bell [Sat, 20 Apr 2013 15:22:35 +0000 (11:22 -0400)]
Fix warnings in ikev2

11 years agoSwitch more things to -isystem
Arran Cudbard-Bell [Sat, 20 Apr 2013 15:07:19 +0000 (11:07 -0400)]
Switch more things to -isystem

11 years agoRevert "Add -isystem"
Arran Cudbard-Bell [Sat, 20 Apr 2013 14:51:57 +0000 (10:51 -0400)]
Revert "Add -isystem"

This reverts commit 1d31ffb835adda0d6d9c92dab0cf6ff58bf72e78.

11 years agoFix typo
Arran Cudbard-Bell [Sat, 20 Apr 2013 14:42:03 +0000 (10:42 -0400)]
Fix typo

11 years agoRemove checkval
Arran Cudbard-Bell [Sat, 20 Apr 2013 00:50:07 +0000 (20:50 -0400)]
Remove checkval

11 years agoadd DEBUGI
Arran Cudbard-Bell [Sat, 20 Apr 2013 00:18:52 +0000 (20:18 -0400)]
add DEBUGI

11 years agoRevert "Hack for clang"
Arran Cudbard-Bell [Sat, 20 Apr 2013 00:05:57 +0000 (20:05 -0400)]
Revert "Hack for clang"

This reverts commit a628e44e86ca399177dc6125dfbcb9f640132844.

11 years agofixup DIAG_{ON,OFF} to get rid of compiler errors
Matthew Newton [Fri, 19 Apr 2013 23:44:37 +0000 (00:44 +0100)]
fixup DIAG_{ON,OFF} to get rid of compiler errors
about not using #pragmas inside functions

11 years agoRemove attrewrite
Arran Cudbard-Bell [Fri, 19 Apr 2013 23:57:39 +0000 (19:57 -0400)]
Remove attrewrite

11 years agoMore const fixes
Arran Cudbard-Bell [Fri, 19 Apr 2013 22:04:04 +0000 (18:04 -0400)]
More const fixes

11 years agoImprove some warning messages
Arran Cudbard-Bell [Fri, 19 Apr 2013 21:43:04 +0000 (17:43 -0400)]
Improve some warning messages

11 years agoExtra warnings thrown up by GCC 4.8
Arran Cudbard-Bell [Fri, 19 Apr 2013 21:37:25 +0000 (17:37 -0400)]
Extra warnings thrown up by GCC 4.8

11 years agoAdd -Wall
Arran Cudbard-Bell [Fri, 19 Apr 2013 19:49:25 +0000 (15:49 -0400)]
Add -Wall

11 years agoFix distclean
Arran Cudbard-Bell [Fri, 19 Apr 2013 18:14:42 +0000 (14:14 -0400)]
Fix distclean

11 years agoMore GCC fixes
Arran Cudbard-Bell [Fri, 19 Apr 2013 17:57:52 +0000 (13:57 -0400)]
More GCC fixes

11 years agoReverse the order of const and type specifier e.g. const char * becomes char const *
Arran Cudbard-Bell [Fri, 19 Apr 2013 17:11:37 +0000 (13:11 -0400)]
Reverse the order of const and type specifier e.g. const char * becomes char const *

Style guides recommend this because if you read from right to left, it's much clearer
what is actually being marked as const.

const char * const *foo

Here the char array, and the pointer to the char array are const, but this isn't
immediately clear.

As the first const marks token to it's right as const, you'd expect the second const
to operate on the token to its right and make the char ** const, but it doesn't,
it instead marks the char * as const.

If we use the new format:

char const * const *foo

and read from right to left it's much clearer what's const and what's not.

11 years agoHack for clang
Alan T. DeKok [Fri, 19 Apr 2013 15:04:45 +0000 (11:04 -0400)]
Hack for clang

11 years agoAllow for printing the condition to a string.
Alan T. DeKok [Fri, 19 Apr 2013 14:52:54 +0000 (10:52 -0400)]
Allow for printing the condition to a string.

And an initial stab at normalization

Update the tests for the string -> parse -> string output

11 years agoDon't check list qualifiers if the first character is a digit
Alan T. DeKok [Fri, 19 Apr 2013 14:10:29 +0000 (10:10 -0400)]
Don't check list qualifiers if the first character is a digit

11 years agoRemember which string was " ' ` /, etc.
Alan T. DeKok [Fri, 19 Apr 2013 12:15:24 +0000 (08:15 -0400)]
Remember which string was " ' ` /, etc.

And parse them to remove the quotes, and de-escape the various strings

11 years agoExpose fr_cond_t, but don't use it (yet)
Alan T. DeKok [Thu, 18 Apr 2013 14:34:57 +0000 (10:34 -0400)]
Expose fr_cond_t, but don't use it (yet)

11 years agoAnother warning in command.c
Arran Cudbard-Bell [Fri, 19 Apr 2013 02:14:29 +0000 (22:14 -0400)]
Another warning in command.c

11 years agoFix warnings in conffile.c
Arran Cudbard-Bell [Fri, 19 Apr 2013 02:08:02 +0000 (22:08 -0400)]
Fix warnings in conffile.c

11 years agoMark perl headers as system headers
Arran Cudbard-Bell [Fri, 19 Apr 2013 02:03:07 +0000 (22:03 -0400)]
Mark perl headers as system headers

11 years agoTypo
Arran Cudbard-Bell [Fri, 19 Apr 2013 01:49:28 +0000 (21:49 -0400)]
Typo

11 years agoMore GCC *sigh*
Arran Cudbard-Bell [Fri, 19 Apr 2013 01:39:06 +0000 (21:39 -0400)]
More GCC *sigh*

11 years agoIgnore deprecated warning from isc_interprete
Arran Cudbard-Bell [Fri, 19 Apr 2013 01:31:48 +0000 (21:31 -0400)]
Ignore deprecated warning from isc_interprete

11 years agoUse fb_interprete (safe version of isc_interprete which takes an error buffer length)
Arran Cudbard-Bell [Fri, 19 Apr 2013 01:05:59 +0000 (21:05 -0400)]
Use fb_interprete (safe version of isc_interprete which takes an error buffer length)

11 years agoFix the last of the GCC warnings
Arran Cudbard-Bell [Fri, 19 Apr 2013 00:46:10 +0000 (20:46 -0400)]
Fix the last of the GCC warnings

11 years agoAdd calls to ykclient_global
Arran Cudbard-Bell [Fri, 19 Apr 2013 00:26:23 +0000 (20:26 -0400)]
Add calls to ykclient_global

11 years agoFix ISC long format
Arran Cudbard-Bell [Thu, 18 Apr 2013 21:58:12 +0000 (17:58 -0400)]
Fix ISC long format

Fix firebird error function

11 years agoFix ISC long format
Arran Cudbard-Bell [Thu, 18 Apr 2013 21:58:12 +0000 (17:58 -0400)]
Fix ISC long format

11 years agoMissed one lasterror
Arran Cudbard-Bell [Thu, 18 Apr 2013 21:56:31 +0000 (17:56 -0400)]
Missed one lasterror

11 years agoApparently error messages shouldn't have been converted to DEBUGE
Arran Cudbard-Bell [Thu, 18 Apr 2013 21:52:37 +0000 (17:52 -0400)]
Apparently error messages shouldn't have been converted to DEBUGE

11 years agoFix more GCC warnings
Arran Cudbard-Bell [Thu, 18 Apr 2013 21:31:11 +0000 (17:31 -0400)]
Fix more GCC warnings

11 years agoNeed ykclient too
Arran Cudbard-Bell [Thu, 18 Apr 2013 20:35:30 +0000 (16:35 -0400)]
Need ykclient too

11 years agoUse universal diagnostic macros
Arran Cudbard-Bell [Thu, 18 Apr 2013 19:19:39 +0000 (15:19 -0400)]
Use universal diagnostic macros

11 years agoAdd -isystem to smart_include and fix python configure script
Arran Cudbard-Bell [Thu, 18 Apr 2013 18:41:22 +0000 (14:41 -0400)]
Add -isystem to smart_include and fix python configure script

11 years agoTypo
Arran Cudbard-Bell [Thu, 18 Apr 2013 18:03:20 +0000 (14:03 -0400)]
Typo

11 years agoCheck for specific compiler versions before using diagnostic pragmas
Arran Cudbard-Bell [Thu, 18 Apr 2013 18:01:29 +0000 (14:01 -0400)]
Check for specific compiler versions before using diagnostic pragmas

11 years agoIgnore ldap_int_tls_config warning
Arran Cudbard-Bell [Thu, 18 Apr 2013 17:34:04 +0000 (13:34 -0400)]
Ignore ldap_int_tls_config warning

11 years agoMore firebird fixes
Arran Cudbard-Bell [Thu, 18 Apr 2013 17:30:32 +0000 (13:30 -0400)]
More firebird fixes

11 years agoFix more debug stuff
Arran Cudbard-Bell [Thu, 18 Apr 2013 16:59:08 +0000 (12:59 -0400)]
Fix more debug stuff

11 years agoUse C99 type
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:42:00 +0000 (22:42 -0400)]
Use C99 type

11 years agoApparently there's PRIu
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:23:55 +0000 (22:23 -0400)]
Apparently there's PRIu

11 years agoAdd missing prototypes
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:18:31 +0000 (22:18 -0400)]
Add missing prototypes

11 years agoMore firebird fixes
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:07:57 +0000 (22:07 -0400)]
More firebird fixes

11 years agoNeed to build with sql_fbapi.c
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:05:24 +0000 (22:05 -0400)]
Need to build with sql_fbapi.c

11 years agoFix const warnings in rlm_counter
Arran Cudbard-Bell [Thu, 18 Apr 2013 02:00:00 +0000 (22:00 -0400)]
Fix const warnings in rlm_counter

11 years agoFix typo
Arran Cudbard-Bell [Thu, 18 Apr 2013 01:56:47 +0000 (21:56 -0400)]
Fix typo

11 years agoI hate the "reference" password name.
Alan T. DeKok [Wed, 17 Apr 2013 13:14:32 +0000 (09:14 -0400)]
I hate the "reference" password name.

It's not a reference.  If it was, what would it refer to?

It's a "known good" password.  Or maybe a "known to be good"
password.  Or maybe a "administratively set" password.

11 years agoUse consistent argument names for connection API callbacks
Arran Cudbard-Bell [Thu, 18 Apr 2013 01:19:25 +0000 (21:19 -0400)]
Use consistent argument names for connection API callbacks

11 years agoShould be da->attr not da->type
Arran Cudbard-Bell [Thu, 18 Apr 2013 01:06:05 +0000 (21:06 -0400)]
Should be da->attr not da->type

11 years agoUse C99 portable definition to print 64 integers
Arran Cudbard-Bell [Thu, 18 Apr 2013 00:59:41 +0000 (20:59 -0400)]
Use C99 portable definition to print 64 integers

11 years agoUninitialized variable
Arran Cudbard-Bell [Thu, 18 Apr 2013 00:55:17 +0000 (20:55 -0400)]
Uninitialized variable

11 years agoFix typo
Arran Cudbard-Bell [Thu, 18 Apr 2013 00:44:29 +0000 (20:44 -0400)]
Fix typo

11 years agoFix SQL warnings
Arran Cudbard-Bell [Thu, 18 Apr 2013 00:10:35 +0000 (20:10 -0400)]
Fix SQL warnings

11 years agoReplace radlog(L_ERR with DEBUGE
Arran Cudbard-Bell [Wed, 17 Apr 2013 23:55:19 +0000 (19:55 -0400)]
Replace radlog(L_ERR with DEBUGE

11 years agoRemove strtok from perl xlat
Arran Cudbard-Bell [Wed, 17 Apr 2013 22:27:20 +0000 (18:27 -0400)]
Remove strtok from perl xlat

11 years agoFix perl xlat logging
Arran Cudbard-Bell [Wed, 17 Apr 2013 22:03:39 +0000 (18:03 -0400)]
Fix perl xlat logging

11 years agoIgnore warnings from perl magic
Arran Cudbard-Bell [Wed, 17 Apr 2013 22:02:07 +0000 (18:02 -0400)]
Ignore warnings from perl magic

11 years agodictionary_dir should be const
Arran Cudbard-Bell [Wed, 17 Apr 2013 21:58:57 +0000 (17:58 -0400)]
dictionary_dir should be const

11 years agoIgnore more literal fmt warnings
Arran Cudbard-Bell [Wed, 17 Apr 2013 21:57:23 +0000 (17:57 -0400)]
Ignore more literal fmt warnings

11 years agoCURLAUTH values are bigger than CURLOpt
Arran Cudbard-Bell [Wed, 17 Apr 2013 20:09:49 +0000 (16:09 -0400)]
CURLAUTH values are bigger than CURLOpt

11 years agoBetter way to disable deprecated API warnings
Arran Cudbard-Bell [Wed, 17 Apr 2013 20:03:01 +0000 (16:03 -0400)]
Better way to disable deprecated API warnings

11 years agoAdd W_UNEEDEDDEC_OFF to turn off warnings for unused debugging functions
Arran Cudbard-Bell [Wed, 17 Apr 2013 19:51:12 +0000 (15:51 -0400)]
Add W_UNEEDEDDEC_OFF to turn off warnings for unused debugging functions

11 years agoConstify more hash functions
Arran Cudbard-Bell [Wed, 17 Apr 2013 19:27:05 +0000 (15:27 -0400)]
Constify more hash functions

11 years agoTurn off non literal fmt argument where appropriate
Arran Cudbard-Bell [Wed, 17 Apr 2013 18:17:28 +0000 (14:17 -0400)]
Turn off non literal fmt argument where appropriate

11 years agoIgnore -Wcast-align
Arran Cudbard-Bell [Wed, 17 Apr 2013 18:04:53 +0000 (14:04 -0400)]
Ignore -Wcast-align

11 years agoFix doxygen warnings
Arran Cudbard-Bell [Tue, 16 Apr 2013 17:48:48 +0000 (13:48 -0400)]
Fix doxygen warnings

11 years agoAllow %{request:Tunnel-Password:1[1]} to work
Alan T. DeKok [Tue, 16 Apr 2013 21:49:32 +0000 (17:49 -0400)]
Allow %{request:Tunnel-Password:1[1]} to work

and add more regression tests

11 years agoRemove unused variable
Alan T. DeKok [Tue, 16 Apr 2013 21:49:23 +0000 (17:49 -0400)]
Remove unused variable

11 years agoFix typo in unlock
Alan T. DeKok [Tue, 16 Apr 2013 21:49:08 +0000 (17:49 -0400)]
Fix typo in unlock

11 years agoCheck for too much text after xlat, too
Alan T. DeKok [Tue, 16 Apr 2013 21:33:03 +0000 (17:33 -0400)]
Check for too much text after xlat, too

11 years agodoxygen
Alan T. DeKok [Tue, 16 Apr 2013 20:27:33 +0000 (16:27 -0400)]
doxygen

11 years agouse &da not da
Alan T. DeKok [Tue, 16 Apr 2013 17:46:03 +0000 (13:46 -0400)]
use &da not da

11 years agodoxygen
Alan T. DeKok [Tue, 16 Apr 2013 17:43:14 +0000 (13:43 -0400)]
doxygen

11 years agoUpdate ruby data types to work with 2.0.0
Arran Cudbard-Bell [Tue, 16 Apr 2013 17:24:36 +0000 (13:24 -0400)]
Update ruby data types to work with 2.0.0

11 years agoFix coverity issues
Arran Cudbard-Bell [Tue, 16 Apr 2013 16:56:08 +0000 (12:56 -0400)]
Fix coverity issues

11 years agoUpdate new conditional parser to create data structures
Alan T. DeKok [Tue, 16 Apr 2013 01:57:57 +0000 (21:57 -0400)]
Update new conditional parser to create data structures

Which aren't exposed yet, but it works.
Also add more tests.

11 years agoFix comment
Alan T. DeKok [Tue, 16 Apr 2013 01:54:31 +0000 (21:54 -0400)]
Fix comment

11 years agoGet excited if there is trailing stuff after the condition
Alan T. DeKok [Tue, 16 Apr 2013 01:54:08 +0000 (21:54 -0400)]
Get excited if there is trailing stuff after the condition

11 years agoShucks
Alan T. DeKok [Tue, 16 Apr 2013 01:53:20 +0000 (21:53 -0400)]
Shucks

11 years agoFix attr_filter.foo.bar.baz.bar
Alan T. DeKok [Tue, 16 Apr 2013 01:39:36 +0000 (21:39 -0400)]
Fix attr_filter.foo.bar.baz.bar

If a module is referenced as '-foo', it can't have a .

11 years agoReplace %C with %{Packet-Src-IP-Address}
Alan T. DeKok [Mon, 15 Apr 2013 15:04:26 +0000 (11:04 -0400)]
Replace %C with %{Packet-Src-IP-Address}

11 years agoClient shortname can be created internally
Alan T. DeKok [Mon, 15 Apr 2013 15:02:46 +0000 (11:02 -0400)]
Client shortname can be created internally

So if the user is looking for it and it doesn't exist
in the config file, return it from the request->client structure

11 years agoUse consistent names for the connection functions
Arran Cudbard-Bell [Mon, 15 Apr 2013 17:13:29 +0000 (13:13 -0400)]
Use consistent names for the connection functions

11 years agoMake connection re-use scheme configurable
Arran Cudbard-Bell [Mon, 15 Apr 2013 16:38:00 +0000 (12:38 -0400)]
Make connection re-use scheme configurable

11 years agoFix typo
Alan T. DeKok [Sun, 14 Apr 2013 15:39:33 +0000 (11:39 -0400)]
Fix typo

11 years agoInclude the DHCP dictionary for the tests
Alan T. DeKok [Sun, 14 Apr 2013 15:23:57 +0000 (11:23 -0400)]
Include the DHCP dictionary for the tests

11 years agoFix typo
Alan T. DeKok [Sun, 14 Apr 2013 15:23:09 +0000 (11:23 -0400)]
Fix typo

11 years agoradius_request_name() shouldn't skip over unknown strings
Alan T. DeKok [Sun, 14 Apr 2013 15:10:53 +0000 (11:10 -0400)]
radius_request_name() shouldn't skip over unknown strings

i.e. "127.0.0.1" should get the caller's default ref returned,
instead of EATING the "127.", and then returning the caller's ref

11 years agoAdd dict_read() API.
Alan T. DeKok [Sun, 14 Apr 2013 14:57:24 +0000 (10:57 -0400)]
Add dict_read() API.

To read one dictionary file.

And made rlm_dhcp read it, so that the DHCP dictionaries can
be loaded automatically.

11 years agoError if we try to load DHCP without DHCP dictionaries
Alan T. DeKok [Sun, 14 Apr 2013 14:43:04 +0000 (10:43 -0400)]
Error if we try to load DHCP without DHCP dictionaries