freeradius.git
10 years agoDHCP-Client-Identifier and DHCP-Vendor-Class-Identifier should both be octets types
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:26:45 +0000 (15:26 +0100)]
DHCP-Client-Identifier and DHCP-Vendor-Class-Identifier should both be octets types

10 years agoWe no longer need to artificially limit the size of DHCP options to 253 bytes
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:14:31 +0000 (15:14 +0100)]
We no longer need to artificially limit the size of DHCP options to 253 bytes

Dynamically allocated value buffers FTW

10 years agoDon't stop parsing on padding options
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:09:39 +0000 (15:09 +0100)]
Don't stop parsing on padding options

10 years agoVPs are allocated in the packet CTX, not the request
Alan T. DeKok [Wed, 11 Jun 2014 13:37:04 +0000 (09:37 -0400)]
VPs are allocated in the packet CTX, not the request

10 years agoFix horrific formatting in EAP-PWD
Arran Cudbard-Bell [Wed, 11 Jun 2014 12:22:35 +0000 (13:22 +0100)]
Fix horrific formatting in EAP-PWD

10 years agoAdd TALLOC_CTX to RADIUS protocol decoder. We're not always allocating in the context...
Arran Cudbard-Bell [Wed, 11 Jun 2014 09:41:26 +0000 (10:41 +0100)]
Add TALLOC_CTX to RADIUS protocol decoder. We're not always allocating in the context of a packet.

Fixes #668

Also fixes potential threading issues in EAP-TTLS

10 years agoFormatting
Arran Cudbard-Bell [Wed, 11 Jun 2014 08:23:41 +0000 (09:23 +0100)]
Formatting

10 years agoNot every LDAP library supports setting Network Timeout
Arran Cudbard-Bell [Wed, 11 Jun 2014 08:17:45 +0000 (09:17 +0100)]
Not every LDAP library supports setting Network Timeout

10 years agoHmm, setting _X_OPEN_SOURCE breaks everything
Arran Cudbard-Bell [Tue, 10 Jun 2014 20:46:05 +0000 (21:46 +0100)]
Hmm, setting _X_OPEN_SOURCE breaks everything

10 years agoMore fixes for Betriebssystemschwein
Arran Cudbard-Bell [Tue, 10 Jun 2014 20:14:08 +0000 (21:14 +0100)]
More fixes for Betriebssystemschwein

Set _X_OPEN_SOURCE=600 and -std=c99 earlier so that ./configure runs against appropriate versions of the POSIX APIs.

Fix rlm_krb5 configure script to correctly detect that Betriebssystemschwein's libkrb5 is based on MIT's

Include fcntl.h in log.c, this should probably always of been included...

Add alternative names for macros in rlm_ldap/ldap.h and #ifdef out a few lines of code, as starttls doesn't seen to be available...

10 years agoCoverity CID #1222259
Arran Cudbard-Bell [Tue, 10 Jun 2014 18:34:06 +0000 (19:34 +0100)]
Coverity CID #1222259

10 years agoAdd dependencies for load-balance redundant-load-balance tests, add load-balance...
Arran Cudbard-Bell [Tue, 10 Jun 2014 18:04:51 +0000 (19:04 +0100)]
Add dependencies for load-balance redundant-load-balance tests, add load-balance test

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 10 Jun 2014 16:13:45 +0000 (17:13 +0100)]
Update ChangeLog

10 years agoTests for redundant load balance
Alan T. DeKok [Tue, 10 Jun 2014 15:43:36 +0000 (11:43 -0400)]
Tests for redundant load balance

10 years agoMake redundant-load-balance work again. Closes #681
Alan T. DeKok [Tue, 10 Jun 2014 15:42:47 +0000 (11:42 -0400)]
Make redundant-load-balance work again.  Closes #681

10 years agoRedundant, load-balance, etc. can't be empty
Alan T. DeKok [Tue, 10 Jun 2014 14:28:21 +0000 (10:28 -0400)]
Redundant, load-balance, etc. can't be empty

10 years agoConvert request_free to a destructor to make double free problems easier to track...
Arran Cudbard-Bell [Tue, 10 Jun 2014 10:23:20 +0000 (11:23 +0100)]
Convert request_free to a destructor to make double free problems easier to track down

10 years agoAdd inlen to fr_hex2bin. rlm_pap used fr_hex2bin with the assumption that the VP...
Arran Cudbard-Bell [Tue, 10 Jun 2014 08:42:19 +0000 (09:42 +0100)]
Add inlen to fr_hex2bin. rlm_pap used fr_hex2bin with the assumption that the VP it was normifying was a string which caused reads into uninitialised memory. Fixes #679

10 years agoFix case change of attribute names when creating attributes.h on Solaris
Arran Cudbard-Bell [Mon, 9 Jun 2014 23:05:46 +0000 (00:05 +0100)]
Fix case change of attribute names when creating attributes.h on Solaris

10 years agoMore fixes for Solaris
Arran Cudbard-Bell [Mon, 9 Jun 2014 22:50:02 +0000 (23:50 +0100)]
More fixes for Solaris

10 years agoFix sig_t check
Arran Cudbard-Bell [Mon, 9 Jun 2014 22:38:12 +0000 (23:38 +0100)]
Fix sig_t check

10 years agoTypo in autoconf (check for htonlll not htonll)
Arran Cudbard-Bell [Mon, 9 Jun 2014 22:13:48 +0000 (23:13 +0100)]
Typo in autoconf (check for htonlll not htonll)

10 years agoUse simple patterns as the default grep in solaris is dumb
Arran Cudbard-Bell [Mon, 9 Jun 2014 22:03:34 +0000 (23:03 +0100)]
Use simple patterns as the default grep in solaris is dumb

10 years agoBetter debug logging for NT-Password and LM-Password attribute searches
Arran Cudbard-Bell [Mon, 9 Jun 2014 21:04:35 +0000 (22:04 +0100)]
Better debug logging for NT-Password and LM-Password attribute searches

10 years agoFixup length in radsniff filter attributes
Arran Cudbard-Bell [Mon, 9 Jun 2014 11:05:59 +0000 (12:05 +0100)]
Fixup length in radsniff filter attributes

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Mon, 9 Jun 2014 10:05:31 +0000 (11:05 +0100)]
Update ChangeLog

10 years agoEnumerate escape-sequences tests
Arran Cudbard-Bell [Sun, 8 Jun 2014 21:12:06 +0000 (22:12 +0100)]
Enumerate escape-sequences tests

10 years agoFix UTF8 chars in %{escape:}, add %{unescape:} and tests
Arran Cudbard-Bell [Sun, 8 Jun 2014 21:08:50 +0000 (22:08 +0100)]
Fix UTF8 chars in %{escape:}, add %{unescape:} and tests

10 years agoUse casts for all urlquote tests
Arran Cudbard-Bell [Sun, 8 Jun 2014 21:08:08 +0000 (22:08 +0100)]
Use casts for all urlquote tests

10 years agoFix comment
Arran Cudbard-Bell [Sun, 8 Jun 2014 08:35:14 +0000 (09:35 +0100)]
Fix comment

10 years agoAdd urlunquote
Arran Cudbard-Bell [Sun, 8 Jun 2014 08:19:34 +0000 (09:19 +0100)]
Add urlunquote

10 years agoFix url quote, enable all url quote tests
Arran Cudbard-Bell [Sat, 7 Jun 2014 20:10:58 +0000 (21:10 +0100)]
Fix url quote, enable all url quote tests

10 years agoAdd tests for urlquote (which currently would not pass)
Arran Cudbard-Bell [Sat, 7 Jun 2014 09:18:07 +0000 (10:18 +0100)]
Add tests for urlquote (which currently would not pass)

10 years agourl quote chars should be upper case
Arran Cudbard-Bell [Fri, 6 Jun 2014 23:18:58 +0000 (00:18 +0100)]
url quote chars should be upper case

10 years agoRename foreach-2 to something meaningful
Arran Cudbard-Bell [Fri, 6 Jun 2014 16:55:42 +0000 (17:55 +0100)]
Rename foreach-2 to something meaningful

10 years agoAdd tests for hexadecimal IP addresses
Arran Cudbard-Bell [Fri, 6 Jun 2014 16:45:00 +0000 (17:45 +0100)]
Add tests for hexadecimal IP addresses

10 years agoFix pairfilter documentation
Arran Cudbard-Bell [Fri, 6 Jun 2014 11:47:47 +0000 (12:47 +0100)]
Fix pairfilter documentation

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 6 Jun 2014 11:26:56 +0000 (12:26 +0100)]
Update ChangeLog

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 6 Jun 2014 11:23:50 +0000 (12:23 +0100)]
Update ChangeLog

10 years agoFixup md4 function names
Arran Cudbard-Bell [Fri, 6 Jun 2014 11:03:23 +0000 (12:03 +0100)]
Fixup md4 function names

10 years agoFixup md5 function names
Arran Cudbard-Bell [Fri, 6 Jun 2014 11:01:33 +0000 (12:01 +0100)]
Fixup md5 function names

10 years agoAdd %{hmacmd5:} and %{hmacsha1} xlat expansions
Arran Cudbard-Bell [Fri, 6 Jun 2014 10:56:48 +0000 (11:56 +0100)]
Add %{hmacmd5:} and %{hmacsha1} xlat expansions

10 years agoMove hmac prototypes into the md5.h/sha1.h headers
Arran Cudbard-Bell [Fri, 6 Jun 2014 10:56:06 +0000 (11:56 +0100)]
Move hmac prototypes into the md5.h/sha1.h headers

10 years agoSwap order of arguments in hmac functions so output is the first argument
Arran Cudbard-Bell [Fri, 6 Jun 2014 09:31:30 +0000 (10:31 +0100)]
Swap order of arguments in hmac functions so output is the first argument

10 years agoAdd dsp-id
Arran Cudbard-Bell [Fri, 6 Jun 2014 09:17:30 +0000 (10:17 +0100)]
Add dsp-id

10 years agoFixup SHA1 function names
Arran Cudbard-Bell [Fri, 6 Jun 2014 09:13:40 +0000 (10:13 +0100)]
Fixup SHA1 function names

10 years agoAdd notes on what's going on
Arran Cudbard-Bell [Thu, 5 Jun 2014 18:26:37 +0000 (19:26 +0100)]
Add notes on what's going on

10 years agoDouble init_delay in preparation for halving it later. Closes #677
Alan T. DeKok [Thu, 5 Jun 2014 14:57:58 +0000 (10:57 -0400)]
Double init_delay in preparation for halving it later.  Closes #677

10 years agoinit_delay = response_window / 2. Closes #677
Alan T. DeKok [Thu, 5 Jun 2014 14:28:10 +0000 (10:28 -0400)]
init_delay = response_window / 2.  Closes #677

This gives the event loop enough time to wake up, and set the
response_window timer before it fires

10 years agoIf REST xlat fails, output the contents of the body using REDEBUG so it's available...
Arran Cudbard-Bell [Thu, 5 Jun 2014 10:20:51 +0000 (11:20 +0100)]
If REST xlat fails, output the contents of the body using REDEBUG so it's available in Module-Failure-Message

10 years agoAllow custom HTTP headers to be specified with control:REST-HTTP-Header
Arran Cudbard-Bell [Wed, 4 Jun 2014 23:19:35 +0000 (00:19 +0100)]
Allow custom HTTP headers to be specified with control:REST-HTTP-Header

10 years agoAdd HTTP_BODY_CUSTOM_LITERAL encoder and expose it through the %{rest:} xlat function
Arran Cudbard-Bell [Wed, 4 Jun 2014 22:48:58 +0000 (23:48 +0100)]
Add HTTP_BODY_CUSTOM_LITERAL encoder and expose it through the %{rest:} xlat function

10 years agoReturn the correct handle in mod_conn_create if connect_uri is not specified
Arran Cudbard-Bell [Wed, 4 Jun 2014 22:43:11 +0000 (23:43 +0100)]
Return the correct handle in mod_conn_create if connect_uri is not specified

10 years agoPull checks from master
Alan T. DeKok [Wed, 4 Jun 2014 21:06:41 +0000 (17:06 -0400)]
Pull checks from master

If we're checking the config, don't create the packet lists

10 years agoMake DEBUG_STATE_MACHINE print out usec timestamps
Alan T. DeKok [Wed, 4 Jun 2014 21:04:52 +0000 (17:04 -0400)]
Make DEBUG_STATE_MACHINE print out usec timestamps

10 years agoCheck for htonll and htonlll (you never know)
Arran Cudbard-Bell [Wed, 4 Jun 2014 20:38:42 +0000 (21:38 +0100)]
Check for htonll and htonlll (you never know)

Use __builtin_bswap64 is htonll is not available

10 years agoAdd check for bswap64
Arran Cudbard-Bell [Wed, 4 Jun 2014 20:17:16 +0000 (21:17 +0100)]
Add check for bswap64

10 years agoTweak builtin checks
Arran Cudbard-Bell [Wed, 4 Jun 2014 20:16:51 +0000 (21:16 +0100)]
Tweak builtin checks

10 years agoFix invalid assert and paircmp check
Arran Cudbard-Bell [Wed, 4 Jun 2014 19:27:50 +0000 (20:27 +0100)]
Fix invalid assert and paircmp check

10 years agoMore talloc_steal
Alan T. DeKok [Wed, 4 Jun 2014 18:21:12 +0000 (14:21 -0400)]
More talloc_steal

10 years agoAllow no proxy reply. Closes #675
Alan T. DeKok [Wed, 4 Jun 2014 13:23:47 +0000 (09:23 -0400)]
Allow no proxy reply.  Closes #675

For "proxy_tunneled_request_as_eap = no"

10 years agoWe need paircmp to support regexes
Arran Cudbard-Bell [Wed, 4 Jun 2014 17:25:26 +0000 (18:25 +0100)]
We need paircmp to support regexes

10 years agoFixup length when converting xlat VPs back to literals in radclient
Arran Cudbard-Bell [Wed, 4 Jun 2014 15:06:46 +0000 (16:06 +0100)]
Fixup length when converting xlat VPs back to literals in radclient

10 years agoSupport new tag behaviour correctly in pairvalidate
Arran Cudbard-Bell [Wed, 4 Jun 2014 13:48:55 +0000 (14:48 +0100)]
Support new tag behaviour correctly in pairvalidate

10 years agoSimplify pairvalidate loop
Arran Cudbard-Bell [Wed, 4 Jun 2014 13:48:36 +0000 (14:48 +0100)]
Simplify pairvalidate loop

10 years agoAdd assert to pairvalidate_debug to catch when pairvalidate misidentified an attribut...
Arran Cudbard-Bell [Wed, 4 Jun 2014 13:48:13 +0000 (14:48 +0100)]
Add assert to pairvalidate_debug to catch when pairvalidate misidentified an attribute as mismatching

10 years agoFix cosmetic error in pairvalidate_debug
Arran Cudbard-Bell [Wed, 4 Jun 2014 13:47:25 +0000 (14:47 +0100)]
Fix cosmetic error in pairvalidate_debug

10 years agoAdd the proxy reply attributes to the reply. Fixes #675
Alan T. DeKok [Wed, 4 Jun 2014 12:15:25 +0000 (08:15 -0400)]
Add the proxy reply attributes to the reply.  Fixes #675

Don't over-write the reply.  The various EAP functions always
put their attributes into the reply, even when run in the
post-proxy stage

10 years agoSet the reply to CHALLENGE if we're not done
Alan T. DeKok [Wed, 4 Jun 2014 12:14:55 +0000 (08:14 -0400)]
Set the reply to CHALLENGE if we're not done

10 years agoMore talloc_steal <sigh>
Alan T. DeKok [Wed, 4 Jun 2014 11:35:18 +0000 (07:35 -0400)]
More talloc_steal <sigh>

10 years agoUse new syntax
Alan T. DeKok [Wed, 4 Jun 2014 11:22:13 +0000 (07:22 -0400)]
Use new syntax

10 years agoDon't print out name for empty sub-section
Alan T. DeKok [Wed, 4 Jun 2014 11:21:37 +0000 (07:21 -0400)]
Don't print out name for empty sub-section

10 years agoBe more careful with proxy delays. Should help #673
Alan T. DeKok [Tue, 3 Jun 2014 21:24:31 +0000 (17:24 -0400)]
Be more careful with proxy delays.  Should help #673

10 years agoPrint timeouts for requests in debugging mode
Alan T. DeKok [Tue, 3 Jun 2014 14:53:06 +0000 (10:53 -0400)]
Print timeouts for requests in debugging mode

10 years agoWe can't build with openssl sha1 by default
Arran Cudbard-Bell [Tue, 3 Jun 2014 13:56:12 +0000 (14:56 +0100)]
We can't build with openssl sha1 by default

10 years agoresponse_window of zero is OK for clients.
Alan T. DeKok [Tue, 3 Jun 2014 13:29:39 +0000 (09:29 -0400)]
response_window of zero is OK for clients.

It means "use the home server response_window"

10 years agoActually build with OPENSSL_SHA1 instead of just saying we're going to build with it
Arran Cudbard-Bell [Tue, 3 Jun 2014 11:49:10 +0000 (12:49 +0100)]
Actually build with OPENSSL_SHA1 instead of just saying we're going to build with it

10 years agoDon't overload default_log
Arran Cudbard-Bell [Tue, 3 Jun 2014 11:48:40 +0000 (12:48 +0100)]
Don't overload default_log

10 years agoExcept in fips186prf.c
Arran Cudbard-Bell [Tue, 3 Jun 2014 11:36:40 +0000 (12:36 +0100)]
Except in fips186prf.c

10 years agoIt's there because it's used by eapsim_calculate_keys
Arran Cudbard-Bell [Tue, 3 Jun 2014 11:35:43 +0000 (12:35 +0100)]
It's there because it's used by eapsim_calculate_keys

10 years agoDon't overload the logging symbols from libfreeradius-server
Arran Cudbard-Bell [Tue, 3 Jun 2014 11:05:40 +0000 (12:05 +0100)]
Don't overload the logging symbols from libfreeradius-server

Remove the dumb hacks in radeapclient.c and call the proper log initialisation functions. Seeing as it's linked against libfreeradius-server now we may as well use them.

10 years agoFormatting
Arran Cudbard-Bell [Tue, 3 Jun 2014 00:08:32 +0000 (01:08 +0100)]
Formatting

10 years agoCache-TTL should now be signed
Arran Cudbard-Bell [Mon, 2 Jun 2014 19:22:25 +0000 (20:22 +0100)]
Cache-TTL should now be signed

10 years agoProcess and consume all Response-Packet-Type and Packet-Type attribute in radclient...
Arran Cudbard-Bell [Mon, 2 Jun 2014 17:39:35 +0000 (18:39 +0100)]
Process and consume all Response-Packet-Type and Packet-Type attribute in radclient filters

10 years agoRemove redundant field in radclient request struct
Arran Cudbard-Bell [Mon, 2 Jun 2014 17:39:05 +0000 (18:39 +0100)]
Remove redundant field in radclient request struct

10 years agoAdd optional Radclient-Test-Name attribute (name is included in any filter error...
Arran Cudbard-Bell [Mon, 2 Jun 2014 17:38:17 +0000 (18:38 +0100)]
Add optional Radclient-Test-Name attribute (name is included in any filter error output)

10 years agoFix debugging verbosity in radclient
Arran Cudbard-Bell [Mon, 2 Jun 2014 16:46:18 +0000 (17:46 +0100)]
Fix debugging verbosity in radclient

10 years agoAllow zero length bodies in REST responses
Arran Cudbard-Bell [Mon, 2 Jun 2014 15:50:11 +0000 (16:50 +0100)]
Allow zero length bodies in REST responses

10 years agoMove all special attribute checks into the loop which iterates over the contents...
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:22:08 +0000 (12:22 +0100)]
Move all special attribute checks into the loop which iterates over the contents of the request list

10 years agoFormatting
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:25:20 +0000 (12:25 +0100)]
Formatting

10 years agoIt's redundant check for server_port as it's value was already set in the packet
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:24:57 +0000 (12:24 +0100)]
It's redundant check for server_port as it's value was already set in the packet

10 years agoAdd comment regarding why we set the destructor for radclient requests so late
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:24:22 +0000 (12:24 +0100)]
Add comment regarding why we set the destructor for radclient requests so late

10 years agoCleanup socket opening failure message
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:23:55 +0000 (12:23 +0100)]
Cleanup socket opening failure message

10 years agoTypo
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:23:26 +0000 (12:23 +0100)]
Typo

10 years agoNot always Accepts and Rejects
Arran Cudbard-Bell [Mon, 2 Jun 2014 11:23:15 +0000 (12:23 +0100)]
Not always Accepts and Rejects

10 years agoFix 'auto' mode. Before responses weren't being matched to requests.
Arran Cudbard-Bell [Mon, 2 Jun 2014 10:34:14 +0000 (11:34 +0100)]
Fix 'auto' mode. Before responses weren't being matched to requests.

10 years agoUse REDEBUG so we know which entry failed parsing
Arran Cudbard-Bell [Mon, 2 Jun 2014 10:32:34 +0000 (11:32 +0100)]
Use REDEBUG so we know which entry failed parsing

10 years agoSkip empty requests (this is closer to previous radclient behaviour)
Arran Cudbard-Bell [Mon, 2 Jun 2014 10:31:03 +0000 (11:31 +0100)]
Skip empty requests (this is closer to previous radclient behaviour)

10 years agoFix assert on error in radclient
Arran Cudbard-Bell [Mon, 2 Jun 2014 08:29:28 +0000 (09:29 +0100)]
Fix assert on error in radclient

10 years agoMore clients.conf cleanup
Arran Cudbard-Bell [Sun, 1 Jun 2014 20:54:26 +0000 (21:54 +0100)]
More clients.conf cleanup