freeradius.git
9 years agoHave a suspicion that enabling null context tracking causes talloc functions to SEGV...
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:06:03 +0000 (12:06 +0100)]
Have a suspicion that enabling null context tracking causes talloc functions to SEGV if you pass NULL context pointers

9 years agoFix parenting issues in rlm_file
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:00:10 +0000 (12:00 +0100)]
Fix parenting issues in rlm_file

9 years agoFix/Enhance fr_log_talloc_report
Arran Cudbard-Bell [Wed, 18 Jun 2014 10:35:59 +0000 (11:35 +0100)]
Fix/Enhance fr_log_talloc_report

9 years agoAllow setting the filter code from the request
Arran Cudbard-Bell [Wed, 18 Jun 2014 10:13:23 +0000 (11:13 +0100)]
Allow setting the filter code from the request

9 years agoTypo
Arran Cudbard-Bell [Wed, 18 Jun 2014 07:49:32 +0000 (08:49 +0100)]
Typo

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:20:48 +0000 (00:20 +0100)]
Update ChangeLog

9 years agotypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:17:58 +0000 (00:17 +0100)]
typo

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:17:21 +0000 (00:17 +0100)]
Update ChangeLog

9 years agoAdd pairdatacpy to fix value parenting issues
Arran Cudbard-Bell [Tue, 17 Jun 2014 22:40:37 +0000 (23:40 +0100)]
Add pairdatacpy to fix value parenting issues

9 years agoMore tweaks for CONSISTENCY CHECK readability
Arran Cudbard-Bell [Tue, 17 Jun 2014 22:23:12 +0000 (23:23 +0100)]
More tweaks for CONSISTENCY CHECK readability

9 years agoBetter checks for DEBUG_PACKET
Alan T. DeKok [Tue, 17 Jun 2014 19:37:09 +0000 (15:37 -0400)]
Better checks for DEBUG_PACKET

9 years agoTypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 19:04:16 +0000 (20:04 +0100)]
Typo

9 years agoProbably want to free the VPs we remove from the control list, oops.
Arran Cudbard-Bell [Tue, 17 Jun 2014 19:00:33 +0000 (20:00 +0100)]
Probably want to free the VPs we remove from the control list, oops.

9 years agoMake CONSISTENCY CHECK messages clearer, add checks for string/octet buffer parenting
Arran Cudbard-Bell [Tue, 17 Jun 2014 18:55:24 +0000 (19:55 +0100)]
Make CONSISTENCY CHECK messages clearer, add checks for string/octet buffer parenting

9 years agoFixed permit_only_eap policy
Herwin Weststrate [Tue, 17 Jun 2014 15:40:07 +0000 (17:40 +0200)]
Fixed permit_only_eap policy

9 years agoUse correct test for debugging
Alan T. DeKok [Tue, 17 Jun 2014 15:27:42 +0000 (11:27 -0400)]
Use correct test for debugging

9 years agoPrint tunneled data in the right place
Alan T. DeKok [Tue, 17 Jun 2014 15:27:21 +0000 (11:27 -0400)]
Print tunneled data in the right place

9 years agoTypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 14:52:22 +0000 (15:52 +0100)]
Typo

9 years agoRemove old text about not proxying CoA. It now works
Alan T. DeKok [Tue, 17 Jun 2014 13:47:06 +0000 (09:47 -0400)]
Remove old text about not proxying CoA.  It now works

9 years agostatus check packets don't have a client. Closes #691
Alan T. DeKok [Tue, 17 Jun 2014 13:40:36 +0000 (09:40 -0400)]
status check packets don't have a client.  Closes #691

9 years agoParent attributes correctly when pulling them out of the TLS session cache
Arran Cudbard-Bell [Tue, 17 Jun 2014 13:35:27 +0000 (14:35 +0100)]
Parent attributes correctly when pulling them out of the TLS session cache

9 years agoAdd newlines to CONSISTENCY CHECK errors
Arran Cudbard-Bell [Tue, 17 Jun 2014 13:27:43 +0000 (14:27 +0100)]
Add newlines to CONSISTENCY CHECK errors

9 years agoPrint file and line number in VERIFY_* messages
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:49:54 +0000 (13:49 +0100)]
Print file and line number in VERIFY_* messages

9 years agoDon't use fr_perror in the verify functions (outputs spurious errors)
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:25:55 +0000 (13:25 +0100)]
Don't use fr_perror in the verify functions (outputs spurious errors)

9 years agoNot sure if talloc_get_name() is legal
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:15:21 +0000 (13:15 +0100)]
Not sure if talloc_get_name() is legal

9 years agoChange ADSL-Agent-Circuit-ID and ADSL-Agent-Remote-ID to octets types as per RFC...
Arran Cudbard-Bell [Tue, 17 Jun 2014 11:19:04 +0000 (12:19 +0100)]
Change ADSL-Agent-Circuit-ID and ADSL-Agent-Remote-ID to octets types as per RFC 4679

9 years agoUse the proper verify_request function instead of talloc_get_type_abort
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:29:44 +0000 (11:29 +0100)]
Use the proper verify_request function instead of talloc_get_type_abort

9 years agoSprinkle VERIFY_REQUEST throughout the state machine
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:26:08 +0000 (11:26 +0100)]
Sprinkle VERIFY_REQUEST throughout the state machine

9 years agoColourise should no be true by default
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:18:18 +0000 (11:18 +0100)]
Colourise should no be true by default

9 years agoMore radclient formatting and minor fixes
Arran Cudbard-Bell [Tue, 17 Jun 2014 09:05:15 +0000 (10:05 +0100)]
More radclient formatting and minor fixes

9 years agoRelax libssl checks
Arran Cudbard-Bell [Tue, 17 Jun 2014 09:04:59 +0000 (10:04 +0100)]
Relax libssl checks

9 years agoMissed break
Arran Cudbard-Bell [Mon, 16 Jun 2014 20:56:21 +0000 (21:56 +0100)]
Missed break

9 years agoMissed type
Arran Cudbard-Bell [Mon, 16 Jun 2014 17:58:30 +0000 (18:58 +0100)]
Missed type

9 years agoshow encoded packet before TLS encryption
Alan T. DeKok [Sat, 14 Jun 2014 14:53:00 +0000 (10:53 -0400)]
show encoded packet before TLS encryption

9 years agoFix indent
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:39:44 +0000 (15:39 +0100)]
Fix indent

9 years agoUse sane macro names for codes. PW_CODE_AUTHENTICATION_ACK, PW_CODE_AUTHENTICATION_RE...
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:37:22 +0000 (15:37 +0100)]
Use sane macro names for codes. PW_CODE_AUTHENTICATION_ACK, PW_CODE_AUTHENTICATION_REJECT? Really?

9 years agoTry harder in radclient to figure out request/response codes and ports from informati...
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:35:00 +0000 (15:35 +0100)]
Try harder in radclient to figure out request/response codes and ports from information we were provided with

9 years agoGah, double negatives
Arran Cudbard-Bell [Mon, 16 Jun 2014 13:19:30 +0000 (14:19 +0100)]
Gah, double negatives

9 years agoFix for backtrace deadlock and GLIBC
Arran Cudbard-Bell [Mon, 16 Jun 2014 11:55:25 +0000 (12:55 +0100)]
Fix for backtrace deadlock and GLIBC

9 years agoBetter ldap version fixes
Arran Cudbard-Bell [Sun, 15 Jun 2014 07:31:51 +0000 (08:31 +0100)]
Better ldap version fixes

9 years agoPrint error if we can't get libldap version
Arran Cudbard-Bell [Sat, 14 Jun 2014 21:02:38 +0000 (22:02 +0100)]
Print error if we can't get libldap version

9 years agoAdd more version checks for modules
Arran Cudbard-Bell [Sat, 14 Jun 2014 20:37:05 +0000 (21:37 +0100)]
Add more version checks for modules

9 years agoWhat's a Boyan?
Arran Cudbard-Bell [Sat, 14 Jun 2014 13:16:03 +0000 (14:16 +0100)]
What's a Boyan?

9 years agosizeof(array_arg) doesn't work as expected so use digest length macros
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:47:08 +0000 (17:47 +0100)]
sizeof(array_arg) doesn't work as expected so use digest length macros

9 years agoFix fall-through behaviour in rlm_sql Closes #622
Arran Cudbard-Bell [Fri, 13 Jun 2014 18:28:53 +0000 (19:28 +0100)]
Fix fall-through behaviour in rlm_sql Closes #622

9 years agoWhitespace
Alan T. DeKok [Fri, 13 Jun 2014 19:36:05 +0000 (15:36 -0400)]
Whitespace

9 years agoAs found in a PPT by Klass Wierenga
Alan T. DeKok [Fri, 13 Jun 2014 19:14:59 +0000 (15:14 -0400)]
As found in a PPT by Klass Wierenga

9 years agoNote correct names for data types
Alan T. DeKok [Fri, 13 Jun 2014 19:14:46 +0000 (15:14 -0400)]
Note correct names for data types

9 years agoDeclare more things as arrays
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:57:16 +0000 (17:57 +0100)]
Declare more things as arrays

9 years agoDeclare hextab as an array
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:52:21 +0000 (17:52 +0100)]
Declare hextab as an array

9 years agoMerge pull request #688 from philmayers/fix-nthash
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:05:12 +0000 (17:05 +0100)]
Merge pull request #688 from philmayers/fix-nthash

pass length of nthashhash as argument

9 years agopass length of nthashhash as argument, since sizeof() does not work on array arguments
Phil Mayers [Fri, 13 Jun 2014 15:54:01 +0000 (16:54 +0100)]
pass length of nthashhash as argument, since sizeof() does not work on array arguments

9 years agoThe fewer magic numbers the better...
Arran Cudbard-Bell [Fri, 13 Jun 2014 15:37:54 +0000 (16:37 +0100)]
The fewer magic numbers the better...

9 years agoBetter debug output from rlm_mschap
Arran Cudbard-Bell [Fri, 13 Jun 2014 15:37:24 +0000 (16:37 +0100)]
Better debug output from rlm_mschap

9 years agoExtraneous comma
Arran Cudbard-Bell [Fri, 13 Jun 2014 14:07:17 +0000 (15:07 +0100)]
Extraneous comma

9 years agoReplaced references to MS-CHAP-Success with MS2-CHAP-Success
Herwin Weststrate [Wed, 11 Jun 2014 14:45:14 +0000 (16:45 +0200)]
Replaced references to MS-CHAP-Success with MS2-CHAP-Success

The first attribute doesn't exist.

9 years agoReintroduced a comma to make sentence readable
Herwin Weststrate [Mon, 2 Jun 2014 09:06:59 +0000 (11:06 +0200)]
Reintroduced a comma to make sentence readable

Accidentally removed in 8430d8fa618140bafe289142626061fdc5419d58

9 years agoFixed some capitalization in mods-available/eap
Herwin Weststrate [Fri, 30 May 2014 08:13:05 +0000 (10:13 +0200)]
Fixed some capitalization in mods-available/eap

9 years agoFixed some whitespace in mods-available/eap
Herwin Weststrate [Fri, 30 May 2014 08:10:14 +0000 (10:10 +0200)]
Fixed some whitespace in mods-available/eap

Make consistently use of tabs, instead of mostly tabs and sometimes spaces.

9 years agoFix and document check_timeout which helps with check_interval
Alan T. DeKok [Fri, 13 Jun 2014 13:37:22 +0000 (09:37 -0400)]
Fix and document check_timeout which helps with check_interval

9 years agoRemove re-defined attributes
Alan T. DeKok [Fri, 13 Jun 2014 12:44:31 +0000 (08:44 -0400)]
Remove re-defined attributes

9 years agoRemove 'children' option from rlm_ldap debug messages when the children scope is...
Arran Cudbard-Bell [Fri, 13 Jun 2014 13:18:18 +0000 (14:18 +0100)]
Remove 'children' option from rlm_ldap debug messages when the children scope is not available

9 years agoOnly parse dereference value if we actually have a value to parse
Arran Cudbard-Bell [Fri, 13 Jun 2014 13:08:48 +0000 (14:08 +0100)]
Only parse dereference value if we actually have a value to parse

9 years agoUse correct lookup table. Fixes #686
Arran Cudbard-Bell [Fri, 13 Jun 2014 13:07:07 +0000 (14:07 +0100)]
Use correct lookup table. Fixes #686

9 years agoRemove empty debug message
Arran Cudbard-Bell [Fri, 13 Jun 2014 12:56:15 +0000 (13:56 +0100)]
Remove empty debug message

9 years agoRespect fr_hostname_lookups in libfreeradius
Arran Cudbard-Bell [Fri, 13 Jun 2014 12:53:56 +0000 (13:53 +0100)]
Respect fr_hostname_lookups in libfreeradius

9 years agoShouldn't be an error...
Arran Cudbard-Bell [Fri, 13 Jun 2014 12:44:50 +0000 (13:44 +0100)]
Shouldn't be an error...

9 years agoFixup PG example and don't send application name by default
Arran Cudbard-Bell [Fri, 13 Jun 2014 12:42:23 +0000 (13:42 +0100)]
Fixup PG example and don't send application name by default

9 years agoDebug fixes for radeapclient
Arran Cudbard-Bell [Fri, 13 Jun 2014 12:37:20 +0000 (13:37 +0100)]
Debug fixes for radeapclient

9 years agoFix radtest to work when the local hostname is not resolvable
Arran Cudbard-Bell [Fri, 13 Jun 2014 10:08:41 +0000 (11:08 +0100)]
Fix radtest to work when the local hostname is not resolvable

9 years agoFixed compile error in rlm_ldap
Herwin Weststrate [Fri, 13 Jun 2014 08:20:04 +0000 (10:20 +0200)]
Fixed compile error in rlm_ldap

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 13 Jun 2014 08:14:08 +0000 (09:14 +0100)]
Update ChangeLog

9 years agoAdd support for dereferencing (following LDAP aliases)
Arran Cudbard-Bell [Fri, 13 Jun 2014 07:54:30 +0000 (08:54 +0100)]
Add support for dereferencing (following LDAP aliases)

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Wed, 12 Feb 2014 14:00:00 +0000 (14:00 +0000)]
Update ChangeLog

9 years agoAdd sql_unset_user(). Fixes #640
Alan T. DeKok [Fri, 13 Jun 2014 02:55:01 +0000 (22:55 -0400)]
Add sql_unset_user().  Fixes #640

It's really just a macro around pairdelete.  But it's clearer
to have sql_set_user() / sql_unset_user, than to use pairdelete

9 years agoMake the configuration more understandable. Fixes #678
Alan T. DeKok [Fri, 13 Jun 2014 02:46:15 +0000 (22:46 -0400)]
Make the configuration more understandable.  Fixes #678

It should just be "response_timeouts", and not "max_response_timeouts"
it's not an upper limit, and there's no "min" limit.

Setting "ignore this many replies missing" is hard to understand.
It's easier to say "trigger zombie period after response_timeouts
packets are lost".

9 years agoAdd max_response_timeouts option
Nikolai Kondrashov [Wed, 4 Jun 2014 17:06:48 +0000 (20:06 +0300)]
Add max_response_timeouts option

Add "max_response_timeouts" - a home server option specifying number of
times replies are allowed to miss "response_window" before the server
enters the zombie period.

This allows more tolerance before transiting to zombie period for lower
response window configurations.

9 years agoLet client response windows override init_delay
Nikolai Kondrashov [Fri, 30 May 2014 17:23:57 +0000 (20:23 +0300)]
Let client response windows override init_delay

Allow client's response_window lower than main_config.init_delay to
override it. This allows initial request processing delay to track
client response windows, in addition to home server response windows.

9 years agoFix error message. Closs #683
Alan T. DeKok [Thu, 12 Jun 2014 13:18:50 +0000 (09:18 -0400)]
Fix error message.  Closs #683

9 years agoMore EAP attribute definitions which should have been converted
Arran Cudbard-Bell [Wed, 11 Jun 2014 18:11:08 +0000 (19:11 +0100)]
More EAP attribute definitions which should have been converted

9 years agoSearch for the correct alternative attributes...
Arran Cudbard-Bell [Wed, 11 Jun 2014 17:51:07 +0000 (18:51 +0100)]
Search for the correct alternative attributes...

9 years agoEAP Sim code should use PW_EAP_* definitions instead of ATTRIBUTE_EAP_SIM_*
Arran Cudbard-Bell [Wed, 11 Jun 2014 17:47:19 +0000 (18:47 +0100)]
EAP Sim code should use PW_EAP_* definitions instead of ATTRIBUTE_EAP_SIM_*

9 years agoWhitespace
Alan T. DeKok [Wed, 11 Jun 2014 17:02:52 +0000 (13:02 -0400)]
Whitespace

9 years agoFormatting
Arran Cudbard-Bell [Wed, 11 Jun 2014 15:50:37 +0000 (16:50 +0100)]
Formatting

9 years agoRelax DHCP sub-option parser slightly
Arran Cudbard-Bell [Wed, 11 Jun 2014 15:50:17 +0000 (16:50 +0100)]
Relax DHCP sub-option parser slightly

9 years agoRemove DHCP Client Identifier hack, this can, and should, be done in policy.
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:45:07 +0000 (15:45 +0100)]
Remove DHCP Client Identifier hack, this can, and should, be done in policy.

9 years agoDHCP-Client-Identifier and DHCP-Vendor-Class-Identifier should both be octets types
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:26:45 +0000 (15:26 +0100)]
DHCP-Client-Identifier and DHCP-Vendor-Class-Identifier should both be octets types

9 years agoWe no longer need to artificially limit the size of DHCP options to 253 bytes
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:14:31 +0000 (15:14 +0100)]
We no longer need to artificially limit the size of DHCP options to 253 bytes

Dynamically allocated value buffers FTW

9 years agoDon't stop parsing on padding options
Arran Cudbard-Bell [Wed, 11 Jun 2014 14:09:39 +0000 (15:09 +0100)]
Don't stop parsing on padding options

9 years agoVPs are allocated in the packet CTX, not the request
Alan T. DeKok [Wed, 11 Jun 2014 13:37:04 +0000 (09:37 -0400)]
VPs are allocated in the packet CTX, not the request

9 years agoFix horrific formatting in EAP-PWD
Arran Cudbard-Bell [Wed, 11 Jun 2014 12:22:35 +0000 (13:22 +0100)]
Fix horrific formatting in EAP-PWD

9 years agoAdd TALLOC_CTX to RADIUS protocol decoder. We're not always allocating in the context...
Arran Cudbard-Bell [Wed, 11 Jun 2014 09:41:26 +0000 (10:41 +0100)]
Add TALLOC_CTX to RADIUS protocol decoder. We're not always allocating in the context of a packet.

Fixes #668

Also fixes potential threading issues in EAP-TTLS

9 years agoFormatting
Arran Cudbard-Bell [Wed, 11 Jun 2014 08:23:41 +0000 (09:23 +0100)]
Formatting

9 years agoNot every LDAP library supports setting Network Timeout
Arran Cudbard-Bell [Wed, 11 Jun 2014 08:17:45 +0000 (09:17 +0100)]
Not every LDAP library supports setting Network Timeout

9 years agoHmm, setting _X_OPEN_SOURCE breaks everything
Arran Cudbard-Bell [Tue, 10 Jun 2014 20:46:05 +0000 (21:46 +0100)]
Hmm, setting _X_OPEN_SOURCE breaks everything

9 years agoMore fixes for Betriebssystemschwein
Arran Cudbard-Bell [Tue, 10 Jun 2014 20:14:08 +0000 (21:14 +0100)]
More fixes for Betriebssystemschwein

Set _X_OPEN_SOURCE=600 and -std=c99 earlier so that ./configure runs against appropriate versions of the POSIX APIs.

Fix rlm_krb5 configure script to correctly detect that Betriebssystemschwein's libkrb5 is based on MIT's

Include fcntl.h in log.c, this should probably always of been included...

Add alternative names for macros in rlm_ldap/ldap.h and #ifdef out a few lines of code, as starttls doesn't seen to be available...

9 years agoCoverity CID #1222259
Arran Cudbard-Bell [Tue, 10 Jun 2014 18:34:06 +0000 (19:34 +0100)]
Coverity CID #1222259

9 years agoAdd dependencies for load-balance redundant-load-balance tests, add load-balance...
Arran Cudbard-Bell [Tue, 10 Jun 2014 18:04:51 +0000 (19:04 +0100)]
Add dependencies for load-balance redundant-load-balance tests, add load-balance test

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 10 Jun 2014 16:13:45 +0000 (17:13 +0100)]
Update ChangeLog

9 years agoTests for redundant load balance
Alan T. DeKok [Tue, 10 Jun 2014 15:43:36 +0000 (11:43 -0400)]
Tests for redundant load balance