freeradius.git
10 years agoMerge pull request #348 from arr2036/zero_length_exp
Alan DeKok [Fri, 5 Jul 2013 16:48:46 +0000 (09:48 -0700)]
Merge pull request #348 from arr2036/zero_length_exp

Don't generate errors on zero length expansions

10 years agoBase sql configs are in main
Arran Cudbard-Bell [Fri, 5 Jul 2013 16:30:17 +0000 (17:30 +0100)]
Base sql configs are in main

10 years agoSet dbc and env to NULL to avoid double free
Arran Cudbard-Bell [Fri, 5 Jul 2013 16:30:54 +0000 (17:30 +0100)]
Set dbc and env to NULL to avoid double free

10 years agoConsistently return a zero length buffer from xlat_process, except on error condition...
Arran Cudbard-Bell [Fri, 5 Jul 2013 15:57:35 +0000 (16:57 +0100)]
Consistently return a zero length buffer from xlat_process, except on error condition (where we free)

10 years agoDon't generate errors on zero length expansions
Arran Cudbard-Bell [Fri, 5 Jul 2013 15:20:54 +0000 (16:20 +0100)]
Don't generate errors on zero length expansions

10 years agoNotes on rlm_sql_freetds/rlm_sql_sybase
Arran Cudbard-Bell [Fri, 5 Jul 2013 13:25:27 +0000 (09:25 -0400)]
Notes on rlm_sql_freetds/rlm_sql_sybase

10 years agoFix quoting style in debug messages, should be double to match expansion quotes
Arran Cudbard-Bell [Fri, 5 Jul 2013 10:50:41 +0000 (11:50 +0100)]
Fix quoting style in debug messages, should be double to match expansion quotes

10 years agoOnly list one deprecated alternative to avoid users needing to change the config...
Arran Cudbard-Bell [Thu, 4 Jul 2013 22:08:41 +0000 (23:08 +0100)]
Only list one deprecated alternative to avoid users needing to change the config item twice

10 years agoSet the destructor only when necessary. Closes #347
Alan T. DeKok [Thu, 4 Jul 2013 20:18:55 +0000 (16:18 -0400)]
Set the destructor only when necessary.  Closes #347

and reset it before returning the memory to the caller

10 years agoWhitespace fixes
Alan T. DeKok [Thu, 4 Jul 2013 12:30:26 +0000 (08:30 -0400)]
Whitespace fixes

10 years agore-align utility help output
Arran Cudbard-Bell [Wed, 3 Jul 2013 18:15:09 +0000 (19:15 +0100)]
re-align utility help output

10 years agoUpdate README.rst
Arran Cudbard-Bell [Wed, 3 Jul 2013 22:11:25 +0000 (18:11 -0400)]
Update README.rst

10 years agoFormatting
Arran Cudbard-Bell [Wed, 3 Jul 2013 17:58:20 +0000 (18:58 +0100)]
Formatting

10 years agoAnother missed default
Arran Cudbard-Bell [Wed, 3 Jul 2013 17:07:19 +0000 (18:07 +0100)]
Another missed default

10 years agoOnly call paircompare register once per instance of rlm_ldap
Arran Cudbard-Bell [Wed, 3 Jul 2013 16:55:33 +0000 (17:55 +0100)]
Only call paircompare register once per instance of rlm_ldap

10 years agoEverything else uses attribute
Arran Cudbard-Bell [Wed, 3 Jul 2013 16:54:53 +0000 (17:54 +0100)]
Everything else uses attribute

10 years agoLast tranche of config item name standardisation (in modules)
Arran Cudbard-Bell [Wed, 3 Jul 2013 16:41:39 +0000 (17:41 +0100)]
Last tranche of config item name standardisation (in modules)

10 years agoUse EXIT_FAILURE and EXIT_SUCCESS macros
Arran Cudbard-Bell [Wed, 3 Jul 2013 14:52:10 +0000 (15:52 +0100)]
Use EXIT_FAILURE and EXIT_SUCCESS macros

10 years agoFix return codes in radiusd
Arran Cudbard-Bell [Wed, 3 Jul 2013 14:49:33 +0000 (15:49 +0100)]
Fix return codes in radiusd

10 years agoMd not dM
Arran Cudbard-Bell [Wed, 3 Jul 2013 14:20:06 +0000 (15:20 +0100)]
Md not dM

10 years agoMemory report and check when performing config check
Arran Cudbard-Bell [Wed, 3 Jul 2013 13:52:41 +0000 (14:52 +0100)]
Memory report and check when performing config check

10 years agoFix memory check on -C -m|-M
Arran Cudbard-Bell [Wed, 3 Jul 2013 13:48:37 +0000 (14:48 +0100)]
Fix memory check on -C -m|-M

10 years agoFix up uses of talloc
Alan T. DeKok [Wed, 3 Jul 2013 13:45:15 +0000 (09:45 -0400)]
Fix up uses of talloc

and change one malloc to talloc

10 years agoMinor updates
Alan T. DeKok [Wed, 3 Jul 2013 01:28:21 +0000 (21:28 -0400)]
Minor updates

10 years agoUpdate ldap
Arran Cudbard-Bell [Tue, 2 Jul 2013 22:45:53 +0000 (18:45 -0400)]
Update ldap

10 years agoMore updates and formatting
Arran Cudbard-Bell [Tue, 2 Jul 2013 21:33:05 +0000 (17:33 -0400)]
More updates and formatting

10 years agoUpdate README.rst
Arran Cudbard-Bell [Tue, 2 Jul 2013 21:21:49 +0000 (17:21 -0400)]
Update README.rst

10 years agoAdd notes on portmanteau config items
Arran Cudbard-Bell [Tue, 2 Jul 2013 21:19:54 +0000 (17:19 -0400)]
Add notes on portmanteau config items

10 years agoBe nice, and print out the name of the new config item if it's next in the array
Arran Cudbard-Bell [Tue, 2 Jul 2013 21:12:24 +0000 (22:12 +0100)]
Be nice, and print out the name of the new config item if it's next in the array

10 years agoRemove default for depricated config item
Arran Cudbard-Bell [Tue, 2 Jul 2013 20:52:23 +0000 (21:52 +0100)]
Remove default for depricated config item

10 years agorlm_expiration no longer takes any configuration items
Arran Cudbard-Bell [Tue, 2 Jul 2013 20:37:55 +0000 (21:37 +0100)]
rlm_expiration no longer takes any configuration items

10 years agoMissed removing config for rlm_expiration
Arran Cudbard-Bell [Tue, 2 Jul 2013 18:58:30 +0000 (19:58 +0100)]
Missed removing config for rlm_expiration

10 years agoBe consistent in our inconsistency
Arran Cudbard-Bell [Tue, 2 Jul 2013 18:57:43 +0000 (19:57 +0100)]
Be consistent in our inconsistency

10 years agoTypo
Arran Cudbard-Bell [Tue, 2 Jul 2013 18:55:50 +0000 (19:55 +0100)]
Typo

10 years agoUse references in cache file example config
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:44:27 +0000 (18:44 +0100)]
Use references in cache file example config

10 years agodeprecate minimum-timeout in longin time, now minimum_timeout
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:41:35 +0000 (18:41 +0100)]
deprecate minimum-timeout in longin time, now minimum_timeout

10 years agoRemove support for reply-message from expiration, this can be set in unlang
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:40:54 +0000 (18:40 +0100)]
Remove support for reply-message from expiration, this can be set in unlang

10 years agoReplace remaining instances of safe-characters with safe_characters
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:30:21 +0000 (18:30 +0100)]
Replace remaining instances of safe-characters with safe_characters

10 years agoReplace nas_table with client_table
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:29:19 +0000 (18:29 +0100)]
Replace nas_table with client_table

10 years agoUse standard TLS config item names across all modules
Arran Cudbard-Bell [Tue, 2 Jul 2013 17:21:05 +0000 (18:21 +0100)]
Use standard TLS config item names across all modules

Although this represents a lot of pain for users upgrading, it allows (with the new section references) a single TLS configuration section to be used for all modules in the server.

10 years agoAttribute should be singular not plaural
Arran Cudbard-Bell [Tue, 2 Jul 2013 16:38:31 +0000 (17:38 +0100)]
Attribute should be singular not plaural

10 years agoSupport 'children' scope
Arran Cudbard-Bell [Tue, 2 Jul 2013 16:35:21 +0000 (17:35 +0100)]
Support 'children' scope

10 years agoChanges to default ldap configuration which were missed
Arran Cudbard-Bell [Tue, 2 Jul 2013 16:24:13 +0000 (17:24 +0100)]
Changes to default ldap configuration which were missed

10 years agoRemove reference to certs patch
Arran Cudbard-Bell [Tue, 2 Jul 2013 14:47:41 +0000 (10:47 -0400)]
Remove reference to certs patch

10 years agonas_query is deprecated, replaced by client_query
Arran Cudbard-Bell [Tue, 2 Jul 2013 14:32:42 +0000 (15:32 +0100)]
nas_query is deprecated, replaced by client_query

10 years agosafe-charcters is deprecated, replaced by safe_characters
Arran Cudbard-Bell [Tue, 2 Jul 2013 14:17:24 +0000 (15:17 +0100)]
safe-charcters is deprecated, replaced by safe_characters
deletestalesessions is deprecated, replaced by delete_stale_sessions
readclients is deprecated, replaced by read_clients

10 years agoCleanup things in modcall and fix missing closing brace
Arran Cudbard-Bell [Tue, 2 Jul 2013 13:37:48 +0000 (14:37 +0100)]
Cleanup things in modcall and fix missing closing brace

10 years agoSQL functions now use ssize_t so that they can indicate actual error conditions
Arran Cudbard-Bell [Tue, 2 Jul 2013 12:36:17 +0000 (13:36 +0100)]
SQL functions now use ssize_t so that they can indicate actual error conditions

A module expanding to a 0 length string is no longer considered and error condition

If a module xlat returns < 0 update sections will return fail

10 years agoDon't shadow a global symbol
Alan T. DeKok [Tue, 2 Jul 2013 12:35:08 +0000 (08:35 -0400)]
Don't shadow a global symbol

10 years agoReorder arguments to radius_exec_program so they make more sense
Arran Cudbard-Bell [Tue, 2 Jul 2013 11:00:56 +0000 (12:00 +0100)]
Reorder arguments to radius_exec_program so they make more sense

Use a single function to deal with status codes and module failure messages

Have fork return 2 (translates to RLM_MODULE_FAIL)

10 years agoMerge pull request #342 from fajarnugraha/master-suse-20130510
Arran Cudbard-Bell [Tue, 2 Jul 2013 07:31:00 +0000 (00:31 -0700)]
Merge pull request #342 from fajarnugraha/master-suse-20130510

Fix suse package to build and run cleanly for current master branch

10 years agosuse: enable parallel build
Fajar A. Nugraha [Tue, 2 Jul 2013 02:37:56 +0000 (09:37 +0700)]
suse: enable parallel build

10 years agosuse: add --disable-developer
Fajar A. Nugraha [Tue, 2 Jul 2013 02:36:21 +0000 (09:36 +0700)]
suse: add --disable-developer

10 years agosuse: cleanup CFLAGS
Fajar A. Nugraha [Tue, 2 Jul 2013 02:34:33 +0000 (09:34 +0700)]
suse: cleanup CFLAGS

Removed '-fstack-protector -fno-strict-aliasing'. Already
included by default, no need to include it manually.

10 years agosuse: link to wiki page for authors credit
Fajar A. Nugraha [Tue, 2 Jul 2013 02:24:46 +0000 (09:24 +0700)]
suse: link to wiki page for authors credit

10 years agoAdd PW_TYPE_FILE_INPUT (which verifies the file exists) and PW_TYPE_FILE_OUTPUT ...
Arran Cudbard-Bell [Mon, 1 Jul 2013 16:48:08 +0000 (17:48 +0100)]
Add PW_TYPE_FILE_INPUT (which verifies the file exists) and PW_TYPE_FILE_OUTPUT , which is still a file, but not required to exist

10 years agoWhitespace changes rlm_exec
Arran Cudbard-Bell [Mon, 1 Jul 2013 13:44:01 +0000 (14:44 +0100)]
Whitespace changes rlm_exec

10 years agoAdd PW_TYPE_EXISTS
Arran Cudbard-Bell [Mon, 1 Jul 2013 13:41:46 +0000 (14:41 +0100)]
Add PW_TYPE_EXISTS

Which requires the file specified to exist on startup

10 years agoMark more things as filenames
Arran Cudbard-Bell [Mon, 1 Jul 2013 13:41:03 +0000 (14:41 +0100)]
Mark more things as filenames

10 years agoRemove unecessary configure arguments
Arran Cudbard-Bell [Mon, 1 Jul 2013 11:27:58 +0000 (04:27 -0700)]
Remove unecessary configure arguments

10 years agoMay as well make it official
Arran Cudbard-Bell [Mon, 1 Jul 2013 09:47:53 +0000 (10:47 +0100)]
May as well make it official

10 years agosuse: build fixes
Fajar A. Nugraha [Mon, 1 Jul 2013 08:28:32 +0000 (15:28 +0700)]
suse: build fixes

* Merge most changes to suse/freeradius.spec from v2.x.x branch.
* Add suse/freeradius-server-rpmlintrc and
  suse/freeradius-server-tmpfiles.conf from v2.x.x branch.
* Merge changes on suse/freeradius-server-2.1.6-suseinit.patch.
* Add BuildRequires: libtalloc-devel.
* Remove BuildRequires: apache2-devel. Dialup admin was removed.
* Remove BuildRequires: cyrus-sasl-devel, openssl. Already installed
  as requirement for other BuildRequires.
* Remove BuildRequires: gettext-devel, libtool, net-snmp-devel.
  No longer needed.
* Remove unneeded configure flags.
* Make main package more generic by using wildcard in %files. For
  example, it will put resulting oracle libs (if enabled during build)
  on the main package.

10 years agoloc is not options
Arran Cudbard-Bell [Mon, 1 Jul 2013 05:30:05 +0000 (06:30 +0100)]
loc is not options

10 years agoIf anything exists don't create the link...
Arran Cudbard-Bell [Sun, 30 Jun 2013 19:08:06 +0000 (20:08 +0100)]
If anything exists don't create the link...

10 years agoUpdate README.rst
Arran Cudbard-Bell [Sun, 30 Jun 2013 16:49:25 +0000 (12:49 -0400)]
Update README.rst

10 years agoUpdate README.rst
Arran Cudbard-Bell [Sun, 30 Jun 2013 16:47:26 +0000 (12:47 -0400)]
Update README.rst

10 years agoApparently making the symlink targets as order only dependencies isnt good enough
Arran Cudbard-Bell [Sun, 30 Jun 2013 16:36:10 +0000 (17:36 +0100)]
Apparently making the symlink targets as order only dependencies isnt good enough

10 years agoDon't start if the configuration contains deprecated config items
Arran Cudbard-Bell [Sun, 30 Jun 2013 16:19:49 +0000 (17:19 +0100)]
Don't start if the configuration contains deprecated config items

10 years agoDon't try and link if legacy files exist already. Fixes #341
Arran Cudbard-Bell [Sun, 30 Jun 2013 15:55:33 +0000 (16:55 +0100)]
Don't try and link if legacy files exist already. Fixes #341

10 years agoNon-existent attrs expand to "". Closes #308
Alan T. DeKok [Sun, 30 Jun 2013 14:53:36 +0000 (10:53 -0400)]
Non-existent attrs expand to "".  Closes #308

10 years agoAlways fixup after deleting a black child node in rbtree
skids [Tue, 25 Jun 2013 00:40:48 +0000 (20:40 -0400)]
Always fixup after deleting a black child node in rbtree

This prevents rbtree_delete from creating unbalanced/illegal rbtrees.

10 years agoUse a consistent callback return code
skids [Thu, 20 Jun 2013 20:54:31 +0000 (16:54 -0400)]
Use a consistent callback return code

  This is the one place in the codebase where a positive return code
  is used in an rbtree_walk callback.  Changing it negative should have no
  effect, and keeps options open as to whether to introduce new symbols
  for the next patch to follow, or to change the libfreeradius API
  slightly WRT rbtree callback return codes.

  Whether any third-party add-ons may use positive return codes is not
  known.

10 years agoFix obvious pasto in PostOrder walk.
skids [Thu, 20 Jun 2013 02:47:33 +0000 (22:47 -0400)]
Fix obvious pasto in PostOrder walk.

10 years agoWhen a socket is closed, just mark the requests as STOP
Alan T. DeKok [Sat, 29 Jun 2013 13:14:31 +0000 (09:14 -0400)]
When a socket is closed, just mark the requests as STOP

Someone else will take care of cleaning them up.  Calling
request_done() appears to cause issues

10 years agoMake auto_limit_acct probabalistic
Alan T. DeKok [Sat, 29 Jun 2013 02:59:29 +0000 (22:59 -0400)]
Make auto_limit_acct probabalistic

10 years agoMinor cleanup to cleanup code
Alan T. DeKok [Sat, 29 Jun 2013 02:37:37 +0000 (22:37 -0400)]
Minor cleanup to cleanup code

10 years agoMake requests NULL talloc context
Alan T. DeKok [Sat, 29 Jun 2013 02:33:42 +0000 (22:33 -0400)]
Make requests NULL talloc context

there are just too many cases where the socket could go away,
and the request is still referenced somewhere else in the code.

10 years agoNote changes to configuration item names
Alan T. DeKok [Sat, 29 Jun 2013 02:08:23 +0000 (22:08 -0400)]
Note changes to configuration item names

10 years agoBe consistent with common config_item names
Arran Cudbard-Bell [Fri, 28 Jun 2013 17:40:43 +0000 (18:40 +0100)]
Be consistent with common config_item names

If a file is being referenced or created the config item 'filename' is used.

If a file is being created, the initial permissions are set by the 'permissions' config item.

If a directory hierarchy needs to be created the permissions are set by 'dir_permissions'

If an external host is referenced in the context of a module the 'server' config item is used.

file, script_file, module, detail, detailfile, attrsfile, perm, dirperm, detailperm,
hostname are all deprecated.

10 years agoRemove debug macro
Alan T. DeKok [Fri, 28 Jun 2013 21:03:57 +0000 (17:03 -0400)]
Remove debug macro

10 years agoMore docs on recent changes
Alan T. DeKok [Fri, 28 Jun 2013 17:21:19 +0000 (13:21 -0400)]
More docs on recent changes

10 years agoAlways set reply timestamp.
Alan T. DeKok [Fri, 28 Jun 2013 17:20:29 +0000 (13:20 -0400)]
Always set reply timestamp.

This allows TCP rejects to be sent.  (oops)

10 years agoSteal the packet so we don't leak memory
Alan T. DeKok [Fri, 28 Jun 2013 13:37:11 +0000 (09:37 -0400)]
Steal the packet so we don't leak memory

10 years agoRemove refcount on mainconfig. It's not used
Alan T. DeKok [Fri, 28 Jun 2013 12:08:59 +0000 (08:08 -0400)]
Remove refcount on mainconfig.  It's not used

10 years agoSimplify request_free() now that we use talloc everywhere
Alan T. DeKok [Fri, 28 Jun 2013 12:07:21 +0000 (08:07 -0400)]
Simplify request_free() now that we use talloc everywhere

10 years agoSteal the CoA packet when we reparent it
Alan T. DeKok [Fri, 28 Jun 2013 12:06:14 +0000 (08:06 -0400)]
Steal the CoA packet when we reparent it

10 years agoMake request_alloc() take a TALLOC_CTX
Alan T. DeKok [Fri, 28 Jun 2013 11:58:25 +0000 (07:58 -0400)]
Make request_alloc() take a TALLOC_CTX

10 years agoIndentation matters
Alan T. DeKok [Fri, 28 Jun 2013 11:53:23 +0000 (07:53 -0400)]
Indentation matters

10 years agoRemove unused function
Alan T. DeKok [Fri, 28 Jun 2013 11:51:15 +0000 (07:51 -0400)]
Remove unused function

10 years agoMove request data to talloc
Alan T. DeKok [Fri, 28 Jun 2013 11:48:15 +0000 (07:48 -0400)]
Move request data to talloc

10 years agoSprinkle PW_TYPE_REQUIRED over module configuration sections
Arran Cudbard-Bell [Fri, 28 Jun 2013 16:31:10 +0000 (17:31 +0100)]
Sprinkle PW_TYPE_REQUIRED over module configuration sections

10 years agoFix -HUP
Arran Cudbard-Bell [Fri, 28 Jun 2013 15:53:37 +0000 (16:53 +0100)]
Fix -HUP

10 years agoMinor formatting in modules.c
Arran Cudbard-Bell [Fri, 28 Jun 2013 15:53:23 +0000 (16:53 +0100)]
Minor formatting in modules.c

10 years agoadded support for IPv6 nas in postgres accounting
GEANT GN3 JRA3 T1 [Fri, 28 Jun 2013 16:43:55 +0000 (17:43 +0100)]
added support for IPv6 nas in postgres accounting

10 years agoCleanup whitespace in config files
Arran Cudbard-Bell [Fri, 28 Jun 2013 13:58:42 +0000 (14:58 +0100)]
Cleanup whitespace in config files

10 years agoMinor fixes to cui policy
Arran Cudbard-Bell [Fri, 28 Jun 2013 13:58:24 +0000 (14:58 +0100)]
Minor fixes to cui policy

10 years agoMerge pull request #337 from armitasp/master
Arran Cudbard-Bell [Fri, 28 Jun 2013 13:36:48 +0000 (06:36 -0700)]
Merge pull request #337 from armitasp/master

updated cui policy

10 years agochange cui policy to remove warning about outer request not being available inner...
GEANT GN3 JRA3 T1 [Fri, 28 Jun 2013 15:15:01 +0000 (16:15 +0100)]
change cui policy to remove warning about outer request not being available inner context

10 years agoCall wait() with WNOHANG to reap any children left over by exec calls
Arran Cudbard-Bell [Fri, 28 Jun 2013 13:15:30 +0000 (14:15 +0100)]
Call wait() with WNOHANG to reap any children left over by exec calls

10 years agoUpdate radiusd.conf man pages with the properties syntax
Arran Cudbard-Bell [Fri, 28 Jun 2013 12:57:57 +0000 (13:57 +0100)]
Update radiusd.conf man pages with the properties syntax