Johannes Berg [Tue, 27 Jan 2009 10:28:05 +0000 (12:28 +0200)]
driver_nl80211: use Linux socket filter to improve performance
TX status information for all transmitted data frames is not going to
be sent to hostapd anymore, so the CPU load with high traffic load is
going to be significantly reduced.
Jouni Malinen [Sat, 24 Jan 2009 10:51:28 +0000 (12:51 +0200)]
Do not forget wpa_passphrase so that WPS can use it
Send ASCII passphrase instead of derived PSK if the configuration uses
the passphrase.
Jouni Malinen [Sat, 24 Jan 2009 10:50:00 +0000 (12:50 +0200)]
WPS: Add a workaround for incorrect passphrase encoding in Network Key
External Registrar in Vista may include NULL termination in the Network
Key when encoding an ASCII passphrase for WPA/WPA2-PSK. As a workaround,
remove this extra octet if present.
Jouni Malinen [Fri, 23 Jan 2009 19:57:43 +0000 (21:57 +0200)]
WPS: Lock AP Setup on multiple AP PIN validation failures
If a Registrar tries to configure the AP, but fails to validate the
device password (AP PIN), lock the AP setup after four failures. This
protects the AP PIN against brute force guessing attacks.
Jouni Malinen [Fri, 23 Jan 2009 19:08:55 +0000 (21:08 +0200)]
Added ap_settings option for overriding WPS AP Settings in M7
This optional configuration parameter can be used to override AP
Settings attributes in M7 similarly to extra_cred option for Credential
attribute(s) in M8.
Jouni Malinen [Fri, 23 Jan 2009 18:51:26 +0000 (20:51 +0200)]
Free extra_cred when freeing configuration
Jouni Malinen [Fri, 23 Jan 2009 16:01:03 +0000 (18:01 +0200)]
Add an EAPOL payload length workaround for a WPS implementation
Buffalo WHR-G125 Ver.1.47 seems to send EAP-WPS packets with too short
EAPOL header length field (14 octets regardless of EAP frame length).
This is fixed in firmware Ver.1.49, but the broken version is included
in many deployed APs. As a workaround, fix the EAPOL header based on the
correct length in the EAP packet. This workaround can be disabled with
eap_workaround=0 option in the network configuration.
Jouni Malinen [Fri, 23 Jan 2009 11:10:58 +0000 (13:10 +0200)]
Allow WPS APs for PIN enrollment even without Selected Registrar
Some WPS APs do not set Selected Registrar attribute to 1 properly when
using an external Registrar. Allow such an AP to be selected for PIN
registration after couple of scan runs that do not find APs marked with
Selected Registrar = 1. This allows wpa_supplicant to iterate through
all APs that advertise WPS support without delaying connection with
implementations that set Selected Registrar = 1 properly.
Jouni Malinen [Thu, 22 Jan 2009 19:26:14 +0000 (21:26 +0200)]
Allow WPS device strings to be unconfigured
Previous version was causing a NULL pointer dereference if a required
string was not set in configuration. It is better to make these
optional.
Jouni Malinen [Thu, 22 Jan 2009 17:32:58 +0000 (19:32 +0200)]
WPS: Pad DH Public Key and Shared Key to 192 octets
WPS spec is not very specific on the presentation used for the DH
values. The Public Key attribute is described to be 192 octets long, so
that could be interpreted to imply that other places use fixed length
presentation for the DH keys. Change the DH derivation to use fixed
length bufferd by zero padding them from beginning if needed. This can
resolve infrequent (about 1/256 chance for both Public Key and Shared
Key being shorter) interop issues.
Masashi Honma [Thu, 22 Jan 2009 13:18:03 +0000 (15:18 +0200)]
Use WPS state Not Configured instead of Configured in Enrollee
This is needed to allow external Registrar (at least the implementation
in Windows Vista) to configure the Enrollee.
With this patch and my previous patch (for wps.c) , I could pass "Wi-Fi
WPS Test Plan Version 1.0 [5.1.4. Add to AP using PIN Config method and
PASS PHRASE through wired external registrar]".
Masashi Honma [Thu, 22 Jan 2009 13:12:18 +0000 (15:12 +0200)]
WPS: Check Device Password ID attribute only if present in AP search
I can't pass the "Wi-Fi WPS Test Plan Version 1.0 [5.1.4. Add to AP
using PIN Config method and PASS PHRASE through wired external
registrar]". The wpa_supplicant-0.6.7 can't recoginize the testbed
AP(BCM94704AGRRev-E.2.4) as WPS PIN AP. Because after PIN entered, the
AP sends Selected Registrar attribute=0 and not send Device Password ID
attribute.
The proposed change as-is removed validation of Selected Registrar
attribute completely. However, that part is not included in this commit
since it can cause problems for environments with multiple WPS-enabled
APs. Another workaround for this will be considered in wpa_supplicant
scanning process (e.g., start trying to use WPS with APs that do not set
Selected Registrar to TRUE after couple of scan runs that do not find
any APs with Selected Registrar TRUE).
Jouni Malinen [Wed, 21 Jan 2009 14:42:11 +0000 (16:42 +0200)]
Documented interface for external WPS credential processing
Jouni Malinen [Wed, 21 Jan 2009 12:18:14 +0000 (14:18 +0200)]
Fixed WPS with open and shared WEP networks
Do not initialize EAPOL state machine for the STA when hostapd is
configured to use WPS with open or shared WEP networks. This allows the
STA to use EAPOL-Start to indicate it wants to start WPS in such a case
and hostapd does not end up running through EAPOL authentication timeout
and disconnecting the STA if WPS is not used.
There was already code for starting EAPOL state machines based on
received EAPOL packets, but that was not working properly since
portEnabled was not set to TRUE on that code path. This is now fixed,
too.
Jouni Malinen [Wed, 21 Jan 2009 11:48:10 +0000 (13:48 +0200)]
WPS: Added option to disable AP auto-config on first registration
This operation can now be moved into an external program by configuring
hostapd with wps_cred_processing=1 and skip_cred_build=1. A new
ctrl_iface message (WPS-REG-SUCCESS <Enrollee MAC addr> <UUID-E>) will
be used to notify external programs of each successful registration and
that can be used as a tricker to move from unconfigured to configured
state.
Jouni Malinen [Wed, 21 Jan 2009 09:54:12 +0000 (11:54 +0200)]
Added wps_cred_processing configuration option for hostapd
This behaves like the one in wpa_supplicant, i.e., hostapd can be
configured not to process new credentials (AP settings) internally and
instead pass the WPS attributes for an external program to process over
ctrl_iface.
Jouni Malinen [Wed, 21 Jan 2009 09:45:56 +0000 (11:45 +0200)]
Enable wpa_msg() for hostapd
Use wpa_msg() like wpa_supplicant in order to avoid having to use direct
hostapd_ctrl_iface_send() calls.
Jouni Malinen [Tue, 20 Jan 2009 19:28:31 +0000 (21:28 +0200)]
Changed Credential MAC Address to be BSSID in AP/Registrar
WPS spec is not very clear on which MAC address is used here, but BSSID
makes more sense than Enrollee MAC address.
Jouni Malinen [Tue, 20 Jan 2009 19:16:29 +0000 (21:16 +0200)]
Changed the version to 0.7.0 since development branch is now 0.7.x
Jouni Malinen [Tue, 20 Jan 2009 19:12:00 +0000 (21:12 +0200)]
Increased wpa_cli/hostapd_cli ping interval and made it configurable
The default interval is now 5 seconds (used to be 1 second for
interactive mode and 2 seconds for wpa_cli -a). The interval can be
changed with -G<seconds> command line option.
Jouni Malinen [Tue, 20 Jan 2009 12:06:02 +0000 (14:06 +0200)]
Implement set_probe_req_ie() for nl80211 drivers
Jouni Malinen [Tue, 20 Jan 2009 11:56:58 +0000 (13:56 +0200)]
Sync nl80211_copy.h with wireless-testing.git linux/nl80211.h
Jouni Malinen [Mon, 19 Jan 2009 16:42:10 +0000 (18:42 +0200)]
Fixed MFP Association Comeback mechanism to use Timeout Interval IE
The separate Association Comeback Time IE was removed from IEEE 802.11w
and the Timeout Interval IE (from IEEE 802.11r) is used instead. The
editing on this is still somewhat incomplete in IEEE 802.11w/D7.0, but
still, the use of Timeout Interval IE is the expected mechanism.
Jouni Malinen [Sun, 18 Jan 2009 10:27:12 +0000 (12:27 +0200)]
WPS: Add configurable option for processing credentials externally
The wps_cred_process option can be used to configure wpa_supplicant to
send received Credential attributes for external processing over
ctrl_iface and dbus. This allows external programs to update their
configuration when WPS is used to provision new networks.
Jouni Malinen [Sat, 17 Jan 2009 20:17:12 +0000 (22:17 +0200)]
WPS: Provide the unparsed Credential attribute to cred_cb()
This makes it easier to pass the credential data to external programs
(e.g., Network Manager) for processing. The actual use of this data is
not yet included in hostapd/wpa_supplicant.
Jouni Malinen [Sat, 17 Jan 2009 19:45:51 +0000 (21:45 +0200)]
WPS: Ignore credentials for unsupported authentication type
The current implementation does not support WPA/WPA2-Enterprise
credentials. Ignore any credential that is using unsupported
authentication type to avoid potential issues with partially configured
network blocks.
Jouni Malinen [Sat, 17 Jan 2009 19:37:15 +0000 (21:37 +0200)]
Fixed WPS credential conversion to wpa_supplicant configuration
Must not set pairwise_cipher/group_cipher for non-WPA/WPA2 networks
since the configuration parser is going to reject such values. In
addition, should not limit group_cipher to just TKIP or TKIP|CCMP just
in case the AP is using WEP as the group cipher. Default group_cipher
value can be used for all cases.
Jouni Malinen [Sat, 17 Jan 2009 19:14:13 +0000 (21:14 +0200)]
Changed the Network Index value to 1 since that is the default value
Jouni Malinen [Sat, 17 Jan 2009 16:14:41 +0000 (18:14 +0200)]
IBSS RSN: Added key configuration
Jouni Malinen [Sat, 17 Jan 2009 15:54:40 +0000 (17:54 +0200)]
Added a separate ctx pointer for wpa_msg() calls in WPA supp
This is needed to allow IBSS RSN to use per-peer context while
maintaining support for wpa_msg() calls to get *wpa_s as the pointer.
Jouni Malinen [Sat, 17 Jan 2009 15:47:25 +0000 (17:47 +0200)]
IBSS RSN: Set the PSK based on network configuration
Jouni Malinen [Sat, 17 Jan 2009 15:39:57 +0000 (17:39 +0200)]
IBSS RSN: Set more hardcoded RSN IEs for now
This allows 4-way handshakes to be completed successfully.
Jouni Malinen [Sat, 17 Jan 2009 15:31:21 +0000 (17:31 +0200)]
IBSS RSN: Added couple of required WPA supplicant callback functions
Jouni Malinen [Sat, 17 Jan 2009 15:25:11 +0000 (17:25 +0200)]
Process received EAPOL frames in IBSS RSN code if in IBSS mode
Jouni Malinen [Sat, 17 Jan 2009 14:44:05 +0000 (16:44 +0200)]
Added support for IBSS scanning into driver_test
Jouni Malinen [Sat, 17 Jan 2009 14:41:47 +0000 (16:41 +0200)]
Disable per-BSSID authentication for RSN IBSS
RSN IBSS uses authentication per-STA and that is initialized separately,
so there is no need to enable the per-BSS like authentication that is
used with APs.
Jouni Malinen [Sat, 17 Jan 2009 11:45:05 +0000 (13:45 +0200)]
Save and restore wpa_gui state when session manager restarts the app
This makes wpa_gui remember whether it was only in the tray when the
session was terminated and starts only in the tray if session manager
restarts it automatically.
Jouni Malinen [Fri, 16 Jan 2009 20:50:41 +0000 (22:50 +0200)]
Added an option to add (or override) Credential attribute(s) in M8
Jouni Malinen [Thu, 15 Jan 2009 23:18:11 +0000 (01:18 +0200)]
Fixed auth_send_eapol() to use correct ctx structure
Jouni Malinen [Thu, 15 Jan 2009 23:11:50 +0000 (01:11 +0200)]
Use a hardcoded RSN IE for testing to start Authenticator
This needs to be replaced with proper RSN IE from the peer STA (e.g.,
from Probe Response).
Jouni Malinen [Thu, 15 Jan 2009 22:56:31 +0000 (00:56 +0200)]
Implement EAPOL sending callbacks for IBSS RSN
Jouni Malinen [Wed, 14 Jan 2009 23:21:55 +0000 (01:21 +0200)]
Added initial step for IBSS RSN support
This commit adds a new build option, CONFIG_IBSS_RSN=y, that can be used
to enable RSN support for IBSS. This links in RSN Authenticator code
from hostapd and adds code for managing per-peer information for IBSS. A
new wpa_cli command or driver event can be used to request RSN
authentication with an IBSS peer. New RSN Authenticator and Supplicant
will be allocated for each peer.
The basic state machine setup code is included in this commit, but the
state machines are not properly started yet. In addition, some of the
callback functions are not yet complete.
Jouni Malinen [Wed, 14 Jan 2009 20:01:26 +0000 (22:01 +0200)]
Renamed PMKSA cache functions to avoid duplicate symbols with supplicant
This allows hostapd/pmksa_cache.c and src/rsn_supp/pmksa_cache.c to be
linked into the same program.
Jouni Malinen [Wed, 14 Jan 2009 19:31:47 +0000 (21:31 +0200)]
Moved rsn_pmkid() into shared code to avoid duplication
Jouni Malinen [Tue, 13 Jan 2009 19:33:09 +0000 (21:33 +0200)]
eapol_test: Allow generated RADIUS attributes to be replaced
Do not add the automatically generated RADIUS attributes NAS-IP-Address,
Calling-Station-Id, Framed-MTU, NAS-Port-Type, and Connect-Info if -N
option is used with the same attribute type. This allows these
attributes to be replaced without causing duplicate entries.
Dan Williams [Tue, 13 Jan 2009 18:42:15 +0000 (20:42 +0200)]
driver_wext: Add IW_ENCODE_TEMP into SIOCSIWENCODE{,EXT} calls
This is needed for airo driver to work correctly and no other driver
seems to care, so the change is safe to make. This has been in number of
distro releases for a long time and no issues have been reported.
Jouni Malinen [Tue, 13 Jan 2009 18:22:42 +0000 (20:22 +0200)]
Removed wpa_sm dereference from pmksa_cache_list()
Jouni Malinen [Tue, 13 Jan 2009 18:15:06 +0000 (20:15 +0200)]
Moved proto == RSN validation from pmksa_cache.c into the caller
Jouni Malinen [Tue, 13 Jan 2009 18:01:29 +0000 (20:01 +0200)]
Moved RADIUS Class attribute helpers into RADIUS module
Jouni Malinen [Tue, 13 Jan 2009 17:37:22 +0000 (19:37 +0200)]
Partial fix for test_wpa build
Jouni Malinen [Tue, 13 Jan 2009 17:31:51 +0000 (19:31 +0200)]
Renamed shadowed variable
Jouni Malinen [Tue, 13 Jan 2009 17:15:42 +0000 (19:15 +0200)]
Removed dead code
Jouni Malinen [Tue, 13 Jan 2009 17:14:38 +0000 (19:14 +0200)]
Fixed copy-paste error in retry configuration (incorrect ioctl used)
Jouni Malinen [Tue, 13 Jan 2009 17:12:25 +0000 (19:12 +0200)]
Removed unused set_regulatory_domain driver function
Jouni Malinen [Mon, 12 Jan 2009 20:08:53 +0000 (22:08 +0200)]
Fixed build without CONFIG_IEEE80211N
Jouni Malinen [Mon, 12 Jan 2009 20:06:51 +0000 (22:06 +0200)]
Fixed a typo in printf -> wpa_printf changes
Jouni Malinen [Mon, 12 Jan 2009 20:06:06 +0000 (22:06 +0200)]
Fixed build with wpa_printf disabled
Jouni Malinen [Mon, 12 Jan 2009 20:03:58 +0000 (22:03 +0200)]
Removed hw_features.o from build if hostapd MLME is not used
Jouni Malinen [Mon, 12 Jan 2009 19:44:57 +0000 (21:44 +0200)]
Added build option for disabling control interface (CONFIG_NO_CTRL_IFACE)
Jouni Malinen [Mon, 12 Jan 2009 19:39:19 +0000 (21:39 +0200)]
Added build option for removing VLAN support (CONFIG_NO_VLAN)
Jouni Malinen [Mon, 12 Jan 2009 19:21:31 +0000 (21:21 +0200)]
Fixed CONFIG_NO_HOSTAPD_LOGGER build
Jouni Malinen [Mon, 12 Jan 2009 14:49:39 +0000 (16:49 +0200)]
Comment out RADIUS configuration parsing if RADIUS client support is
disabled in the build.
Jouni Malinen [Mon, 12 Jan 2009 14:49:04 +0000 (16:49 +0200)]
Replaced printf() calls with wpa_printf()
Jouni Malinen [Mon, 12 Jan 2009 13:20:12 +0000 (15:20 +0200)]
Remove TLS-PRF from hostapd build if it is not needed
Jouni Malinen [Mon, 12 Jan 2009 13:15:35 +0000 (15:15 +0200)]
Added CONFIG_NO_AES_EXTRAS for hostapd
This allows unneeded AES routines to be removed from the build to reduce
binary size.
Jouni Malinen [Mon, 12 Jan 2009 13:08:33 +0000 (15:08 +0200)]
Fixed couple of build failures with minimal configuration
Kel Modderman [Sun, 11 Jan 2009 19:44:07 +0000 (21:44 +0200)]
wpa_gui-qt4: silence compile warning + wpsTab enable/disable
Fix compile warning by renaming gridLayout to wpsGridLayout in
wpagui.ui, it seems to be used internally.
/usr/bin/uic-qt4 eventhistory.ui -o .ui/ui_eventhistory.h
/usr/bin/uic-qt4 scanresults.ui -o .ui/ui_scanresults.h
/usr/bin/uic-qt4 wpagui.ui -o .ui/ui_wpagui.h
Warning: name gridLayout is already used
/usr/bin/uic-qt4 userdatarequest.ui -o .ui/ui_userdatarequest.h
/usr/bin/uic-qt4 networkconfig.ui -o .ui/ui_networkconfig.h
Also disable WPS tab if the running supplicant doesn't support that,
just as the WPS action menu is.
Signed-off-by: Kel Modderman <kel@otaku42.de>
Jouni Malinen [Sun, 11 Jan 2009 08:42:07 +0000 (10:42 +0200)]
Silenced some sparse warnings
Jouni Malinen [Sat, 10 Jan 2009 19:36:41 +0000 (21:36 +0200)]
Fixed build with 802.11n disabled
Jouni Malinen [Fri, 9 Jan 2009 19:45:31 +0000 (21:45 +0200)]
Include SIM simular for EAP-SIM in Windows build
USIM simulator for EAP-AKA was already included, but the SIM version was
forgotten from the build script.
Jouni Malinen [Fri, 9 Jan 2009 16:04:57 +0000 (18:04 +0200)]
Cleaned up main() by splitting it into number of helper functions
Jouni Malinen [Fri, 9 Jan 2009 15:27:03 +0000 (17:27 +0200)]
Moved driver callback functions from hostapd.c to a new file
Jouni Malinen [Fri, 9 Jan 2009 15:12:33 +0000 (17:12 +0200)]
Moved TKIP countermeasures from hostapd.c to its own file
Jouni Malinen [Fri, 9 Jan 2009 15:06:54 +0000 (17:06 +0200)]
Cleanup: move related functions closer to eachother
Jouni Malinen [Fri, 9 Jan 2009 15:00:29 +0000 (17:00 +0200)]
Fixed TKIP countermeasueres for drivers that do not use hostapd MLME
The Michael MIC reporting functions have to be included even when using
driver MLME.
Jouni Malinen [Fri, 9 Jan 2009 14:55:59 +0000 (16:55 +0200)]
Add wrapper functions for IEEE 802.11 driver calls into driver.h
These functions allow the driver_*.c wrappers not to include
ieee802_11.h.
Jouni Malinen [Fri, 9 Jan 2009 14:33:59 +0000 (16:33 +0200)]
Use a wrapper function for ieee802_1x_receive() to avoid ieee802_1x.h
Driver wrappers should not need to include ieee802_1x.h, so use a
wrapper function declared in driver.h.
Jouni Malinen [Fri, 9 Jan 2009 14:27:30 +0000 (16:27 +0200)]
Moved disassociation processing away from driver_*.c
Jouni Malinen [Fri, 9 Jan 2009 14:17:20 +0000 (16:17 +0200)]
Moved association check from driver_*.c into ieee802_1x_receive()
Jouni Malinen [Fri, 9 Jan 2009 14:13:07 +0000 (16:13 +0200)]
Moved WPA setup etc. association processing away from driver_*.c
This is all details that should not need to be handled in driver_*.c.
Jouni Malinen [Fri, 9 Jan 2009 13:44:45 +0000 (15:44 +0200)]
Move RX-from-unknown-STA processing away from driver_*.c
This cleans up the driver wrapper interface by getting rid of sta_info.h
dependency in all drivers that use MLME implementation in hostapd
(driver_hostap.c and driver_nl80211.c).
Jouni Malinen [Fri, 9 Jan 2009 13:33:36 +0000 (15:33 +0200)]
Moved TX status processing for STA entries away from driver_*.c
Driver wrappers should not need to know about this level of core hostapd
details.
Jouni Malinen [Fri, 9 Jan 2009 13:22:19 +0000 (15:22 +0200)]
Share the same radiotap helper implementation
Jouni Malinen [Fri, 9 Jan 2009 13:06:48 +0000 (15:06 +0200)]
Moved rfc1042_header into driver_*.c that use it
No need to share such a small buffer and make hostapd.[ch] more complex
with it.
Jouni Malinen [Fri, 9 Jan 2009 13:01:50 +0000 (15:01 +0200)]
Fixed a typo in a comment
Jouni Malinen [Fri, 9 Jan 2009 11:27:56 +0000 (13:27 +0200)]
Fixed eapol_test build after RADIUS API changes (const)
Jouni Malinen [Thu, 8 Jan 2009 18:14:05 +0000 (20:14 +0200)]
Move generic definitions away from hostapd.h
This is an initial step in trying to make hostapd.h not needed to be
included in so many files.
Jouni Malinen [Thu, 8 Jan 2009 17:48:52 +0000 (19:48 +0200)]
Split hostapd/driver.h into two files
driver.h contains the definitions needed in driver wrapper
implementations (driver_*.c) and driver_i.h contains the definitions
that are used in core hostapd code to interact with the driver wrappers.
Jouni Malinen [Thu, 8 Jan 2009 17:15:25 +0000 (19:15 +0200)]
Added support for removing RADIUS accounting and RADIUS in general
CONFIG_NO_ACCOUNTING=y and CONFIG_NO_RADIUS=y build options can now be
used to remove RADIUS support from the hostapd build.
Jouni Malinen [Thu, 8 Jan 2009 16:40:14 +0000 (18:40 +0200)]
Remove MLME code from build if none of the enabled drivers need it
Jouni Malinen [Thu, 8 Jan 2009 14:57:04 +0000 (16:57 +0200)]
Replaced printf() with wpa_printf()
Jouni Malinen [Thu, 8 Jan 2009 14:47:04 +0000 (16:47 +0200)]
Added CONFIG_NO_STDOUT_DEBUG for hostapd
This is similar to one in wpa_supplicant and can be used to reduce the
binary size by removing debugging messages.
Jouni Malinen [Thu, 8 Jan 2009 14:41:47 +0000 (16:41 +0200)]
Mark shared secret const in RADIUS client routines
Jouni Malinen [Thu, 8 Jan 2009 14:33:00 +0000 (16:33 +0200)]
Moved documentation from developer.txt into source code files
Use Doxygen comments for functions to replace the old text file that was
not up-to-date anymore.
Jouni Malinen [Tue, 6 Jan 2009 18:22:52 +0000 (20:22 +0200)]
Create PNG icon before running qmake to avoid resource warning
Jouni Malinen [Tue, 6 Jan 2009 18:11:15 +0000 (20:11 +0200)]
Preparations for 0.6.7 release
Eygene Ryabinkin [Mon, 5 Jan 2009 19:32:48 +0000 (21:32 +0200)]
wpa_cli: Embed command usage into the wpa_cli_commands array
It is better to have command description around the command definitions:
the chances for omitting usage, forgotting to change/delete them, etc.
are smaller than for the separate usage statement. [Bug 290]
Signed-off-by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Eygene Ryabinkin [Mon, 5 Jan 2009 19:05:05 +0000 (21:05 +0200)]
wpa_cli: Improve sensitive command detection for readline history
I had added flags to the every command description: just now the only
meaningful flag tells that this command has sensitive arguments and it
shouldn't be written to the disk. I rewrote the logics for the search
for the sensitive commands: special procedure is now loops over all
commands and tries to see if command has sensitive data. [Bug 289]
Signed-off-by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Eygene Ryabinkin [Mon, 5 Jan 2009 18:48:45 +0000 (20:48 +0200)]
wpa_cli: fix readline history cleaning
First of all, the history had not been written to the disk, since almost
all commands were cleaned up due to the error in the history cleaning:
the return value of the last os_strncasecmp() call was not compared to
zero, but was rather used as is. So the condition was almost always
true and most commands were removed from the history.
The second problem was that the evaluation of the potentially sensitive
commands was started at the entry number 1, instead of very first entry.
Ihar Hrachyshka [Mon, 5 Jan 2009 18:32:04 +0000 (20:32 +0200)]
Fix wpa_supplicant build for uClinux
The code contains a bogus #ifdef for uClinux building. [Bug 286]