Arran Cudbard-Bell [Sun, 17 Feb 2013 04:01:53 +0000 (23:01 -0500)]
Fix for coverity (potential segv for argument names over 49 bytes in jlibtool)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:58:28 +0000 (22:58 -0500)]
Fix for coverity (fix potential buffer overflow in cleanup_tmp_dir)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:49:08 +0000 (22:49 -0500)]
Fix for coverity (zero out sizeof(*fi) not sizeof(fi) in fr_fifo_free)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:47:17 +0000 (22:47 -0500)]
Fix for coverity (zero out sizeof(*packet) not sizeof(packet) in fr_dhcp_rcv)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:42:34 +0000 (22:42 -0500)]
Fix const warning in jlibtool
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:40:27 +0000 (22:40 -0500)]
Fix for coverity (ensure inst is not NULL before dereferencing it in eap_pwd_initiate)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:37:53 +0000 (22:37 -0500)]
Fix for covertiy (ensure we have a home_server when insert_into_proxy_hash is called)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:33:42 +0000 (22:33 -0500)]
Fix for coverity (don't leak memory on run_mode)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:29:58 +0000 (22:29 -0500)]
Fix for coverity (fix run command so it doesn't leak memory allocated for the command)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:23:14 +0000 (22:23 -0500)]
Fix for coverity (fix load_install_path so it doesn't leak memory if passed a non absolute path)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:20:35 +0000 (22:20 -0500)]
Fix for coverity (fix cleanup_tmp_dir so it doesn't leak directory handles)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:17:53 +0000 (22:17 -0500)]
Fix for coverity (don't leak memory if the object doesn't exist)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:16:22 +0000 (22:16 -0500)]
Fix for coverity (don't leak memory if we can't find the library)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:06:41 +0000 (22:06 -0500)]
Fix for coverity (don't leak memory in add_rpath_noinstall)
Arran Cudbard-Bell [Sun, 17 Feb 2013 03:04:07 +0000 (22:04 -0500)]
Fix for coverity (should use zu for sizeof)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:58:22 +0000 (21:58 -0500)]
Fix for coverity (don't segfault if rlm_realm is called in the recv-coa section and Operator-Name isn't present)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:52:22 +0000 (21:52 -0500)]
Fix for coverity (may pass NULL char pointer to strstr)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:46:37 +0000 (21:46 -0500)]
Fix for coverity (array will always decompose to a pointer which will always be true)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:43:30 +0000 (21:43 -0500)]
Fix for coverity (fall-through is intentional)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:38:07 +0000 (21:38 -0500)]
For for coverity (don't segfault in cf_log_err if we get a NULL ci)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:29:45 +0000 (21:29 -0500)]
Fix for coverity (fr_server_domain_socket should check is path is NULL)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:26:01 +0000 (21:26 -0500)]
Fix for coverity (should check both octets of dv_type if length is two)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:22:41 +0000 (21:22 -0500)]
Don't warn if the dir already exists
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:18:53 +0000 (21:18 -0500)]
Fix for coverity (check setsockopt succeeded)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:15:25 +0000 (21:15 -0500)]
Fix for coverity (return error code if address family is unknown)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:08:48 +0000 (21:08 -0500)]
Fix for coverity (deal with getsockname failure)
Arran Cudbard-Bell [Sun, 17 Feb 2013 02:01:45 +0000 (21:01 -0500)]
Fix for coverity (warn if mkdir fails)
Arran Cudbard-Bell [Sun, 17 Feb 2013 01:54:38 +0000 (20:54 -0500)]
Fix for coverity
Alan T. DeKok [Sun, 17 Feb 2013 02:14:37 +0000 (21:14 -0500)]
Free vp on error
Closes coverity #982098
Alan T. DeKok [Sun, 17 Feb 2013 02:12:06 +0000 (21:12 -0500)]
Close fd on error
Fixes Coverity #982099
Alan T. DeKok [Sun, 17 Feb 2013 02:09:39 +0000 (21:09 -0500)]
Close newfd on error
Closes Coverity #982101
Alan T. DeKok [Sun, 17 Feb 2013 02:08:17 +0000 (21:08 -0500)]
pairparsevalue() returns int, not VALUE_PAIR*
To avoid the caller doing: vp = pairparsevalue(vp, "nonsense")
and leaking vp
Closes Coverity #982102
Alan T. DeKok [Sun, 17 Feb 2013 02:00:21 +0000 (21:00 -0500)]
Add vp to request->packet->vps
Closes Coverity #982103
Alan T. DeKok [Sun, 17 Feb 2013 01:58:37 +0000 (20:58 -0500)]
Check bufsize
Closes Coverity #982104
Alan T. DeKok [Sun, 17 Feb 2013 01:56:51 +0000 (20:56 -0500)]
Don't use strcpy
Closes Coverity #982105
Alan T. DeKok [Sun, 17 Feb 2013 01:54:42 +0000 (20:54 -0500)]
Ensure da is initialized and checked
Closes Coverity #982108
Alan T. DeKok [Sun, 17 Feb 2013 01:52:49 +0000 (20:52 -0500)]
Don't use uninitialized variables
Fixes Coverity #982109
Alan T. DeKok [Sun, 17 Feb 2013 01:51:14 +0000 (20:51 -0500)]
Ensure conn is initialized
Closes Coverity #982110
Alan T. DeKok [Sun, 17 Feb 2013 01:46:48 +0000 (20:46 -0500)]
orrectly remove trailing \n in smbencrypt
Closes Coverity #982111
Alan T. DeKok [Sun, 17 Feb 2013 01:43:42 +0000 (20:43 -0500)]
Fix for coverity issue #982114
Alan T. DeKok [Sun, 17 Feb 2013 01:23:10 +0000 (20:23 -0500)]
Removed unused variable
Alan T. DeKok [Sun, 17 Feb 2013 01:21:52 +0000 (20:21 -0500)]
ensure initialized variable
Alan T. DeKok [Sun, 17 Feb 2013 01:19:06 +0000 (20:19 -0500)]
Fix compile warning
Alan T. DeKok [Sun, 17 Feb 2013 01:09:13 +0000 (20:09 -0500)]
Delete last vp->type as data type
Alan T. DeKok [Sun, 17 Feb 2013 01:05:57 +0000 (20:05 -0500)]
Merge combo-IP fixes to use the new API
Alan T. DeKok [Sun, 17 Feb 2013 00:58:51 +0000 (19:58 -0500)]
One last fix so it builds
Arran Cudbard-Bell [Sat, 16 Feb 2013 22:26:40 +0000 (17:26 -0500)]
Remove jradius dictionary file
Arran Cudbard-Bell [Sat, 16 Feb 2013 22:23:34 +0000 (17:23 -0500)]
Fixup Doxygen comments
Arran Cudbard-Bell [Sat, 16 Feb 2013 22:08:27 +0000 (17:08 -0500)]
Remove redundant flags and fields from VALUE_PAIR
Arran Cudbard-Bell [Sat, 16 Feb 2013 22:07:59 +0000 (17:07 -0500)]
Use DICT_ATTR for attribute number and vendor number
Arran Cudbard-Bell [Sat, 16 Feb 2013 22:05:39 +0000 (17:05 -0500)]
Fixup remaining calls to old xlat functions in evaluate.c and main/valuepair.c
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:42:43 +0000 (16:42 -0500)]
Copy xlat source values when copying attributes
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:39:45 +0000 (16:39 -0500)]
Misc whitespace fixes in libradius.h
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:34:25 +0000 (16:34 -0500)]
Remove pairmake_xlat
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:20:06 +0000 (16:20 -0500)]
Modify pair read so that it parses values into a more generic structure, and update it to use the new xlat functions
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:15:31 +0000 (16:15 -0500)]
Fixup rlm_sql to use the new xlat functions
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:05:37 +0000 (16:05 -0500)]
Update pairmake_any to call dict_attrunknown
Arran Cudbard-Bell [Sat, 16 Feb 2013 21:00:00 +0000 (16:00 -0500)]
Rename some arguments to be more consistent in pair compare
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:59:01 +0000 (15:59 -0500)]
Use da->name in pair compare
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:58:32 +0000 (15:58 -0500)]
Use da attribute and vendor in paircompare
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:43:55 +0000 (15:43 -0500)]
Add radius_xlat_do and rename pairxlatmove to radius_xlat_move
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:38:09 +0000 (15:38 -0500)]
Remove dependency on pairxlatmove in rlm_rest (it never really needed to use it anyway)
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:36:24 +0000 (15:36 -0500)]
Fixup dict_valbyattr call in rlm_rediswho
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:25:20 +0000 (15:25 -0500)]
Add pairmark_xlat
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:10:19 +0000 (15:10 -0500)]
White space changes in rlm_sql
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:09:06 +0000 (15:09 -0500)]
Fixup some function documentation in main/valuepair.c
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:05:42 +0000 (15:05 -0500)]
Our implementation of DHCP assumes DHCP-Client-Identifier is always a MAC Address
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:04:51 +0000 (15:04 -0500)]
Don't bother checking for truncation in rlm_rest, it doesn't work for xlat expanded values anyway
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:03:52 +0000 (15:03 -0500)]
Use type int for boolean values, apparently json-c no longer defines it.
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:03:11 +0000 (15:03 -0500)]
Remove rlm_policy from the red hat spec file
Arran Cudbard-Bell [Sat, 16 Feb 2013 20:02:52 +0000 (15:02 -0500)]
Remove rlm_jradius documentation and dictionaries
Alan T. DeKok [Sat, 16 Feb 2013 19:52:48 +0000 (14:52 -0500)]
Use new RADIUS decoder.
It keys off of attribute data type, instead of using hard-coded
functions and checks. The "long-extended" attrs aren't there yet.
But WiMAX is there (continued, etc.), and it works.
The end result is ~300 LoC smaller than the previous one.
It still needs checks in dict.c to enforce parent/child
relationships in types. i.e. "evs" can't be a member of any
other data type, etc.
Alan T. DeKok [Sat, 16 Feb 2013 19:52:21 +0000 (14:52 -0500)]
Remove "type" from paircreate() function.
Now that we have "unknown" attributes in the dictionaries,
there's no need to have type for paircreate(). Instead, it just
creates a DICT_ATTR with the appropriate data
Alan T. DeKok [Sat, 16 Feb 2013 19:09:54 +0000 (14:09 -0500)]
Make xlat use vp->da->*
Alan T. DeKok [Wed, 13 Feb 2013 18:40:00 +0000 (13:40 -0500)]
Added test for continued attrs
Alan T. DeKok [Sat, 16 Feb 2013 19:00:49 +0000 (14:00 -0500)]
Move tag out of "flags" struct.
The VP's shouldn't have flags, and the DICT_ATTRs shouldn't
have tags.
Edit libradius.h, followed by:
$ replace 'flags.tag' tag $(find src/ -name "*.c" -print)
Alan T. DeKok [Sat, 16 Feb 2013 18:53:47 +0000 (13:53 -0500)]
Make the main directory use vp->da
Alan T. DeKok [Sat, 16 Feb 2013 18:53:38 +0000 (13:53 -0500)]
Make the lib directory use vp->da
Alan T. DeKok [Sat, 16 Feb 2013 16:40:33 +0000 (11:40 -0500)]
Changed vp->attribute to vp->da->attr, etc.
Also fixed a number of bugs left over from v2, where vp->attribute
was checked, but vp->vendor wasn't checked.
This commit may leak memory, crash, etc. But the server builds
and seems to run. It's one more stage on the way to the new API
Alan T. DeKok [Sat, 16 Feb 2013 16:21:48 +0000 (11:21 -0500)]
Removed fastusers and policy
Alan T. DeKok [Sat, 16 Feb 2013 16:19:24 +0000 (11:19 -0500)]
Deleted this module.
It's not maintained. The new version of jradius binary uses
a different protocol to talk to FreeRADIUS. And it's incompatible.
So, we remove it until such time as people complain, and it's
made compatible
Alan T. DeKok [Sat, 16 Feb 2013 16:16:13 +0000 (11:16 -0500)]
Removed the policy module.
Nearly all of its functionality is handled by unlang.
What isn't handled is very esoteric. It's better for people
to use Perl or (upcoming) lua module
Alan T. DeKok [Sat, 16 Feb 2013 16:14:02 +0000 (11:14 -0500)]
This module is no longer necessary
The "users" file does everything this does.
It was left in v2 for compatibility with v1, but that is no longer necessary
Alan T. DeKok [Sat, 16 Feb 2013 16:09:30 +0000 (11:09 -0500)]
Update vp->da in pairalloc(), and update dictionary functions
Alan T. DeKok [Sat, 16 Feb 2013 15:57:05 +0000 (10:57 -0500)]
Made Vendor-Specific to be of data tyoe "vsa"
In preparation for new decoder
Alan T. DeKok [Sat, 16 Feb 2013 15:49:34 +0000 (10:49 -0500)]
Updated dictionary functions in preparation for new decoder
Alan T. DeKok [Sat, 16 Feb 2013 15:38:27 +0000 (10:38 -0500)]
Build / link without OpenSSL
Alan T. DeKok [Sat, 16 Feb 2013 15:34:36 +0000 (10:34 -0500)]
Boilermake is enabled by default
Alan T. DeKok [Sat, 16 Feb 2013 15:29:17 +0000 (10:29 -0500)]
Added DICT_ATTR* to VALUE_PAIR, in preparation for next commits
Arran Cudbard-Bell [Sat, 16 Feb 2013 13:07:23 +0000 (08:07 -0500)]
Add ;
Arran Cudbard-Bell [Fri, 15 Feb 2013 23:35:52 +0000 (18:35 -0500)]
Fix hangover from some earlier refactoring
Arran Cudbard-Bell [Fri, 15 Feb 2013 22:53:17 +0000 (17:53 -0500)]
Fix segv in rlm_otp
Arran Cudbard-Bell [Fri, 15 Feb 2013 22:40:43 +0000 (17:40 -0500)]
Cast challenge string as unsigned
Alan T. DeKok [Fri, 15 Feb 2013 22:22:44 +0000 (17:22 -0500)]
Disable EAP caching. Doesn't seem to work
Alan T. DeKok [Fri, 15 Feb 2013 22:19:37 +0000 (17:19 -0500)]
mypriority can be -1, too
Arran Cudbard-Bell [Fri, 15 Feb 2013 05:27:21 +0000 (21:27 -0800)]
Merge pull request #190 from candlerb/candlerb/redis_fixes_master
Broken rlm_redis in master branch
Arran Cudbard-Bell [Thu, 14 Feb 2013 19:26:16 +0000 (14:26 -0500)]
Update autoconf json-c stuff
Brian Candler [Thu, 14 Feb 2013 16:04:26 +0000 (16:04 +0000)]
Remove unnecessary variable
Brian Candler [Thu, 14 Feb 2013 12:52:30 +0000 (12:52 +0000)]
rlm_rediswho: allow insert/trim/expire to be configured independently
For example you might want to do SET and EXPIRE on a start record,
and just EXPIRE on interim and stop.
Brian Candler [Thu, 14 Feb 2013 12:46:52 +0000 (12:46 +0000)]
rlm_rediswho: return RLM_MODULE_FAIL on failure (including failed Expire)