freeradius.git
9 years agoClarify warning message
Alan T. DeKok [Fri, 12 Dec 2014 12:25:27 +0000 (07:25 -0500)]
Clarify warning message

9 years agoFormatting
Arran Cudbard-Bell [Thu, 11 Dec 2014 16:46:06 +0000 (11:46 -0500)]
Formatting

9 years agoRemove last call to pairdatacpy and remove pairdatacpy
Arran Cudbard-Bell [Thu, 11 Dec 2014 16:44:39 +0000 (11:44 -0500)]
Remove last call to pairdatacpy and remove pairdatacpy

9 years agoMore call to pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:09:20 +0000 (11:09 -0500)]
More call to pairdatacpy()

9 years agoRemove call to pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:06:25 +0000 (11:06 -0500)]
Remove call to pairdatacpy()

9 years agosrc is const
Alan T. DeKok [Thu, 11 Dec 2014 16:05:56 +0000 (11:05 -0500)]
src is const

9 years agoRemove one more caller of pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:03:56 +0000 (11:03 -0500)]
Remove one more caller of pairdatacpy()

9 years agoCreate value_data_copy function
Alan T. DeKok [Thu, 11 Dec 2014 16:03:27 +0000 (11:03 -0500)]
Create value_data_copy function

9 years agoDon't call pairdatacpy. Closes #853
Alan T. DeKok [Thu, 11 Dec 2014 15:19:40 +0000 (10:19 -0500)]
Don't call pairdatacpy.  Closes #853

9 years agoThere might not be a name2
Alan T. DeKok [Wed, 10 Dec 2014 21:30:12 +0000 (16:30 -0500)]
There might not be a name2

9 years agoTypo
Arran Cudbard-Bell [Thu, 11 Dec 2014 13:31:30 +0000 (08:31 -0500)]
Typo

9 years agoPass pointer to head of list when doing pairsort in perl_store_vps Fixes #852
Arran Cudbard-Bell [Thu, 11 Dec 2014 13:20:09 +0000 (08:20 -0500)]
Pass pointer to head of list when doing pairsort in perl_store_vps Fixes #852

9 years agoDisallow attribute zero in the dictionaries. Closes #851
Alan T. DeKok [Wed, 10 Dec 2014 16:26:16 +0000 (11:26 -0500)]
Disallow attribute zero in the dictionaries.  Closes #851

Except for Colubris, who use it

9 years agoRemove unused variables
Alan T. DeKok [Wed, 10 Dec 2014 15:04:20 +0000 (10:04 -0500)]
Remove unused variables

9 years agoSmash bad filenames
Alan T. DeKok [Wed, 10 Dec 2014 13:55:13 +0000 (08:55 -0500)]
Smash bad filenames

9 years agoSmash bad filenames
Alan T. DeKok [Wed, 10 Dec 2014 13:55:13 +0000 (08:55 -0500)]
Smash bad filenames

9 years agoMake filename escaping configurable.
Alan T. DeKok [Wed, 10 Dec 2014 13:47:14 +0000 (08:47 -0500)]
Make filename escaping configurable.

9 years agoShort-circuit fr_prints() when there's no quoting
Alan T. DeKok [Tue, 9 Dec 2014 21:29:02 +0000 (16:29 -0500)]
Short-circuit fr_prints() when there's no quoting

9 years agoFix argument order in fr_prints so out is first
Arran Cudbard-Bell [Tue, 9 Dec 2014 21:33:12 +0000 (16:33 -0500)]
Fix argument order in fr_prints so out is first

9 years agoOnly include <ldap.h> in ldap.h
Arran Cudbard-Bell [Tue, 9 Dec 2014 21:05:52 +0000 (16:05 -0500)]
Only include <ldap.h> in ldap.h

9 years agoNote recent changes
Alan T. DeKok [Tue, 9 Dec 2014 20:56:26 +0000 (15:56 -0500)]
Note recent changes

9 years agoAllow spaces in certificate passwords
Alan T. DeKok [Tue, 9 Dec 2014 20:55:38 +0000 (15:55 -0500)]
Allow spaces in certificate passwords

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 9 Dec 2014 19:51:06 +0000 (14:51 -0500)]
Update ChangeLog

9 years agoWork around potential race in ldap_create
Arran Cudbard-Bell [Tue, 9 Dec 2014 19:39:12 +0000 (14:39 -0500)]
Work around potential race in ldap_create

9 years agoFormatting
Arran Cudbard-Bell [Tue, 9 Dec 2014 17:38:57 +0000 (12:38 -0500)]
Formatting

9 years agoAdded checks for braces at end of string
Alan T. DeKok [Tue, 9 Dec 2014 19:03:56 +0000 (14:03 -0500)]
Added checks for braces at end of string

9 years agoDefine LDAP_DEPRECATED outside of autoconf (and before including ldap.h)
Arran Cudbard-Bell [Mon, 8 Dec 2014 23:16:10 +0000 (18:16 -0500)]
Define LDAP_DEPRECATED outside of autoconf (and before including ldap.h)

9 years agoActually use the pool we alloced
Arran Cudbard-Bell [Mon, 8 Dec 2014 23:08:25 +0000 (18:08 -0500)]
Actually use the pool we alloced

9 years agoMore tests
Alan T. DeKok [Mon, 8 Dec 2014 20:31:02 +0000 (15:31 -0500)]
More tests

9 years agoPrint *data* not *pointer* if it's octets
Alan T. DeKok [Mon, 8 Dec 2014 20:30:39 +0000 (15:30 -0500)]
Print *data* not *pointer* if it's octets

9 years agoMissed cast
Arran Cudbard-Bell [Mon, 8 Dec 2014 20:01:34 +0000 (15:01 -0500)]
Missed cast

9 years agoDoxygen
Arran Cudbard-Bell [Mon, 8 Dec 2014 19:56:02 +0000 (14:56 -0500)]
Doxygen

9 years agoFixup LDAP group debugging messages so they're more useful
Arran Cudbard-Bell [Mon, 8 Dec 2014 19:34:15 +0000 (14:34 -0500)]
Fixup LDAP group debugging messages so they're more useful

Operations are now idented by group being checked

Also fixup quadratic group membership attribute insertion

9 years agoCopyright notices
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:07:23 +0000 (10:07 -0500)]
Copyright notices

9 years agoBreak out serialization functions from rlm_cache_memcached
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:07:12 +0000 (10:07 -0500)]
Break out serialization functions from rlm_cache_memcached

9 years agoAdd note on pairstrncpy
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:06:02 +0000 (10:06 -0500)]
Add note on pairstrncpy

9 years agoRename fr_print_string to fr_prints
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:37:12 +0000 (17:37 -0500)]
Rename fr_print_string to fr_prints

9 years agoexfile_open now opens files for read/writing, which is useful if the exfile instance...
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:31:09 +0000 (17:31 -0500)]
exfile_open now opens files for read/writing, which is useful if the exfile instance may be used to acquire fds for reading too

add 'append' argument, that controls whether exfile_open seeks to the end of the file.

9 years agoMake fr_print_string take -1 to signify that it should calculate the length of inlen
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:29:38 +0000 (17:29 -0500)]
Make fr_print_string take -1 to signify that it should calculate the length of inlen

Fix fr_print_string_len to produce the correct length (fr_print_string was modified without equivalent modifications being made to fr_print_string_len)

Add fr_aprints to allocate a printable string

9 years agoMake it clear why the xlat failed
Arran Cudbard-Bell [Sun, 7 Dec 2014 20:01:58 +0000 (15:01 -0500)]
Make it clear why the xlat failed

9 years agoConvert all calls to ldap_get_values (now deprecated) to ldap_get_values_len
Arran Cudbard-Bell [Sun, 7 Dec 2014 20:01:17 +0000 (15:01 -0500)]
Convert all calls to ldap_get_values (now deprecated) to ldap_get_values_len

9 years agoFixup stupidity around rlm_ldap URL handling
Arran Cudbard-Bell [Sun, 7 Dec 2014 16:48:54 +0000 (11:48 -0500)]
Fixup stupidity around rlm_ldap URL handling

We can accept URLs in either format irrespective of whether ldap_initialize() is available or not

9 years agoUse cf_log_err to log config errors in rlm_ldap
Arran Cudbard-Bell [Sun, 7 Dec 2014 16:47:06 +0000 (11:47 -0500)]
Use cf_log_err to log config errors in rlm_ldap

9 years agoNote recent changes
Alan T. DeKok [Mon, 8 Dec 2014 16:04:36 +0000 (11:04 -0500)]
Note recent changes

9 years agoMerge pull request #850 from mcnewton/patch-dpkg
Alan DeKok [Mon, 8 Dec 2014 16:04:18 +0000 (11:04 -0500)]
Merge pull request #850 from mcnewton/patch-dpkg

set debian package format to native

9 years agoSave Module-Failure-Message to the outer session-state
Alan T. DeKok [Mon, 8 Dec 2014 15:38:05 +0000 (10:38 -0500)]
Save Module-Failure-Message to the outer session-state

9 years agoMark requests as alloc'd
Alan T. DeKok [Mon, 8 Dec 2014 13:24:55 +0000 (08:24 -0500)]
Mark requests as alloc'd

9 years agoQuiet scanner
Alan T. DeKok [Sun, 7 Dec 2014 23:42:27 +0000 (18:42 -0500)]
Quiet scanner

9 years agoQuiet scan.
Alan T. DeKok [Sun, 7 Dec 2014 23:36:35 +0000 (18:36 -0500)]
Quiet scan.

We really need to take a pass through the source marking up
every function with CC_HINT(nonnull).  Just like we fixed all
of the other compiler warnings

9 years agoBe less aggressive about casting to octets
Alan T. DeKok [Sun, 7 Dec 2014 16:55:01 +0000 (11:55 -0500)]
Be less aggressive about casting to octets

9 years agoDon't do full debugging on tests
Alan T. DeKok [Sun, 7 Dec 2014 16:53:26 +0000 (11:53 -0500)]
Don't do full debugging on tests

9 years agoAdded low-level escaping tests
Alan T. DeKok [Sun, 7 Dec 2014 16:33:06 +0000 (11:33 -0500)]
Added low-level escaping tests

9 years agoAuto-cast octet strings
Alan T. DeKok [Sun, 7 Dec 2014 13:52:22 +0000 (08:52 -0500)]
Auto-cast octet strings

So ("bob" == 0x626f62) will work

9 years agoEnsure data.ptr is always initialized
Alan T. DeKok [Sat, 6 Dec 2014 21:59:01 +0000 (16:59 -0500)]
Ensure data.ptr is always initialized

9 years agoDoxygen
Alan T. DeKok [Sat, 6 Dec 2014 15:51:43 +0000 (10:51 -0500)]
Doxygen

9 years agoDon't free thing until we're done
Alan T. DeKok [Sat, 6 Dec 2014 15:49:30 +0000 (10:49 -0500)]
Don't free thing until we're done

9 years agoQuiet scanner
Alan T. DeKok [Sat, 6 Dec 2014 15:45:27 +0000 (10:45 -0500)]
Quiet scanner

9 years agoRemove unneeded variable
Alan T. DeKok [Sat, 6 Dec 2014 15:42:30 +0000 (10:42 -0500)]
Remove unneeded variable

9 years agoQuiet scanner
Alan T. DeKok [Sat, 6 Dec 2014 15:42:18 +0000 (10:42 -0500)]
Quiet scanner

9 years agoQuiet scanner
Alan T. DeKok [Sat, 6 Dec 2014 15:42:08 +0000 (10:42 -0500)]
Quiet scanner

9 years agoQuiet compiler
Alan T. DeKok [Sat, 6 Dec 2014 15:34:19 +0000 (10:34 -0500)]
Quiet compiler

9 years agoMore escaping / unescaping fixes.
Alan T. DeKok [Sat, 6 Dec 2014 15:17:06 +0000 (10:17 -0500)]
More escaping / unescaping fixes.

The template names are now binary-safe if cf_new_escape

The various parsing functions take a quotation character, so that
they can do the correct de-escaping.

The tests have been audited and updated.

9 years agoNumber failure cases
Alan T. DeKok [Fri, 5 Dec 2014 20:41:00 +0000 (15:41 -0500)]
Number failure cases

9 years agoFix PREREQS so that the cache module builds
Alan T. DeKok [Fri, 5 Dec 2014 20:28:05 +0000 (15:28 -0500)]
Fix PREREQS so that the cache module builds

9 years ago%n is allowed, too
Alan T. DeKok [Fri, 5 Dec 2014 16:20:23 +0000 (11:20 -0500)]
%n is allowed, too

9 years agoMake tmpl_alloc be binary safe
Alan T. DeKok [Fri, 5 Dec 2014 00:18:43 +0000 (19:18 -0500)]
Make tmpl_alloc be binary safe

9 years agoUse the new escaping for the tests
Alan T. DeKok [Wed, 3 Dec 2014 23:51:57 +0000 (18:51 -0500)]
Use the new escaping for the tests

9 years agoCall fr_print_string instead of doing things ourselves
Alan T. DeKok [Wed, 3 Dec 2014 23:47:13 +0000 (18:47 -0500)]
Call fr_print_string instead of doing things ourselves

9 years agoClarify fr_print_string
Alan T. DeKok [Wed, 3 Dec 2014 22:18:00 +0000 (17:18 -0500)]
Clarify fr_print_string

9 years agoFix fr_print_string_len, too
Alan T. DeKok [Wed, 3 Dec 2014 21:50:14 +0000 (16:50 -0500)]
Fix fr_print_string_len, too

9 years agoAdd filename unescape
Arran Cudbard-Bell [Sat, 6 Dec 2014 03:41:09 +0000 (22:41 -0500)]
Add filename unescape

9 years agoMissed const
Arran Cudbard-Bell [Sat, 6 Dec 2014 03:36:39 +0000 (22:36 -0500)]
Missed const

9 years agoFormatting
Arran Cudbard-Bell [Sat, 6 Dec 2014 02:58:38 +0000 (21:58 -0500)]
Formatting

9 years agoMove exclusive file access functions into their own source file (exfile.c)
Arran Cudbard-Bell [Sat, 6 Dec 2014 02:57:24 +0000 (21:57 -0500)]
Move exclusive file access functions into their own source file (exfile.c)

9 years agoset debian package format to native
Matthew Newton [Fri, 5 Dec 2014 20:59:43 +0000 (20:59 +0000)]
set debian package format to native

With the quilt format you can't build a dpkg from git unless you package up
into a tarball first as well.

Removes local-options (unapply patches) so that make deb still works with
a native format package.

9 years agoEscape filename expansions
Arran Cudbard-Bell [Thu, 4 Dec 2014 19:40:20 +0000 (14:40 -0500)]
Escape filename expansions

Attributes used in xlat expansions involving filenames will now be subject to tight escaping rules to prevent injection attacks, and to allow maximum compatibility.

A little scary this wasn't done already, but for most systems it would have been pretty hard to exploit in a useful way.

9 years agoFormatting
Arran Cudbard-Bell [Thu, 4 Dec 2014 19:38:05 +0000 (14:38 -0500)]
Formatting

9 years agoNote on why we don't need to escaping for execve
Arran Cudbard-Bell [Thu, 4 Dec 2014 16:54:33 +0000 (11:54 -0500)]
Note on why we don't need to escaping for execve

9 years agoCache Stripped-User-Domain too
Arran Cudbard-Bell [Thu, 4 Dec 2014 15:14:51 +0000 (10:14 -0500)]
Cache Stripped-User-Domain too

9 years agoUpdate range of cached TLS attributes
Arran Cudbard-Bell [Thu, 4 Dec 2014 15:11:46 +0000 (10:11 -0500)]
Update range of cached TLS attributes

9 years agoFormatting
Arran Cudbard-Bell [Thu, 4 Dec 2014 15:09:57 +0000 (10:09 -0500)]
Formatting

9 years agoDuplicate init
Arran Cudbard-Bell [Thu, 4 Dec 2014 04:05:30 +0000 (23:05 -0500)]
Duplicate init

9 years agoSlightly better debug output
Arran Cudbard-Bell [Thu, 4 Dec 2014 01:44:55 +0000 (20:44 -0500)]
Slightly better debug output

9 years agoFix issue that caused radclient to default to sending Accounting-Request when auto...
Arran Cudbard-Bell [Thu, 4 Dec 2014 01:35:16 +0000 (20:35 -0500)]
Fix issue that caused radclient to default to sending Accounting-Request when auto was specified and Packet-Type was set

9 years agoEscape backslashes only when necessary
Alan T. DeKok [Wed, 3 Dec 2014 21:15:09 +0000 (16:15 -0500)]
Escape backslashes only when necessary

9 years agoMerge pull request #847 from spbnick/man_clients_update
Arran Cudbard-Bell [Wed, 3 Dec 2014 18:31:46 +0000 (13:31 -0500)]
Merge pull request #847 from spbnick/man_clients_update

clients(5) update

9 years agoNote recent changes
Alan T. DeKok [Wed, 3 Dec 2014 18:11:07 +0000 (13:11 -0500)]
Note recent changes

9 years agorlm_cache_rbtree isn't in "stable". It's ALWAYS built.
Alan T. DeKok [Wed, 3 Dec 2014 16:36:02 +0000 (11:36 -0500)]
rlm_cache_rbtree isn't in "stable".  It's ALWAYS built.

It has no configure script, so we don't need to recurse
into it's subdirectory to configure it

9 years agoDelete state correctly
Alan T. DeKok [Wed, 3 Dec 2014 16:33:41 +0000 (11:33 -0500)]
Delete state correctly

9 years agoChange references to vp->length to vp->vp_length
Arran Cudbard-Bell [Wed, 3 Dec 2014 17:59:32 +0000 (12:59 -0500)]
Change references to vp->length to vp->vp_length

9 years agoAdd vp_length macro (makes it easier to backport changes from master)
Arran Cudbard-Bell [Wed, 3 Dec 2014 18:00:31 +0000 (13:00 -0500)]
Add vp_length macro (makes it easier to backport changes from master)

9 years agoMake IP resolution errors a bit clearer
Arran Cudbard-Bell [Wed, 3 Dec 2014 06:56:45 +0000 (01:56 -0500)]
Make IP resolution errors a bit clearer

9 years agoUse correct type for log_lvl and add prefix to rdebug_pair
Arran Cudbard-Bell [Wed, 3 Dec 2014 02:58:42 +0000 (21:58 -0500)]
Use correct type for log_lvl and add prefix to rdebug_pair

9 years agoman: Remove references to naslist and clients
Nikolai Kondrashov [Tue, 2 Dec 2014 14:43:49 +0000 (16:43 +0200)]
man: Remove references to naslist and clients

Remove references to non-existent naslist and clients manpages as they
are confusing.

9 years agoman: Remove client attribute description
Nikolai Kondrashov [Tue, 2 Dec 2014 14:39:28 +0000 (16:39 +0200)]
man: Remove client attribute description

Remove attribute description from clients.conf(5) source as it is
outdated, lists just a few attributes and wasn't updated for more than a
year. Refer to clients.conf file itself, instead.

9 years agoAlways get the "certs" index for SSL.
Alan T. DeKok [Tue, 2 Dec 2014 18:54:23 +0000 (13:54 -0500)]
Always get the "certs" index for SSL.

9 years agoBump for version 3.0.6
Alan T. DeKok [Tue, 2 Dec 2014 18:34:32 +0000 (13:34 -0500)]
Bump for version 3.0.6

9 years agoClarify debugging message
Alan T. DeKok [Tue, 2 Dec 2014 15:05:27 +0000 (10:05 -0500)]
Clarify debugging message

9 years agoDebug attributes added in cbtls_verify
Alan T. DeKok [Tue, 2 Dec 2014 15:03:33 +0000 (10:03 -0500)]
Debug attributes added in cbtls_verify

9 years agoIf we're doing fallback resolution we need to set the address family to AF_UNSPEC...
Arran Cudbard-Bell [Mon, 1 Dec 2014 19:15:45 +0000 (14:15 -0500)]
If we're doing fallback resolution we need to set the address family to AF_UNSPEC to get both IPv6 and IPv4 addresses

The af that was passed in, is then used to set the preference