freeradius.git
9 years agoChange boolean do_ntlm_auth to enum MSCHAP_AUTH_METHOD
Matthew Newton [Tue, 2 Dec 2014 12:09:52 +0000 (12:09 +0000)]
Change boolean do_ntlm_auth to enum MSCHAP_AUTH_METHOD

9 years agoFixup some comments in fr_cursor_insert
Arran Cudbard-Bell [Sat, 21 Mar 2015 14:36:38 +0000 (10:36 -0400)]
Fixup some comments in fr_cursor_insert

9 years agoInvalid assert
Arran Cudbard-Bell [Fri, 20 Mar 2015 18:15:50 +0000 (14:15 -0400)]
Invalid assert

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 20 Mar 2015 20:31:38 +0000 (16:31 -0400)]
Update ChangeLog

9 years agoFix corner case where cursor.next wasn't fixed up correctly on fr_cursor_insert
Arran Cudbard-Bell [Fri, 20 Mar 2015 16:52:08 +0000 (12:52 -0400)]
Fix corner case where cursor.next wasn't fixed up correctly on fr_cursor_insert

9 years agoFixup cursor.last if we removed the vp it was referring to
Arran Cudbard-Bell [Fri, 20 Mar 2015 16:34:37 +0000 (12:34 -0400)]
Fixup cursor.last if we removed the vp it was referring to

9 years agoLast should be set to the VP we just inserted
Arran Cudbard-Bell [Fri, 20 Mar 2015 16:34:14 +0000 (12:34 -0400)]
Last should be set to the VP we just inserted

9 years agoFormatting
Arran Cudbard-Bell [Fri, 20 Mar 2015 16:32:28 +0000 (12:32 -0400)]
Formatting

9 years agoCreate a standard set of socket connection functions for UNIX/TCP/UDP
Arran Cudbard-Bell [Thu, 19 Mar 2015 19:04:21 +0000 (15:04 -0400)]
Create a standard set of socket connection functions for UNIX/TCP/UDP

We should eventually add SCTP too, but the OSX kernel doesn't support it yet *boo*, and I don't have time to compile the 3rd party kext.

9 years agoMove fr_nonblock and fr_blocking to misc.c. They're useful for files as well as sockets.
Arran Cudbard-Bell [Thu, 19 Mar 2015 19:02:45 +0000 (15:02 -0400)]
Move fr_nonblock and fr_blocking to misc.c. They're useful for files as well as sockets.

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Wed, 18 Mar 2015 20:38:06 +0000 (16:38 -0400)]
Update ChangeLog

9 years agoAdd user configurable busy_timeout to rlm_sql_sqlite driver
Arran Cudbard-Bell [Wed, 18 Mar 2015 20:25:01 +0000 (16:25 -0400)]
Add user configurable busy_timeout to rlm_sql_sqlite driver

9 years agoConvert comment to doxygen
Arran Cudbard-Bell [Wed, 18 Mar 2015 17:31:56 +0000 (13:31 -0400)]
Convert comment to doxygen

9 years agoMerge pull request #928 from painless-security/to_submit
Arran Cudbard-Bell [Wed, 18 Mar 2015 20:23:56 +0000 (16:23 -0400)]
Merge pull request #928 from painless-security/to_submit

Abfab policy and trust router changes

9 years agodocument sample ABFAb RP client
Sam Hartman [Wed, 18 Mar 2015 19:46:28 +0000 (15:46 -0400)]
document sample ABFAb RP client

9 years agodynamic = yes not true
Sam Hartman [Wed, 18 Mar 2015 19:29:07 +0000 (15:29 -0400)]
dynamic = yes not true

The config parser doesn't seem to accept dynamic = true, but only
dynamic = yes.  Update error message to provide useful description.

9 years agosqlite: include busy wait for locks
Sam Hartman [Thu, 12 Mar 2015 18:49:04 +0000 (14:49 -0400)]
sqlite: include busy wait for locks

Previously, sqlite would fail any query if there was a lock held on
the database, such as an outstanding write.  In practice this
generated failures even with low-volume writes to the database.
Permit a query to hang for up to 200 ms.

9 years agoUpdates to abfab policy
Sam Hartman [Thu, 12 Mar 2015 18:43:47 +0000 (14:43 -0400)]
Updates to abfab policy

* Move policy from pre-proxy to authorize because we need to run some
  of the updates prior to realm because they now influence generated
  trust router requests.

* Include setting reply messages

9 years agotrustrouter: permit trust-router-COI and error handling
Sam Hartman [Fri, 6 Mar 2015 19:19:52 +0000 (14:19 -0500)]
trustrouter: permit trust-router-COI and error handling

Improve the error handling of the trust router integration.  Set
Error-Cause to indicate a proxy routing failure if we fail to get a
realm via trustrouter.  Include the error back from the trust router
in Reply-Message.

Set trust-router-coi in the trust router code rather than depending on
unlang to do so.  Permit a previously specified trust-router-coi in
the request to override the community in the configuration.  Unlang is
responsible for performing any authorization checks regarding
community.

9 years agoPermit Error-Cause in access reject messages
Sam Hartman [Thu, 5 Mar 2015 15:25:46 +0000 (10:25 -0500)]
Permit Error-Cause in access reject messages

9 years agoSplit out unix socket connection function
Arran Cudbard-Bell [Wed, 18 Mar 2015 17:03:11 +0000 (13:03 -0400)]
Split out unix socket connection function

9 years agoProcess profiles too
Arran Cudbard-Bell [Wed, 18 Mar 2015 16:28:32 +0000 (12:28 -0400)]
Process profiles too

9 years agoInvalid assert in _request_free
Arran Cudbard-Bell [Tue, 17 Mar 2015 17:40:04 +0000 (13:40 -0400)]
Invalid assert in _request_free

Parent is set for fake requests too (Not just divorced CoA/Disconnect ones).

It'd complicate the code more to require parent to be set to NULL before freeing the request, and it'd be pretty pointless.

9 years agoMark groupobj membership filter as being expanded
Arran Cudbard-Bell [Sun, 15 Mar 2015 22:43:44 +0000 (18:43 -0400)]
Mark groupobj membership filter as being expanded

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sun, 15 Mar 2015 19:40:48 +0000 (15:40 -0400)]
Update ChangeLog

9 years agoCreate equivalent pairs for all attributes
Arran Cudbard-Bell [Sun, 15 Mar 2015 05:11:01 +0000 (01:11 -0400)]
Create equivalent pairs for all attributes

9 years agoCreate CONF_PAIRs in client CONF_SECTIONs for string type fields.
Arran Cudbard-Bell [Sat, 14 Mar 2015 21:05:37 +0000 (17:05 -0400)]
Create CONF_PAIRs in client CONF_SECTIONs for string type fields.

This is needed by the "%{client:}" xlat

9 years agodeprecated nastype mucks up dynamic client debug output
Arran Cudbard-Bell [Sat, 14 Mar 2015 20:14:15 +0000 (16:14 -0400)]
deprecated nastype mucks up dynamic client debug output

9 years agoCID 1288496
Arran Cudbard-Bell [Sat, 14 Mar 2015 00:03:05 +0000 (20:03 -0400)]
CID 1288496

9 years agoNot a pointer
Arran Cudbard-Bell [Fri, 13 Mar 2015 20:36:52 +0000 (16:36 -0400)]
Not a pointer

9 years agoDoxygen for state machine
Alan T. DeKok [Fri, 13 Mar 2015 21:25:43 +0000 (17:25 -0400)]
Doxygen for state machine

9 years agotypos
Alan T. DeKok [Fri, 13 Mar 2015 21:11:41 +0000 (17:11 -0400)]
typos

9 years agoTypos
Arran Cudbard-Bell [Fri, 13 Mar 2015 19:45:13 +0000 (15:45 -0400)]
Typos

9 years agoBut it's been config_items for N number of decades!
Arran Cudbard-Bell [Fri, 13 Mar 2015 19:44:39 +0000 (15:44 -0400)]
But it's been config_items for N number of decades!

9 years agoCleanup the REQUEST structure
Arran Cudbard-Bell [Fri, 13 Mar 2015 19:37:16 +0000 (15:37 -0400)]
Cleanup the REQUEST structure

Document a few bits of process.c

Split out listen structures into their own header

9 years agoFormatting
Arran Cudbard-Bell [Fri, 13 Mar 2015 17:41:16 +0000 (13:41 -0400)]
Formatting

9 years agoinitialize child state before printing it
Alan T. DeKok [Fri, 13 Mar 2015 17:19:27 +0000 (13:19 -0400)]
initialize child state before printing it

9 years agoMove request_process_timer() to request_max_time()
Alan T. DeKok [Fri, 13 Mar 2015 17:07:55 +0000 (13:07 -0400)]
Move request_process_timer() to request_max_time()

which simplifies it a lot

9 years agoAdd CHECK_FOR_STOP macro to state machine functions
Alan T. DeKok [Fri, 13 Mar 2015 16:35:47 +0000 (12:35 -0400)]
Add CHECK_FOR_STOP macro to state machine functions

to check if the request should be stopped

9 years agoMove coa_separate checks to a macro
Alan T. DeKok [Fri, 13 Mar 2015 16:29:32 +0000 (12:29 -0400)]
Move coa_separate checks to a macro

9 years agocoa_separate() doesn't need to take an action.
Alan T. DeKok [Fri, 13 Mar 2015 13:55:00 +0000 (09:55 -0400)]
coa_separate() doesn't need to take an action.

rename coa_timer to coa_retransmit, which is saner

9 years agoMove cleanup_delay calculations to cleanup_delay function
Alan T. DeKok [Fri, 13 Mar 2015 13:35:52 +0000 (09:35 -0400)]
Move cleanup_delay calculations to cleanup_delay function

9 years agoMove response_delay calculations to response_delay function
Alan T. DeKok [Fri, 13 Mar 2015 13:33:32 +0000 (09:33 -0400)]
Move response_delay calculations to response_delay function

9 years agoprocess_timer shouldn't need to handle child PROXIED state
Alan T. DeKok [Fri, 13 Mar 2015 13:27:42 +0000 (09:27 -0400)]
process_timer shouldn't need to handle child PROXIED state

the rest of the state machine takes care of that.

9 years agoRely on eol_listener to STOP requests when a socket goes away
Alan T. DeKok [Fri, 13 Mar 2015 13:20:25 +0000 (09:20 -0400)]
Rely on eol_listener to STOP requests when a socket goes away

9 years agoDocument process timer function
Alan T. DeKok [Fri, 13 Mar 2015 13:16:55 +0000 (09:16 -0400)]
Document process timer function

9 years agorequest_common is now only request_process_timer
Alan T. DeKok [Fri, 13 Mar 2015 03:28:36 +0000 (23:28 -0400)]
request_common is now only request_process_timer

9 years agoMove complaint for duplicate packets to its own function
Alan T. DeKok [Fri, 13 Mar 2015 03:27:35 +0000 (23:27 -0400)]
Move complaint for duplicate packets to its own function

Which should start simplifying the code

9 years agoConvert some returns to break for style
Alan T. DeKok [Fri, 13 Mar 2015 03:16:41 +0000 (23:16 -0400)]
Convert some returns to break for style

where they're the same

9 years agoAbstract "proxy reply too late" to separate function
Alan T. DeKok [Fri, 13 Mar 2015 03:12:50 +0000 (23:12 -0400)]
Abstract "proxy reply too late" to separate function

9 years agoset request->process = request_response_delay immediately
Alan T. DeKok [Fri, 13 Mar 2015 03:02:23 +0000 (23:02 -0400)]
set request->process = request_response_delay immediately

9 years agoBuild without threads, too
Alan T. DeKok [Thu, 12 Mar 2015 16:35:59 +0000 (12:35 -0400)]
Build without threads, too

9 years agoAlwauys build with ASSERT_MASTER
Alan T. DeKok [Thu, 12 Mar 2015 16:34:43 +0000 (12:34 -0400)]
Alwauys build with ASSERT_MASTER

9 years agoBetter fix for last commit
Alan T. DeKok [Thu, 12 Mar 2015 15:52:52 +0000 (11:52 -0400)]
Better fix for last commit

9 years agoSet the reply code from the proxy code
Alan T. DeKok [Thu, 12 Mar 2015 15:43:09 +0000 (11:43 -0400)]
Set the reply code from the proxy code

9 years agoAlways build with we_are_master()
Alan T. DeKok [Thu, 12 Mar 2015 15:14:46 +0000 (11:14 -0400)]
Always build with we_are_master()

9 years agoAlways call request_finish() after proxy reply, or proxy no reply.
Alan T. DeKok [Thu, 12 Mar 2015 14:55:55 +0000 (10:55 -0400)]
Always call request_finish() after proxy reply, or proxy no reply.

Previously, if the Post-Proxy-Type returned "handled" or "fail",
it wouldn't reply to the client.  This is probably not a good
idea.

9 years agoUse correct value for Auth-Type = Reject
Alan T. DeKok [Thu, 12 Mar 2015 14:55:18 +0000 (10:55 -0400)]
Use correct value for Auth-Type = Reject

9 years agoRemove unnecessary comment
Alan T. DeKok [Thu, 12 Mar 2015 14:52:17 +0000 (10:52 -0400)]
Remove unnecessary comment

9 years agoWhen we originate CoA packets, discard them when we're done
Alan T. DeKok [Thu, 12 Mar 2015 14:48:25 +0000 (10:48 -0400)]
When we originate CoA packets, discard them when we're done

We don't need to run request_finish

9 years agoRemove redundant argument to cleanup_delay_init
Alan T. DeKok [Thu, 12 Mar 2015 14:46:12 +0000 (10:46 -0400)]
Remove redundant argument to cleanup_delay_init

9 years agoDon't touch request after calling request_finish()
Alan T. DeKok [Wed, 11 Mar 2015 21:52:58 +0000 (17:52 -0400)]
Don't touch request after calling request_finish()

9 years agoMove unlinking to assertions
Alan T. DeKok [Wed, 11 Mar 2015 21:39:45 +0000 (17:39 -0400)]
Move unlinking to assertions

9 years agoEnsure log_name is talloc'd
Alan T. DeKok [Wed, 11 Mar 2015 20:59:20 +0000 (16:59 -0400)]
Ensure log_name is talloc'd

9 years agoRevert "Enable state machine tracing for debug builds on RDEBUG3"
Arran Cudbard-Bell [Wed, 11 Mar 2015 20:46:05 +0000 (16:46 -0400)]
Revert "Enable state machine tracing for debug builds on RDEBUG3"

This reverts commit fd2c20480503ebbe2a97775974c2d28e4c32cfd4.

9 years agoWe don't need this many ASSERT_MASTER
Alan T. DeKok [Wed, 11 Mar 2015 19:34:34 +0000 (15:34 -0400)]
We don't need this many ASSERT_MASTER

9 years agoUpdate log_name after we've discovered the port
Alan T. DeKok [Wed, 11 Mar 2015 19:23:36 +0000 (15:23 -0400)]
Update log_name after we've discovered the port

9 years agoMagic values aren't fun
Arran Cudbard-Bell [Wed, 11 Mar 2015 18:30:54 +0000 (14:30 -0400)]
Magic values aren't fun

9 years agoEnable state machine tracing for debug builds on RDEBUG3
Arran Cudbard-Bell [Wed, 11 Mar 2015 18:44:33 +0000 (14:44 -0400)]
Enable state machine tracing for debug builds on RDEBUG3

9 years agoRename value_pair_tmpl_t for v3.0.x too, else merging with be a nightmare
Arran Cudbard-Bell [Wed, 11 Mar 2015 17:29:23 +0000 (13:29 -0400)]
Rename value_pair_tmpl_t for v3.0.x too, else merging with be a nightmare

9 years agoFix uses of cleanup_delay_init() and child threading
Alan T. DeKok [Wed, 11 Mar 2015 16:10:35 +0000 (12:10 -0400)]
Fix uses of cleanup_delay_init() and child threading

9 years agoRename option to debug level
Alan T. DeKok [Wed, 11 Mar 2015 13:59:55 +0000 (09:59 -0400)]
Rename option to debug level

9 years agoUpdate Aruba dictionary (from ClearPass 6.5.0)
Alexis La Goutte [Tue, 10 Mar 2015 20:16:56 +0000 (21:16 +0100)]
Update Aruba dictionary (from ClearPass 6.5.0)

9 years agoSimplify stats counting
Alan T. DeKok [Tue, 10 Mar 2015 16:31:52 +0000 (12:31 -0400)]
Simplify stats counting

9 years agoMore assertions on free request
Alan T. DeKok [Tue, 10 Mar 2015 15:20:06 +0000 (11:20 -0400)]
More assertions on free request

9 years agomd4 == nt
Alan T. DeKok [Tue, 10 Mar 2015 13:55:15 +0000 (09:55 -0400)]
md4 == nt

9 years agoFix Cisco attributes. Fixes #921
Alan T. DeKok [Mon, 9 Mar 2015 20:06:50 +0000 (16:06 -0400)]
Fix Cisco attributes.  Fixes #921

9 years agoRe-enable "Temporarily disable failing regex tests"
Alan T. DeKok [Mon, 9 Mar 2015 19:48:21 +0000 (15:48 -0400)]
Re-enable "Temporarily disable failing regex tests"

This reverts commit 3bfb4d220c95403764056d28588b8f7d7fca2775.

9 years agotypo
Alan T. DeKok [Mon, 9 Mar 2015 19:13:24 +0000 (15:13 -0400)]
typo

9 years agonote recent changes
Alan T. DeKok [Mon, 9 Mar 2015 19:00:19 +0000 (15:00 -0400)]
note recent changes

9 years agoRe-run command after connection failure
Alan T. DeKok [Mon, 9 Mar 2015 16:53:49 +0000 (12:53 -0400)]
Re-run command after connection failure

9 years agoClean up statistics handling
Alan T. DeKok [Mon, 9 Mar 2015 16:48:32 +0000 (12:48 -0400)]
Clean up statistics handling

9 years agolast may be NULL
Alan T. DeKok [Mon, 9 Mar 2015 16:45:20 +0000 (12:45 -0400)]
last may be NULL

9 years agoMark home server state unknown after "response_window"
Alan T. DeKok [Mon, 9 Mar 2015 16:03:20 +0000 (12:03 -0400)]
Mark home server state unknown after "response_window"

if now > last_packet + response_window, the state is unknown

otherwise, we got a packet recently, so it's still alive

9 years agoRealloc string to the correct length
Alan T. DeKok [Mon, 9 Mar 2015 13:57:58 +0000 (09:57 -0400)]
Realloc string to the correct length

9 years agoRename 2.x.x branch to long term support
Arran Cudbard-Bell [Mon, 9 Mar 2015 02:18:33 +0000 (22:18 -0400)]
Rename 2.x.x branch to long term support

9 years agoMerge pull request #919 from nchaigne/3.0.x-fb3
Arran Cudbard-Bell [Sun, 8 Mar 2015 23:00:48 +0000 (19:00 -0400)]
Merge pull request #919 from nchaigne/3.0.x-fb3

Use proper DHCP vendor

9 years agoProper fix for "Disable regex \n test. Some engines can't take \n"
Arran Cudbard-Bell [Sun, 8 Mar 2015 22:55:19 +0000 (18:55 -0400)]
Proper fix for "Disable regex \n test.  Some engines can't take \n"

9 years agoAdd notes on 3.1.x branch
Arran Cudbard-Bell [Sun, 8 Mar 2015 22:25:24 +0000 (18:25 -0400)]
Add notes on 3.1.x branch

9 years agoDisable regex \n test. Some engines can't take \n
Alan T. DeKok [Sun, 8 Mar 2015 13:49:51 +0000 (09:49 -0400)]
Disable regex \n test.  Some engines can't take \n

9 years agoTypo
Alan T. DeKok [Sun, 8 Mar 2015 00:57:21 +0000 (19:57 -0500)]
Typo

9 years agoDeclare proxy_ctx for WITH_PROXY
Alan T. DeKok [Sat, 7 Mar 2015 22:35:20 +0000 (17:35 -0500)]
Declare proxy_ctx for WITH_PROXY

9 years agoUse correct length for printing template names
Alan T. DeKok [Sat, 7 Mar 2015 21:02:29 +0000 (16:02 -0500)]
Use correct length for printing template names

9 years agoUse standard functions for sockaddr to ipaddr
Alan T. DeKok [Sat, 7 Mar 2015 20:56:19 +0000 (15:56 -0500)]
Use standard functions for sockaddr to ipaddr

9 years agoIf we have no unescaping, there's no need to re-parse it
Alan T. DeKok [Sat, 7 Mar 2015 16:03:55 +0000 (11:03 -0500)]
If we have no unescaping, there's no need to re-parse it

9 years agoLimit memcpy to length
Alan T. DeKok [Sat, 7 Mar 2015 15:59:03 +0000 (10:59 -0500)]
Limit memcpy to length

9 years agoTemporarily disable failing regex tests
Arran Cudbard-Bell [Sat, 7 Mar 2015 01:50:25 +0000 (20:50 -0500)]
Temporarily disable failing regex tests

9 years agoNo longer a valid error (templates are allowed for module config items)
Arran Cudbard-Bell [Sat, 7 Mar 2015 00:16:11 +0000 (19:16 -0500)]
No longer a valid error (templates are allowed for module config items)

9 years agoRemove duplicate CC_HINT
Arran Cudbard-Bell [Sat, 7 Mar 2015 00:10:51 +0000 (19:10 -0500)]
Remove duplicate CC_HINT

9 years agonote recent changes
Alan T. DeKok [Fri, 6 Mar 2015 21:30:25 +0000 (16:30 -0500)]
note recent changes