freeradius.git
10 years agocerts will be NULL for outgoing proxy sockets.
Alan T. DeKok [Wed, 28 May 2014 21:26:20 +0000 (17:26 -0400)]
certs will be NULL for outgoing proxy sockets.

10 years agoFix use of fr_nonblock && listen() for sockets
Alan T. DeKok [Wed, 28 May 2014 21:18:10 +0000 (17:18 -0400)]
Fix use of fr_nonblock && listen() for sockets

Outgoing TCP sockets are non-blocking.  Incoming sockets
are non-blocking.  Outgoing TLS sockets are blocking.

Don't call listen() on outgoing sockets

10 years agoDon't set nonblock on outgoing client connections.
Alan T. DeKok [Wed, 28 May 2014 21:17:43 +0000 (17:17 -0400)]
Don't set nonblock on outgoing client connections.

The caller will need to set it if necessary

10 years agoStatus should always be initialised in rlm_ldap_bind
Arran Cudbard-Bell [Wed, 28 May 2014 19:13:37 +0000 (20:13 +0100)]
Status should always be initialised in rlm_ldap_bind

We'll never actually hit this (it would require fr_connection_get_num to return a negative value).

10 years agoNeed extra break
Arran Cudbard-Bell [Wed, 28 May 2014 16:34:01 +0000 (17:34 +0100)]
Need extra break

10 years agoDon't need memset if it's static
Arran Cudbard-Bell [Wed, 28 May 2014 16:12:03 +0000 (17:12 +0100)]
Don't need memset if it's static

10 years agopairparsevalue should return 0 or -1 like pretty much every other function int the...
Arran Cudbard-Bell [Wed, 28 May 2014 16:03:05 +0000 (17:03 +0100)]
pairparsevalue should return 0 or -1 like pretty much every other function int the server

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Wed, 28 May 2014 15:53:41 +0000 (16:53 +0100)]
Update ChangeLog

10 years agoAdd some more asserts for catching invalid VPs when build without WITH_VERIFY_PTR
Arran Cudbard-Bell [Wed, 28 May 2014 15:28:03 +0000 (16:28 +0100)]
Add some more asserts for catching invalid VPs when build without WITH_VERIFY_PTR

10 years agoAdd \0 safe parsing of LDAP binary attributes
Arran Cudbard-Bell [Wed, 28 May 2014 15:05:44 +0000 (16:05 +0100)]
Add \0 safe parsing of LDAP binary attributes

10 years agoMake pairparsevalue binary safe
Arran Cudbard-Bell [Wed, 28 May 2014 14:40:24 +0000 (15:40 +0100)]
Make pairparsevalue binary safe

10 years agoAdded debian/freeradius-rest to gitignore
Herwin Weststrate [Wed, 28 May 2014 13:53:29 +0000 (15:53 +0200)]
Added debian/freeradius-rest to gitignore

Otherwise, building a Debian package leaves a change in the repository.
Tested with Debian Wheezy 32bit on tag release_3_0_4_rc0 and current
master (commit 73c90fc26a6a56becdf9153abce8d05175fdb06a).

10 years agoMore LDAP tweaks
Arran Cudbard-Bell [Wed, 28 May 2014 08:26:42 +0000 (09:26 +0100)]
More LDAP tweaks

10 years agoDon't retry ldap binds on failure (if were opening a new connection)
Arran Cudbard-Bell [Wed, 28 May 2014 07:24:40 +0000 (08:24 +0100)]
Don't retry ldap binds on failure (if were opening a new connection)

10 years agoExtra message
Arran Cudbard-Bell [Tue, 27 May 2014 22:47:56 +0000 (23:47 +0100)]
Extra message

10 years agoMake it clearer what's happening on exit Fixes #665
Arran Cudbard-Bell [Tue, 27 May 2014 22:40:01 +0000 (23:40 +0100)]
Make it clearer what's happening on exit Fixes #665

10 years agoTweak error message
Alan T. DeKok [Tue, 27 May 2014 17:30:29 +0000 (13:30 -0400)]
Tweak error message

10 years agoAdd option not to add applicaiton_name
Arran Cudbard-Bell [Tue, 27 May 2014 15:04:34 +0000 (16:04 +0100)]
Add option not to add applicaiton_name

10 years agoRe-arrange calls to setup_post_proxy_fail
Alan T. DeKok [Tue, 27 May 2014 14:45:26 +0000 (10:45 -0400)]
Re-arrange calls to setup_post_proxy_fail

So they all follow the same pattern

10 years agoWe can suppress delayed proxy responses, too
Alan T. DeKok [Tue, 27 May 2014 13:12:54 +0000 (09:12 -0400)]
We can suppress delayed proxy responses, too

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 27 May 2014 11:39:33 +0000 (12:39 +0100)]
Update ChangeLog

10 years agoNeed to create new attributes as integer64 type in rlm_sqlcounter
Arran Cudbard-Bell [Tue, 27 May 2014 11:19:33 +0000 (12:19 +0100)]
Need to create new attributes as integer64 type in rlm_sqlcounter

10 years agoNew DHCP options encoder
Arran Cudbard-Bell [Tue, 27 May 2014 09:25:38 +0000 (10:25 +0100)]
New DHCP options encoder

Use the correct fields for accessing non uint32_t types

10 years agoBackport radius_vpt_get_vp changes from master
Arran Cudbard-Bell [Tue, 27 May 2014 09:24:52 +0000 (10:24 +0100)]
Backport radius_vpt_get_vp changes from master

10 years agoUse OpenSSL MD4 and MD5 by default.
Alan T. DeKok [Tue, 27 May 2014 00:41:09 +0000 (20:41 -0400)]
Use OpenSSL MD4 and MD5 by default.

Don't do this for SHA, because src/modules/rlm_eap/libeap/fips186prf.c
needs access to the SHA internals

10 years agoMerge pull request #662 from fajarnugraha/v3.0.x-suse-20140526
Arran Cudbard-Bell [Tue, 27 May 2014 00:05:32 +0000 (01:05 +0100)]
Merge pull request #662 from fajarnugraha/v3.0.x-suse-20140526

V3.0.x suse specfile build fix

10 years agosuse: specfile build fixes
Fajar A. Nugraha [Mon, 26 May 2014 23:51:20 +0000 (06:51 +0700)]
suse: specfile build fixes

10 years agofix compile error
Alan T. DeKok [Mon, 26 May 2014 22:16:34 +0000 (18:16 -0400)]
fix compile error

10 years agoWe always have a "request" now
Alan T. DeKok [Mon, 26 May 2014 22:14:51 +0000 (18:14 -0400)]
We always have a "request" now

10 years agoStart request numbers at 1
Alan T. DeKok [Mon, 26 May 2014 22:10:53 +0000 (18:10 -0400)]
Start request numbers at 1

Which distinguishes them from fake requests

10 years agoAdd a fake request for outgoing TLS client connections
Alan T. DeKok [Mon, 26 May 2014 22:10:09 +0000 (18:10 -0400)]
Add a fake request for outgoing TLS client connections

10 years agoFix cbtls now we don't check for request in RDEBUG macros
Arran Cudbard-Bell [Mon, 26 May 2014 21:59:52 +0000 (22:59 +0100)]
Fix cbtls now we don't check for request in RDEBUG macros

10 years agoAdd instance to application name
Arran Cudbard-Bell [Mon, 26 May 2014 20:22:45 +0000 (21:22 +0100)]
Add instance to application name

10 years agoShould be error message
Arran Cudbard-Bell [Mon, 26 May 2014 19:28:57 +0000 (20:28 +0100)]
Should be error message

10 years agoAdd asserts to radlog functions
Arran Cudbard-Bell [Mon, 26 May 2014 19:27:39 +0000 (20:27 +0100)]
Add asserts to radlog functions

10 years agorm unused goto
Arran Cudbard-Bell [Mon, 26 May 2014 18:47:14 +0000 (19:47 +0100)]
rm unused goto

10 years agoThis should never happen
Arran Cudbard-Bell [Mon, 26 May 2014 18:29:55 +0000 (19:29 +0100)]
This should never happen

10 years agoImpose a hard limit on the number of reconnection attempts for rlm_sql and rlm_ldap
Arran Cudbard-Bell [Mon, 26 May 2014 18:16:44 +0000 (19:16 +0100)]
Impose a hard limit on the number of reconnection attempts for rlm_sql and rlm_ldap

10 years agoDon't reconnect on QUERY CANCELED
Arran Cudbard-Bell [Mon, 26 May 2014 18:16:15 +0000 (19:16 +0100)]
Don't reconnect on QUERY CANCELED

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Mon, 26 May 2014 14:34:47 +0000 (15:34 +0100)]
Update ChangeLog

10 years agoUse the same format as other applications
Arran Cudbard-Bell [Mon, 26 May 2014 14:28:43 +0000 (15:28 +0100)]
Use the same format as other applications

10 years agoTighter range constraint on INTEGER types
Arran Cudbard-Bell [Mon, 26 May 2014 13:45:27 +0000 (14:45 +0100)]
Tighter range constraint on INTEGER types

10 years agoCall rad_postauth() and send the packet from proxy_no_reply. Closes #657
Alan T. DeKok [Mon, 26 May 2014 13:31:04 +0000 (09:31 -0400)]
Call rad_postauth() and send the packet from proxy_no_reply.  Closes #657

10 years agoDon't delay proxy replies when there was a timeout
Alan T. DeKok [Mon, 26 May 2014 13:30:38 +0000 (09:30 -0400)]
Don't delay proxy replies when there was a timeout

10 years agoOne last sign fix for rlm_securid
Arran Cudbard-Bell [Mon, 26 May 2014 13:23:01 +0000 (14:23 +0100)]
One last sign fix for rlm_securid

10 years agoTypo
Arran Cudbard-Bell [Mon, 26 May 2014 13:03:44 +0000 (14:03 +0100)]
Typo

10 years agoCast interval values to ints before use, so we don't get sign issues with time_t...
Arran Cudbard-Bell [Mon, 26 May 2014 12:30:48 +0000 (13:30 +0100)]
Cast interval values to ints before use, so we don't get sign issues with time_t. Fixes #659

10 years agoUse signed int to represent epoch in rlm_cache
Arran Cudbard-Bell [Mon, 26 May 2014 12:09:25 +0000 (13:09 +0100)]
Use signed int to represent epoch in rlm_cache

10 years agoFix compilation of rlm_eap
Nikolai Kondrashov [Mon, 26 May 2014 11:26:41 +0000 (14:26 +0300)]
Fix compilation of rlm_eap

Mark rlm_eap_tnc connection_string const to cater to FR_CONF_OFFSET
invocation. This fixes the build of rlm_eap module.

10 years agoDoing it the smart way causes Doxygen errors
Arran Cudbard-Bell [Mon, 26 May 2014 11:25:58 +0000 (12:25 +0100)]
Doing it the smart way causes Doxygen errors

10 years agoMove db_string building into the pg instantiation function
Arran Cudbard-Bell [Mon, 26 May 2014 11:07:42 +0000 (12:07 +0100)]
Move db_string building into the pg instantiation function

Add application_name to the db_string

10 years agoAdd talloc_frees in realm
Arran Cudbard-Bell [Sun, 25 May 2014 22:42:14 +0000 (23:42 +0100)]
Add talloc_frees in realm

10 years agoSync rlm_python and rlm_ldap with master
Arran Cudbard-Bell [Sun, 25 May 2014 22:21:14 +0000 (23:21 +0100)]
Sync rlm_python and rlm_ldap with master

10 years agoAdd compile time checking for config pointers
Arran Cudbard-Bell [Sun, 25 May 2014 22:00:11 +0000 (23:00 +0100)]
Add compile time checking for config pointers

10 years agoFix comments which caused doxygen parse issues
Arran Cudbard-Bell [Sat, 24 May 2014 21:28:37 +0000 (22:28 +0100)]
Fix comments which caused doxygen parse issues

10 years agoRest auth should just do the same checks as rlm_pap for credentials
Arran Cudbard-Bell [Sat, 24 May 2014 21:07:53 +0000 (22:07 +0100)]
Rest auth should just do the same checks as rlm_pap for credentials

10 years agoFix for scan warning
Alan T. DeKok [Sat, 24 May 2014 19:31:24 +0000 (15:31 -0400)]
Fix for scan warning

10 years agoDon't set SO_REUSEADDR for UDP ports
Arran Cudbard-Bell [Sat, 24 May 2014 19:19:55 +0000 (20:19 +0100)]
Don't set SO_REUSEADDR for UDP ports

10 years agoFormatting
Arran Cudbard-Bell [Sat, 24 May 2014 17:50:09 +0000 (18:50 +0100)]
Formatting

10 years agoAll usage messages should go to the same place
Arran Cudbard-Bell [Sat, 24 May 2014 17:36:35 +0000 (18:36 +0100)]
All usage messages should go to the same place

10 years agoExit after reading all packets in radsniff
Arran Cudbard-Bell [Sat, 24 May 2014 17:35:23 +0000 (18:35 +0100)]
Exit after reading all packets in radsniff

10 years agoIt's either a read error or a read of an invalid number of bytes
Arran Cudbard-Bell [Sat, 24 May 2014 16:25:36 +0000 (17:25 +0100)]
It's either a read error or a read of an invalid number of bytes

10 years agoCheck for NULL hs_type first
Arran Cudbard-Bell [Sat, 24 May 2014 15:59:53 +0000 (16:59 +0100)]
Check for NULL hs_type first

10 years agoAdd coa_no_reply and glue it into the state machine
Alan T. DeKok [Sat, 24 May 2014 15:51:41 +0000 (11:51 -0400)]
Add coa_no_reply and glue it into the state machine

10 years agoDEBUG2 --> RDEBUG2 for messages
Alan T. DeKok [Sat, 24 May 2014 15:50:58 +0000 (11:50 -0400)]
DEBUG2 --> RDEBUG2 for messages

10 years agoCatch race condition in proxy_reply
Alan T. DeKok [Sat, 24 May 2014 15:49:46 +0000 (11:49 -0400)]
Catch race condition in proxy_reply

If we've decided there's no reply, then we don't use it, even
if one comes in

10 years agoAdd check for limits.h
Arran Cudbard-Bell [Sat, 24 May 2014 15:37:16 +0000 (16:37 +0100)]
Add check for limits.h

10 years agoAdd limits.h to libradius.h
Arran Cudbard-Bell [Sat, 24 May 2014 15:10:58 +0000 (16:10 +0100)]
Add limits.h to libradius.h

10 years agoChange num to int
Arran Cudbard-Bell [Sat, 24 May 2014 15:01:13 +0000 (16:01 +0100)]
Change num to int

10 years agoTypo
Arran Cudbard-Bell [Sat, 24 May 2014 14:49:17 +0000 (15:49 +0100)]
Typo

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sat, 24 May 2014 12:31:02 +0000 (13:31 +0100)]
Update ChangeLog

10 years agoAdd xlat to print the current tag of an attribute
Arran Cudbard-Bell [Sat, 24 May 2014 12:27:47 +0000 (13:27 +0100)]
Add xlat to print the current tag of an attribute

10 years ago#647 only appeared after 3.0.3 and #648 is so minor it doesn't need mentioning
Arran Cudbard-Bell [Sat, 24 May 2014 12:03:56 +0000 (13:03 +0100)]
#647 only appeared after 3.0.3 and #648 is so minor it doesn't need mentioning

10 years agoUpdate ChangeLog release_3_0_4_rc0
Arran Cudbard-Bell [Sat, 24 May 2014 11:52:17 +0000 (12:52 +0100)]
Update ChangeLog

10 years agoShould be signed
Arran Cudbard-Bell [Sat, 24 May 2014 11:12:49 +0000 (12:12 +0100)]
Should be signed

10 years agoVarious coverity fixes
Arran Cudbard-Bell [Sat, 24 May 2014 11:03:58 +0000 (12:03 +0100)]
Various coverity fixes

10 years agoDon't SEGV on parse error in unittest
Arran Cudbard-Bell [Sat, 24 May 2014 10:39:29 +0000 (11:39 +0100)]
Don't SEGV on parse error in unittest

10 years agoclang analyzer issue
Arran Cudbard-Bell [Sat, 24 May 2014 09:56:52 +0000 (10:56 +0100)]
clang analyzer issue

10 years agoReformatting
Arran Cudbard-Bell [Sat, 24 May 2014 09:48:23 +0000 (10:48 +0100)]
Reformatting

10 years agoTests for removal by tag and index
Arran Cudbard-Bell [Sat, 24 May 2014 09:43:35 +0000 (10:43 +0100)]
Tests for removal by tag and index

Make tag processing consistent everywhere

Make all internally created VALUE_PAIRs default to TAG_ANY so that when used as 'check'/'filter' vps they match all tagged and untagged attributes.

10 years agoVarious fixups in xlat_getvp
Arran Cudbard-Bell [Fri, 23 May 2014 22:05:51 +0000 (23:05 +0100)]
Various fixups in xlat_getvp

10 years agonumber xlat-attr-tag
Arran Cudbard-Bell [Fri, 23 May 2014 22:02:36 +0000 (23:02 +0100)]
number xlat-attr-tag

10 years agononnull declarations should go at the begining
Arran Cudbard-Bell [Fri, 23 May 2014 21:08:59 +0000 (22:08 +0100)]
nonnull declarations should go at the begining

10 years agoMinor fixes in pairmake
Arran Cudbard-Bell [Fri, 23 May 2014 22:01:26 +0000 (23:01 +0100)]
Minor fixes in pairmake

10 years agoFix tag filter debug
Arran Cudbard-Bell [Fri, 23 May 2014 22:00:23 +0000 (23:00 +0100)]
Fix tag filter debug

10 years agoUsing [*] [#] [0] on fake attributes should produce the same result as on the real...
Arran Cudbard-Bell [Fri, 23 May 2014 21:01:09 +0000 (22:01 +0100)]
Using [*] [#] [0] on fake attributes should produce the same result as on the real ones

10 years agoDon't assert on list copy (head should of been NULL after adding all it's pairs)
Arran Cudbard-Bell [Fri, 23 May 2014 21:08:43 +0000 (22:08 +0100)]
Don't assert on list copy (head should of been NULL after adding all it's pairs)

10 years agoFix more places where tags weren't respected correctly
Arran Cudbard-Bell [Fri, 23 May 2014 17:39:19 +0000 (18:39 +0100)]
Fix more places where tags weren't respected correctly

10 years agoFix ref to re-named test
Alan T. DeKok [Fri, 23 May 2014 17:14:27 +0000 (13:14 -0400)]
Fix ref to re-named test

10 years agoSimplify proxy no reply case. Closes #657
Alan T. DeKok [Fri, 23 May 2014 16:31:07 +0000 (12:31 -0400)]
Simplify proxy no reply case.  Closes #657

10 years agoAdd tag correction pass so update sections insert tagged attributes again
Arran Cudbard-Bell [Fri, 23 May 2014 16:18:31 +0000 (17:18 +0100)]
Add tag correction pass so update sections insert tagged attributes again

10 years agoAdd additional texts for index
Arran Cudbard-Bell [Fri, 23 May 2014 16:00:13 +0000 (17:00 +0100)]
Add additional texts for index

10 years agoAllow Post-Proxy-Type Fail. Closes #656
Alan T. DeKok [Fri, 23 May 2014 15:24:18 +0000 (11:24 -0400)]
Allow Post-Proxy-Type Fail.  Closes #656

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 23 May 2014 15:16:46 +0000 (16:16 +0100)]
Update ChangeLog

10 years agoTypo
Arran Cudbard-Bell [Fri, 23 May 2014 14:59:46 +0000 (15:59 +0100)]
Typo

10 years agoFix merge issue
Arran Cudbard-Bell [Fri, 23 May 2014 14:44:18 +0000 (15:44 +0100)]
Fix merge issue

10 years agoredhat: add rlm_unpack, remove rlm_unbound config
Fajar A. Nugraha [Fri, 23 May 2014 13:33:46 +0000 (20:33 +0700)]
redhat: add rlm_unpack, remove rlm_unbound config

10 years agoChange array index range back to between 0-1000
Arran Cudbard-Bell [Fri, 23 May 2014 14:00:06 +0000 (15:00 +0100)]
Change array index range back to between 0-1000

10 years agoFix corner case when using fr_cursor_remove and fr_cursor_next_by_da together
Arran Cudbard-Bell [Fri, 23 May 2014 13:49:49 +0000 (14:49 +0100)]
Fix corner case when using fr_cursor_remove and fr_cursor_next_by_da together

10 years agoFix array offsets to that offset 0 is differentiated from no offset
Arran Cudbard-Bell [Fri, 23 May 2014 13:14:23 +0000 (14:14 +0100)]
Fix array offsets to that offset 0 is differentiated from no offset