freeradius.git
9 years agoCoverity CID #1258575
Arran Cudbard-Bell [Mon, 15 Dec 2014 20:46:00 +0000 (15:46 -0500)]
Coverity CID #1258575

9 years agoDecrease block protected by the mutex. Closes CID #1258573
Alan T. DeKok [Mon, 15 Dec 2014 20:38:00 +0000 (15:38 -0500)]
Decrease block protected by the mutex. Closes CID #1258573

9 years agoCoverity CID #1258572
Arran Cudbard-Bell [Mon, 15 Dec 2014 20:30:44 +0000 (15:30 -0500)]
Coverity CID #1258572

9 years agoCoverity CID #1258569
Arran Cudbard-Bell [Mon, 15 Dec 2014 20:24:27 +0000 (15:24 -0500)]
Coverity CID #1258569

9 years agoCoverity CID #1258567
Arran Cudbard-Bell [Mon, 15 Dec 2014 20:18:10 +0000 (15:18 -0500)]
Coverity CID #1258567

9 years agoRemove dead code
Alan T. DeKok [Mon, 15 Dec 2014 20:32:13 +0000 (15:32 -0500)]
Remove dead code

9 years agoTypo
Alan T. DeKok [Mon, 15 Dec 2014 20:32:03 +0000 (15:32 -0500)]
Typo

9 years agoTypo. Closes CID #1258570
Alan T. DeKok [Mon, 15 Dec 2014 20:30:29 +0000 (15:30 -0500)]
Typo.  Closes CID #1258570

9 years agoNote recent changes
Alan T. DeKok [Mon, 15 Dec 2014 20:29:32 +0000 (15:29 -0500)]
Note recent changes

9 years agoReturn on bad things. Closes CID #1258571
Alan T. DeKok [Mon, 15 Dec 2014 20:29:03 +0000 (15:29 -0500)]
Return on bad things.  Closes CID #1258571

9 years agoWe need an "update" config. Closes CID #1258577
Alan T. DeKok [Mon, 15 Dec 2014 20:27:19 +0000 (15:27 -0500)]
We need an "update" config.  Closes CID #1258577

9 years agoWe don't need an "update" config. Closes CID #1258577
Alan T. DeKok [Mon, 15 Dec 2014 20:25:27 +0000 (15:25 -0500)]
We don't need an "update" config.  Closes CID #1258577

9 years agoClose sockfd if we fail. Closes CID #1258578
Alan T. DeKok [Mon, 15 Dec 2014 20:21:55 +0000 (15:21 -0500)]
Close sockfd if we fail.  Closes CID #1258578

9 years agoNote that we're falling through. Closes CID #1258579
Alan T. DeKok [Mon, 15 Dec 2014 20:21:40 +0000 (15:21 -0500)]
Note that we're falling through.  Closes CID #1258579

9 years agoMove printing the reply out a little later (after we've decoded it)
Arran Cudbard-Bell [Mon, 15 Dec 2014 19:37:03 +0000 (14:37 -0500)]
Move printing the reply out a little later (after we've decoded it)

9 years agoAdd &attr[n] which gets the last instance of an attribute (Useful to get the most...
Arran Cudbard-Bell [Mon, 15 Dec 2014 19:25:11 +0000 (14:25 -0500)]
Add &attr[n] which gets the last instance of an attribute (Useful to get the most recent instance of Module-Failure-Message)

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Mon, 15 Dec 2014 19:27:52 +0000 (14:27 -0500)]
Update ChangeLog

9 years agoMore fixes for coa separate
Alan T. DeKok [Mon, 15 Dec 2014 18:18:13 +0000 (13:18 -0500)]
More fixes for coa separate

9 years agoAdd packet debugging back into radclient
Arran Cudbard-Bell [Mon, 15 Dec 2014 18:06:33 +0000 (13:06 -0500)]
Add packet debugging back into radclient

9 years agoTypo
Arran Cudbard-Bell [Mon, 15 Dec 2014 17:30:45 +0000 (12:30 -0500)]
Typo

9 years agoAdd explicit tests for unknown in condition
Alan T. DeKok [Mon, 15 Dec 2014 17:27:53 +0000 (12:27 -0500)]
Add explicit tests for unknown in condition

9 years agoBetter way of dealing with undefined attrs in update
Alan T. DeKok [Mon, 15 Dec 2014 17:26:35 +0000 (12:26 -0500)]
Better way of dealing with undefined attrs in update

9 years agoMerge pull request #857 from spbnick/move_trigger_include
Alan DeKok [Mon, 15 Dec 2014 17:14:52 +0000 (12:14 -0500)]
Merge pull request #857 from spbnick/move_trigger_include

raddb: Move trigger.conf INCLUDE before modules

9 years agoError out if the attribute is unknown after pass2
Alan T. DeKok [Mon, 15 Dec 2014 16:59:24 +0000 (11:59 -0500)]
Error out if the attribute is unknown after pass2

9 years agoRemove unused code
Arran Cudbard-Bell [Mon, 15 Dec 2014 15:56:09 +0000 (10:56 -0500)]
Remove unused code

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Mon, 15 Dec 2014 15:24:25 +0000 (10:24 -0500)]
Update ChangeLog

9 years agoraddb: Move trigger.conf INCLUDE before modules
Nikolai Kondrashov [Mon, 15 Dec 2014 14:48:26 +0000 (16:48 +0200)]
raddb: Move trigger.conf INCLUDE before modules

Move "$INCLUDE trigger.conf" chunk before module section in
"radiusd.conf.in". This makes it possible to reference "snmptrap" and
related trigger variables under "pool.trigger" in module configurations,
simplifying them.

E.g. like this (in raddb/mods-enabled/ldap):

ldap ldap_instance {
    pool {
        trigger {
            args = "radiusdModuleName s '${...:name}' radiusdModuleInstance s '${...:instance}'"
            open = "${snmptrap}::serverModuleConnectionUp ${args}"
            close = "${snmptrap}::serverModuleConnectionDown ${args}"
        }
    }
}

9 years agoAvoid shift overflow that cause incorrect masking to be applied to /64 prefixes
Arran Cudbard-Bell [Mon, 15 Dec 2014 14:51:27 +0000 (09:51 -0500)]
Avoid shift overflow that cause incorrect masking to be applied to /64 prefixes

9 years agoFormatting
Arran Cudbard-Bell [Mon, 15 Dec 2014 14:50:43 +0000 (09:50 -0500)]
Formatting

9 years agoAdd code to convert between IPv4/v6 addresses and IPv4/v6 prefixes
Arran Cudbard-Bell [Mon, 15 Dec 2014 01:02:33 +0000 (20:02 -0500)]
Add code to convert between IPv4/v6 addresses and IPv4/v6 prefixes

9 years agoRemove restriction on implicit casts in map_to_vp
Arran Cudbard-Bell [Mon, 15 Dec 2014 05:30:33 +0000 (00:30 -0500)]
Remove restriction on implicit casts in map_to_vp

9 years agoAdd more EVAL_DEBUG statements so we can determine source of normalisation type
Arran Cudbard-Bell [Mon, 15 Dec 2014 01:01:43 +0000 (20:01 -0500)]
Add more EVAL_DEBUG statements so we can determine source of normalisation type

9 years agoZero log.indent in child requests
Arran Cudbard-Bell [Mon, 15 Dec 2014 01:01:04 +0000 (20:01 -0500)]
Zero log.indent in child requests

9 years agoTypo
Arran Cudbard-Bell [Mon, 15 Dec 2014 01:00:51 +0000 (20:00 -0500)]
Typo

9 years agoRemove &Attr[#] it's very difficult to make it work correctly everywhere
Arran Cudbard-Bell [Mon, 15 Dec 2014 01:00:39 +0000 (20:00 -0500)]
Remove &Attr[#] it's very difficult to make it work correctly everywhere

9 years agoTypo
Arran Cudbard-Bell [Mon, 15 Dec 2014 00:59:52 +0000 (19:59 -0500)]
Typo

9 years agoFix bad VP array type value accesses
Arran Cudbard-Bell [Mon, 15 Dec 2014 00:59:41 +0000 (19:59 -0500)]
Fix bad VP array type value accesses

9 years agoFix coa_separate to behave differently for proxy reply
Alan T. DeKok [Mon, 15 Dec 2014 13:31:25 +0000 (08:31 -0500)]
Fix coa_separate to behave differently for proxy reply

9 years agoMerge pull request #849 from spbnick/util_help
Arran Cudbard-Bell [Mon, 15 Dec 2014 13:30:03 +0000 (08:30 -0500)]
Merge pull request #849 from spbnick/util_help

rad_counter and dhcpclient online help fixes

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sun, 14 Dec 2014 00:44:12 +0000 (19:44 -0500)]
Update ChangeLog

9 years agoUpdate the unlang man page
Arran Cudbard-Bell [Sun, 14 Dec 2014 00:37:03 +0000 (19:37 -0500)]
Update the unlang man page

9 years agoAdd support for 'm' (multiline) regex flag
Arran Cudbard-Bell [Sat, 13 Dec 2014 21:04:54 +0000 (16:04 -0500)]
Add support for 'm' (multiline) regex flag

9 years agoTypos
Arran Cudbard-Bell [Sat, 13 Dec 2014 04:42:21 +0000 (23:42 -0500)]
Typos

9 years agoShould be HAVE_REGEX
Arran Cudbard-Bell [Sat, 13 Dec 2014 04:38:56 +0000 (23:38 -0500)]
Should be HAVE_REGEX

9 years agoFmt is used
Arran Cudbard-Bell [Sat, 13 Dec 2014 01:59:47 +0000 (20:59 -0500)]
Fmt is used

9 years agoUnneeded debug
Arran Cudbard-Bell [Sat, 13 Dec 2014 01:59:19 +0000 (20:59 -0500)]
Unneeded debug

9 years agoAdd support for named capture groups
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:22:51 +0000 (19:22 -0500)]
Add support for named capture groups

9 years agoDoxygen
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:22:36 +0000 (19:22 -0500)]
Doxygen

9 years agoFix handling of regexes with > 32 capture groups
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:22:15 +0000 (19:22 -0500)]
Fix handling of regexes with > 32 capture groups

9 years agoNeed MAX_REGEX + 1 for the complete match group
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:21:44 +0000 (19:21 -0500)]
Need MAX_REGEX + 1 for the complete match group

9 years agoxlat_inst only needed for foreach
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:20:52 +0000 (19:20 -0500)]
xlat_inst only needed for foreach

9 years agoFix xlat_tokenize code so it handles arbitrary numbers of capture groups
Arran Cudbard-Bell [Sat, 13 Dec 2014 00:20:30 +0000 (19:20 -0500)]
Fix xlat_tokenize code so it handles arbitrary numbers of capture groups

9 years agoTypo
Arran Cudbard-Bell [Fri, 12 Dec 2014 20:56:24 +0000 (15:56 -0500)]
Typo

9 years agoSwitch to new subcapture handling code
Arran Cudbard-Bell [Fri, 12 Dec 2014 20:54:19 +0000 (15:54 -0500)]
Switch to new subcapture handling code

9 years agoAdd always flag to fr_debug_break
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:14:54 +0000 (13:14 -0500)]
Add always flag to fr_debug_break

9 years agoCreate abstraction layer around regular expression libraries
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:14:34 +0000 (13:14 -0500)]
Create abstraction layer around regular expression libraries

Call libpcre with native functions, and use the JIT where appropriate/possible

Call regnexec and regncomp where available, and complain about null bytes in patterns and subjects if they're not.

9 years agoReturn -1 if we can't allocate memory for node for request data
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:03:04 +0000 (13:03 -0500)]
Return -1 if we can't allocate memory for node for request data

9 years agoPrint PCRE library version
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:02:37 +0000 (13:02 -0500)]
Print PCRE library version

9 years agoOutput debug for virtual expansions
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:02:23 +0000 (13:02 -0500)]
Output debug for virtual expansions

9 years agoUpdate truncation test to work around limitations in some regular expressions max...
Arran Cudbard-Bell [Fri, 12 Dec 2014 18:01:31 +0000 (13:01 -0500)]
Update truncation test to work around limitations in some regular expressions max repetition limit

9 years agoClarify warning message
Alan T. DeKok [Fri, 12 Dec 2014 12:25:27 +0000 (07:25 -0500)]
Clarify warning message

9 years agoFormatting
Arran Cudbard-Bell [Thu, 11 Dec 2014 16:46:06 +0000 (11:46 -0500)]
Formatting

9 years agoRemove last call to pairdatacpy and remove pairdatacpy
Arran Cudbard-Bell [Thu, 11 Dec 2014 16:44:39 +0000 (11:44 -0500)]
Remove last call to pairdatacpy and remove pairdatacpy

9 years agoMore call to pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:09:20 +0000 (11:09 -0500)]
More call to pairdatacpy()

9 years agoRemove call to pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:06:25 +0000 (11:06 -0500)]
Remove call to pairdatacpy()

9 years agosrc is const
Alan T. DeKok [Thu, 11 Dec 2014 16:05:56 +0000 (11:05 -0500)]
src is const

9 years agoRemove one more caller of pairdatacpy()
Alan T. DeKok [Thu, 11 Dec 2014 16:03:56 +0000 (11:03 -0500)]
Remove one more caller of pairdatacpy()

9 years agoCreate value_data_copy function
Alan T. DeKok [Thu, 11 Dec 2014 16:03:27 +0000 (11:03 -0500)]
Create value_data_copy function

9 years agoDon't call pairdatacpy. Closes #853
Alan T. DeKok [Thu, 11 Dec 2014 15:19:40 +0000 (10:19 -0500)]
Don't call pairdatacpy.  Closes #853

9 years agoThere might not be a name2
Alan T. DeKok [Wed, 10 Dec 2014 21:30:12 +0000 (16:30 -0500)]
There might not be a name2

9 years agoTypo
Arran Cudbard-Bell [Thu, 11 Dec 2014 13:31:30 +0000 (08:31 -0500)]
Typo

9 years agoPass pointer to head of list when doing pairsort in perl_store_vps Fixes #852
Arran Cudbard-Bell [Thu, 11 Dec 2014 13:20:09 +0000 (08:20 -0500)]
Pass pointer to head of list when doing pairsort in perl_store_vps Fixes #852

9 years agoDisallow attribute zero in the dictionaries. Closes #851
Alan T. DeKok [Wed, 10 Dec 2014 16:26:16 +0000 (11:26 -0500)]
Disallow attribute zero in the dictionaries.  Closes #851

Except for Colubris, who use it

9 years agoRemove unused variables
Alan T. DeKok [Wed, 10 Dec 2014 15:04:20 +0000 (10:04 -0500)]
Remove unused variables

9 years agoSmash bad filenames
Alan T. DeKok [Wed, 10 Dec 2014 13:55:13 +0000 (08:55 -0500)]
Smash bad filenames

9 years agoSmash bad filenames
Alan T. DeKok [Wed, 10 Dec 2014 13:55:13 +0000 (08:55 -0500)]
Smash bad filenames

9 years agoMake filename escaping configurable.
Alan T. DeKok [Wed, 10 Dec 2014 13:47:14 +0000 (08:47 -0500)]
Make filename escaping configurable.

9 years agoShort-circuit fr_prints() when there's no quoting
Alan T. DeKok [Tue, 9 Dec 2014 21:29:02 +0000 (16:29 -0500)]
Short-circuit fr_prints() when there's no quoting

9 years agoFix argument order in fr_prints so out is first
Arran Cudbard-Bell [Tue, 9 Dec 2014 21:33:12 +0000 (16:33 -0500)]
Fix argument order in fr_prints so out is first

9 years agoOnly include <ldap.h> in ldap.h
Arran Cudbard-Bell [Tue, 9 Dec 2014 21:05:52 +0000 (16:05 -0500)]
Only include <ldap.h> in ldap.h

9 years agoNote recent changes
Alan T. DeKok [Tue, 9 Dec 2014 20:56:26 +0000 (15:56 -0500)]
Note recent changes

9 years agoAllow spaces in certificate passwords
Alan T. DeKok [Tue, 9 Dec 2014 20:55:38 +0000 (15:55 -0500)]
Allow spaces in certificate passwords

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 9 Dec 2014 19:51:06 +0000 (14:51 -0500)]
Update ChangeLog

9 years agoWork around potential race in ldap_create
Arran Cudbard-Bell [Tue, 9 Dec 2014 19:39:12 +0000 (14:39 -0500)]
Work around potential race in ldap_create

9 years agoFormatting
Arran Cudbard-Bell [Tue, 9 Dec 2014 17:38:57 +0000 (12:38 -0500)]
Formatting

9 years agoAdded checks for braces at end of string
Alan T. DeKok [Tue, 9 Dec 2014 19:03:56 +0000 (14:03 -0500)]
Added checks for braces at end of string

9 years agoDefine LDAP_DEPRECATED outside of autoconf (and before including ldap.h)
Arran Cudbard-Bell [Mon, 8 Dec 2014 23:16:10 +0000 (18:16 -0500)]
Define LDAP_DEPRECATED outside of autoconf (and before including ldap.h)

9 years agoActually use the pool we alloced
Arran Cudbard-Bell [Mon, 8 Dec 2014 23:08:25 +0000 (18:08 -0500)]
Actually use the pool we alloced

9 years agoMore tests
Alan T. DeKok [Mon, 8 Dec 2014 20:31:02 +0000 (15:31 -0500)]
More tests

9 years agoPrint *data* not *pointer* if it's octets
Alan T. DeKok [Mon, 8 Dec 2014 20:30:39 +0000 (15:30 -0500)]
Print *data* not *pointer* if it's octets

9 years agoMissed cast
Arran Cudbard-Bell [Mon, 8 Dec 2014 20:01:34 +0000 (15:01 -0500)]
Missed cast

9 years agoDoxygen
Arran Cudbard-Bell [Mon, 8 Dec 2014 19:56:02 +0000 (14:56 -0500)]
Doxygen

9 years agoFixup LDAP group debugging messages so they're more useful
Arran Cudbard-Bell [Mon, 8 Dec 2014 19:34:15 +0000 (14:34 -0500)]
Fixup LDAP group debugging messages so they're more useful

Operations are now idented by group being checked

Also fixup quadratic group membership attribute insertion

9 years agoCopyright notices
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:07:23 +0000 (10:07 -0500)]
Copyright notices

9 years agoBreak out serialization functions from rlm_cache_memcached
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:07:12 +0000 (10:07 -0500)]
Break out serialization functions from rlm_cache_memcached

9 years agoAdd note on pairstrncpy
Arran Cudbard-Bell [Mon, 8 Dec 2014 15:06:02 +0000 (10:06 -0500)]
Add note on pairstrncpy

9 years agoRename fr_print_string to fr_prints
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:37:12 +0000 (17:37 -0500)]
Rename fr_print_string to fr_prints

9 years agoexfile_open now opens files for read/writing, which is useful if the exfile instance...
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:31:09 +0000 (17:31 -0500)]
exfile_open now opens files for read/writing, which is useful if the exfile instance may be used to acquire fds for reading too

add 'append' argument, that controls whether exfile_open seeks to the end of the file.

9 years agoMake fr_print_string take -1 to signify that it should calculate the length of inlen
Arran Cudbard-Bell [Sun, 7 Dec 2014 22:29:38 +0000 (17:29 -0500)]
Make fr_print_string take -1 to signify that it should calculate the length of inlen

Fix fr_print_string_len to produce the correct length (fr_print_string was modified without equivalent modifications being made to fr_print_string_len)

Add fr_aprints to allocate a printable string

9 years agoMake it clear why the xlat failed
Arran Cudbard-Bell [Sun, 7 Dec 2014 20:01:58 +0000 (15:01 -0500)]
Make it clear why the xlat failed