freeradius.git
10 years agoAdd version consistency checks between applications, libfreeradius-radius, libfreerad...
Arran Cudbard-Bell [Thu, 23 Jan 2014 16:19:15 +0000 (16:19 +0000)]
Add version consistency checks between applications, libfreeradius-radius, libfreeradius-server, and modules

10 years agoRevert "Auto-load dictionary.vqp and dictionary.dhcp"
Alan T. DeKok [Thu, 23 Jan 2014 15:02:14 +0000 (10:02 -0500)]
Revert "Auto-load dictionary.vqp and dictionary.dhcp"

This reverts commit 184c620705ba5c072492ea87c26c1ddaf28fd274.

We'll do this in the master branch later

10 years agoBackport length xlat so length tests pass
Arran Cudbard-Bell [Thu, 23 Jan 2014 12:16:06 +0000 (12:16 +0000)]
Backport length xlat so length tests pass

10 years agoIncrease log message buffer slightly, this should be large enough to handle the large...
Arran Cudbard-Bell [Thu, 23 Jan 2014 11:09:26 +0000 (11:09 +0000)]
Increase log message buffer slightly, this should be large enough to handle the largest string value we can add using an update section

10 years agoAdd stub for truncation test
Arran Cudbard-Bell [Thu, 23 Jan 2014 11:08:43 +0000 (11:08 +0000)]
Add stub for truncation test

10 years agoAdd tests for length xlat
Arran Cudbard-Bell [Wed, 22 Jan 2014 23:28:27 +0000 (23:28 +0000)]
Add tests for length xlat

10 years agoFix typo
Alan T. DeKok [Thu, 23 Jan 2014 01:07:34 +0000 (20:07 -0500)]
Fix typo

10 years agoAuto-load dictionary.vqp and dictionary.dhcp
Alan T. DeKok [Thu, 23 Jan 2014 00:59:19 +0000 (19:59 -0500)]
Auto-load dictionary.vqp and dictionary.dhcp

10 years agoNote if we don't change the limit
Alan T. DeKok [Thu, 23 Jan 2014 00:32:17 +0000 (19:32 -0500)]
Note if we don't change the limit

10 years agoAdd tests for hex xlat
Arran Cudbard-Bell [Wed, 22 Jan 2014 22:54:43 +0000 (22:54 +0000)]
Add tests for hex xlat

10 years agoOnly isdigit is c90
Arran Cudbard-Bell [Wed, 22 Jan 2014 20:47:36 +0000 (20:47 +0000)]
Only isdigit is c90

10 years agoUse size out output buffer, not size of output pointer
Alan T. DeKok [Wed, 22 Jan 2014 20:11:33 +0000 (15:11 -0500)]
Use size out output buffer, not size of output pointer

10 years agoReturn error if the exec'd program exited via a signal
Alan T. DeKok [Wed, 22 Jan 2014 19:53:09 +0000 (14:53 -0500)]
Return error if the exec'd program exited via a signal

10 years agoUse our source IP when relaying the packet.
Alan T. DeKok [Wed, 22 Jan 2014 19:31:47 +0000 (14:31 -0500)]
Use our source IP when relaying the packet.

The gateway IP address goes inside of the DHCP packet,
and shouldn't affect the IP header

10 years agoFix port for giaddr.
Alan T. DeKok [Wed, 22 Jan 2014 19:23:55 +0000 (14:23 -0500)]
Fix port for giaddr.

The destination should be the server port, not the client port.

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Wed, 22 Jan 2014 19:04:06 +0000 (19:04 +0000)]
Update ChangeLog

10 years agoAdd tests for base64 xlat
Arran Cudbard-Bell [Wed, 22 Jan 2014 18:59:48 +0000 (18:59 +0000)]
Add tests for base64 xlat

Also tests host to network ordering conversion

10 years agoWork around const
Arran Cudbard-Bell [Wed, 22 Jan 2014 18:57:23 +0000 (18:57 +0000)]
Work around const

10 years agoFix parsing of ascend string attributes
Arran Cudbard-Bell [Wed, 22 Jan 2014 18:53:54 +0000 (18:53 +0000)]
Fix parsing of ascend string attributes

10 years agoAdd a test for casting integers to IPv4 addresses, then fix the code so the test...
Arran Cudbard-Bell [Wed, 22 Jan 2014 16:48:15 +0000 (16:48 +0000)]
Add a test for casting integers to IPv4 addresses, then fix the code so the test passes!

Test based development FTW!

10 years agoRemove value length limit in base64/hex xlats
Arran Cudbard-Bell [Wed, 22 Jan 2014 14:37:15 +0000 (14:37 +0000)]
Remove value length limit in base64/hex xlats

Max is now xlat buffer size

10 years agoFormatting
Arran Cudbard-Bell [Wed, 22 Jan 2014 12:12:40 +0000 (12:12 +0000)]
Formatting

10 years agoSupport %{integer:} conversion for SIGNED integers and ETHERNET addresses
Arran Cudbard-Bell [Wed, 22 Jan 2014 11:46:00 +0000 (11:46 +0000)]
Support %{integer:} conversion for SIGNED integers and ETHERNET addresses

10 years agoMake MSCHAP xlat return -1 on failure
Arran Cudbard-Bell [Wed, 22 Jan 2014 11:14:26 +0000 (11:14 +0000)]
Make MSCHAP xlat return -1 on failure
Change many debug messages to error messages (so Module-Failure-Message is set)
White space fixes

10 years agoSimplify rdebug_pair_list
Arran Cudbard-Bell [Tue, 21 Jan 2014 23:58:03 +0000 (23:58 +0000)]
Simplify rdebug_pair_list

Conflicts:
src/main/valuepair.c

10 years agoMore unused log args
Arran Cudbard-Bell [Tue, 21 Jan 2014 23:24:27 +0000 (23:24 +0000)]
More unused log args

10 years agoRemove extraneous #include
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:59:54 +0000 (22:59 +0000)]
Remove extraneous #include

10 years agoArg no longer used
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:57:12 +0000 (22:57 +0000)]
Arg no longer used

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:54:30 +0000 (22:54 +0000)]
Update ChangeLog

10 years agoMissed break
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:42:43 +0000 (22:42 +0000)]
Missed break

10 years agoDoxygen
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:40:54 +0000 (22:40 +0000)]
Doxygen

10 years agoFixup format strings
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:33:20 +0000 (22:33 +0000)]
Fixup format strings

10 years agoFix operation of fr_strerror()
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:21:01 +0000 (22:21 +0000)]
Fix operation of fr_strerror()

A while back a flag was added to fr_strerror() to stop the same error message being output multiple times (and leading to confusing debug output).

Unfortunately the macro for RERROR() and pals, inadvertently called fr_strerror() multiple times as ## __VA_ARGS__ was passed both to module_failure_msg() and radlog_request(), with the arguments to the macro being evaluated once per call.

The solution is to switch the logging functions to use va_list instead of the ellipses, add a helper to convert ## __VA_ARGS__ into va_list, and then use va_copy to create a copy of the arguments for the radlog_request() call.

As a side effect, it appears to of enabled printf format validation for more macros, so the next commit will be to fix all the places where that was previously unreported...

10 years agoFormatting and extra error messages
Arran Cudbard-Bell [Tue, 21 Jan 2014 22:08:41 +0000 (22:08 +0000)]
Formatting and extra error messages

10 years agoUnsigned comes after "int"
Alan T. DeKok [Tue, 21 Jan 2014 19:41:03 +0000 (14:41 -0500)]
Unsigned comes after "int"

10 years agoreconnect can be called with an unused connection handle. Fixes #507
Alan T. DeKok [Tue, 21 Jan 2014 19:37:42 +0000 (14:37 -0500)]
reconnect can be called with an unused connection handle.  Fixes #507

10 years agoFix scan warnings
Alan T. DeKok [Mon, 20 Jan 2014 20:39:14 +0000 (15:39 -0500)]
Fix scan warnings

10 years agoRemove unused assignment
Alan T. DeKok [Mon, 20 Jan 2014 20:33:02 +0000 (15:33 -0500)]
Remove unused assignment

10 years agoAdd comparisons for SIGNED and ETHERNET types
Arran Cudbard-Bell [Tue, 21 Jan 2014 12:52:36 +0000 (12:52 +0000)]
Add comparisons for SIGNED and ETHERNET types

Conflicts:
src/lib/valuepair.c

10 years agoDo NOT just return 0 silently if we don't support the type in paircmp, that's a great...
Arran Cudbard-Bell [Tue, 21 Jan 2014 12:51:55 +0000 (12:51 +0000)]
Do NOT just return 0 silently if we don't support the type in paircmp, that's a great way to mess up any trees which use the function

10 years agoFix merge issue...
Arran Cudbard-Bell [Tue, 21 Jan 2014 09:38:07 +0000 (09:38 +0000)]
Fix merge issue...

10 years agoExtend the H3C dictionary based on public manuals
Mathieu Simon [Mon, 20 Jan 2014 15:04:17 +0000 (16:04 +0100)]
Extend the H3C dictionary based on public manuals

Try to extend the H3C dictionary based on what is scattered on
their pages. At least most of it is found quite consistently in
the product-specific "Security Configuration Guides".

This compilation/crosschecking is based H3C documentation for
listed devices:
- H3C S12500 and S6800 Switches
- H3C WA WLAN Access Points
- H3C MSR Routers

Remarks:
Does not stick with H3C's use of of underline in attribute naming.

Conflicts:
share/dictionary.h3c

10 years agoMissed
Arran Cudbard-Bell [Mon, 20 Jan 2014 13:39:16 +0000 (13:39 +0000)]
Missed

10 years agoFix mschap host/ xlat
Arran Cudbard-Bell [Mon, 20 Jan 2014 13:37:31 +0000 (13:37 +0000)]
Fix mschap host/ xlat

10 years agoAdd additional Cisco-Disconnect-Cause Values
Mathieu Simon [Mon, 20 Jan 2014 09:22:12 +0000 (10:22 +0100)]
Add additional Cisco-Disconnect-Cause Values

Obtained from Cisco documentation, some additional
Disconnect-Causes as i.e. used by IOS 15.x and likely
previous versions.

10 years agoFormatting
Arran Cudbard-Bell [Sun, 19 Jan 2014 22:46:06 +0000 (22:46 +0000)]
Formatting

10 years agoAdd H3C HW-Exec-Privilege as posted by Mathieu Simon
Arran Cudbard-Bell [Sun, 19 Jan 2014 22:45:58 +0000 (22:45 +0000)]
Add H3C HW-Exec-Privilege as posted by Mathieu Simon

10 years agoChange priority of encoding error messages
Arran Cudbard-Bell [Sun, 19 Jan 2014 22:26:46 +0000 (22:26 +0000)]
Change priority of encoding error messages

10 years agoPrint errors when decoding RADSEC packets
Arran Cudbard-Bell [Sun, 19 Jan 2014 22:18:43 +0000 (22:18 +0000)]
Print errors when decoding RADSEC packets

10 years agoDocument that 'max' should be the maximum number of threads
Alan T. DeKok [Sun, 19 Jan 2014 16:02:22 +0000 (11:02 -0500)]
Document that 'max' should be the maximum number of threads

10 years agoSet the default length for the attributes
Alan T. DeKok [Sat, 18 Jan 2014 20:58:28 +0000 (15:58 -0500)]
Set the default length for the attributes

10 years agoscan warnings
Alan T. DeKok [Fri, 17 Jan 2014 19:42:16 +0000 (14:42 -0500)]
scan warnings

10 years agoRemove unnecessary assignment
Alan T. DeKok [Fri, 17 Jan 2014 19:37:36 +0000 (14:37 -0500)]
Remove unnecessary assignment

10 years agoUpdate ippool
Arran Cudbard-Bell [Fri, 17 Jan 2014 17:00:33 +0000 (17:00 +0000)]
Update ippool

10 years agoConvert more things to bools
Arran Cudbard-Bell [Fri, 17 Jan 2014 16:43:09 +0000 (16:43 +0000)]
Convert more things to bools

10 years agoUse the new name for session-db
Arran Cudbard-Bell [Fri, 17 Jan 2014 16:21:13 +0000 (16:21 +0000)]
Use the new name for session-db

10 years agoUse correct reference for error message
Alan T. DeKok [Fri, 17 Jan 2014 16:22:30 +0000 (11:22 -0500)]
Use correct reference for error message

10 years agoFix clang scanner warnings
Alan T. DeKok [Fri, 17 Jan 2014 16:20:31 +0000 (11:20 -0500)]
Fix clang scanner warnings

10 years agoRequest can't be NULL
Alan T. DeKok [Fri, 17 Jan 2014 16:20:20 +0000 (11:20 -0500)]
Request can't be NULL

10 years agoRemove unused assignment
Alan T. DeKok [Fri, 17 Jan 2014 16:18:10 +0000 (11:18 -0500)]
Remove unused assignment

10 years agoFix typo.
Alan T. DeKok [Fri, 17 Jan 2014 15:27:57 +0000 (10:27 -0500)]
Fix typo.

10 years agoWe no longer allow paircopy2(..., -1)
Alan T. DeKok [Fri, 17 Jan 2014 14:38:06 +0000 (09:38 -0500)]
We no longer allow paircopy2(..., -1)

10 years agoCount number of retrieved groups
Arran Cudbard-Bell [Thu, 16 Jan 2014 20:26:46 +0000 (20:26 +0000)]
Count number of retrieved groups

10 years agoAdd debug message to show when the user wasn't a member of any groups
Arran Cudbard-Bell [Thu, 16 Jan 2014 20:15:29 +0000 (20:15 +0000)]
Add debug message to show when the user wasn't a member of any groups

10 years agoNote 3.0.2
Alan T. DeKok [Wed, 15 Jan 2014 15:56:16 +0000 (10:56 -0500)]
Note 3.0.2

10 years agoIgnore .rej files
Alan T. DeKok [Wed, 15 Jan 2014 15:56:09 +0000 (10:56 -0500)]
Ignore .rej files

10 years agoAdd support for IPv[4|6] prefixes in dynamic clients
Arran Cudbard-Bell [Tue, 14 Jan 2014 17:51:42 +0000 (17:51 +0000)]
Add support for IPv[4|6] prefixes in dynamic clients

10 years agoMinor fixes in radius_start_program
Arran Cudbard-Bell [Mon, 13 Jan 2014 20:24:35 +0000 (20:24 +0000)]
Minor fixes in radius_start_program

10 years agoFix auto-generation of Makefiles to have the correct dependencies
Alan T. DeKok [Tue, 14 Jan 2014 16:49:22 +0000 (11:49 -0500)]
Fix auto-generation of Makefiles to have the correct dependencies

10 years agoFix ref to release branch release_3_0_1
Alan T. DeKok [Tue, 14 Jan 2014 01:13:56 +0000 (20:13 -0500)]
Fix ref to release branch

10 years agoThis is no longer true
Alan T. DeKok [Mon, 13 Jan 2014 19:22:11 +0000 (14:22 -0500)]
This is no longer true

10 years agoFinal before 3.0.1
Alan T. DeKok [Mon, 13 Jan 2014 19:20:03 +0000 (14:20 -0500)]
Final before 3.0.1

10 years ago<sigh> Gnu Make is enormously stupid
Alan T. DeKok [Mon, 13 Jan 2014 15:55:17 +0000 (10:55 -0500)]
<sigh>  Gnu Make is enormously stupid

10 years agoFix the build by working around GNU Make's issues
Alan T. DeKok [Mon, 13 Jan 2014 15:35:53 +0000 (10:35 -0500)]
Fix the build by working around GNU Make's issues

10 years agoRevert "Revert "Move dependency checks to one-time build""
Alan T. DeKok [Sun, 12 Jan 2014 00:03:59 +0000 (19:03 -0500)]
Revert "Revert "Move dependency checks to one-time build""

This reverts commit f0b9b43d9a2c73bbf1c43a372a0397cb83d32f7d.

Which was erroneously blamed for breaking the build

10 years agoBuilding the objects requires the headers
Alan T. DeKok [Sat, 11 Jan 2014 21:24:49 +0000 (16:24 -0500)]
Building the objects requires the headers

Not C / H files

10 years agoUpdate the bugs document
Arran Cudbard-Bell [Tue, 7 Jan 2014 11:36:28 +0000 (11:36 +0000)]
Update the bugs document

10 years agoUpdate changelog
Arran Cudbard-Bell [Fri, 10 Jan 2014 11:50:25 +0000 (11:50 +0000)]
Update changelog

10 years agoCorrect declarations for 'check_config' global
Arran Cudbard-Bell [Fri, 10 Jan 2014 11:39:17 +0000 (11:39 +0000)]
Correct declarations for 'check_config' global

sizeof(int) != sizeof(bool) on some systems

10 years agoRevert "Move dependency checks to one-time build"
Arran Cudbard-Bell [Fri, 10 Jan 2014 11:26:49 +0000 (11:26 +0000)]
Revert "Move dependency checks to one-time build"

This reverts commit fe77ef86428a31db3088ec7435440a31e37c685c.

10 years agoFix the other snprintf in rlm_sqlcounter. Closes #498
Arran Cudbard-Bell [Fri, 10 Jan 2014 10:55:40 +0000 (10:55 +0000)]
Fix the other snprintf in rlm_sqlcounter. Closes #498

10 years agoAcctsession time is unsigned int
Alan T. DeKok [Thu, 9 Jan 2014 13:32:10 +0000 (08:32 -0500)]
Acctsession time is unsigned int

10 years agoStupid warnings when building under ubuntu
Arran Cudbard-Bell [Tue, 7 Jan 2014 23:08:29 +0000 (23:08 +0000)]
Stupid warnings when building under ubuntu

10 years agoMove dependency checks to one-time build
Alan T. DeKok [Tue, 7 Jan 2014 21:36:31 +0000 (16:36 -0500)]
Move dependency checks to one-time build

So we don't re-run "shell ... grep ... sed ..." on every make

This makes "time make -j 4 all" on a clean build drop ~50% in
time

10 years agoTemporarily remove static build from matrix until it's properly supported
Arran Cudbard-Bell [Tue, 7 Jan 2014 21:35:22 +0000 (21:35 +0000)]
Temporarily remove static build from matrix until it's properly supported

10 years agoTypos in comment
Alan T. DeKok [Tue, 7 Jan 2014 21:19:13 +0000 (16:19 -0500)]
Typos in comment

10 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 7 Jan 2014 20:18:04 +0000 (15:18 -0500)]
Update ChangeLog

10 years agoFix issues with previous commit
Arran Cudbard-Bell [Tue, 7 Jan 2014 20:00:50 +0000 (20:00 +0000)]
Fix issues with previous commit

10 years agoBuild fixes WITHOUT_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:54:15 +0000 (14:54 -0500)]
Build fixes WITHOUT_ACCOUNTING

10 years agoBuild fixes WITHOUT_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:53:00 +0000 (14:53 -0500)]
Build fixes WITHOUT_ACCOUNTING

10 years agoBuild fixes WITH_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:52:26 +0000 (14:52 -0500)]
Build fixes WITH_ACCOUNTING

10 years agoBuild warnings WITHOUT_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:50:25 +0000 (14:50 -0500)]
Build warnings WITHOUT_ACCOUNTING

10 years agoBuild fixes WITHOUT_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:49:34 +0000 (14:49 -0500)]
Build fixes WITHOUT_ACCOUNTING

10 years agoBuild fixes WITHOUT_ACCOUNTING
Alan T. DeKok [Tue, 7 Jan 2014 19:48:21 +0000 (14:48 -0500)]
Build fixes WITHOUT_ACCOUNTING

10 years agoReport a non-zero exit status if after forking, the child encounters an error during...
Arran Cudbard-Bell [Tue, 7 Jan 2014 19:47:28 +0000 (19:47 +0000)]
Report a non-zero exit status if after forking, the child encounters an error during the rest of server initialisation

Tests to follow

10 years agoBuild fixes WITHOUT_UNLANG
Alan T. DeKok [Tue, 7 Jan 2014 19:46:39 +0000 (14:46 -0500)]
Build fixes WITHOUT_UNLANG

10 years agoBuild warnings WITHOUT_UNLANG
Alan T. DeKok [Tue, 7 Jan 2014 19:46:26 +0000 (14:46 -0500)]
Build warnings WITHOUT_UNLANG

10 years agoBuild fixes for WITHOUT_PROXY
Alan T. DeKok [Tue, 7 Jan 2014 19:39:56 +0000 (14:39 -0500)]
Build fixes for WITHOUT_PROXY

10 years agoBuild fixes for WITHOUT_PROXY
Alan T. DeKok [Tue, 7 Jan 2014 19:38:44 +0000 (14:38 -0500)]
Build fixes for WITHOUT_PROXY

10 years agoBuild fixes for WITHOUT_PROXY
Alan T. DeKok [Tue, 7 Jan 2014 19:37:41 +0000 (14:37 -0500)]
Build fixes for WITHOUT_PROXY