From 74197e0adf4c63ba5551ed7e816f7d61e74a36b1 Mon Sep 17 00:00:00 2001 From: Andrei Otcheretianski Date: Tue, 28 Apr 2015 14:01:02 +0300 Subject: [PATCH] wpa_cli: Fix memory leak when tracking networks Fix memory leak introduced in commit 32a097fdd26b9401fbd22054a2a01ba2d71f139a ("wpa_cli: Keep track of available networks") by tracking networks only when in interactive mode. Signed-off-by: Andrei Otcheretianski --- wpa_supplicant/wpa_cli.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c index 54777d2..bd5846b 100644 --- a/wpa_supplicant/wpa_cli.c +++ b/wpa_supplicant/wpa_cli.c @@ -1456,7 +1456,8 @@ static int wpa_cli_cmd_add_network(struct wpa_ctrl *ctrl, int argc, char *argv[]) { int res = wpa_ctrl_command(ctrl, "ADD_NETWORK"); - update_networks(ctrl); + if (interactive) + update_networks(ctrl); return res; } @@ -1465,7 +1466,8 @@ static int wpa_cli_cmd_remove_network(struct wpa_ctrl *ctrl, int argc, char *argv[]) { int res = wpa_cli_cmd(ctrl, "REMOVE_NETWORK", 1, argc, argv); - update_networks(ctrl); + if (interactive) + update_networks(ctrl); return res; } -- 2.1.4