From 2873e9bbe412bb664746f1014c007fedd3451528 Mon Sep 17 00:00:00 2001
From: kkalev <kkalev>
Date: Mon, 9 Sep 2002 07:57:01 +0000
Subject: [PATCH] Only connect and bind to the ldap server if we haven't done
 that before.

---
 dialup_admin/Changelog                    | 1 +
 dialup_admin/lib/ldap/change_attrs.php3   | 6 ++++--
 dialup_admin/lib/ldap/change_info.php3    | 6 ++++--
 dialup_admin/lib/ldap/change_passwd.php3  | 6 ++++--
 dialup_admin/lib/ldap/create_user.php3    | 6 ++++--
 dialup_admin/lib/ldap/defaults.php3       | 6 ++++--
 dialup_admin/lib/ldap/delete_user.php3    | 6 ++++--
 dialup_admin/lib/ldap/find.php3           | 6 ++++--
 dialup_admin/lib/ldap/functions.php3      | 6 ++++--
 dialup_admin/lib/ldap/password_check.php3 | 3 ++-
 dialup_admin/lib/ldap/user_info.php3      | 6 ++++--
 11 files changed, 39 insertions(+), 19 deletions(-)

diff --git a/dialup_admin/Changelog b/dialup_admin/Changelog
index 2ce51c5..24561c1 100644
--- a/dialup_admin/Changelog
+++ b/dialup_admin/Changelog
@@ -44,6 +44,7 @@ Ver 1.59:
   a where in () caluse.
 * Also cache the default.vals file.
 * Update documentation
+* Only connect and bind to the ldap server if we haven't done that before.
 Ver 1.55:
 * Update the FAQ about missing attributes from the user/group edit pages and add a few comments
   in the configuration files
diff --git a/dialup_admin/lib/ldap/change_attrs.php3 b/dialup_admin/lib/ldap/change_attrs.php3
index 937d70c..d1781d0 100644
--- a/dialup_admin/lib/ldap/change_attrs.php3
+++ b/dialup_admin/lib/ldap/change_attrs.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-	$ds = @ldap_connect($config[ldap_server]);
+	if (!isset($ds))
+		$ds = @ldap_connect($config[ldap_server]);
 	if ($ds){
-		$r = @da_ldap_bind($ds,$config);
+		if (!isset($r))
+			$r = @da_ldap_bind($ds,$config);
 		if ($r){
 
 			foreach($show_attrs as $key => $attr){
diff --git a/dialup_admin/lib/ldap/change_info.php3 b/dialup_admin/lib/ldap/change_info.php3
index d41a414..dafb3f8 100644
--- a/dialup_admin/lib/ldap/change_info.php3
+++ b/dialup_admin/lib/ldap/change_info.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-	$ds = @ldap_connect($config[ldap_server]);
+	if (!isset($ds))
+		$ds = @ldap_connect($config[ldap_server]);
 	if ($ds){
-		$r = @da_ldap_bind($ds,$config);
+		if (!isset($r))
+			$r = @da_ldap_bind($ds,$config);
 		if ($r){
 			if ($Fcn != '' && $Fcn != '-' && $Fcn != $cn)
 				$mod['cn'] = $Fcn;
diff --git a/dialup_admin/lib/ldap/change_passwd.php3 b/dialup_admin/lib/ldap/change_passwd.php3
index 48dc4a0..2a962bf 100644
--- a/dialup_admin/lib/ldap/change_passwd.php3
+++ b/dialup_admin/lib/ldap/change_passwd.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-	$ds = @ldap_connect($config[ldap_server]);
+	if (!isset($ds))
+		$ds = @ldap_connect($config[ldap_server]);
 	if ($ds){
-		$r = @da_ldap_bind($ds,$config);
+		if (!isset($r))
+			$r = @da_ldap_bind($ds,$config);
 		if ($r){
 			if (is_file("../lib/crypt/$config[general_encryption_method].php3")){
 				include("../lib/crypt/$config[general_encryption_method].php3");
diff --git a/dialup_admin/lib/ldap/create_user.php3 b/dialup_admin/lib/ldap/create_user.php3
index d64fe0e..48d555b 100644
--- a/dialup_admin/lib/ldap/create_user.php3
+++ b/dialup_admin/lib/ldap/create_user.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-	$ds = @ldap_connect($config[ldap_server]);
+	if (!isset($ds))
+		$ds = @ldap_connect($config[ldap_server]);
 	if ($ds){
-		$r = @da_ldap_bind($ds,$config);
+		if (!isset($r))
+			$r = @da_ldap_bind($ds,$config);
 		if ($r){
 			list ($givenname,$sn) = split(' ',$Fcn,3);
 			$dn = 'uid=' . $login . ',' . $config[ldap_default_new_entry_suffix];
diff --git a/dialup_admin/lib/ldap/defaults.php3 b/dialup_admin/lib/ldap/defaults.php3
index 4169d8a..4136395 100644
--- a/dialup_admin/lib/ldap/defaults.php3
+++ b/dialup_admin/lib/ldap/defaults.php3
@@ -3,9 +3,11 @@ require_once('../lib/ldap/functions.php3');
 if ($config[ldap_default_dn] != ''){
 	include('../lib/ldap/attrmap.php3');
 	$regular_profile_attr = $config[ldap_regular_profile_attr];
-	$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
+	if (!isset($ds))
+		$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
 	if ($ds) {
-       		$r=@da_ldap_bind($ds,$config);
+		if (!isset($r))
+       			$r=@da_ldap_bind($ds,$config);
        		$sr=@ldap_search($ds,"$config[ldap_default_dn]", 'objectclass=*');
        		if ($info = @ldap_get_entries($ds, $sr)){
        			$dn = $info[0]['dn'];
diff --git a/dialup_admin/lib/ldap/delete_user.php3 b/dialup_admin/lib/ldap/delete_user.php3
index 052ab78..a2136ed 100644
--- a/dialup_admin/lib/ldap/delete_user.php3
+++ b/dialup_admin/lib/ldap/delete_user.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-$ds = @ldap_connect($config[ldap_server]);
+if (!isset($ds))
+	$ds = @ldap_connect($config[ldap_server]);
 if ($ds){
-	$r = @da_ldap_bind($ds,$config);
+	if (!isset($r))
+		$r = @da_ldap_bind($ds,$config);
 	if ($r){
 		@ldap_delete($ds,$dn);
 		if (@ldap_error($ds) == 'Success')
diff --git a/dialup_admin/lib/ldap/find.php3 b/dialup_admin/lib/ldap/find.php3
index 5c6da52..185330b 100644
--- a/dialup_admin/lib/ldap/find.php3
+++ b/dialup_admin/lib/ldap/find.php3
@@ -1,8 +1,10 @@
 <?php
 require_once('../lib/ldap/functions.php3');
-$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
+if (!isset($ds))
+	$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
 if ($ds) {
-	$r=@da_ldap_bind($ds,$config);
+	if (!isset($r))
+		$r=@da_ldap_bind($ds,$config);
 	if ($search_IN == 'name' || $search_IN == 'ou')
 		$attr = ($search_IN == 'name') ? 'cn' : 'ou';
 	else if ($search_IN == 'radius'){
diff --git a/dialup_admin/lib/ldap/functions.php3 b/dialup_admin/lib/ldap/functions.php3
index d480bf3..27c25ce 100644
--- a/dialup_admin/lib/ldap/functions.php3
+++ b/dialup_admin/lib/ldap/functions.php3
@@ -29,9 +29,11 @@ function da_ldap_bind($ds,$config)
 
 function connect2db($config)
 {
-	$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
+	if (!isset($ds))
+		$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
 	if ($ds)
-		$r=@da_ldap_bind($ds,$config);
+		if (!isset($r))
+			$r=@da_ldap_bind($ds,$config);
 	return $ds;
 }
 
diff --git a/dialup_admin/lib/ldap/password_check.php3 b/dialup_admin/lib/ldap/password_check.php3
index 0fae14b..3b9d03d 100644
--- a/dialup_admin/lib/ldap/password_check.php3
+++ b/dialup_admin/lib/ldap/password_check.php3
@@ -1,7 +1,8 @@
 <?php
 
 if ($action == 'checkpass'){
-	$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
+	if (!isset($ds))
+		$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
 	if ($ds){
 		if ($dn != ''){
 			if ($passwd == '')
diff --git a/dialup_admin/lib/ldap/user_info.php3 b/dialup_admin/lib/ldap/user_info.php3
index f14ef3d..d3d685b 100644
--- a/dialup_admin/lib/ldap/user_info.php3
+++ b/dialup_admin/lib/ldap/user_info.php3
@@ -24,9 +24,11 @@ $mobile = '-';
 $mail = '-';
 $mailalt = '-';
 
-$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
+if (!isset($ds))
+	$ds=@ldap_connect("$config[ldap_server]");  // must be a valid ldap server!
 if ($ds) {
-	$r=@da_ldap_bind($ds,$config);
+	if (!isset($r))
+		$r=@da_ldap_bind($ds,$config);
 	$sr=@ldap_search($ds,"$config[ldap_base]", 'uid=' . $login);
 	$info = @ldap_get_entries($ds, $sr);
 	$dn = $info[0]['dn'];
-- 
2.1.4